Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on code in PR #14490:
URL: https://github.com/apache/kafka/pull/14490#discussion_r1348082752


##
tests/kafkatest/version.py:
##
@@ -120,7 +120,7 @@ def get_version(node=None):
 return DEV_BRANCH
 
 DEV_BRANCH = KafkaVersion("dev")
-DEV_VERSION = KafkaVersion("3.6.0-SNAPSHOT")
+DEV_VERSION = KafkaVersion("3.7.0-SNAPSHOT")

Review Comment:
   The vote was closed, and @satishd did pump the version in all other places 
already (cf 
https://github.com/apache/kafka/commit/9e3b1f9b9bf48603acde7f71c704af812a6dab4b)
 -- his PR should have also bumped `DEV_VERSION`(otherwise system test start to 
break) but missed it.
   
   `DEV_VERSION` must match what is in `gradle.properties`, so this is really 
just a plain fix :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on code in PR #14490:
URL: https://github.com/apache/kafka/pull/14490#discussion_r1348082752


##
tests/kafkatest/version.py:
##
@@ -120,7 +120,7 @@ def get_version(node=None):
 return DEV_BRANCH
 
 DEV_BRANCH = KafkaVersion("dev")
-DEV_VERSION = KafkaVersion("3.6.0-SNAPSHOT")
+DEV_VERSION = KafkaVersion("3.7.0-SNAPSHOT")

Review Comment:
   The vote was closed, and @satishd did pump the version in all other places 
already (cf 
https://github.com/apache/kafka/commit/9e3b1f9b9bf48603acde7f71c704af812a6dab4b)
 -- this PR should have also bumped this version (otherwise system test start 
to break).
   
   `DEV_VERSION` must match what is in `gradle.properties`, so this is really 
just a plain fix :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14500:
URL: https://github.com/apache/kafka/pull/14500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14498:
URL: https://github.com/apache/kafka/pull/14498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14497:
URL: https://github.com/apache/kafka/pull/14497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14496:
URL: https://github.com/apache/kafka/pull/14496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14495:
URL: https://github.com/apache/kafka/pull/14495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14493:
URL: https://github.com/apache/kafka/pull/14493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14492:
URL: https://github.com/apache/kafka/pull/14492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax merged PR #14490:
URL: https://github.com/apache/kafka/pull/14490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mimaison commented on code in PR #14490:
URL: https://github.com/apache/kafka/pull/14490#discussion_r1347568957


##
tests/kafkatest/version.py:
##
@@ -120,7 +120,7 @@ def get_version(node=None):
 return DEV_BRANCH
 
 DEV_BRANCH = KafkaVersion("dev")
-DEV_VERSION = KafkaVersion("3.6.0-SNAPSHOT")
+DEV_VERSION = KafkaVersion("3.7.0-SNAPSHOT")

Review Comment:
   This may be just bad timing as @satishd is releasing 3.6.0 right now. We 
typically bump this version after the vote passes according to the release 
process: 
https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-Afterthevotepasses
   
   I wonder if we should undo this change from this PR and let Satish do it as 
part of the release process. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


satishd commented on code in PR #14490:
URL: https://github.com/apache/kafka/pull/14490#discussion_r1347362913


##
tests/kafkatest/version.py:
##
@@ -257,6 +257,4 @@ def get_version(node=None):
 V_3_6_0 = KafkaVersion("3.6.0")
 LATEST_3_6 = V_3_6_0
 
-# 3.7.x versions
-V_3_7_0 = KafkaVersion("3.7.0")
-LATEST_3_7 = V_3_7_0
\ No newline at end of file
+# only add released versions here

Review Comment:
   Thanks for adding this comment. It will clarify for other RMs or whoever is 
making the required changes for the release.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748587571

   3.6 is fine, but also needs some version bumps: 
https://github.com/apache/kafka/pull/14501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748539140

   3.5 is broken as well: https://github.com/apache/kafka/pull/14500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748531708

   3.4 is ok, just needs a few versions bumps: 
https://github.com/apache/kafka/pull/14499


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748476906

   3.3 -> https://github.com/apache/kafka/pull/14498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748462526

   3.2 -> https://github.com/apache/kafka/pull/14497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748434181

   3.1 is broken, too: https://github.com/apache/kafka/pull/14496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748413966

   3.0 is also broken -> https://github.com/apache/kafka/pull/14495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748401740

   2.8 is not broken, but needs some version bumps -> 
https://github.com/apache/kafka/pull/14494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748366470

   Also 2.7 -> https://github.com/apache/kafka/pull/14493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on PR #14490:
URL: https://github.com/apache/kafka/pull/14490#issuecomment-1748315191

   Found a similar issue for 2.6 branch -> 
https://github.com/apache/kafka/pull/14492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on code in PR #14490:
URL: https://github.com/apache/kafka/pull/14490#discussion_r1346844509


##
tests/kafkatest/version.py:
##
@@ -120,7 +120,7 @@ def get_version(node=None):
 return DEV_BRANCH
 
 DEV_BRANCH = KafkaVersion("dev")
-DEV_VERSION = KafkaVersion("3.6.0-SNAPSHOT")
+DEV_VERSION = KafkaVersion("3.7.0-SNAPSHOT")
 
 LATEST_METADATA_VERSION = "3.6"

Review Comment:
   Not sure what this is -- does it need to be bumped or not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on code in PR #14490:
URL: https://github.com/apache/kafka/pull/14490#discussion_r1346842409


##
tests/kafkatest/version.py:
##
@@ -120,7 +120,7 @@ def get_version(node=None):
 return DEV_BRANCH
 
 DEV_BRANCH = KafkaVersion("dev")
-DEV_VERSION = KafkaVersion("3.6.0-SNAPSHOT")
+DEV_VERSION = KafkaVersion("3.7.0-SNAPSHOT")

Review Comment:
   forgot to dump the dev-version -- this breaks the system test setup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HOTIFX: fix Kafka versions for system tests [kafka]

2023-10-05 Thread via GitHub


mjsax commented on code in PR #14490:
URL: https://github.com/apache/kafka/pull/14490#discussion_r1346843365


##
tests/kafkatest/version.py:
##
@@ -257,6 +257,4 @@ def get_version(node=None):
 V_3_6_0 = KafkaVersion("3.6.0")
 LATEST_3_6 = V_3_6_0
 
-# 3.7.x versions
-V_3_7_0 = KafkaVersion("3.7.0")
-LATEST_3_7 = V_3_7_0
\ No newline at end of file
+# only add released versions here

Review Comment:
   Side cleanup -- happens all the time -- added a comment now -- we only add 
released versions here. There is no 3.7.0 release yet -- seems even 3.6.0 was 
added pre-mature -- your PR bumping the versions should have added 3.6.0...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org