Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-04 Thread via GitHub 


msn-tldr commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1346104788


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   @nizhikov i can see its fixed in trunk, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


jolshan commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344425267


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   I was worried for a moment since I definitely checked the build on this  
Glad it was sorted.



##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   I was worried for a moment since I definitely checked the build on this  
Glad it was sorted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


nizhikov commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344361140


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   @msn-tldr Fix merge e90f82b62a94dc556e231f033e22030c06d60232



##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   @msn-tldr Fix merged e90f82b62a94dc556e231f033e22030c06d60232



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


nizhikov commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344317637


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   Fix - #14475 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


nizhikov commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344288356


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   I will provide fix in the nearest time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


nizhikov commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344287439


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   It seems like 7553d3f562f3af6c7f9b062b9220bcad80b00478 breaks compilation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


nizhikov commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344283995


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   Hello. 
   
   Please, take a look at jenkins build of trunk after this merged - 
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka/detail/trunk/2248/pipeline
   
   Looks like it builds successfully.
   Can you, please, clarify, how you trying to build trunk and what exactly 
fails?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


msn-tldr commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344282594


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   I see builds fail on jenkins similarly -
   https://lists.apache.org/thread/qnscvw8nb3dscrkm43r7g5224067jzc6



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-03 Thread via GitHub 


msn-tldr commented on code in PR #14456:
URL: https://github.com/apache/kafka/pull/14456#discussion_r1344277985


##
build.gradle:
##
@@ -1908,6 +1908,7 @@ project(':tools') {
 testImplementation project(':connect:api')
 testImplementation project(':connect:runtime')
 testImplementation project(':connect:runtime').sourceSets.test.output
+testImplementation project(':storage:api').sourceSets.main.output

Review Comment:
   @nizhikov 
   This gradle change is breaking `trunk` builds for me locally, should this be 
`:storage:storage-api` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-02 Thread via GitHub 


nizhikov commented on PR #14456:
URL: https://github.com/apache/kafka/pull/14456#issuecomment-1743719944

   @jolshan Thank you very much for the review and merge. Appreciate it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-02 Thread via GitHub 


jolshan merged PR #14456:
URL: https://github.com/apache/kafka/pull/14456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-02 Thread via GitHub 


jolshan commented on PR #14456:
URL: https://github.com/apache/kafka/pull/14456#issuecomment-1743685795

   Hey sorry. I was off for the weekend. I can take another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java [kafka]

2023-10-02 Thread via GitHub 


nizhikov commented on PR #14456:
URL: https://github.com/apache/kafka/pull/14456#issuecomment-1742776092

   CI is OK after code review changes.
   @jolshan do you have other comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org