Re: [PR] KAFKA-15215: migrate StreamedJoinTest to Mockito [kafka]
ijuma commented on code in PR #15424:
URL: https://github.com/apache/kafka/pull/15424#discussion_r1511284102
##
build.gradle:
##
@@ -2333,6 +2333,8 @@ project(':streams:streams-scala') {
testImplementation libs.junitJupiter
testImplementation libs.easymock
+testImplementation libs.mockitoCore
Review Comment:
There were no mocks used at all in this module, but the streams module has
all but 2 tests using mockito. I removed the easymock dependency from this
module (and a few others) in a subsequent commit
https://github.com/apache/kafka/commit/2c0cab39aedab3a8635510acfac2551aaeb62ffb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15215: migrate StreamedJoinTest to Mockito [kafka]
ableegoldman merged PR #15424: URL: https://github.com/apache/kafka/pull/15424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15215: migrate StreamedJoinTest to Mockito [kafka]
ableegoldman commented on PR #15424: URL: https://github.com/apache/kafka/pull/15424#issuecomment-1965693809 Looks like a new build was triggered when I renamed the PR but I have the results from before that and it looked good. Test failures all unrelated. Will merge this to trunk Build from before the name change: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15424/2/tests/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15215: migrate StreamedJoinTest to Mockito [kafka]
ableegoldman commented on PR #15424: URL: https://github.com/apache/kafka/pull/15424#issuecomment-1965688725 remember to name your PRs correctly -- I added the `KAFKA-15215` prefix since this came about from that ticket, but you can always use `MINOR:` for small fixes that don't have a corresponding ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15215: migrate StreamedJoinTest to Mockito [kafka]
agavra commented on code in PR #15424:
URL: https://github.com/apache/kafka/pull/15424#discussion_r1503563459
##
build.gradle:
##
@@ -2333,6 +2333,8 @@ project(':streams:streams-scala') {
testImplementation libs.junitJupiter
testImplementation libs.easymock
+testImplementation libs.mockitoCore
Review Comment:
I checked. looks like no tests in the streams scala tests used mockito yet 路
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15215: migrate StreamedJoinTest to Mockito [kafka]
ableegoldman commented on code in PR #15424:
URL: https://github.com/apache/kafka/pull/15424#discussion_r1503562979
##
build.gradle:
##
@@ -2333,6 +2333,8 @@ project(':streams:streams-scala') {
testImplementation libs.junitJupiter
testImplementation libs.easymock
+testImplementation libs.mockitoCore
Review Comment:
Wait...why do we need to add a dependency for this? I thought the whole
point of the change was to align this test with others in the same file --
shouldn't that mean whatever dependencies are needed are already there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
