Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
dajac commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1805313339 This PR has introduces a compilation error (JDK 8 and Scala 2.12): ``` > Task :core:compileScala [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-14392/core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:305:49: value incl is not a member of scala.collection.immutable.Set[org.apache.kafka.common.Uuid] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
cmccabe closed pull request #14392: KAFKA-15360: Include dirs in BrokerRegistration URL: https://github.com/apache/kafka/pull/14392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
cmccabe commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1804419672 Committed, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
pprovenzano commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1802120042 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
pprovenzano commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1802108456 > I don't think I understand your comment/suggestion. The broker can only know UUIDs for directories that are online. If they are offline the directory ID cannot be read. What should be done differently and why? Sorry, this I saw the same heartbeat code that is in https://github.com/apache/kafka/pull/14368 and was wondering why? I missed the code that actually sends the registration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
soarez commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1801863864 I don't think I understand your comment/suggestion. The broker can only know UUIDs for directories that are online. If they are offline the directory ID cannot be read. What should be done differently and why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
pprovenzano commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1799807037 So, I think here we just want to set the list of directory UUIDs that we know about and assume they are online. We can later set a known directory to offline with our first heartbeat. Since there can be directories that the controller knows about and the broker doesn't we will need to reconcile those first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]
soarez commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1795069125 @cmccabe @pprovenzano this builds on [KAFKA-15451](https://github.com/apache/kafka/pull/14368) (#14368). Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
