Re: [PR] KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs [kafka]

2023-12-18 Thread via GitHub


rondagostino merged PR #15042:
URL: https://github.com/apache/kafka/pull/15042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs [kafka]

2023-12-18 Thread via GitHub


rondagostino merged PR #14998:
URL: https://github.com/apache/kafka/pull/14998


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs [kafka]

2023-12-18 Thread via GitHub


rondagostino commented on PR #14998:
URL: https://github.com/apache/kafka/pull/14998#issuecomment-1861589141

   `shouldHaveSamePositionBoundActiveAndStandBy` only failed on JDKs 8 and 21 
on the 3.7 PR (https://github.com/apache/kafka/pull/15042), which overall had 
`37 tests have failed.  There are 0 new tests failing, 37 existing failing.`
   
   `testTaskRequestWithOldStartMsGetsUpdated` only failed on JDK 11 on the 3.7 
PR.
   
   I'm inclined to say these are flaky tests.  I'mm ognna merge this and the 
other one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs [kafka]

2023-12-18 Thread via GitHub


rondagostino commented on PR #14998:
URL: https://github.com/apache/kafka/pull/14998#issuecomment-1861580429

   `shouldHaveSamePositionBoundActiveAndStandBy – `34 tests have failed.  There 
are 26 new tests failing, 8 existing failing and 288 skipped.`
   
   'org.apache.kafka.streams.integration.ConsistencyVectorIntegrationTest` 
failed in 3 of the 4 JDK versions (8, 11, and 17), but that seems unrelated.  
`testTaskRequestWithOldStartMsGetsUpdated() – 
org.apache.kafka.trogdor.coordinator.CoordinatorTest` failed in JDK 21 and 11 
and also seems unrelated.
   
   @viktorsomogyi WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs [kafka]

2023-12-18 Thread via GitHub


viktorsomogyi commented on PR #14998:
URL: https://github.com/apache/kafka/pull/14998#issuecomment-1860860214

   Raised the cherr-pick in #15042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs [kafka]

2023-12-18 Thread via GitHub


viktorsomogyi commented on PR #14998:
URL: https://github.com/apache/kafka/pull/14998#issuecomment-1860847417

   @stanislavkozlovski I think this is important for 3.7. I now restarted the 
unit tests as previously seems like Jenkins terminated. I'll make sure to 
cherry-pick this to the 3.7 branch too and the tests there as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15364: Replay BrokerRegistrationChangeRecord.logDirs [kafka]

2023-12-12 Thread via GitHub


soarez commented on PR #14998:
URL: https://github.com/apache/kafka/pull/14998#issuecomment-1853247402

   > 36 tests have failed There are 0 new tests failing, 36 existing failing 
and 271 skipped.
   
   @rondagostino PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org