Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
atu-sharm commented on code in PR #14473: URL: https://github.com/apache/kafka/pull/14473#discussion_r1366678883 ## gradle.properties: ## @@ -25,6 +25,9 @@ group=org.apache.kafka # - streams/quickstart/java/pom.xml version=3.7.0-SNAPSHOT scalaVersion=2.13.12 +# Adding swaggerVersion in gradle.properties to have a single version in place for swagger +# New version of Swagger 2.2.14 requires minimum JDK 11. +swaggerVersion=2.2.8 Review Comment: Yes, i agree @ijuma , but as per the https://github.com/gradle/gradle/issues/1697#issuecomment-506910915 , plugin block is highly constrained, as 1. Only the version accepts interpolated strings (id must be a string literal) 2. Replacement expressions are limited to variable references: this means that we cannot call methods or use sophisticated build logic to retrieve dependency versions. But anything declared in a gradle.properties file can be inserted into the version string So, i made changes accordingly. Apparently we can have another approach possible where we can add specific resolutionStrategy using the pluginManagement block in settings.gradle and specify to use the specific plugin having the version defined in dependencies.gradle, this would work as well. Your thoughts @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
ijuma commented on code in PR #14473: URL: https://github.com/apache/kafka/pull/14473#discussion_r1350536831 ## gradle.properties: ## @@ -25,6 +25,9 @@ group=org.apache.kafka # - streams/quickstart/java/pom.xml version=3.7.0-SNAPSHOT scalaVersion=2.13.12 +# Adding swaggerVersion in gradle.properties to have a single version in place for swagger +# New version of Swagger 2.2.14 requires minimum JDK 11. +swaggerVersion=2.2.8 Review Comment: Why didn't we keep this in `dependencies.gradle`? It's confusing to have versions split across multiple files (outside of the Scala version, which is special in a few ways). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
ijuma commented on code in PR #14473: URL: https://github.com/apache/kafka/pull/14473#discussion_r1350536831 ## gradle.properties: ## @@ -25,6 +25,9 @@ group=org.apache.kafka # - streams/quickstart/java/pom.xml version=3.7.0-SNAPSHOT scalaVersion=2.13.12 +# Adding swaggerVersion in gradle.properties to have a single version in place for swagger +# New version of Swagger 2.2.14 requires minimum JDK 11. +swaggerVersion=2.2.8 Review Comment: Why didn't we keep this in `dependencies.gradle`? It's confusing to have a separate file for versions (outside of the Scala version, which is special in a few ways). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
mimaison merged PR #14473: URL: https://github.com/apache/kafka/pull/14473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
atu-sharm commented on PR #14473: URL: https://github.com/apache/kafka/pull/14473#issuecomment-1748940720 Thanks, @mimaison for the review, added changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
mimaison commented on code in PR #14473:
URL: https://github.com/apache/kafka/pull/14473#discussion_r1347410102
##
gradle/dependencies.gradle:
##
@@ -158,9 +158,6 @@ versions += [
slf4j: "1.7.36",
snappy: "1.1.10.5",
spotbugs: "4.7.3",
- // New version of Swagger 2.2.14 requires minimum JDK 11.
Review Comment:
Can we keep this comment in gradle.properties?
I created https://issues.apache.org/jira/browse/KAFKA-15549 to remember us
we will be able to bump it once support for Java 8 is removed.
##
build.gradle:
##
@@ -37,7 +37,7 @@ plugins {
id 'java-library'
id 'org.owasp.dependencycheck' version '8.2.1'
id 'org.nosphere.apache.rat' version "0.8.1"
- id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8" // keep
aligned with the swagger version used in gradle/dependencies.gradle
+ id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}" //
keep aligned with the swagger version used in gradle/dependencies.gradle
Review Comment:
I guess we can remove the comment if we have the version in a single place
##
build.gradle:
##
@@ -938,7 +938,7 @@ project(':core') {
exclude group: 'junit', module: 'junit'
}
testImplementation libs.caffeine
-
Review Comment:
Can we undo this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
atu-sharm commented on PR #14473: URL: https://github.com/apache/kafka/pull/14473#issuecomment-1744276832 Hey @mimaison can you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
atu-sharm commented on PR #14473: URL: https://github.com/apache/kafka/pull/14473#issuecomment-1744276403 As per - Gradle docs : https://docs.gradle.org/current/userguide/plugins.html#sec:plugin_version_management:~:text=will%20be%20checked.-,Plugin%20Version%20Management,-A%20plugins%20%7B%7D - PR: https://github.com/gradle/gradle/issues/1697#issuecomment-506910915 "We cannot call methods or use sophisticated build logic to retrieve dependency versions. But anything declared in a gradle.properties file can be inserted into the version string." Made changes accordingly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies [kafka]
atu-sharm closed pull request #14472: KAFKA-15521: Refactor build.gradle to align gradle swagger plugin with swagger dependencies URL: https://github.com/apache/kafka/pull/14472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
