Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

[via GitHub]

cadonna merged PR #14859:
URL: https://github.com/apache/kafka/pull/14859


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

[via GitHub]

cadonna commented on code in PR #14859:
URL: https://github.com/apache/kafka/pull/14859#discussion_r1412110677


##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -663,6 +662,10 @@ public Map 
committed(final Set

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

[via GitHub]

AndrewJSchofield commented on code in PR #14859:
URL: https://github.com/apache/kafka/pull/14859#discussion_r1411266359


##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -653,7 +652,7 @@ public Map 
committed(final Set();
+return Collections.emptyMap();

Review Comment:
   I made it strictly identical to the previous implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

[via GitHub]

kirktrue commented on code in PR #14859:
URL: https://github.com/apache/kafka/pull/14859#discussion_r1411224159


##
checkstyle/suppressions.xml:
##
@@ -48,7 +48,7 @@
 
 

Review Comment:
   Thank you for this clean up!



##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -594,8 +594,9 @@ class PlaintextConsumerTest extends BaseConsumerTest {
 assertThrows(classOf[InvalidTopicException], () => 
consumer.partitionsFor(";3# ads,{234"))
   }
 
+  // Temporarily do not run flaky test for consumer group protocol
   @ParameterizedTest(name = 
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
-  @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+  
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersGenericGroupProtocolOnly"))

Review Comment:
    



##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -653,7 +652,7 @@ public Map 
committed(final Set();
+return Collections.emptyMap();

Review Comment:
   Does this make a difference, or just a stylistic/pet peeve/optimiz/sation 
thing?



##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -594,8 +594,9 @@ class PlaintextConsumerTest extends BaseConsumerTest {
 assertThrows(classOf[InvalidTopicException], () => 
consumer.partitionsFor(";3# ads,{234"))
   }
 
+  // Temporarily do not run flaky test for consumer group protocol
   @ParameterizedTest(name = 
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
-  @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+  
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersGenericGroupProtocolOnly"))

Review Comment:
    



##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -663,6 +662,10 @@ public Map 
committed(final Set 
committed(final Set

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

[via GitHub]

AndrewJSchofield commented on PR #14859:
URL: https://github.com/apache/kafka/pull/14859#issuecomment-1831950136

   https://issues.apache.org/jira/browse/KAFKA-15932 opened for flaky test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

[via GitHub]

AndrewJSchofield closed pull request #14859: KAFKA-15842: Correct handling of 
KafkaConsumer.committed for new consumer
URL: https://github.com/apache/kafka/pull/14859


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

[via GitHub]

AndrewJSchofield commented on PR #14859:
URL: https://github.com/apache/kafka/pull/14859#issuecomment-1831514140

   Closing and reopening PR to retry failed build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org