Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
OmniaGM commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-2126925294 > @OmniaGM Are you still working on moving KafkaConfig out of core? Can you, please, show me PR's you are currently working on regarding KafkaConfig? I was about to open a pr for this :) I have two local prs left then we can call this jira done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
nizhikov commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-2126366162 @OmniaGM Are you still working on moving KafkaConfig out of core? Can you, please, show me PR's you are currently working on regarding KafkaConfig? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
OmniaGM closed pull request #15501: KAFKA-15853: Move KafkaConfig properties definition out of core URL: https://github.com/apache/kafka/pull/15501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
OmniaGM commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-2061520938 Am going to close this one as it drifted away from the approach we took to break the configs out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
nizhikov commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-2008920265 @OmniaGM > Start doing this but will be continue this after the Kafka Summit London. Great! Don't hesitate to ask for assistance if you need any help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
OmniaGM commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-2008054490 > Hello @OmniaGM > > > > Are you be able to split this PR in several to simplify review and merge? > > My jira https://issues.apache.org/jira/browse/KAFKA-14588 blocked by migration `KafkaConfig` from `core` so I want to help you with these changes somehow. > > > > If you have no time to split - I can offer my help with this. Start doing this but will be continue this after the Kafka Summit London. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
nizhikov commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-2007922919 Hello @OmniaGM Are you be able to split this PR in several to simplify review and merge? My jira https://issues.apache.org/jira/browse/KAFKA-14588 blocked by migration `KafkaConfig` from `core` so I want to help you with these changes somehow. If you have no time to split - I can offer my help with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]
nizhikov commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-1999413290 Hello @OmniaGM I think this PR still too big for one change. Can we split it? We can start with LogConfiguration: ``` /** * Log Configuration ***/ val NumPartitionsProp = "num.partitions" val LogDirsProp = LogConfigPrefix + "dirs" val LogDirProp = LogConfigPrefix + "dir" val LogSegmentBytesProp = ServerTopicConfigSynonyms.serverSynonym(TopicConfig.SEGMENT_BYTES_CONFIG) ``` and replication configuration: ``` /** * Replication configuration ***/ val ControllerSocketTimeoutMsProp = "controller.socket.timeout.ms" val DefaultReplicationFactorProp = "default.replication.factor" val ReplicaLagTimeMaxMsProp = "replica.lag.time.max.ms" val ReplicaSocketTimeoutMsProp = "replica.socket.timeout.ms" val ReplicaSocketReceiveBufferBytesProp = "replica.socket.receive.buffer.bytes" ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
