Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
omkreddy merged PR #14938: URL: https://github.com/apache/kafka/pull/14938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
VedarthConfluent commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422647778
##
docs/quickstart.html:
##
@@ -94,6 +98,12 @@
$
bin/kafka-server-start.sh config/kraft/server.properties
+Using docker image
+
+Start the kafka docker container
+
+$ docker run -p
9092:9092 apache/kafka:{{fullDotVersion}}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
VedarthConfluent commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422629371
##
docs/quickstart.html:
##
@@ -94,6 +98,12 @@
$
bin/kafka-server-start.sh config/kraft/server.properties
+Using docker image
+
+Start the kafka docker container
+
+$ docker run -p
9092:9092 apache/kafka:{{fullDotVersion}}
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
VedarthConfluent commented on code in PR #14938: URL: https://github.com/apache/kafka/pull/14938#discussion_r1422629627 ## docker/examples/jvm/cluster/combined/ssl/docker-compose.yml: ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +version: '2' +services: + kafka-1: +image: apache/kafka:latest +hostname: kafka-1 +container_name: kafka-1 +ports: + - 29093:9093 +volumes: + - ../../../../fixtures/secrets:/etc/kafka/secrets +environment: + KAFKA_NODE_ID: 1 + KAFKA_PROCESS_ROLES: 'broker,controller' + KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: 'SSL:SSL,CONTROLLER:PLAINTEXT,SSL-INT:SSL' Review Comment: Done ## docs/docker.html: ## @@ -0,0 +1,104 @@ + + + + + +
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
VedarthConfluent commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422629371
##
docs/quickstart.html:
##
@@ -94,6 +98,12 @@
$
bin/kafka-server-start.sh config/kraft/server.properties
+Using docker image
+
+Start the kafka docker container
+
+$ docker run -p
9092:9092 apache/kafka:{{fullDotVersion}}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
omkreddy commented on code in PR #14938: URL: https://github.com/apache/kafka/pull/14938#discussion_r1422015243 ## docker/examples/jvm/cluster/combined/ssl/docker-compose.yml: ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +version: '2' +services: + kafka-1: +image: apache/kafka:latest +hostname: kafka-1 +container_name: kafka-1 +ports: + - 29093:9093 +volumes: + - ../../../../fixtures/secrets:/etc/kafka/secrets +environment: + KAFKA_NODE_ID: 1 + KAFKA_PROCESS_ROLES: 'broker,controller' + KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: 'SSL:SSL,CONTROLLER:PLAINTEXT,SSL-INT:SSL' Review Comment: SSL-INT => SSL-INTERNAL ## docker/examples/jvm/cluster/combined/plaintext/docker-compose.yml: ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +version: '2' +services: + kafka-1: +image: apache/kafka:latest +hostname: kafka-1 +container_name: kafka-1 +ports: + - 29092:9092 +environment: + KAFKA_NODE_ID: 1 + KAFKA_PROCESS_ROLES: 'broker,controller' + KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: 'CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT' + KAFKA_CONTROLLER_QUORUM_VOTERS: '1@kafka-1:9093,2@kafka-2:9093,3@kafka-3:9093' + KAFKA_LISTENERS: 'PLAINTEXT://:19092,CONTROLLER://:9093,PLAINTEXT_HOST://:9092' Review Comment: PLAINTEXT -> PLAINTEXT_INTERNAL ## docs/docker.html: ## @@ -0,0 +1,104 @@ + + + + + +
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
VedarthConfluent commented on code in PR #14938: URL: https://github.com/apache/kafka/pull/14938#discussion_r1420442398 ## docker/examples/README.md: ## @@ -0,0 +1,31 @@ +Kafka Docker Image Examples +--- + +- This directory contains docker compose files for some example configs to run docker image. + +- Run the commands from root of the repository. + +- To bring up the docker compose examples, use docker compose command. + +For example:- +``` +# This command brings up JVM cluster +$ docker compose -f docker/examples/jvm/cluster/docker-compose.yml up Review Comment: This is done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
omkreddy commented on code in PR #14938: URL: https://github.com/apache/kafka/pull/14938#discussion_r1419313577 ## docker/examples/README.md: ## @@ -0,0 +1,31 @@ +Kafka Docker Image Examples +--- + +- This directory contains docker compose files for some example configs to run docker image. + +- Run the commands from root of the repository. + +- To bring up the docker compose examples, use docker compose command. + +For example:- +``` +# This command brings up JVM cluster +$ docker compose -f docker/examples/jvm/cluster/docker-compose.yml up Review Comment: need to update file path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
VedarthConfluent commented on code in PR #14938: URL: https://github.com/apache/kafka/pull/14938#discussion_r1418917975 ## docker/examples/jvm/cluster/docker-compose.yml: ## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +version: '1' Review Comment: I have added an example for multi node combined mode. I will create a new PR for adding more examples, including relatively complex ones like you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15879: Add documentation and examples for docker image [kafka]
omkreddy commented on code in PR #14938: URL: https://github.com/apache/kafka/pull/14938#discussion_r1418474509 ## docker/examples/jvm/cluster/docker-compose.yml: ## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +version: '1' Review Comment: It will be great if we can add a multi-node example with multiple listeners like SSL, SASL_SSL (plain mechanism) with authorizer configured. Can be added in another PR ## docker/examples/jvm/cluster/docker-compose.yml: ## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +--- +version: '1' Review Comment: can we also add compose file for multi node combined mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
