Re: [PR] KAFKA-15981: update Group size only when groups size changes [kafka]

2023-12-13 Thread via GitHub


dajac merged PR #14988:
URL: https://github.com/apache/kafka/pull/14988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15981: update Group size only when groups size changes [kafka]

2023-12-13 Thread via GitHub


dajac commented on PR #14988:
URL: https://github.com/apache/kafka/pull/14988#issuecomment-1853432817

   All the failed tests are not related. Merging to trunk and 3.7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15981: update Group size only when groups size changes [kafka]

2023-12-13 Thread via GitHub


dajac commented on PR #14988:
URL: https://github.com/apache/kafka/pull/14988#issuecomment-1853431750

   @jeffkbkim Yeah, I have noticed that failing test too. It is not related to 
your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15981: update Group size only when groups size changes [kafka]

2023-12-12 Thread via GitHub


jeffkbkim commented on PR #14988:
URL: https://github.com/apache/kafka/pull/14988#issuecomment-1853155239

   The previous build had the error from test 
`testNoGroupEpochBumpWhenStaticMemberTemporarilyLeaves() – 
org.apache.kafka.coordinator.group.GroupMetadataManagerTest` from jdk 8
   ```
   expected: 
<[Record(key=ApiMessageAndVersion(ConsumerGroupCurrentMemberAssignmentKey(groupId='fooup',
 memberId='_hAb4Z1NSHG2Xp42s7KO9Q') at version 8), 
value=ApiMessageAndVersion(ConsumerGroupCurrentMemberAssignmentValue(memberEpoch=-2,
 previousMemberEpoch=9, targetMemberEpoch=10, 
assignedPartitions=[TopicPartitions(topicId=YX9w07JjSp2Yw1ra6Bfkaw, 
partitions=[2]), TopicPartitions(topicId=brQVJtH8RsyF4BayziKeBQ, partitions=[3, 
4, 5])], partitionsPendingRevocation=[], partitionsPendingAssignment=[], 
error=0, metadataVersion=0, metadataBytes=[]) at version 0))]> but was: 
<[Record(key=ApiMessageAndVersion(ConsumerGroupCurrentMemberAssignmentKey(groupId='fooup',
 memberId='_hAb4Z1NSHG2Xp42s7KO9Q') at version 8), 
value=ApiMessageAndVersion(ConsumerGroupCurrentMemberAssignmentValue(memberEpoch=-2,
 previousMemberEpoch=9, targetMemberEpoch=10, 
assignedPartitions=[TopicPartitions(topicId=brQVJtH8RsyF4BayziKeBQ, 
partitions=[3, 4, 5]), TopicPartitions(topicId=YX9w07JjSp2Yw1ra6Bfkaw, 
partitions=
 [2])], partitionsPendingRevocation=[], partitionsPendingAssignment=[], 
error=0, metadataVersion=0, metadataBytes=[]) at version 0))]>
   ```
   
   Where the diff is the ordering between the two `TopicPartitions` in 
`assignedPartitions` field. I don't think my code touched this. Was this 
already flaky?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org