Re: [PR] KAFKA-16013: impelement ExpiresPerSec for remote fetch [kafka]
showuon commented on code in PR #15015:
URL: https://github.com/apache/kafka/pull/15015#discussion_r1429855974
##
core/src/main/scala/kafka/server/DelayedRemoteFetch.scala:
##
@@ -41,6 +41,10 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void],
responseCallback: Seq[(TopicIdPartition,
FetchPartitionData)] => Unit)
extends DelayedOperation(fetchParams.maxWaitMs) {
+ if (fetchParams.isFromFollower) {
+warn(s"The follower should not invoke remote fetch. Fetch params are:
$fetchParams")
Review Comment:
Yes, agree. Let me update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16013: impelement ExpiresPerSec for remote fetch [kafka]
satishd commented on code in PR #15015:
URL: https://github.com/apache/kafka/pull/15015#discussion_r1429830043
##
core/src/main/scala/kafka/server/DelayedRemoteFetch.scala:
##
@@ -41,6 +41,10 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void],
responseCallback: Seq[(TopicIdPartition,
FetchPartitionData)] => Unit)
extends DelayedOperation(fetchParams.maxWaitMs) {
+ if (fetchParams.isFromFollower) {
+warn(s"The follower should not invoke remote fetch. Fetch params are:
$fetchParams")
Review Comment:
Can we throw an exception instead of throwing a warning message as it should
not have reached here for follower fetch requests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16013: impelement ExpiresPerSec for remote fetch [kafka]
showuon commented on PR #15015: URL: https://github.com/apache/kafka/pull/15015#issuecomment-1857731719 @satishd , addressed your comment in this PR. Thanks. https://github.com/apache/kafka/pull/15014#discussion_r1426937685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16013: impelement ExpiresPerSec for remote fetch [kafka]
showuon commented on PR #15015: URL: https://github.com/apache/kafka/pull/15015#issuecomment-1855741809 Will open for review after https://github.com/apache/kafka/pull/15014 merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
