Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership (2) [kafka]

[via GitHub]

chia7712 commented on PR #15857:
URL: https://github.com/apache/kafka/pull/15857#issuecomment-2145657572

   @Alexander-Aghili Could you please fix conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership (2) [kafka]

[via GitHub]

Alexander-Aghili commented on PR #15857:
URL: https://github.com/apache/kafka/pull/15857#issuecomment-2144259480

   Apologizes for the delay. I changed the code so that the tests passed 
locally. Let me know if that resolved the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership (2) [kafka]

[via GitHub]

chia7712 commented on PR #15857:
URL: https://github.com/apache/kafka/pull/15857#issuecomment-2133900808

   @Alexander-Aghili any update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership (2) [kafka]

[via GitHub]

chia7712 commented on code in PR #15857:
URL: https://github.com/apache/kafka/pull/15857#discussion_r1589872138


##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -590,76 +681,92 @@ public void testClusterCopy() {
 errors.put("topic3", Errors.INVALID_TOPIC_EXCEPTION);
 errors.put("topic4", Errors.TOPIC_AUTHORIZATION_FAILED);
 
+
 MetadataResponse metadataResponse = 
RequestTestUtils.metadataUpdateWith("dummy", 4, errors, counts);
 metadata.updateWithCurrentRequestVersion(metadataResponse, false, 0L);
 
+
 Cluster cluster = metadata.fetch();
 assertEquals(cluster.clusterResource().clusterId(), "dummy");
 assertEquals(cluster.nodes().size(), 4);
 
+
 // topic counts
 assertEquals(cluster.invalidTopics(), Collections.singleton("topic3"));
 assertEquals(cluster.unauthorizedTopics(), 
Collections.singleton("topic4"));
 assertEquals(cluster.topics().size(), 3);
 assertEquals(cluster.internalTopics(), 
Collections.singleton(Topic.GROUP_METADATA_TOPIC_NAME));
 
+
 // partition counts
 assertEquals(cluster.partitionsForTopic("topic1").size(), 2);
 assertEquals(cluster.partitionsForTopic("topic2").size(), 3);
 
+
 // Sentinel instances
 InetSocketAddress address = 
InetSocketAddress.createUnresolved("localhost", 0);
-Cluster fromMetadata = 
MetadataSnapshot.bootstrap(Collections.singletonList(address)).cluster();
+Cluster fromMetadata = 
MetadataCache.bootstrap(Collections.singletonList(address)).cluster();

Review Comment:
   It seems this change make build failed. Could you check it please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org