Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

[via GitHub]

cmccabe merged PR #15118:
URL: https://github.com/apache/kafka/pull/15118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

[via GitHub]

mumrah commented on PR #15118:
URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875988796

   All production usages now call `latestProduction` and test usages (including 
benchmark classes) call `latestTesting. One exception is is 
`QuorumFeatures#defaultFeatureMap(boolean enableUnstable)` which calls either 
depending on its argument.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

[via GitHub]

cmccabe commented on PR #15118:
URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875906638

   Alternately, if we wanted to make this literally impossible to invoke from a 
non-test context, we could move `MetadataVersion.latest` into 
`MetadataVersionTest.latest`.
   
   The downside is that that would require all the other test modules to depend 
on `:server-common:test` (although a lot of them already do?) That might extend 
the build time? Not sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

[via GitHub]

cmccabe commented on PR #15118:
URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875904378

   I agree with @ijuma that just having a boolean isn't very clear.
   
   How about renaming `MetadataVersion.latest()` to 
`MetadataVersion.latestTesting()`, and then creating a separate function 
`MetadataVersion.latestProduction()`?
   
   That seems like the clearest we're going to get with this. Devs won't want 
to invoke something with "testing" in the name in  a non-test context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

[via GitHub]

ijuma commented on code in PR #15118:
URL: https://github.com/apache/kafka/pull/15118#discussion_r1440881725


##
core/src/main/java/kafka/server/builders/LogManagerBuilder.java:
##
@@ -48,7 +48,7 @@ public class LogManagerBuilder {
 private int maxTransactionTimeoutMs = 15 * 60 * 1000;
 private ProducerStateManagerConfig producerStateManagerConfig = new 
ProducerStateManagerConfig(6, false);
 private int producerIdExpirationCheckIntervalMs = 60;
-private MetadataVersion interBrokerProtocolVersion = 
MetadataVersion.latest();
+private MetadataVersion interBrokerProtocolVersion = 
MetadataVersion.latest(true);

Review Comment:
   An enum instead of boolean would make this a lot more readable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org