Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
omkreddy merged PR #16027: URL: https://github.com/apache/kafka/pull/16027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
omkreddy commented on PR #16027: URL: https://github.com/apache/kafka/pull/16027#issuecomment-2129194429 There is an failure due to missing license: ``` [2024-05-23T07:39:35.270Z] Execution failed for task ':rat'. [2024-05-23T07:39:35.270Z] > A failure occurred while executing org.nosphere.apache.rat.RatWork [2024-05-23T07:39:35.270Z]> Apache Rat audit failure - 1 unapproved license [2024-05-23T07:39:35.270Z] See file:///home/jenkins/workspace/Kafka_kafka-pr_PR-16027/build/rat/index.html ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
KrishVora01 commented on code in PR #16027:
URL: https://github.com/apache/kafka/pull/16027#discussion_r1611093413
##
docker/generate_kafka_pr_template.py:
##
@@ -0,0 +1,100 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Python script to prepare the PR template for the docker official image
+This script is used to prepare the PR template for the docker official image
+
+Usage:
+Example command:-
+generate_kafka_pr_template.py --help
+Get detailed description of each option
+
+generate_kafka_pr_template.py --image-type
+
+This command will build a PR template for as image type
(jvm by default) based docker official image,
+on the directories present under docker/docker_official_images.
+This PR template will be used to raise a PR in the Docker Official
Images Repo.
+"""
+
+import os
+import subprocess
+import sys
+import argparse
+from pathlib import Path
+
+
+# Returns the current branch from which the script is being run
+def get_current_branch():
+return subprocess.check_output(["git", "rev-parse", "--abbrev-ref",
"HEAD"]).strip().decode('utf-8')
+
+
+# Returns the hash of the most recent commit that modified any of the
specified files.
+def file_commit(*files):
+return subprocess.check_output(["git", "log", "-1", "--format=format:%H",
"HEAD", "--"] + list(files)).strip().decode('utf-8')
+
+
+# Returns the latest commit hash for all files in a given directory.
+def dir_commit(directory):
+docker_required_scripts = [str(path) for path in
Path(directory).rglob('*') if path.is_file()]
+files_to_check = [os.path.join(directory, "Dockerfile")] +
docker_required_scripts
+return file_commit(*files_to_check)
+
+
+# Split the version string into parts and convert them to integers for version
comparision
+def get_version_parts(version):
+return tuple(int(part) for part in version.name.split('.'))
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("--image-type", "-type", choices=[
+"jvm"], default="jvm", dest="image_type", help="Image
type you want to build")
+args = parser.parse_args()
+if get_current_branch() != "trunk":
Review Comment:
Removed this check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
KrishVora01 commented on code in PR #16027:
URL: https://github.com/apache/kafka/pull/16027#discussion_r1611093207
##
docker/docker_official_image_build_test.py:
##
@@ -0,0 +1,90 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Python script to build and test a docker image
+This script is used to generate a test report
+
+Usage:
+docker_official_image_build_test.py --help
+Get detailed description of each option
+
+Example command:-
+docker_official_image_build_test.py --image-tag
--image-type --kafka-version
+
+This command will build an image with as image name,
as image_tag (it will be latest by default),
+ as image type (jvm by default), for the
kafka version for which the image is being built, and
+run tests on the image.
+-b can be passed as additional argument if you just want to build the
image.
+-t can be passed if you just want to run tests on the image.
+"""
+
+import argparse
+from distutils.dir_util import copy_tree
+import shutil
+from common import execute
+from docker_build_test import run_docker_tests
+import tempfile
+import os
+
+
+def build_docker_official_image(image, tag, kafka_version, image_type):
+image = f'{image}:{tag}'
+current_dir = os.path.dirname(os.path.realpath(__file__))
+temp_dir_path = tempfile.mkdtemp()
+
copy_tree(f"{current_dir}/docker_official_images/{kafka_version}/{image_type}",
+ f"{temp_dir_path}/{image_type}")
+
copy_tree(f"{current_dir}/docker_official_images/{kafka_version}/jvm/resources",
+ f"{temp_dir_path}/{image_type}/resources")
+command = f"docker build -f $DOCKER_FILE -t {image} $DOCKER_DIR"
+command = command.replace("$DOCKER_FILE",
f"{temp_dir_path}/{image_type}/Dockerfile")
+command = command.replace("$DOCKER_DIR", f"{temp_dir_path}/{image_type}")
+try:
+execute(command.split())
+except:
+raise SystemError("Docker Image Build failed")
+finally:
+shutil.rmtree(temp_dir_path)
+
+
+if __name__ == '__main__':
+parser = argparse.ArgumentParser()
+parser.add_argument(
+"image", help="Image name that you want to keep for the Docker image")
+parser.add_argument("--image-tag", "-tag", default="latest",
+dest="tag", help="Image tag that you want to add to
the image")
+parser.add_argument("--image-type", "-type", choices=[
+"jvm"], default="jvm", dest="image_type", help="Image
type you want to build")
+parser.add_argument("--kafka-version", "-v", dest="kafka_version",
+help="Kafka version for which the source for docker
official image is to be built")
+parser.add_argument("--build", "-b", action="store_true",
dest="build_only",
+default=False, help="Only build the image, don't run
tests")
+parser.add_argument("--test", "-t", action="store_true", dest="test_only",
+default=False, help="Only run the tests, don't build
the image")
+args = parser.parse_args()
+kafka_url =
f"https://downloads.apache.org/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz;
+if args.build_only or not (args.build_only or args.test_only):
+if args.kafka_version:
+build_docker_official_image(args.image, args.tag,
args.kafka_version, args.image_type)
+else:
+raise ValueError(
+"--kafka-version is required argument for jvm docker official
image image")
+if args.test_only or not (args.build_only or args.test_only):
+run_docker_tests(args.image, args.tag, kafka_url, args.image_type)
+
Review Comment:
removed extra lines from all files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
KrishVora01 commented on code in PR #16027: URL: https://github.com/apache/kafka/pull/16027#discussion_r1611092562 ## .github/workflows/prepare_docker_official_image_source.yml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Docker Prepare Docker Official Image Source + +on: + workflow_dispatch: +inputs: + image_type: +type: choice +description: Docker image type to build and test +options: + - "jvm" + kafka_version: +description: Kafka version for which the source for docker official image is to be built +required: true + +jobs: + build: +runs-on: ubuntu-latest +steps: +- uses: actions/checkout@v3 +- name: Set up Python 3.10 + uses: actions/setup-python@v3 + with: +python-version: "3.10" +- name: Install dependencies + run: | +python -m pip install --upgrade pip +pip install -r docker/requirements.txt +- name: Build New Artifact Review Comment: Renamed this ## docker/docker_official_images/.gitignore: ## Review Comment: modified this to .gitkeep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
KrishVora01 commented on code in PR #16027: URL: https://github.com/apache/kafka/pull/16027#discussion_r1611091209 ## .github/workflows/docker_official_image_build_and_test.yml: ## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Docker Official Image Build Test + +on: + workflow_dispatch: +inputs: + image_type: +type: choice +description: Docker image type to build and test +options: + - "jvm" + kafka_version: +description: Kafka version for which the source for docker official image is to be built Review Comment: Made this change. ## .github/workflows/prepare_docker_official_image_source.yml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Docker Prepare Docker Official Image Source + +on: + workflow_dispatch: +inputs: + image_type: +type: choice +description: Docker image type to build and test +options: + - "jvm" + kafka_version: +description: Kafka version for which the source for docker official image is to be built Review Comment: Made this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
VedarthConfluent commented on code in PR #16027:
URL: https://github.com/apache/kafka/pull/16027#discussion_r1611077695
##
docker/generate_kafka_pr_template.py:
##
@@ -0,0 +1,100 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Python script to prepare the PR template for the docker official image
+This script is used to prepare the PR template for the docker official image
+
+Usage:
+Example command:-
+generate_kafka_pr_template.py --help
+Get detailed description of each option
+
+generate_kafka_pr_template.py --image-type
+
+This command will build a PR template for as image type
(jvm by default) based docker official image,
+on the directories present under docker/docker_official_images.
+This PR template will be used to raise a PR in the Docker Official
Images Repo.
+"""
+
+import os
+import subprocess
+import sys
+import argparse
+from pathlib import Path
+
+
+# Returns the current branch from which the script is being run
+def get_current_branch():
+return subprocess.check_output(["git", "rev-parse", "--abbrev-ref",
"HEAD"]).strip().decode('utf-8')
+
+
+# Returns the hash of the most recent commit that modified any of the
specified files.
+def file_commit(*files):
+return subprocess.check_output(["git", "log", "-1", "--format=format:%H",
"HEAD", "--"] + list(files)).strip().decode('utf-8')
+
+
+# Returns the latest commit hash for all files in a given directory.
+def dir_commit(directory):
+docker_required_scripts = [str(path) for path in
Path(directory).rglob('*') if path.is_file()]
+files_to_check = [os.path.join(directory, "Dockerfile")] +
docker_required_scripts
+return file_commit(*files_to_check)
+
+
+# Split the version string into parts and convert them to integers for version
comparision
+def get_version_parts(version):
+return tuple(int(part) for part in version.name.split('.'))
+
+
+def main():
+parser = argparse.ArgumentParser()
+parser.add_argument("--image-type", "-type", choices=[
+"jvm"], default="jvm", dest="image_type", help="Image
type you want to build")
+args = parser.parse_args()
+if get_current_branch() != "trunk":
Review Comment:
Not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
VedarthConfluent commented on code in PR #16027: URL: https://github.com/apache/kafka/pull/16027#discussion_r1611056103 ## docker/docker_official_images/.gitignore: ## Review Comment: Can consider using .gitkeep if empty folder is needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
VedarthConfluent commented on code in PR #16027: URL: https://github.com/apache/kafka/pull/16027#discussion_r1611048213 ## docker/docker_official_images/.gitignore: ## Review Comment: Not needed, we can remove this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
VedarthConfluent commented on code in PR #16027:
URL: https://github.com/apache/kafka/pull/16027#discussion_r1611047289
##
docker/docker_official_image_build_test.py:
##
@@ -0,0 +1,90 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Python script to build and test a docker image
+This script is used to generate a test report
+
+Usage:
+docker_official_image_build_test.py --help
+Get detailed description of each option
+
+Example command:-
+docker_official_image_build_test.py --image-tag
--image-type --kafka-version
+
+This command will build an image with as image name,
as image_tag (it will be latest by default),
+ as image type (jvm by default), for the
kafka version for which the image is being built, and
+run tests on the image.
+-b can be passed as additional argument if you just want to build the
image.
+-t can be passed if you just want to run tests on the image.
+"""
+
+import argparse
+from distutils.dir_util import copy_tree
+import shutil
+from common import execute
+from docker_build_test import run_docker_tests
+import tempfile
+import os
+
+
+def build_docker_official_image(image, tag, kafka_version, image_type):
+image = f'{image}:{tag}'
+current_dir = os.path.dirname(os.path.realpath(__file__))
+temp_dir_path = tempfile.mkdtemp()
+
copy_tree(f"{current_dir}/docker_official_images/{kafka_version}/{image_type}",
+ f"{temp_dir_path}/{image_type}")
+
copy_tree(f"{current_dir}/docker_official_images/{kafka_version}/jvm/resources",
+ f"{temp_dir_path}/{image_type}/resources")
+command = f"docker build -f $DOCKER_FILE -t {image} $DOCKER_DIR"
+command = command.replace("$DOCKER_FILE",
f"{temp_dir_path}/{image_type}/Dockerfile")
+command = command.replace("$DOCKER_DIR", f"{temp_dir_path}/{image_type}")
+try:
+execute(command.split())
+except:
+raise SystemError("Docker Image Build failed")
+finally:
+shutil.rmtree(temp_dir_path)
+
+
+if __name__ == '__main__':
+parser = argparse.ArgumentParser()
+parser.add_argument(
+"image", help="Image name that you want to keep for the Docker image")
+parser.add_argument("--image-tag", "-tag", default="latest",
+dest="tag", help="Image tag that you want to add to
the image")
+parser.add_argument("--image-type", "-type", choices=[
+"jvm"], default="jvm", dest="image_type", help="Image
type you want to build")
+parser.add_argument("--kafka-version", "-v", dest="kafka_version",
+help="Kafka version for which the source for docker
official image is to be built")
+parser.add_argument("--build", "-b", action="store_true",
dest="build_only",
+default=False, help="Only build the image, don't run
tests")
+parser.add_argument("--test", "-t", action="store_true", dest="test_only",
+default=False, help="Only run the tests, don't build
the image")
+args = parser.parse_args()
+kafka_url =
f"https://downloads.apache.org/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz;
+if args.build_only or not (args.build_only or args.test_only):
+if args.kafka_version:
+build_docker_official_image(args.image, args.tag,
args.kafka_version, args.image_type)
+else:
+raise ValueError(
+"--kafka-version is required argument for jvm docker official
image image")
+if args.test_only or not (args.build_only or args.test_only):
+run_docker_tests(args.image, args.tag, kafka_url, args.image_type)
+
Review Comment:
nit: remove extra lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
VedarthConfluent commented on code in PR #16027: URL: https://github.com/apache/kafka/pull/16027#discussion_r1611042138 ## .github/workflows/prepare_docker_official_image_source.yml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Docker Prepare Docker Official Image Source + +on: + workflow_dispatch: +inputs: + image_type: +type: choice +description: Docker image type to build and test +options: + - "jvm" + kafka_version: +description: Kafka version for which the source for docker official image is to be built +required: true + +jobs: + build: +runs-on: ubuntu-latest +steps: +- uses: actions/checkout@v3 +- name: Set up Python 3.10 + uses: actions/setup-python@v3 + with: +python-version: "3.10" +- name: Install dependencies + run: | +python -m pip install --upgrade pip +pip install -r docker/requirements.txt +- name: Build New Artifact Review Comment: nit: Maybe Build Docker Official Image Source? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
VedarthConfluent commented on code in PR #16027: URL: https://github.com/apache/kafka/pull/16027#discussion_r1611041547 ## .github/workflows/prepare_docker_official_image_source.yml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Docker Prepare Docker Official Image Source + +on: + workflow_dispatch: +inputs: + image_type: +type: choice +description: Docker image type to build and test +options: + - "jvm" + kafka_version: +description: Kafka version for which the source for docker official image is to be built Review Comment: Same as https://github.com/apache/kafka/pull/16027/files#r1611040507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
VedarthConfluent commented on code in PR #16027: URL: https://github.com/apache/kafka/pull/16027#discussion_r1611040507 ## .github/workflows/docker_official_image_build_and_test.yml: ## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Docker Official Image Build Test + +on: + workflow_dispatch: +inputs: + image_type: +type: choice +description: Docker image type to build and test +options: + - "jvm" + kafka_version: +description: Kafka version for which the source for docker official image is to be built Review Comment: Simplify and mention that version should be >= 3.7.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
KrishVora01 closed pull request #16018: KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images URL: https://github.com/apache/kafka/pull/16018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images [kafka]
KrishVora01 closed pull request #15704: KAFKA-16373: KIP-1028: Adding code to support Apache Kafka Docker Official Images URL: https://github.com/apache/kafka/pull/15704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
