Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter`, `GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module [kafka]
chia7712 commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2171118271 > If we mark core Formatter to deprecate, should It need to delete at next Kafka version? yep if we push the code to deprecate them in 3.9.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter`, `GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module [kafka]
m1a2st commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2171062358 If we mark core Formatter to deprecate, should It need to delete at next Kafka version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter`, `GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module [kafka]
chia7712 commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2170988619 just have another idea for minimizing the changes: Maybe we don't touch the code in the core, but we deprecate them. And then we add new message formatter instead. For example: 1. add new TransactionLogMessageFormatter and deprecate core code 2. add new OffsetsMessageFormatter and deprecate core code 3. add new GroupMetadataMessageFormatter and deprecate core code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter`, `GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module [kafka]
m1a2st commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2169144736 I think that seperate to three PRs are good, these formatter are not dependency for each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter`, `GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module [kafka]
chia7712 commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2169105054 This PR includes many migration, and hence it gets a bit complicated. Maybe we should separate it into different PRs. For example: 1. move `TransactionLog` to `transaction-coordinator` module. this include `TransactionLogMessageFormatter` migration 2. move `OffsetsMessageFormatter` 3. move `GroupMetadataMessageFormatter` WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter`, `GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module [kafka]
m1a2st commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2147551725 @chia7712, Please take a look, Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter`, GroupMetadataMessageFormatter` and `OffsetsMessageFormatter`to tools module [kafka]
chia7712 commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2124952595 @m1a2st could you please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
