Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
chia7712 commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668784663
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -171,7 +170,7 @@ object RequestChannel extends Logging {
s"$forwardDescription$header -- ${loggableRequest.toString(details)}"
}
-def body[T <: AbstractRequest](implicit classTag: ClassTag[T],
@nowarn("cat=unused") nn: NotNothing[T]): T = {
+def body[T <: AbstractRequest](implicit classTag: ClassTag[T]): T = {
Review Comment:
> It was there for a reason (to prevent cases where ClassTag is
automatically inferred to Nothing)
That was a good protection, but we use the request once casting the `body`.
Hence, the `nothing` type (i.e request.body`) will be noticed soon as we can't
call any methods from it.
> we decide to use the second way to resolve this problem
As @m1a2st mentioned, there is another approach for it. We can go back to
use it if @ijuma prefer it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
chia7712 commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668767527
##
build.gradle:
##
@@ -651,7 +651,7 @@ subprojects {
scalaCompileOptions.keepAliveMode = userKeepAliveMode
scalaCompileOptions.additionalParameters = [
- "-deprecation",
+ "-deprecation:false",
Review Comment:
Another way is to enable that check, and then we fix all related warnings
(most of fixes are to add `nowarn`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668739308
##
build.gradle:
##
@@ -651,7 +651,7 @@ subprojects {
scalaCompileOptions.keepAliveMode = userKeepAliveMode
scalaCompileOptions.additionalParameters = [
- "-deprecation",
+ "-deprecation:false",
Review Comment:
In new scala version, it will check the deprecated method, and make the
compile error like below
```
[2024-05-15T01:51:49.255Z] > Task :core:compileScala
[2024-05-15T01:51:49.255Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18:
method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:518:14:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:524:24:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:533:23:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:533:49:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
```
To resolve this, I found the way is to add `"-deprecation:false"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668748500
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -171,7 +170,7 @@ object RequestChannel extends Logging {
s"$forwardDescription$header -- ${loggableRequest.toString(details)}"
}
-def body[T <: AbstractRequest](implicit classTag: ClassTag[T],
@nowarn("cat=unused") nn: NotNothing[T]): T = {
+def body[T <: AbstractRequest](implicit classTag: ClassTag[T]): T = {
Review Comment:
In new Scala version, it will check `@nowarn` annotation, and make that
build error.
```
[2024-05-16T08:37:59.531Z] [Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/network/RequestChannel.scala:174:69:
@nowarn annotation does not suppress any warnings
[2024-05-16T08:37:59.531Z] one error found
```
In previous comments, we have two way to resolve this.
1. "-Wconf:cat=unused-nowarn:s"
2. Remove the usage of NotNothing
we decide to use the second way to resolve this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668748500
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -171,7 +170,7 @@ object RequestChannel extends Logging {
s"$forwardDescription$header -- ${loggableRequest.toString(details)}"
}
-def body[T <: AbstractRequest](implicit classTag: ClassTag[T],
@nowarn("cat=unused") nn: NotNothing[T]): T = {
+def body[T <: AbstractRequest](implicit classTag: ClassTag[T]): T = {
Review Comment:
In new Scala version, it will check `@nowarn` annotation, and make that
build error.
```
[2024-05-16T08:37:59.531Z] [Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/network/RequestChannel.scala:174:69:
@nowarn annotation does not suppress any warnings
[2024-05-16T08:37:59.531Z] one error found
```
In previous comments, we have two way to resolve this.
1. "-Wconf:cat=unused-nowarn:s"
2. Remove the usage of NotNothing
we decide to use the second way to resolve this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668739308
##
build.gradle:
##
@@ -651,7 +651,7 @@ subprojects {
scalaCompileOptions.keepAliveMode = userKeepAliveMode
scalaCompileOptions.additionalParameters = [
- "-deprecation",
+ "-deprecation:false",
Review Comment:
In new scala version, it will check the deprecated method, and make the
compile error like below
```
[2024-05-15T01:51:49.255Z] > Task :core:compileScala
[2024-05-15T01:51:49.255Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18:
method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:518:14:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:524:24:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:533:23:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
[2024-05-15T01:51:50.590Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:533:49:
class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated
```
To resolve this, I found the answer is to add `"-deprecation:false"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
ijuma commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668687904
##
build.gradle:
##
@@ -651,7 +651,7 @@ subprojects {
scalaCompileOptions.keepAliveMode = userKeepAliveMode
scalaCompileOptions.additionalParameters = [
- "-deprecation",
+ "-deprecation:false",
Review Comment:
Why was this changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
ijuma commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668682320
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -171,7 +170,7 @@ object RequestChannel extends Logging {
s"$forwardDescription$header -- ${loggableRequest.toString(details)}"
}
-def body[T <: AbstractRequest](implicit classTag: ClassTag[T],
@nowarn("cat=unused") nn: NotNothing[T]): T = {
+def body[T <: AbstractRequest](implicit classTag: ClassTag[T]): T = {
Review Comment:
Why did we remove this? It was there for a reason (to prevent cases where
`ClassTag` is automatically inferred to `Nothing`). Same for all other similar
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
ijuma commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668682320
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -171,7 +170,7 @@ object RequestChannel extends Logging {
s"$forwardDescription$header -- ${loggableRequest.toString(details)}"
}
-def body[T <: AbstractRequest](implicit classTag: ClassTag[T],
@nowarn("cat=unused") nn: NotNothing[T]): T = {
+def body[T <: AbstractRequest](implicit classTag: ClassTag[T]): T = {
Review Comment:
Why did we remove this? It was there for a reason (to prevent cases where
`ClassTag` is automatically inferred to `Nothing`. Same for all other similar
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
ijuma commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668682320
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -171,7 +170,7 @@ object RequestChannel extends Logging {
s"$forwardDescription$header -- ${loggableRequest.toString(details)}"
}
-def body[T <: AbstractRequest](implicit classTag: ClassTag[T],
@nowarn("cat=unused") nn: NotNothing[T]): T = {
+def body[T <: AbstractRequest](implicit classTag: ClassTag[T]): T = {
Review Comment:
Why did we remove this? It was there for a reason. Same for all other
similar cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
ijuma commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1668682320
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -171,7 +170,7 @@ object RequestChannel extends Logging {
s"$forwardDescription$header -- ${loggableRequest.toString(details)}"
}
-def body[T <: AbstractRequest](implicit classTag: ClassTag[T],
@nowarn("cat=unused") nn: NotNothing[T]): T = {
+def body[T <: AbstractRequest](implicit classTag: ClassTag[T]): T = {
Review Comment:
Why did we remove this? It was there for a reason. Same for all other
similar cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
chia7712 merged PR #15958: URL: https://github.com/apache/kafka/pull/15958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
chia7712 commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602988530
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
@m1a2st You have to remove the usage of `NotNothing`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602889444
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
```
[2024-05-16T08:37:59.531Z] [Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/network/RequestChannel.scala:174:69:
@nowarn annotation does not suppress any warnings
[2024-05-16T08:37:59.531Z] one error found
```
This error happened on Jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602865064
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
Ok, I will remove the `"-Wconf:cat=unused-nowarn:s"`, and try to complie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
chia7712 commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602851781
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
The issue is caused by the magic `NotNothing`. As we are in modern scala,
could you try to remove it? I give a try on my local, and both compile and test
work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602821237
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
I catch two main errors are class is depreate (1. ) and `@nowarn` build
error in previous build in Jenkins, but these classes or method are used by
other classes. I consider that I should not migrate these methods or classes in
this PR, thus I think that should closed these check when building scala
version 2.3.
1. ([Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18:
method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602821237
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
I catch two main errors are class is depreate (1. ) and `@nowarn` build
error in previous build in Jenkins, but these classes or method are used by
other classes. I consider that I should not migrate these methods or classes in
this PR, thus I think I should closed these check when building scala version
2.3.
1. ([Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18:
method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602821237
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
I catch two main errors are class is depreate (1. ) and @nowarn build error
in previous build in Jenkins, but these classes or method are used by other
classes. I consider that I should not migrate these methods or classes in this
PR, thus I think I should closed these check when building scala version 2.3.
1. ([Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18:
method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
chia7712 commented on code in PR #15958:
URL: https://github.com/apache/kafka/pull/15958#discussion_r1602785679
##
build.gradle:
##
@@ -671,7 +671,8 @@ subprojects {
"-Xlint:private-shadow",
"-Xlint:stars-align",
"-Xlint:type-parameter-shadow",
- "-Xlint:unused"
+ "-Xlint:unused",
Review Comment:
Pardon me, why we need those changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on PR #15958: URL: https://github.com/apache/kafka/pull/15958#issuecomment-2113680080 @chia7712, Thanks for your review, Scala 2.3 build is passed in Jenkins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
chia7712 commented on PR #15958: URL: https://github.com/apache/kafka/pull/15958#issuecomment-2111632709 ``` [2024-05-15T01:51:49.255Z] > Task :core:compileScala [2024-05-15T01:51:49.255Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18: method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated [2024-05-15T01:51:50.590Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:518:14: class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated [2024-05-15T01:51:50.590Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:524:24: class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated [2024-05-15T01:51:50.590Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:533:23: class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated [2024-05-15T01:51:50.590Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/zk/ZkData.scala:533:49: class LegacyPartitionAssignment in object ReassignPartitionsZNode is deprecated ``` please file the build error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 [kafka]
m1a2st commented on PR #15958: URL: https://github.com/apache/kafka/pull/15958#issuecomment-2111504233 @chia7712, This PR please take a look, Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
