Re: [PR] MINOR: Add public documentation for metrics introduced in KIP-963 [kafka]

2024-01-08 Thread via GitHub


satishd commented on PR #15138:
URL: https://github.com/apache/kafka/pull/15138#issuecomment-1882372491

   Merged to trunk and 3.7 branches. cc @stanislavkozlovski 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Add public documentation for metrics introduced in KIP-963 [kafka]

2024-01-08 Thread via GitHub


satishd merged PR #15138:
URL: https://github.com/apache/kafka/pull/15138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Add public documentation for metrics introduced in KIP-963 [kafka]

2024-01-07 Thread via GitHub


kamalcph commented on PR #15138:
URL: https://github.com/apache/kafka/pull/15138#issuecomment-1880411187

   Can we hold on this PR until #15133 gets merged? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Add public documentation for metrics introduced in KIP-963 [kafka]

2024-01-05 Thread via GitHub


clolov closed pull request #15131: MINOR: Add public documentation for metrics 
introduced in KIP-963
URL: https://github.com/apache/kafka/pull/15131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Add public documentation for metrics introduced in KIP-963 [kafka]

2024-01-05 Thread via GitHub


clolov commented on PR #15131:
URL: https://github.com/apache/kafka/pull/15131#issuecomment-1878999520

   Closing this PR and moving it to https://github.com/apache/kafka/pull/15138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Add public documentation for metrics introduced in KIP-963 [kafka]

2024-01-05 Thread via GitHub


showuon commented on PR #15131:
URL: https://github.com/apache/kafka/pull/15131#issuecomment-1878532279

   I found the bug that we didn't update the all topic metric value: 
[KAFKA-16085](https://issues.apache.org/jira/browse/KAFKA-16085) and the 
drafted solution: https://github.com/apache/kafka/pull/15133 . Please take a 
look when available. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Add public documentation for metrics introduced in KIP-963 [kafka]

2024-01-04 Thread via GitHub


clolov commented on PR #15131:
URL: https://github.com/apache/kafka/pull/15131#issuecomment-1878268696

   Heya @showuon and thanks for the review! I will make the changes in a couple 
of hours


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org