Re: [PR] MINOR: Add retry for CI [kafka]
ex172000 closed pull request #14828: MINOR: Add retry for CI URL: https://github.com/apache/kafka/pull/14828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Add retry for CI [kafka]
mimaison commented on PR #14828: URL: https://github.com/apache/kafka/pull/14828#issuecomment-1847179565 So should we close this PR and work on getting https://github.com/apache/kafka/pull/14862 merged instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Add retry for CI [kafka]
ex172000 commented on PR #14828: URL: https://github.com/apache/kafka/pull/14828#issuecomment-1827030588 > Thanks for the PR. The Jenkins file already sets those settings to retry failed tests in cradle. See here: > > https://github.com/apache/kafka/blob/95f41d59b389b6f25000b7bc4ddb948cfdb90448/Jenkinsfile#L32 > > . > I think that the confusion comes from the fact that the retired tests are still reported as failures. I am looking into improving this here: #14743. Thank you @dajac for the explaination. That makes sense. Do you mind review #14829, looks like they are really flaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Add retry for CI [kafka]
dajac commented on PR #14828: URL: https://github.com/apache/kafka/pull/14828#issuecomment-1826316639 Thanks for the PR. The Jenkins file already sets those settings to retry failed tests in cradle. See here: https://github.com/apache/kafka/blob/95f41d59b389b6f25000b7bc4ddb948cfdb90448/Jenkinsfile#L32. I think that the confusion comes from the fact that the retired tests are still reported as failures. I am looking into improving this here: https://github.com/apache/kafka/pull/14743. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Add retry for CI [kafka]
ex172000 commented on PR #14828: URL: https://github.com/apache/kafka/pull/14828#issuecomment-1826221078 > Thanks for the PR. Note that The CI configuration already sets retries, we don't need a CI server configuration. Is the CI retry a global setting? It might make more sense if we just retry the failed ones from gradle? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Add retry for CI [kafka]
ijuma commented on PR #14828: URL: https://github.com/apache/kafka/pull/14828#issuecomment-1825825013 Thanks for the PR. Note that The CI configuration already sets retries, we don't need a CI server configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
