Re: [PR] MINOR: Fix ClusterConnectionStatesTest.testSingleIP [kafka]

2023-11-13 Thread via GitHub


jolshan commented on PR #14741:
URL: https://github.com/apache/kafka/pull/14741#issuecomment-1808642447

   Shall we backport this to 3.6 as well? Maybe not a huge deal, but I see it 
causing some issues there too. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Fix ClusterConnectionStatesTest.testSingleIP [kafka]

2023-11-13 Thread via GitHub


dajac merged PR #14741:
URL: https://github.com/apache/kafka/pull/14741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Fix ClusterConnectionStatesTest.testSingleIP [kafka]

2023-11-12 Thread via GitHub


vamossagar12 commented on PR #14741:
URL: https://github.com/apache/kafka/pull/14741#issuecomment-1807052792

   > @showuon , I noticed the JDK21 build failed with `[this-escape] possible 
'this' escape before subclass is fully initialized`. I created [this 
PR](https://github.com/apache/kafka/pull/14742) to get around that issue. The 
classes in question in Streams merged yesterday. Let me know what you think.
   
   Actually ignore, found that 
[this](https://github.com/apache/kafka/pull/14708) already fixes it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Fix ClusterConnectionStatesTest.testSingleIP [kafka]

2023-11-12 Thread via GitHub


vamossagar12 commented on PR #14741:
URL: https://github.com/apache/kafka/pull/14741#issuecomment-1807052287

   @showuon , I noticed the JDK21 build failed with `[this-escape] possible 
'this' escape before subclass is fully initialized`. I created [this 
PR](https://github.com/apache/kafka/pull/14742) to get around that issue. The 
classes in question in Streams merged yesterday. Let me know what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org