Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]
jlprat merged PR #10767: URL: https://github.com/apache/kafka/pull/10767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]
jlprat commented on code in PR #10767:
URL: https://github.com/apache/kafka/pull/10767#discussion_r1478363587
##
docs/quickstart.html:
##
@@ -233,19 +233,16 @@
Edit the config/connect-standalone.properties file, add or
change the plugin.path configuration property match the following,
and save the file:
-
- echo "plugin.path=libs/connect-file-{{fullDotVersion}}.jar"
+$ echo
"plugin.path=libs/connect-file-{{fullDotVersion}}.jar"
Review Comment:
pushed the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]
jlprat commented on code in PR #10767:
URL: https://github.com/apache/kafka/pull/10767#discussion_r1478360214
##
docs/quickstart.html:
##
@@ -233,19 +233,16 @@
Edit the config/connect-standalone.properties file, add or
change the plugin.path configuration property match the following,
and save the file:
-
- echo "plugin.path=libs/connect-file-{{fullDotVersion}}.jar"
+$ echo
"plugin.path=libs/connect-file-{{fullDotVersion}}.jar"
Review Comment:
I believe you are correct. I was checking the history of the file, and it
seems it has been always wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]
mimaison commented on code in PR #10767:
URL: https://github.com/apache/kafka/pull/10767#discussion_r1478327944
##
docs/quickstart.html:
##
@@ -233,19 +233,16 @@
Edit the config/connect-standalone.properties file, add or
change the plugin.path configuration property match the following,
and save the file:
-
- echo "plugin.path=libs/connect-file-{{fullDotVersion}}.jar"
+$ echo
"plugin.path=libs/connect-file-{{fullDotVersion}}.jar"
Review Comment:
Should the command be `echo "plugin.path=libs/connect-file-3.8.0.jar" >>
config/connect-standalone.properties`, otherwise the echo command just print
the line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]
jlprat commented on code in PR #10767: URL: https://github.com/apache/kafka/pull/10767#discussion_r1476011006 ## docs/quickstart.html: ## @@ -32,8 +32,8 @@ the latest Kafka release and extract it: -$ tar -xzf kafka_2.13-2.8.0.tgz -$ cd kafka_2.13-2.8.0 + tar -xzf kafka_2.13-2.8.0.tgz Review Comment: Changed these and all the other occurrences ## docs/quickstart.html: ## @@ -121,7 +121,7 @@ By default, each line you enter will result in a separate event being written to the topic. -$ bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 + bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]
mimaison commented on code in PR #10767: URL: https://github.com/apache/kafka/pull/10767#discussion_r1475937346 ## docs/quickstart.html: ## @@ -121,7 +121,7 @@ By default, each line you enter will result in a separate event being written to the topic. -$ bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 + bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 Review Comment: The console producer tool prints a greater-than character for each new line, so the lines below should be: ``` >This is my first event >This is my second event ## docs/quickstart.html: ## @@ -32,8 +32,8 @@ the latest Kafka release and extract it: -$ tar -xzf kafka_2.13-2.8.0.tgz -$ cd kafka_2.13-2.8.0 + tar -xzf kafka_2.13-2.8.0.tgz Review Comment: I find the dollar sign more idiomatic for a shell prompt than greater-than. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
