Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on code in PR #15406: URL: https://github.com/apache/kafka/pull/15406#discussion_r1500387364 ## docs/upgrade.html: ## @@ -36,9 +36,9 @@ Notable changes in 3 -Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading to 3.6.1 from any version 0.8.x through 3.5.x Review Comment: thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1959092677 Cherry-picked to - 3.6 with https://github.com/apache/kafka/commit/e38a1ed757f4347cc6a40c36e36bb9b64264c196 and - 3.7 with https://github.com/apache/kafka/commit/069073aef81af7eefe603f14f65a39cfc05e0a10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1959078100 @divijvaidya - following up in https://github.com/apache/kafka/pull/15418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1959056392 Thanks @mimaison, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski merged PR #15406: URL: https://github.com/apache/kafka/pull/15406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
mimaison commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1956462946 So +1 for merging this and https://github.com/apache/kafka/pull/15407 now so we can update kafka-site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
mimaison commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1956448543 Locally I rebased this PR on trunk to fix the compilation issue (https://github.com/apache/kafka/commit/cc49fc76564b15f2111801faf62341aaf01c4d8c) and ran `./gradlew siteDocsTar`. Extracted to `kafka-site/3.6` and ran `./start-preview.sh`. The 3.6 upgrade section seems fine.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
mimaison commented on code in PR #15406: URL: https://github.com/apache/kafka/pull/15406#discussion_r1497349150 ## docs/upgrade.html: ## @@ -36,9 +36,9 @@ Notable changes in 3 -Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading to 3.6.1 from any version 0.8.x through 3.5.x Review Comment: I created https://issues.apache.org/jira/browse/KAFKA-16292 to refresh the upgrade.html file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
divijvaidya commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1956428098 > @mimaison should I wait for a build with this type of PR, or is that unnecessary? I guess we should in case we introduce broken HTML Our build in apache/kafka doesn't detect a broken html. For validation, we usually copy this to kafka-site, start a server locally and manually verify on localhost that site formatting etc. looks good. It's also useful to add a screenshot which helps the reviewers validate the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1956410967 @mimaison should I wait for a build with this type of PR, or is that unnecessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
mimaison commented on code in PR #15406: URL: https://github.com/apache/kafka/pull/15406#discussion_r1497332515 ## docs/upgrade.html: ## @@ -36,9 +36,9 @@ Notable changes in 3 -Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading to 3.6.1 from any version 0.8.x through 3.5.x Review Comment: Thanks for the cleanup! We should revamp the upgrading section. This page is now huge as we keep adding to it for each release. I'm not sure keeping a section for all previous versions in the latest docs is really helpful. The upgrade steps already exist for each version in the docs for that version. Maybe we should still keep a section for each bugfix to avoid breaking links as we started linking to them in the blog page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
divijvaidya commented on code in PR #15406: URL: https://github.com/apache/kafka/pull/15406#discussion_r1497321443 ## docs/upgrade.html: ## @@ -36,9 +36,9 @@ Notable changes in 3 -Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading to 3.6.1 from any version 0.8.x through 3.5.x Review Comment: FWIW I agree with @mimaison's suggestion. Patch versions are "patches". Their upgrade path and associated impact should be same as the associated minor version's upgrade. hence, it makes sense to only keep the upgrade documentation at a minor version level. I agree that this needs to be tackled separately from 3.7 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1956385351 My plan after merging this PR is: 1. cherry-pick to 3.6 and 3.7 2. copy the 3.6 upgrade.html into kafka-site/36 3. create & merge a PR that adds 3.7 upgrade notes, targeting kafka/trunk, cherry-pick that into 3.7 4. copy the kafka/3.7 upgrade.html into kafka-site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on code in PR #15406: URL: https://github.com/apache/kafka/pull/15406#discussion_r1497309453 ## docs/upgrade.html: ## @@ -36,9 +36,9 @@ Notable changes in 3 -Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading to 3.6.1 from any version 0.8.x through 3.5.x Review Comment: Note there is a slight divergence in philosophy here. @mimaison mentioned that it's best to have the latest version in this upgrade section, whereas with 3.5.2 and 3.5.1 we had a mini section mentioning the extra stuff from those versions and linking to the major 3.5.0 upgrade notes. Not sure what we wanna do going forward, but sticking to this since it's what we have as content right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]
stanislavkozlovski commented on code in PR #15406: URL: https://github.com/apache/kafka/pull/15406#discussion_r1497307890 ## docs/upgrade.html: ## @@ -79,7 +79,7 @@ Upgrading ZooKeeper-based clus -Upgrading KRaft-based clusters +Upgrading KRaft-based clusters Review Comment: note this is still `upgrade_360_kraft` in kafka-site, which I think is inconsistent. So fixing it here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
