Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]
chia7712 merged PR #15865: URL: https://github.com/apache/kafka/pull/15865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]
yashmayya commented on code in PR #15865:
URL: https://github.com/apache/kafka/pull/15865#discussion_r1603105885
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java:
##
@@ -160,7 +155,7 @@ public KafkaStatusBackingStore(Time time, Converter
converter, Supplier kafkaLog) {
-this(time, converter);
+this(time, converter, null, "connect-distributed-");
Review Comment:
Yeah, that's a good point. I think this and the "`ownTopicAdmin`" are cruft
left over from earlier refactors and are definitely no longer used anywhere in
Connect itself (or MM2). Since these aren't part of Connect's public API, I
think we should be fine with removing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]
chia7712 commented on PR #15865: URL: https://github.com/apache/kafka/pull/15865#issuecomment-2114786021 @yashmayya any update? I'm ok to merge it and open follow-up to address remaining comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]
chia7712 commented on code in PR #15865:
URL: https://github.com/apache/kafka/pull/15865#discussion_r1590318726
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java:
##
@@ -160,7 +155,7 @@ public KafkaStatusBackingStore(Time time, Converter
converter, Supplier kafkaLog) {
-this(time, converter);
+this(time, converter, null, "connect-distributed-");
Review Comment:
This constructor is used by testing. It set `topicAdminSupplier` to null, so
we have to handle the "null" `topicAdminSupplier` just for testing. That is a
bit awkward to me. Could we require those test cases pass a
`topicAdminSupplier` instead of `null`? Those tests can pass a fake
`topicAdminSupplier` to constructor if they expect `topicAdminSupplier` should
not be called in testing.
https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java#L137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]
yashmayya commented on PR #15865: URL: https://github.com/apache/kafka/pull/15865#issuecomment-2094813303 Context - https://github.com/apache/kafka/pull/13434#discussion_r1590212654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
