Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2016331846 ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful :metadata:test --tests QuorumControllerMetricsIntegrationTest.testClosingQuorumControllerClosesMetrics --tests QuorumControllerTest.testBrokerHeartbeatDuringMigration :connect:mirror:test --tests MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicateSourceDefault --tests MirrorConnectorsIntegrationTransactionsTest.testReplicationWithEmptyPartition :core:test --tests PlaintextAdminIntegrationTest.testAlterReplicaLogDirs --tests DelegationTokenEndToEndAuthorizationWithOwnerTest.testNoProduceWithDescribeAcl --tests DelegationTokenEndToEndAuthorizationWithOwnerTest.testProduceConsumeViaSubscribe --tests ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric --tests SaslGssapiSslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl --tests ControllerRegistrationManagerTest.testWr ongIncarnationId --tests LogDirFailureTest.testIOExceptionDuringLogRoll --tests LogDirFailureTest.testIOExceptionDuringCheckpoint --tests ProducerIdManagerTest.testUnrecoverableErrors :clients:test --tests StickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription ``` all failed tests pass on my local. will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2016331977 @nizhikov thanks for this refactor! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]
chia7712 merged PR #15560: URL: https://github.com/apache/kafka/pull/15560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]
nizhikov commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2014973339 Hello @chia7712 Are you ready to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2012152816 the failed tests pass on my local ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful :metadata:test --tests QuorumControllerMetricsIntegrationTest.testClosingQuorumControllerClosesMetrics --tests QuorumControllerTest.testBrokerHeartbeatDuringMigration :connect:mirror:test --tests MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicateSourceDefault --tests MirrorConnectorsIntegrationTransactionsTest.testReplicationWithEmptyPartition :core:test --tests PlaintextAdminIntegrationTest.testAlterReplicaLogDirs --tests DelegationTokenEndToEndAuthorizationWithOwnerTest.testNoProduceWithDescribeAcl --tests DelegationTokenEndToEndAuthorizationWithOwnerTest.testProduceConsumeViaSubscribe --tests ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric --tests SaslGssapiSslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl --tests ControllerRegistrationManagerTest.testWr ongIncarnationId --tests LogDirFailureTest.testIOExceptionDuringLogRoll --tests LogDirFailureTest.testIOExceptionDuringCheckpoint --tests ProducerIdManagerTest.testUnrecoverableErrors :clients:test --tests StickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription ``` will merge it tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-201902 @nizhikov could you please rebase code to trigger QA again? one of build is shutdown :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]
nizhikov commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2009033688 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
