Re: [PR] MINOR: Upgrade jqwik to version 1.8.2 [kafka]

2024-03-02 Thread via GitHub


chia7712 commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1974982326

   ```
   [2024-03-02T21:51:02.002Z] 
kafka.api.PlaintextAdminIntegrationTest.testElectPreferredLeaders(String)[2] 
failed, log available in 
/home/jenkins/workspace/Kafka_kafka-pr_PR-14365/core/build/reports/testOutput/kafka.api.PlaintextAdminIntegrationTest.testElectPreferredLeaders(String)[2].test.stdout
   [2024-03-02T21:51:02.002Z] 
   [2024-03-02T21:51:02.002Z] Gradle Test Run :core:test > Gradle Test Executor 
94 > PlaintextAdminIntegrationTest > testElectPreferredLeaders(String) > 
testElectPreferredLeaders(String).quorum=kraft FAILED
   [2024-03-02T21:51:02.002Z] org.opentest4j.AssertionFailedError: Timed 
out waiting for leader to become Some(0). Last metadata lookup returned leader 
= Some(1) ==> expected:  but was: 
   [2024-03-02T21:51:02.002Z] at 
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
   [2024-03-02T21:51:02.002Z] at 
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
   [2024-03-02T21:51:02.002Z] at 
org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
   [2024-03-02T21:51:02.002Z] at 
org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
   [2024-03-02T21:51:02.002Z] at 
org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
   [2024-03-02T21:51:02.002Z] at 
kafka.utils.TestUtils$.waitForLeaderToBecome(TestUtils.scala:2116)
   [2024-03-02T21:51:02.002Z] at 
kafka.utils.TestUtils$.assertLeader(TestUtils.scala:2079)
   [2024-03-02T21:51:02.002Z] at 
kafka.api.PlaintextAdminIntegrationTest.changePreferredLeader$1(PlaintextAdminIntegrationTest.scala:1439)
   [2024-03-02T21:51:02.002Z] at 
kafka.api.PlaintextAdminIntegrationTest.testElectPreferredLeaders(PlaintextAdminIntegrationTest.scala:1501)
   ```
   https://issues.apache.org/jira/browse/KAFKA-8458
   
   ```
   [2024-03-03T00:18:55.732Z] 
kafka.server.ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric() failed, 
log available in 
/home/jenkins/workspace/Kafka_kafka-pr_PR-14365/core/build/reports/testOutput/kafka.server.ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric().test.stdout
   [2024-03-03T00:18:55.732Z] 
   [2024-03-03T00:18:55.732Z] Gradle Test Run :core:test > Gradle Test Executor 
95 > ReplicaManagerTest > testRemoteFetchExpiresPerSecMetric() FAILED
   [2024-03-03T00:18:55.732Z] org.opentest4j.AssertionFailedError: The 
ExpiresPerSec value is not incremented. Current value is: 0
   [2024-03-03T00:18:55.732Z] at 
org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
   [2024-03-03T00:18:55.732Z] at 
org.junit.jupiter.api.Assertions.fail(Assertions.java:138)
   [2024-03-03T00:18:55.732Z] at 
kafka.server.ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric(ReplicaManagerTest.scala:4174)
   ```
   https://issues.apache.org/jira/browse/KAFKA-13530
   
   those failed tests are flaky since there are jira already. Also, they pass 
on my local. so +1 to this PR and I will merge it tomorrow if there is no 
objection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Upgrade jqwik to version 1.8.2 [kafka]

2024-03-02 Thread via GitHub


bmscomp commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1974904749

   @chia7712 Jqwik version is updated to 1.8.3 and conflicts are resolved 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Upgrade jqwik to version 1.8.2 [kafka]

2024-03-02 Thread via GitHub


chia7712 commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1974864320

   the last version of `jqwik` is 1.8.3. Maybe we should rebase the code with 
1.8.3, and then merge it if there is no related failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Upgrade jqwik to version 1.8.2 [kafka]

2024-02-02 Thread via GitHub


mimaison commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1924054180

   @yashmayya @divijvaidya I'll let you finish the review. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Upgrade jqwik to version 1.8.2 [kafka]

2024-02-02 Thread via GitHub


bmscomp commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1923976723

   @mimaison  Rebase done and conflicts are resolved 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org