Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
chia7712 merged PR #15991: URL: https://github.com/apache/kafka/pull/15991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
brandboat commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1608609569 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic streams-wordcount-output \ --from-beginning \ ---formatter kafka.tools.DefaultMessageFormatter \ +--formatter org.apache.kafka.tools.consumer.DefaultMessageFormatter \ Review Comment: > Filed JIRA https://issues.apache.org/jira/browse/KAFKA-16795. Will file another PR soon. gentle ping @mimaison, I just filed https://github.com/apache/kafka/pull/16020, would be an honor if you can take a look. > DefaultMessageFormatter is the default value so we could even remove the --formatter <> flag from the command. Sounds good, thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
brandboat commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1608609569 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic streams-wordcount-output \ --from-beginning \ ---formatter kafka.tools.DefaultMessageFormatter \ +--formatter org.apache.kafka.tools.consumer.DefaultMessageFormatter \ Review Comment: > Filed JIRA https://issues.apache.org/jira/browse/KAFKA-16795. Will file another PR soon. gentle ping @mimaison, I just filed https://github.com/apache/kafka/pull/16020, would be my honor if you can take a look. > DefaultMessageFormatter is the default value so we could even remove the --formatter <> flag from the command. Sounds good, thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
mimaison commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1608601059 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic streams-wordcount-output \ --from-beginning \ ---formatter kafka.tools.DefaultMessageFormatter \ +--formatter org.apache.kafka.tools.consumer.DefaultMessageFormatter \ Review Comment: Sure we can re-add these formatter classes and have them print a deprecation message when used. `DefaultMessageFormatter` is the default value so we could even remove the `--formatter <>` flag from the command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
brandboat commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1605980737 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic streams-wordcount-output \ --from-beginning \ ---formatter kafka.tools.DefaultMessageFormatter \ +--formatter org.apache.kafka.tools.consumer.DefaultMessageFormatter \ Review Comment: Filed JIRA https://issues.apache.org/jira/browse/KAFKA-16795. Will file another PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
chia7712 commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1605966784 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic streams-wordcount-output \ --from-beginning \ ---formatter kafka.tools.DefaultMessageFormatter \ +--formatter org.apache.kafka.tools.consumer.DefaultMessageFormatter \ Review Comment: @brandboat Could you please file another PR to fix broken compatibility? Let this PR focus on docs updates :smile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
brandboat commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1605934347 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic streams-wordcount-output \ --from-beginning \ ---formatter kafka.tools.DefaultMessageFormatter \ +--formatter org.apache.kafka.tools.consumer.DefaultMessageFormatter \ Review Comment: I agree with this. Many scripts could be affected by this breaking change. We should implement a deprecation cycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix incorrect formatter package in streams quickstart [kafka]
chia7712 commented on code in PR #15991: URL: https://github.com/apache/kafka/pull/15991#discussion_r1605853497 ## docs/streams/quickstart.html: ## @@ -200,7 +200,7 @@ Step 4: St bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 \ --topic streams-wordcount-output \ --from-beginning \ ---formatter kafka.tools.DefaultMessageFormatter \ +--formatter org.apache.kafka.tools.consumer.DefaultMessageFormatter \ Review Comment: It seems to me this is a kind of broken compatibility. We should allow user to keep using `kafka.tools.NoOpMessageFormatter`, `kafka.tools.DefaultMessageFormatter`, and `kafka.tools.LoggingMessageFormatter`, but we also display warning messages to say those "strings" will be removed in 4.0 @mimaison WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
