Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

[via GitHub]

gaurav-narula commented on PR #15065:
URL: https://github.com/apache/kafka/pull/15065#issuecomment-2098952056

   Bumping this thread for more visibility.
   
   Would be nice if we give this a shot since we still run into builds which 
[time 
out](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15836/12/pipeline/9)
 out of the blue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

[via GitHub]

gaurav-narula commented on code in PR #15065:
URL: https://github.com/apache/kafka/pull/15065#discussion_r1484162204


##
clients/src/test/resources/junit-platform.properties:
##
@@ -13,3 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 junit.jupiter.params.displayname.default = "{displayName}.{argumentsWithNames}"
+junit.jupiter.execution.timeout.default = 10 m

Review Comment:
   Also stumbled upon [Thread 
Mode](https://github.com/junit-team/junit5/pull/2949) which avoids pitfalls 
where the test code [doesn't 
interrupt](https://github.com/junit-team/junit5/issues/2087).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

[via GitHub]

gaurav-narula commented on code in PR #15065:
URL: https://github.com/apache/kafka/pull/15065#discussion_r1482924308


##
clients/src/test/resources/junit-platform.properties:
##
@@ -13,3 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 junit.jupiter.params.displayname.default = "{displayName}.{argumentsWithNames}"
+junit.jupiter.execution.timeout.default = 10 m

Review Comment:
   Note that this sets a timeout of `10m` on the lifecycle methods as well. 
While I think we should have a timeout on lifecycle methods too, perhaps we can 
decrease its value to say `5m` (or even lesser if that seems apt)?  WDYT?
   
   Refer the `junit.jupiter.execution.timeout.lifecycle.method.default` prop 
for more information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

[via GitHub]

ijuma commented on PR #15065:
URL: https://github.com/apache/kafka/pull/15065#issuecomment-1881861076

   This does actually work consistently? My experience with JUnit 5 timeout 
annotations has not been good, unfortunately (they often would simply not work 
at all). I haven't tried this approach though. It would be great if it did work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

[via GitHub]

dajac commented on PR #15065:
URL: https://github.com/apache/kafka/pull/15065#issuecomment-1881833093

   I like the idea! Have we been able to get a stable build with this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

[via GitHub]

jolshan commented on PR #15065:
URL: https://github.com/apache/kafka/pull/15065#issuecomment-1869836473

   Thanks @showuon for getting started with this. I noticed the first build 
still ran about 8h and hit an OOM issue. Looks like that will have to be 
addressed separately (which is ok). (edit, looks like the second build also hit 
OOM)
   
   I was wondering if we saw any previously passing tests that were just 10 
minutes so we hit the timeout. I didn't see any so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

[via GitHub]

showuon commented on PR #15065:
URL: https://github.com/apache/kafka/pull/15065#issuecomment-1867639044

   @dajac @ijuma @jolshan @stanislavkozlovski , call for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org