Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]
gaurav-narula commented on PR #15451: URL: https://github.com/apache/kafka/pull/15451#issuecomment-2176503765 Thanks for reviewing Igor! I rebased but ran into what seems like a bug in trunk. This is therefore blocked on [KAFKA-16990](https://issues.apache.org/jira/browse/KAFKA-16990) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]
github-actions[bot] commented on PR #15451: URL: https://github.com/apache/kafka/pull/15451#issuecomment-2157136549 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]
soarez commented on PR #15451: URL: https://github.com/apache/kafka/pull/15451#issuecomment-1989015331 @showuon could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]
gaurav-narula commented on code in PR #15451:
URL: https://github.com/apache/kafka/pull/15451#discussion_r1509056087
##
tests/kafkatest/tests/core/kraft_upgrade_test.py:
##
@@ -108,6 +108,27 @@ def run_upgrade(self, from_kafka_version):
assert len(cluster_id) == 22
assert self.kafka.check_protocol_errors(self)
+# Ensure we can create another topic and produce/consume to/from it
+new_topic_cfg = {
+"topic": "test-topic-2",
+"partitions": self.partitions,
+"replication-factor": self.replication_factor,
+"configs": {"min.insync.replicas": 2}
Review Comment:
Addressed in
https://github.com/apache/kafka/pull/15451/commits/6776bdf9751198294de2f8c4cf7c97351f34f97a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]
soarez commented on code in PR #15451:
URL: https://github.com/apache/kafka/pull/15451#discussion_r1509037381
##
tests/kafkatest/tests/core/kraft_upgrade_test.py:
##
@@ -108,6 +108,27 @@ def run_upgrade(self, from_kafka_version):
assert len(cluster_id) == 22
assert self.kafka.check_protocol_errors(self)
+# Ensure we can create another topic and produce/consume to/from it
+new_topic_cfg = {
+"topic": "test-topic-2",
+"partitions": self.partitions,
+"replication-factor": self.replication_factor,
+"configs": {"min.insync.replicas": 2}
Review Comment:
Don't we want to consider `self.replication_factor` here? Maybe `min(2,
self.replication_factor)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]
gaurav-narula commented on PR #15451: URL: https://github.com/apache/kafka/pull/15451#issuecomment-1973222033 CC: @soarez @pprovenzano @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
