Re: [PR] MINOR: use assertInstanceOf to replace assertTrue [kafka]

2024-04-22 Thread via GitHub


chia7712 merged PR #15769:
URL: https://github.com/apache/kafka/pull/15769


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: use assertInstanceOf to replace assertTrue [kafka]

2024-04-22 Thread via GitHub


chia7712 commented on PR #15769:
URL: https://github.com/apache/kafka/pull/15769#issuecomment-2069289874

   @evalaiyc98 thanks for you contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: use assertInstanceOf to replace assertTrue [kafka]

2024-04-21 Thread via GitHub


evalaiyc98 commented on PR #15769:
URL: https://github.com/apache/kafka/pull/15769#issuecomment-2068055223

   @chia7712 Could you help review this?
   If there is a need for any further improvement, please let me know. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org