DO NOT REPLY [Bug 2063] - CookieManager truncates cookie values if values contain '='
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=2063. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=2063 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |REOPENED Priority|P3 |P2 Resolution|FIXED | Version|unspecified |2.1.1 --- Additional Comments From [EMAIL PROTECTED] 2006-03-06 22:55 --- I understand that this bug was closed with the release of 1.8, but its still lingering in the current version 2.1.1. I had to go back to version 1.8.1 to find a version that works with my test site that has an equals = sign in the cookie. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 2063] - CookieManager truncates cookie values if values contain '='
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=2063. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=2063 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Additional Comments From [EMAIL PROTECTED] 2006-03-06 23:39 --- I've just tried this with the current 2.1 branch code - it seems to work for me, at least in a unit test. Can you try and see if the nightly build solves the problem? Alternatively, can you provide access to a server that generates such cookies? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r383712 - /jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
Author: sebb
Date: Mon Mar 6 16:01:18 2006
New Revision: 383712
URL: http://svn.apache.org/viewcvs?rev=383712view=rev
Log:
Remove broken method
Modified:
jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
Modified:
jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
URL:
http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java?rev=383712r1=383711r2=383712view=diff
==
---
jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
(original)
+++
jakarta/jmeter/branches/rel-2-1/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
Mon Mar 6 16:01:18 2006
@@ -15,6 +15,8 @@
*
*/
+// For unit tests @see TestCookieManager
+
package org.apache.jmeter.protocol.http.control;
import java.io.BufferedReader;
@@ -95,17 +97,6 @@
public void setClearEachIteration(boolean clear) {
setProperty(new BooleanProperty(CLEAR, clear));
- }
-
- // Incorrect method. Always returns String. I changed CookiePanel code
to
- // perform this lookup.
- // public Class getColumnClass(int column)
- // {
- // return columnNames[column].getClass();
- // }
-
- public Cookie getCookie(int row) {
- return (Cookie) getCookies().get(row);
}
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r383714 - /jakarta/jmeter/branches/rel-2-1/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java
Author: sebb
Date: Mon Mar 6 16:02:12 2006
New Revision: 383714
URL: http://svn.apache.org/viewcvs?rev=383714view=rev
Log:
Add test for bug 2063 - Cookie with = in value
Modified:
jakarta/jmeter/branches/rel-2-1/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java
Modified:
jakarta/jmeter/branches/rel-2-1/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java
URL:
http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java?rev=383714r1=383713r2=383714view=diff
==
---
jakarta/jmeter/branches/rel-2-1/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java
(original)
+++
jakarta/jmeter/branches/rel-2-1/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java
Mon Mar 6 16:02:12 2006
@@ -107,6 +107,18 @@
assertEquals(test=1, s);
}
+// Bug 2063
+public void testCookieWithEquals() throws Exception {
+URL url = new URL(http://a.b.c/;);
+man.addCookieFromHeader(NSCP_USER_LOGIN1_NEW=SHA=x, url);
+String s = man.getCookieHeaderForURL(url);
+assertNotNull(s);
+assertEquals(NSCP_USER_LOGIN1_NEW=SHA=x, s);
+Cookie c=man.get(0);
+assertEquals(NSCP_USER_LOGIN1_NEW,c.getName());
+assertEquals(SHA=x,c.getValue());
+}
+
// Test Old cookie is not returned
public void testOldCookie() throws Exception {
URL url = new URL(http://a.b.c/;);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Reminder to subscribe to general@
We're discussing various ideas and thoughts on restructuring Jakarta on the [EMAIL PROTECTED] mailing list. On the off chance that someone isn't subscribed to the general@jakarta.apache.org mailing list, I thought I'd drop an email to each of the -dev mailing lists so they have a chance to be involved. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
