DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715

User Parameters do not work in HTTP Cookie Manager





--- Additional Comments From [EMAIL PROTECTED]  2004-05-04 12:36 ---
Could you attach a simple test case that shows the problem, please?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715

User Parameters do not work in HTTP Cookie Manager





--- Additional Comments From [EMAIL PROTECTED]  2004-05-18 11:53 ---
Created an attachment (id=11589)
simple test plan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715

User Parameters do not work in HTTP Cookie Manager





--- Additional Comments From [EMAIL PROTECTED]  2004-05-18 11:56 ---
I'm having the same problem, although I'm using the "User Defined Variables" 
defined in the "Test Plan". In the file I attached, I set a "domain" variable, 
and I try to use it for the cookie domain. Won't work :(

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715

User Parameters do not work in HTTP Cookie Manager





--- Additional Comments From [EMAIL PROTECTED]  2004-05-21 17:30 ---
We are also seeing this bug, with user variables and built in variables like 
${_StringFromFile(file-path)}.  We need to change a value in the cookie to 
about a hundred different combonations.  BTW keep up the good work, I really 
like what I have seen so far, in fact better than loadrunner.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715

User Parameters do not work in HTTP Cookie Manager





--- Additional Comments From [EMAIL PROTECTED]  2004-05-22 09:02 ---
[Thanks for the sample]

I've had a quick look at the code, and the Cookie Manager stores its values in 
a slightly different way from (most) other test elements - the result is that 
it treats them as fixed strings, and does not try to interpret them as 
functions/variables.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715


[EMAIL PROTECTED] changed:

   What|Removed |Added

 OS/Version||All




--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 15:27 ---
I just want to say I also face with this limitation (not possible to add
personalized cookies to each user threads, using user variables or other means)
of JMeter. I think it could be a very useful enhancement of JMeter.
Nevertheless congratulations and thanks for your work.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715





--- Additional Comments From [EMAIL PROTECTED]  2005-10-10 21:46 ---
Created an attachment (id=16640)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=16640&action=view)
Fix to allow expansion of functions and user parameters in the CookieManager

This patch allows the expansion of UserParameters and Function calls in the
Cookie Manager.  It does so by no longer overriding the setRunningVersion and
recoverRunningVersion methods.
As a result of no longer overriding these, I had to create some way to
accurately reset cookies for each iteration.  So I introduced a variable
"temporaryCookies" which gets populated with the cookie name of any cookie to
remove - any cookie added while isRunningVersion is set to true.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715





--- Additional Comments From [EMAIL PROTECTED]  2005-10-10 21:48 ---
Oh yeah - forgot to mention.  The patch I just uploaded is against the following
version:
[EMAIL PROTECTED] jakarta-jmeter]$ cvs status
src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
===
File: CookieManager.javaStatus: Locally Modified

   Working revision:1.40
   Repository revision: 1.40   
/home/cvspublic/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java,v
   Sticky Tag:  v2_1_1 (revision: 1.40)
   Sticky Date: (none)
   Sticky Options:  (none)


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715





--- Additional Comments From [EMAIL PROTECTED]  2007-03-18 10:35 ---
I have been briefly looking at this.

The following short patch seems to make it possible to use functions and user
parameters in the CookieManager.

Index: C:/Documents and
Settings/alf/workspace/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
===
--- C:/Documents and
Settings/alf/workspace/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
(revision 519613)
+++ C:/Documents and
Settings/alf/workspace/Jmeter/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
(working copy)
@@ -290,7 +290,10 @@
 int i=0;
 for (PropertyIterator iter = getCookies().iterator(); iter.hasNext();) 
{
 Cookie jmcookie = (Cookie) iter.next().getObjectValue();
+// Set to running version, to allow function evaluation for the
cookie values
+jmcookie.setRunningVersion(true);
 cookies[i++] = makeCookie(jmcookie);
+jmcookie.setRunningVersion(false);
 }
 String host = url.getHost();
 String protocol = url.getProtocol();


However, I'm not sure this is the correct way of fixing this.
I have not looked much at the CookieManager code.
Are there threading issues involved ? I.e. can different threads be accessing
the cookies at the same time ? In that case, the different threads can set and
unset the running version.
Or do each thread have it's own instance of the CookieManager and all other
ConfigTestElement ?
If each thread have their own CookieManager, I think the simple patch above is
correct.

Do we want to only allow variable expansion in the static cookies, and not in
the runtime cookies received during sampling ?

Perhaps Stephen Cooper's patch from 2005-10-10 looks better, but the code seems
to have changed a bit since his suggestion.

Could we just call "setRunningVersion(false); setRunningVersion(false);" on each
cookie as the first thing to do in "testIterationStart" ?
Or will we get threading issues here as well ?

And also call "setRunningVersion(false);" on each cookie on "testEnded" ?
Perhaps that is not needed, as it seems like the GUI recreates all the cookies
"static cookies" when you go to the CookieManager GUI. I'm at least unable to
figure out when all the dynamic cookies are deleted, but I never see them in the
GUI.

Or should we add a flag to the Cookie class, so we know which ones are static
and which ones are dynamic, and then loop over all the static ones in
the following methods in CookieManager :
public void recoverRunningVersion() 
public void setRunningVersion

I'm sorry for all the questions, but this bug seems like an "easy" one to fix,
and quite important.

Any comments ?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28715] - User Parameters do not work in HTTP Cookie Manager

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28715


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-09-01 05:42 ---
Code has been added to Cookie Manager in SVN r571789.

Just in case it causes a problem, one can set the property:

CookieManager.allow_variable_cookies=false 

to disable the fix.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]