Re: [josm-dev] Refactoring of the JOSM architecture vs. Plugins
On Sat, Aug 23, 2008 at 4:37 AM, Gervase Markham [EMAIL PROTECTED] wrote: It seems as if someone who comes along and says I'm an experienced Java programmer, and want to improve JOSM in this way is less trusted and accepted than someone who comes along and says I know nothing about programming at all, and want to improve JOSM in this way. That seems backwards. I think what Frederik has pointed out is that people who tend to talk about refactoring don't talk about it as a means to an end, but take it for granted as something that should be done regardless of anything else. There are other people who don't worry about the code architecture and just submit patches for bugs or features, and this is more relevant and useful to Frederik currently. I believe he's already mentioned that if someone was contributing useful patches, and wanted to do some refactoring as part of their work, he wouldn't be opposed to it. The problem lies in people who have never done any JOSM development saying that the first thing they'd like to do is refactor the whole codebase. I can see why that would be annoying and unwanted. -Ted ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Performance optimizations
Hello, I tried your patch. I didn't see any big performance improvement, but that's probably that I wasn't watching it intensively. I have seen a problem, that the screen is not redrawn after deletion of the node. I have big problem with JOSM that slowing down through time when I am editing large data sets and using WMS plug-in intensively. It become unusable after some time, and I must restart whole application. That didn't solve with that patch. On Sat, 23 Aug 2008 15:14:57 +0200, Dirk Stöcker [EMAIL PROTECTED] wrote: Hello, Jörg Henne ist currently developing a set of performance improvements for JOSM. Find the patch here: http://www.dstoecker.eu/2008-08-21.patch Here his note: --- Attached you'll find a patch against JOSM #813 which enhances the performance of certain common operations: dragging nodes and ways and selecting/deselecting elements. Please apply copious amounts of testing and/or abuse. --- Please try the patch and report positive and negative test results. The patch causes some major changes, so I don't want to introduce that without others having a look at it before. Ciao -- Petr Dlouhý ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Performance optimizations
On Sat, 23 Aug 2008, Tobias Wendorff wrote: Dirk Stöcker schrieb: I compiled it for you: http://www.dstoecker.eu/josm-custom.jar Thanks a lot! I would love to read a HowTo someday :-) www.google.com If you have specific problems, you need to ask these directly. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Performance optimizations
Dirk Stöcker schrieb: www.google.com If you have specific problems, you need to ask these directly. Ah ... that's why I love OpenSource: You need support? Sorry, no support ... Google for it! ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Performance optimizations
On Sat, 23 Aug 2008, Tobias Wendorff wrote: Dirk Stöcker schrieb: www.google.com If you have specific problems, you need to ask these directly. Ah ... that's why I love OpenSource: You need support? Sorry, no support ... Google for it! Yes. That's the way it goes. When I think of the fact how expensive I myself am when at work, then this is logical. Take the fact the as consultant I cost more than 100 Euro an hour and that answering a little more complex email takes 10-30 minutes. So the result is - Support costs money. Help is for free, but only given, when I see that the other side already tried to solve the problems by reading available source himself first and the question is specific. Like this most other open source programmer work. Usually this also means, that if you did the initial searches, you get high quality answer which in the commercial field aren't naturally. BTW: Regarding consultants - I can't by myself - Don't get enough money a month to rent me :-) Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Performance optimizations
Dirk Stöcker napsal(a): Hello, Jörg Henne ist currently developing a set of performance improvements for JOSM. Find the patch here: http://www.dstoecker.eu/2008-08-21.patch It would be fine if Jörg cold separate the real functional patch from all the unrelated formatting changes. It is quite hard to follow the semantics of the change in all the noise... If I were sober, I could have followed the patch in this form too, but not now ;-) -- Petr Nenik Nejedly, NetBeans/Sun Microsystems, http://www.netbeans.org 355/113 -- Not the famous irrational number PI, but an incredible simulation! ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] patch for JOSM runtime error on MacOS
On Sat, 23 Aug 2008, A Morris wrote: I am trying to run the latest SVN revision of JOSM in eclipse on a Mac. The code builds, but does not run; it hangs inside the native method Object.wait() in ElemStyleHandler. The offending line is: curIcon = new ImageIcon(Toolkit.getDefaultToolkit().createImage(path)); I note that the file 'misc/no_icon.png' (which it is trying to load) does not exist anywhere in my filesystem. (Actually neither does 'amenity.png'). I have applied the following patch which seems to have fixed the problem on my system (the hang, that is, not the fact that icons seem to be missing): You use an external styles file? It must have some errors. The problem is, that the internal style names aren't properly initialized in case an external file is loaded. I will fix that. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] patch for JOSM runtime error on MacOS
I don't knowingly use an external styles file - I simply tried to build and run the latest JOSM revision. Is it not a problem that icon files that are referenced in the source code do not exist in SVN? Cheers, Aled. On Sat, Aug 23, 2008 at 9:10 PM, Dirk Stöcker [EMAIL PROTECTED] wrote: On Sat, 23 Aug 2008, A Morris wrote: I am trying to run the latest SVN revision of JOSM in eclipse on a Mac. The code builds, but does not run; it hangs inside the native method Object.wait() in ElemStyleHandler. The offending line is: curIcon = new ImageIcon(Toolkit.getDefaultToolkit().createImage(path)); I note that the file 'misc/no_icon.png' (which it is trying to load) does not exist anywhere in my filesystem. (Actually neither does 'amenity.png'). I have applied the following patch which seems to have fixed the problem on my system (the hang, that is, not the fact that icons seem to be missing): You use an external styles file? It must have some errors. The problem is, that the internal style names aren't properly initialized in case an external file is loaded. I will fix that. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Strange compilation errors in Eclipse
Perhaps it's related to java 6. Josm development is based on Java 1.5... Pieren On Sat, Aug 23, 2008 at 3:10 PM, rainerr [EMAIL PROTECTED] wrote: gettext-commons-0.9.2.jar is already in my java build path. As I said before, the compilation errors disappear, if I change the static imports to non-static imports. Therefore, it doesn't look like a classpath issue to me. Pieren Pieren wrote: Your problem should be solved if you add the gettext-commons-0.9.2.jar library in the project java build path settings. Pieren -- View this message in context: http://www.nabble.com/Strange-compilation-errors-in-Eclipse-tp19120862p19121449.html Sent from the OpenStreetMap - JOSM Dev mailing list archive at Nabble.com. ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] patch for JOSM runtime error on MacOS
On Sat, 23 Aug 2008, A Morris wrote: I don't knowingly use an external styles file - I simply tried to build and run the latest JOSM revision. I fixed that access. Should work now for you too. a) Could you paste any lines with mappaint in your josm-preferences here. b) Please list the whole content of your josm dir. (~/.josm under Linux). Is it not a problem that icon files that are referenced in the source code do not exist in SVN? They are there: images/styles/standard/ Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Layer order and active layer
On Sat, 23 Aug 2008, Bodo Meissner wrote: | I closed bug 371. Now it is no longer possible to change an inactive | layer. I don't like this change. I often select a GPX layer when drawing new ways or moving existing ways to my tracks. When the OSM data layer is active it is often difficult to see the tracks even if I change the color. That's why I prefer to have the ways displayed in grey color when tracing GPS tracks. An acceptable workaround would be a switch to dim the active data layer. Why don't you use the wireframe mode for that? Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Reworked virtual nodes
Hello, I reworked the virtual nodes in revision 853. The virtual nodes are no longer created on clicking a node, but only when you click the virtual node and also drag it. This should reduce the existing problems a lot and make the feature as intended originally. This means a single click now again selects the way. Note also, that creating node and moving no longer are two undo steps, but only one. Please retest the feature and tell me your test results. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] patch for JOSM runtime error on MacOS
Aha. I had forgotten I had obtained out the code from launchpad.net, mainly to see if it worked, which obviously, it didn't. (something to do with svn externals?). It works fine when checked out directly from svn. (I had deleted ~/.josm, so that wasn't a factor) Cheers, Aled. On Sat, Aug 23, 2008 at 10:23 PM, Dirk Stöcker [EMAIL PROTECTED] wrote: On Sat, 23 Aug 2008, A Morris wrote: I don't knowingly use an external styles file - I simply tried to build and run the latest JOSM revision. I fixed that access. Should work now for you too. a) Could you paste any lines with mappaint in your josm-preferences here. b) Please list the whole content of your josm dir. (~/.josm under Linux). Is it not a problem that icon files that are referenced in the source code do not exist in SVN? They are there: images/styles/standard/ Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Strange compilation errors in Eclipse
On Sat, Aug 23, 2008 at 1:39 PM, Pieren [EMAIL PROTECTED] wrote: Perhaps it's related to java 6. Josm development is based on Java 1.5... Pieren I doubt it. I can compile JOSM in Eclipse and I haven't changed my compiler settings from the default 1.6. Karl ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Strange compilation errors in Eclipse
Hi Rainer, It is a strange Eclipse bug that has been reported several times in this forum before. Comment out the offending lines containing the marktr lines and save the file. Don't worry if this causes other compile errors. Uncomment the offending lines and the problem will be fixed. Regards, Brent. *** REPLY SEPARATOR *** On 23/08/2008 at 1:47 PM Rainer Rothkegel wrote: Hi, when I try to compile the josm sources in Eclipse, I get 3 strange error messages related to static imports and the gettext-commons-0.9.2.jar: The method marktr(String) is undefined for the type AutoScaleAction josm/src/org/openstreetmap/josm/actionsAutoScaleAction.javaline 27 The method tr(String) is undefined for the type MainMenu josm/src/org/openstreetmap/josm/guiMainMenu.java line 120 The method tr(String) is undefined for the type MainMenu josm/src/org/openstreetmap/josm/guiMainMenu.java line 123 If I change the static imports to non-static imports, everything compiles fine. Also, if I compile the (unchanged) sources with ant outside of Eclipse, there are no errors. My java environment is based on the latest versions in the Kubuntu Hardy stable repository: ii sun-java6-jdk 6-07-3ubuntu2 ii eclipse3.2.2-5ubuntu2 ii ant1.7.0-3 Does anyone have an idea what the problem is? Thanks, Rainer ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
