[josm-dev] pixel per degree
Hi, Why is it called pixelPerDegree in ImageryInfo? Apparently, the value is in pixels per unit in projected space (pixelPerEastNorth). There is an interesting bug in ImageryLayer.getPPD(), line 86: It returns Main.getProjection().getDefaultZoomInPPD() when mapframe is null. However the Projection-PPD is not the same, as the Imagery-PPD, in fact they are inverse to each other. (Or NavigatableComponent line 99 is wrong, I haven't investigated the full history if this...) I suggest to rename all this, so it makes more sense. Paul ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] pixel per degree
Hi, As far as I remember I inherited this name from WMSPlugin. I was somewhat confused by this name too, but haven't bothered to rename it. Maybe we should do it at last to avoid further confusion. There is may be a bug in getPPD(), but it doesn't affect anything) There is an interesting bug in ImageryLayer.getPPD(), line 86: It returns Main.getProjection().getDefaultZoomInPPD() when mapframe is null. However the Projection-PPD is not the same, as the Imagery-PPD, in fact they are inverse to each other. (Or NavigatableComponent line 99 is wrong, I haven't investigated the full history if this...) I suggest to rename all this, so it makes more sense. Paul ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev -- Best regards, Upliner ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] pixel per degree
On Mon, 19 Sep 2011, Paul Hartmann wrote: Why is it called pixelPerDegree in ImageryInfo? Apparently, the value is in pixels per unit in projected space (pixelPerEastNorth). Which is nonsense as well. It should not be relative to projected coordinates. I think the sole idea behind this is the bookmark feature and this should not depend on projection. This is very old code (before we had proper projection support) and probably neeeds to be reworked. The idea of bookmarks is to have a cross-session caching possibility. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
