Re: [josm-dev] Shortcuts

2012-02-18 Thread Dirk Stöcker

On Fri, 17 Feb 2012, Ian Dees wrote:


I agree that JOSM core should get preference for plugin conflicts, but I
think that if a user has explicitly set a key binding by unchecking the
"Use Default" option, nothing but the user should change that key binding.
For example, I explicitly set "W" to "Draw Buildings" (unchecking "Use
Default" in the process) and when I just downloaded a new JOSM JAR and ran
it, the plugin keybinding switched back to Ctrl+Shift+W.


During the update process old preferences are lost, as Shortcut system 
changes a lot. I may add a portability fix before next tested, but I doubt 
it is worth the effort. You may need to reapply your own bindings after 
this transition period.


Temporary downgrading josm should get your old bindings back. Reapplying 
them now may cause a loss soon again, as new design is not yet final.



If a user has gone to the trouble of explicitly setting up their key
bindings, nothing should override it.


Agreed, but this is still voluntary OpenSource and for a developer it is 
much easier to update when he simply can drop old stuff. ;-) For 
self-assigned shortcuts I assumed, that the number of affected users will 
be very small and thus I made no compatibility transition (especially as 
anyway a lot of trouble will come, so a little more trouble wont be 
noticed :-)


Ciao
--
http://www.dstoecker.eu/ (PGP key available)


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Shortcuts

2012-02-18 Thread Paul Hartmann
On 02/18/2012 10:19 AM, Dirk Stöcker wrote:
> On Fri, 17 Feb 2012, Ian Dees wrote:
> 
>> I agree that JOSM core should get preference for plugin conflicts, but I
>> think that if a user has explicitly set a key binding by unchecking the
>> "Use Default" option, nothing but the user should change that key
>> binding.
>> For example, I explicitly set "W" to "Draw Buildings" (unchecking "Use
>> Default" in the process) and when I just downloaded a new JOSM JAR and
>> ran
>> it, the plugin keybinding switched back to Ctrl+Shift+W.
> 
> During the update process old preferences are lost, as Shortcut system
> changes a lot. I may add a portability fix before next tested, but I
> doubt it is worth the effort. You may need to reapply your own bindings
> after this transition period.
> 
> Temporary downgrading josm should get your old bindings back. Reapplying
> them now may cause a loss soon again, as new design is not yet final.
> 
>> If a user has gone to the trouble of explicitly setting up their key
>> bindings, nothing should override it.
> 
> Agreed, but this is still voluntary OpenSource and for a developer it is
> much easier to update when he simply can drop old stuff. ;-) For
> self-assigned shortcuts I assumed, that the number of affected users
> will be very small and thus I made no compatibility transition
> (especially as anyway a lot of trouble will come, so a little more
> trouble wont be noticed :-)

Wow, there are a lot of changes [1]. It's great we finally got rid of
these strange groups and use shift, ctrl & alt directly. In the
preferences there is a tab "read first". I think this tab can be moved
to the help pages - it's nothing you absolutely must need to know and
could not have guessed.

[1]


Paul

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Shortcuts

2012-02-18 Thread Dirk Stöcker

On Sat, 18 Feb 2012, Paul Hartmann wrote:


Wow, there are a lot of changes [1]. It's great we finally got rid of
these strange groups and use shift, ctrl & alt directly. In the
preferences there is a tab "read first". I think this tab can be moved
to the help pages - it's nothing you absolutely must need to know and
could not have guessed.


Hah, I also wanted to remove it, but didn't like to drop the information. 
Now moved it to the wiki. Info-Tab is gone as well.


The whole code starts to feel good finally. After fixing the remaining 
shortcut issues and updating plugins everything will be much better 
usable.


The original design was not bad, but it never quite worked as it was 
meant to do.


Ciao
--
http://www.dstoecker.eu/ (PGP key available)


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


[josm-dev] Shortcuts 2

2012-02-18 Thread Dirk Stöcker

Hello,

the conflicts on
[http://josm.openstreetmap.de/wiki/DevelopersGuide/ShortcutsList]
are down to 10 in P, R and T namespace.

Any suggestions to fix the remaining ones are welcome, as well as ideas 
where the shortcut assignments don't reflect the real importance of 
functions.


Supply ideas at http://josm.openstreetmap.de/ticket/7226 - Only proper 
solutions welcome. Don't bother to write there if you have no 
conflict-free rearrangement plan for your suggestion.


Akks already did some rearrangements to get short and better reachable 
combinations to more important functions.


If no good suggestions come, I will move the remaining conflicts to X, Q 
and K letters without any good logic.


The remaining single letter shortcuts should remain free except there is a 
really important function to use them.


Ciao
--
http://www.dstoecker.eu/ (PGP key available)


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev