Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Raphael Mack wrote:
Am Sonntag, 24. August 2008 schrieb Dirk Stöcker:
On Sun, 24 Aug 2008, Raphael Mack wrote:
There is still some work left to get the latest features like virtual
nodes in, but I'd be glad to hear, that you are interested in my
changes, else I just stop working on it.
I would like to have the ability to clean out GPX files without the
current workaround to convert them into osm and back.
ok, so I went on merging changes and got a version, which seems to work
somehow.
Find a diff and a josm-custom.jar at
http://files.raphael-mack.de/josm/josm-selection/
It would be nice, if you could try the recently introduced features and
take a look at the code.
Beside the deprecation warnings, I get following errors:
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:647: cannot
find symbol
[javac] symbol : method
selectPrims(java.util.Setorg.openstreetmap.josm.data.osm.OsmPrimitive,boolean,boolean)
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac]
selectPrims(Collections.singleton((OsmPrimitive)virtualNode), false, false);
[javac] ^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:656: cannot
find symbol
[javac] symbol : variable Mode
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac] if (mode == Mode.rotate affectedNodes.size() 2)
[javac] ^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:664: cannot
find symbol
[javac] symbol : variable Mode
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac] if (mode == Mode.move) {
[javac] ^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:681: cannot
find symbol
[javac] symbol : variable Mode
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac] } else if (mode == Mode.rotate) {
[javac]^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:685: cannot
find symbol
[javac] symbol : constructor
RotateCommand(java.util.Collectionorg.openstreetmap.josm.data.osm.OsmPrimitive,org.openstreetmap.josm.data.coor.EastNorth,org.openstreetmap.josm.data.coor.EastNorth)
[javac] location: class org.openstreetmap.josm.command.RotateCommand
[javac] Main.main.undoRedo.add(new RotateCommand(selection,
mouseStartEN, mouseEN));
[javac]^
Ciao
--
http://www.dstoecker.eu/ (PGP key available)___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Mon, 25 Aug 2008, Raphael Mack wrote: Ooops, I wanted to make a patch against the latest revision in svn and did a svn up before making the patch. And I forgot to recompile... should be better now. (its a patch against r868 now) The deprecation messages are trivial to resolve and I'll do it before commiting of course. One of the problems are the conflicts with Jörg's patches. How complicated are they to resolve, when I checkin his patch before the stuff of yours? Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
Hi In any case, if I have time enough, I will be glad to be a beta-user for actually, it is already there: http://files.raphael-mack.de/josm/josm-selection/josm-custom.jar I have tested it, here my results: * opening a gpx file still works :-) * selecting one / several GPX point(s) is OK, with and without openend osm layer, and thus according to the selected layer (if marker selected, it selects markers, if osm, nothing, if gpx it selects points) * saving file: according to timestamps, it allows to save the file. What I was not able to do: once I have selected some several points making a wrong track, I wanted to delete them. But I did not succeeded in my attempts. I did following: in JOSM menu, - delete: no success the icone with the line and the trash - no success delete button - no success. Maybe I missed something ? If yes, could you explain me? else ready for another trial. by the way: I tested it with windows XP, sp2, and jre sun 1.5_6 best regards Pierre-André ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
nice thanks for your report. Actually deleting is not yet implemented. This Ok already is a rather big change. And if it does not introduce bugs it's I will use your custom from now one. If you introduce some changes and need testing, let me know, and I will download the latest latest in order to test it. cu Pierre-André ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Selecting objects in JOSM
Hi, quite a while ago (http://lists.openstreetmap.org/pipermail/josm-dev/2008-March/000797.html) I started to work on support to edit GPX in JOSM (only drop/filter nodes, not move and add). Therefore I suggested to add a interface Selectable and handle selection related things via the layer. Since then I was quite busy, but will probably find more time in the upcoming months, so I'd like to start a new try to get that selection stuff in. Since there are quite a few new names on this list since then, I hope to get a bit more feedback than last time. - else I'll just make it work and commit. I do not have a patch against a new version yet, therefore I try to summarize the main changes: - new interface Selectable, which shall be implemented by all objects which may be selected (OsmPrimitives, Gpx-/WayPoints, but also Markers, and the like) - SelectionChangeListeners are not registered at the DataSet anymore, but in Main, now. - each layer stores it's own set of selected objects (Selectables) There is still some work left to get the latest features like virtual nodes in, but I'd be glad to hear, that you are interested in my changes, else I just stop working on it. Cheers, Rapha ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Raphael Mack wrote: There is still some work left to get the latest features like virtual nodes in, but I'd be glad to hear, that you are interested in my changes, else I just stop working on it. I would like to have the ability to clean out GPX files without the current workaround to convert them into osm and back. Thought I would not like do the necessary changes myself :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
Am Sonntag, 24. August 2008 schrieb Dirk Stöcker: On Sun, 24 Aug 2008, Raphael Mack wrote: There is still some work left to get the latest features like virtual nodes in, but I'd be glad to hear, that you are interested in my changes, else I just stop working on it. I would like to have the ability to clean out GPX files without the current workaround to convert them into osm and back. ok, so I went on merging changes and got a version, which seems to work somehow. Find a diff and a josm-custom.jar at http://files.raphael-mack.de/josm/josm-selection/ It would be nice, if you could try the recently introduced features and take a look at the code. Feedback is welcome! Rapha ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Raphael Mack wrote: Am Sonntag, 24. August 2008 schrieb Dirk Stöcker: On Sun, 24 Aug 2008, Raphael Mack wrote: There is still some work left to get the latest features like virtual nodes in, but I'd be glad to hear, that you are interested in my changes, else I just stop working on it. I would like to have the ability to clean out GPX files without the current workaround to convert them into osm and back. ok, so I went on merging changes and got a version, which seems to work somehow. Find a diff and a josm-custom.jar at http://files.raphael-mack.de/josm/josm-selection/ It would be nice, if you could try the recently introduced features and take a look at the code. Wow. Major changes. Can we break these into smaller pieces? I had a look at the whole diff and all the modifications seem to go into the right direction, but I would not like to introduce them in such a large pack. A step-by-step integration would be much more the style I would favour. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
Hi, Dirk Stöcker wrote: Wow. Major changes. Can we break these into smaller pieces? I had a look at the whole diff and all the modifications seem to go into the right direction, but I would not like to introduce them in such a large pack. A step-by-step integration would be much more the style I would favour. Well now that we're establishing josm-tested, we could also wait a day or two, then make the current version with the virtual nodes into -tested, and apply Raphael's patch to -latest and see what happens ;-) Bye Frederik -- Frederik Ramm ## eMail [EMAIL PROTECTED] ## N49°00'09 E008°23'33 ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Frederik Ramm wrote: Wow. Major changes. Can we break these into smaller pieces? I had a look at the whole diff and all the modifications seem to go into the right direction, but I would not like to introduce them in such a large pack. A step-by-step integration would be much more the style I would favour. Well now that we're establishing josm-tested, we could also wait a day or two, then make the current version with the virtual nodes into -tested, and apply Raphael's patch to -latest and see what happens ;-) Ok. Let's try this. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
