Re: [josm-dev] how does the transition to tested work ?

2010-03-09 Thread Sebastian Klein
Ævar Arnfjörð Bjarmason wrote:
> I just tried and I can't reproduce this or the issue with the number
> of objects to be uploaded drifting from what really needs to be
> uploaded.
> 
> Now if I upload a per-object upload and it fails partway the objects
> that were uploaded up until that point will be counted as uploaded and
> won't be re-uploaded.
> 
> But like I said I don't know if this issue in particular was what was
> causing some of the duplicates I was seeing initially.

Thanks for clearing this up. If you find other pitfalls, or run across
data destroying bugs, please let us know! (Power users like you and
Skyper seem to have a much higher probability of running into these. :)   )

__

Sebastian





___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-09 Thread Dirk Stöcker
On Mon, 8 Mar 2010, Matthias Julius wrote:

>> This is a major issue which I think should be adressed soon. It won't
>> replace the current feature for resolving
>> an individual conflict, but it should complete it with better support
>> for mass resolution.
>
> Since a while I have been thinking adding "Take mine" and "Take theirs"
> to the context menu of the conflict list dialog.  Even quicker would be
> if the conflict list dialog had buttons for this.

Be careful with this. It should only be offered for simple conflicts.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Matthias Julius
Karl Guggisberg  writes:

>>  maybe we should add a comment that uploads should be done in 1 transaction 
>> only until this bug is fixed.
> This wouldn't really help. Even if data is uploaded in one "transaction" 
> (i.e. with exactly one upload into one changeset before the changeset is 
> closed), we may run into the problem if the user cancels the upload.
>
> Anyway, a warning message couldn't harm, but I'd display it when the user 
> cancels an upload. It should read something along the lines of:
>
> * if the upload included new objects
>"You canceled the upload of new objects. If you retry the upload the same 
> objects could be uploaded again. Before the next upload
> please update your data and run validator for duplicate nodes."
>
> * if the upload didn't included new objects
>"You canceled an upload. If you retry the upload you might create a lot of 
> conflicts because your local dataset might be out of sync
> with the data on the server. Before the next upload  please update your 
> data and resolve any conflicts."
>
> But both these warnings aren't really helpful because in both cases you may 
> end up with strange data and/or a lot of work (resolving
> hundreds of conflicts, for instance). We will probably have to implement the 
> workaround described in #4401 and hope for an improved
> API/protocol in API 0.7.

If an upload fails, times out, gets canceled, or whatever JOSM could
examine the changeset and see what matches the data to be uploaded.

Matthias

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Matthias Julius
Karl Guggisberg  writes:

> Yes, conflict resolution today is clearly not well-designed for mass 
> resolution of conflicts. Openening a dialog,
> resolving the conflict, and closing the dialog again, is very tedious if 
> you have to resolve more than, say, 20 conflicts.
>
> This is a major issue which I think should be adressed soon. It won't 
> replace the current feature for resolving
> an individual conflict, but it should complete it with better support 
> for mass resolution.

Since a while I have been thinking adding "Take mine" and "Take theirs"
to the context menu of the conflict list dialog.  Even quicker would be
if the conflict list dialog had buttons for this.

I didn't do anything in that direction, yet, because we are trying to
stabilize JOSM.

Matthias

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 8, 2010 at 19:21, Ævar Arnfjörð Bjarmason  wrote:
>> Don't fear to clutter the database for testing. If you can help us
>> resolving this, it's for the greater good. :)
>
> I'll see if I can reproduce this on api06.dev.

I just tried and I can't reproduce this or the issue with the number
of objects to be uploaded drifting from what really needs to be
uploaded.

Now if I upload a per-object upload and it fails partway the objects
that were uploaded up until that point will be counted as uploaded and
won't be re-uploaded.

But like I said I don't know if this issue in particular was what was
causing some of the duplicates I was seeing initially.

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 8, 2010 at 17:01, Sebastian Klein  wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> This is how I've been running into this:
>>
>>   1. Download data from the OSM server, say 20 ways
>>   2. While I edit 10 of those 2 have been changed already, so 2/10 conflict
>>   3. Press "upload" in single-object mode, will upload 1/10, 2/10...
>>   4. It conflicts at say the 5th object out of 10 and stops the entire
>> upload process
>>   6. If I try again it'll still start from 1/10 instead of 1/5
>>
>> As I said I haven't tracked this down in any detail but it seems that
>> in some situations JOSM doesn't track the stuff it has uploaded
>> already when it runs into conflicts during uploads.
>
> I forgot to ask: With "recently" you mean after 5th February or so? (The
> server behavior has changed at that time due to a reimplementation.)

Recently meaning from January up to March 1st. I ran into his a lot
when processing the ourFootPrints import as blogged about here:
http://www.openstreetmap.org/user/%C3%86var%20Arnfj%C3%B6r%C3%B0%20Bjarmason/diary/9698

> What edits did you perform? Did you add more nodes, deleted nodes or
> just updated tags?

These are pretty much the edits we were doing:


http://wiki.openstreetmap.org/wiki/WikiProject_Iceland/ourFootPrints#Dealing_with_the_ofp_data

The conflicts occured when we stepped on each others toes. This
happened a bit frequently since we were all editing with day-old
Iceland.osm dumps so we'd occasionally step on each others toes.

> Don't fear to clutter the database for testing. If you can help us
> resolving this, it's for the greater good. :)

I'll see if I can reproduce this on api06.dev.

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Sebastian Klein
Ævar Arnfjörð Bjarmason wrote:
> This is how I've been running into this:
> 
>   1. Download data from the OSM server, say 20 ways
>   2. While I edit 10 of those 2 have been changed already, so 2/10 conflict
>   3. Press "upload" in single-object mode, will upload 1/10, 2/10...
>   4. It conflicts at say the 5th object out of 10 and stops the entire
> upload process
>   6. If I try again it'll still start from 1/10 instead of 1/5
> 
> As I said I haven't tracked this down in any detail but it seems that
> in some situations JOSM doesn't track the stuff it has uploaded
> already when it runs into conflicts during uploads.

I forgot to ask: With "recently" you mean after 5th February or so? (The 
server behavior has changed at that time due to a reimplementation.)

What edits did you perform? Did you add more nodes, deleted nodes or 
just updated tags?

Don't fear to clutter the database for testing. If you can help us 
resolving this, it's for the greater good. :)

__

Sebastian

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 8, 2010 at 16:59, Dirk Stöcker  wrote:
> On Mon, 8 Mar 2010, Ævar Arnfjörð Bjarmason wrote:
>
>>> To have better conflict solving you may use "Update modified" from first
>>> menu. This will produce all conflicts in one single run and allows them
>>> to
>>> fix in one go.
>>
>> Yes, but due to the bad interface for conflict resolution in JOSM this
>> isn't an option sometimes. There isn't support for mass-resolution of
>> similar conflicts (I've filed bugs for this) so you run into
>> situations where you can either:
>
> Well, I think about a year ago we had NO working conflict resolution at all
> and I also think JOSM is the only editor which has that feature working
> reliable. So be happy you can click 300 dialogs :-)
>
> Beside that a semi-automatic conflict resolution for very common cases
> should be implemented. Probably we should add a "send workflow data to
> server" option, so we can get data about the real user needs (for these
> cases where users don't know at all what the would like to have).
>
> We already have rudimentary support (plugin list and version string) for
> such analysis and it influenced development already.

Sure. I know this is a hard problem to get right and we're all aware
of these issues already. I just wanted to point out why "Update
modified" isn't always what you want because you sometimes want to
explicitly avoid the conflict resolution and upload as much of what
you can from your local dataset.

In my experience if you get more than 30 conflicts in JOSM it's going
to be less work just to close JOSM and redo all your edits than
dealing with the resolving them (although I do save frequently).

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Dirk Stöcker

On Mon, 8 Mar 2010, Ævar Arnfjörð Bjarmason wrote:


To have better conflict solving you may use "Update modified" from first
menu. This will produce all conflicts in one single run and allows them to
fix in one go.


Yes, but due to the bad interface for conflict resolution in JOSM this
isn't an option sometimes. There isn't support for mass-resolution of
similar conflicts (I've filed bugs for this) so you run into
situations where you can either:


Well, I think about a year ago we had NO working conflict resolution at 
all and I also think JOSM is the only editor which has that feature 
working reliable. So be happy you can click 300 dialogs :-)


Beside that a semi-automatic conflict resolution for very common cases 
should be implemented. Probably we should add a "send workflow data to 
server" option, so we can get data about the real user needs (for these 
cases where users don't know at all what the would like to have).


We already have rudimentary support (plugin list and version string) for 
such analysis and it influenced development already.


Ciao
--
http://www.dstoecker.eu/ (PGP key available)___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Karl Guggisberg
Yes, conflict resolution today is clearly not well-designed for mass 
resolution of conflicts. Openening a dialog,
resolving the conflict, and closing the dialog again, is very tedious if 
you have to resolve more than, say, 20 conflicts.

This is a major issue which I think should be adressed soon. It won't 
replace the current feature for resolving
an individual conflict, but it should complete it with better support 
for mass resolution.

Regards
Karl

Am 08.03.2010 17:39, schrieb Ævar Arnfjörð Bjarmason:
> On Mon, Mar 8, 2010 at 16:30, Dirk Stöcker  wrote:
>
>> On Mon, 8 Mar 2010, Ævar Arnfjörð Bjarmason wrote:
>>
>>  
 for me this is really a bug not an enhancement. Josm is used for semi
 automatic imports a lot and this creates big mess of duplicates on
 server/network interrupts. I know it wasn't designed for that but Josm is
 just such a great workhorse.
 on normal editing this can leave a user with  conflicts after a partial
 upload, maybe we should add a comment that uploads should be done in 1
 transaction only until this bug is fixed.

 Anyway thanks for the great work and it's better to have a stable again.
 Josm is improving big with every release:)
  
>>> The problem with recommending that is that the only reason for using
>>> one object at a time uploading is to narrow down conflicts you may be
>>> having, right now due to this bug at the cost of adding lots of
>>> duplicates to the database.
>>>
>> To have better conflict solving you may use "Update modified" from first
>> menu. This will produce all conflicts in one single run and allows them to
>> fix in one go.
>>  
> Yes, but due to the bad interface for conflict resolution in JOSM this
> isn't an option sometimes. There isn't support for mass-resolution of
> similar conflicts (I've filed bugs for this) so you run into
> situations where you can either:
>
> * Solve 300 conflicts which are of the same nature manually. Which
> requires for each one:
>   1. Click on an item in the conflict list
>   2. Move to tags/whatever in the dialog
>   3. Click merge your/remote changes
>   4. Apply
>   5 Repeat
>
> After I'm done with that I'll have manually clicked UI elements at
> least 300*4 times or so.
>
> So instead of doing that when I run into it I just cut my losses and
> try to upload at least /some/ of my data. I do this by turning on
> single-object upload, trying to select subsets of the dataset and see
> if I can upload them without conflicts.
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev
>

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 8, 2010 at 16:30, Dirk Stöcker  wrote:
> On Mon, 8 Mar 2010, Ævar Arnfjörð Bjarmason wrote:
>
>>> for me this is really a bug not an enhancement. Josm is used for semi
>>> automatic imports a lot and this creates big mess of duplicates on
>>> server/network interrupts. I know it wasn't designed for that but Josm is
>>> just such a great workhorse.
>>> on normal editing this can leave a user with  conflicts after a partial
>>> upload, maybe we should add a comment that uploads should be done in 1
>>> transaction only until this bug is fixed.
>>>
>>> Anyway thanks for the great work and it's better to have a stable again.
>>> Josm is improving big with every release:)
>>
>> The problem with recommending that is that the only reason for using
>> one object at a time uploading is to narrow down conflicts you may be
>> having, right now due to this bug at the cost of adding lots of
>> duplicates to the database.
>
> To have better conflict solving you may use "Update modified" from first
> menu. This will produce all conflicts in one single run and allows them to
> fix in one go.

Yes, but due to the bad interface for conflict resolution in JOSM this
isn't an option sometimes. There isn't support for mass-resolution of
similar conflicts (I've filed bugs for this) so you run into
situations where you can either:

   * Solve 300 conflicts which are of the same nature manually. Which
requires for each one:
 1. Click on an item in the conflict list
 2. Move to tags/whatever in the dialog
 3. Click merge your/remote changes
 4. Apply
 5 Repeat

After I'm done with that I'll have manually clicked UI elements at
least 300*4 times or so.

So instead of doing that when I run into it I just cut my losses and
try to upload at least /some/ of my data. I do this by turning on
single-object upload, trying to select subsets of the dataset and see
if I can upload them without conflicts.

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 8, 2010 at 16:21, Sebastian Klein  wrote:
> Ævar Arnfjörð Bjarmason wrote:
>>> #4401 (JOSM does not remember what has been uploaded) It's more
>>> like an enhancement. Too complicated, will be fixed after release.
>>
>> I've used JOSM a lot recently to upload objects in the "one object at
>>  a time" mode, if it fails with a conflict it will start the whole
>> thing over again (even if it doesn't need to).
>
> This is news to me. Just tried the little "test script" from Karl in
> "one object at a time" mode and it worked well. (I.e. it created a
> conflict and the objects that had been uploaded before, where not marked
> as "modified" anymore.

This is how I've been running into this:

  1. Download data from the OSM server, say 20 ways
  2. While I edit 10 of those 2 have been changed already, so 2/10 conflict
  3. Press "upload" in single-object mode, will upload 1/10, 2/10...
  4. It conflicts at say the 5th object out of 10 and stops the entire
upload process
  6. If I try again it'll still start from 1/10 instead of 1/5

As I said I haven't tracked this down in any detail but it seems that
in some situations JOSM doesn't track the stuff it has uploaded
already when it runs into conflicts during uploads.

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Karl Guggisberg
>  I attempted to fix this once, but gave up soon. All these listeners
>  firing back and forth - it was frustrating to debug. Maybe you could
>  have a look, Karl? :)
Yeah, I will, I think I was very fascinated by PropertyChangeListeners
when I hacked this ;-)

-- Karl

Am 08.03.2010 17:21, schrieb Sebastian Klein:
> Ævar Arnfjörð Bjarmason wrote:
>
>>> #4584 (cursor not show in textfields of relations-editor) Cannot
>>> reproduce. We don't have enough info to fix this.
>>>
>> I think this is the same issue as I've just described in this bug
>> report: https://josm.openstreetmap.de/ticket/4686
>>  
> If it actually is the same issue, then it might be possible to fix it.
>
> (This "broken" state seems to be the default behavior of a Java table.)
>
>
>>> #4631 (Plugin download broken) [3090] should have addressed most
>>> points of this ticket.
>>>
>>> #4401 (JOSM does not remember what has been uploaded) It's more
>>> like an enhancement. Too complicated, will be fixed after release.
>>>
>> I've used JOSM a lot recently to upload objects in the "one object at
>>   a time" mode, if it fails with a conflict it will start the whole
>> thing over again (even if it doesn't need to).
>>  
> This is news to me. Just tried the little "test script" from Karl in
> "one object at a time" mode and it worked well. (I.e. it created a
> conflict and the objects that had been uploaded before, where not marked
> as "modified" anymore.
>
> I would appreciate, if you could describe a way to reproduce.
>
>
>>> #4371 (Changeset comment reverts to previous when switching
>>> options) The blocker flag wasn't set by a developer. Should be
>>> fixed, but isn't all that serious.
>>>
>> FWIW I have at least 10 large changesets uploaded to the main API
>> that have inaccurate changeset summaries because of this and related
>> bugs.
>>  
> I attempted to fix this once, but gave up soon. All these listeners
> firing back and forth - it was frustrating to debug. Maybe you could
> have a look, Karl? :)
>
> __
>
> Sebastian
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev
>

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Karl Guggisberg

>  maybe we should add a comment that uploads should be done in 1 transaction 
> only until this bug is fixed.
This wouldn't really help. Even if data is uploaded in one "transaction" (i.e. 
with exactly one upload into one changeset before the changeset is closed), we 
may run into the problem if the user cancels the upload.

Anyway, a warning message couldn't harm, but I'd display it when the user 
cancels an upload. It should read something along the lines of:

* if the upload included new objects
   "You canceled the upload of new objects. If you retry the upload the same 
objects could be uploaded again. Before the next upload
please update your data and run validator for duplicate nodes."

* if the upload didn't included new objects
   "You canceled an upload. If you retry the upload you might create a lot of 
conflicts because your local dataset might be out of sync
with the data on the server. Before the next upload  please update your 
data and resolve any conflicts."

But both these warnings aren't really helpful because in both cases you may end 
up with strange data and/or a lot of work (resolving
hundreds of conflicts, for instance). We will probably have to implement the 
workaround described in #4401 and hope for an improved
API/protocol in API 0.7.

-- Karl


Am 08.03.2010 17:15, schrieb Apollinaris Schoell:
> On 8 Mar 2010, at 7:04 , Sebastian Klein wrote:
>
>
>> #4401 (JOSM does not remember what has been uploaded)
>>It's more like an enhancement. Too complicated, will be fixed after
>> release.
>>
>>  
> for me this is really a bug not an enhancement. Josm is used for semi 
> automatic imports a lot and this creates big mess of duplicates on 
> server/network interrupts. I know it wasn't designed for that but Josm is 
> just such a great workhorse.
> on normal editing this can leave a user with  conflicts after a partial 
> upload, maybe we should add a comment that uploads should be done in 1 
> transaction only until this bug is fixed.
>
> Anyway thanks for the great work and it's better to have a stable again.
> Josm is improving big with every release:)
>
>
>> ___
>> josm-dev mailing list
>> josm-dev@openstreetmap.org
>> http://lists.openstreetmap.org/listinfo/josm-dev
>>  
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev
>
>

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Dirk Stöcker

On Mon, 8 Mar 2010, Ævar Arnfjörð Bjarmason wrote:


for me this is really a bug not an enhancement. Josm is used for semi automatic 
imports a lot and this creates big mess of duplicates on server/network 
interrupts. I know it wasn't designed for that but Josm is just such a great 
workhorse.
on normal editing this can leave a user with  conflicts after a partial upload, 
maybe we should add a comment that uploads should be done in 1 transaction only 
until this bug is fixed.

Anyway thanks for the great work and it's better to have a stable again.
Josm is improving big with every release:)


The problem with recommending that is that the only reason for using
one object at a time uploading is to narrow down conflicts you may be
having, right now due to this bug at the cost of adding lots of
duplicates to the database.


To have better conflict solving you may use "Update modified" from first 
menu. This will produce all conflicts in one single run and allows them to 
fix in one go.


Ciao
--
http://www.dstoecker.eu/ (PGP key available)___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Sebastian Klein
Ævar Arnfjörð Bjarmason wrote:
>> #4584 (cursor not show in textfields of relations-editor) Cannot
>> reproduce. We don't have enough info to fix this.
> 
> I think this is the same issue as I've just described in this bug 
> report: https://josm.openstreetmap.de/ticket/4686

If it actually is the same issue, then it might be possible to fix it.

(This "broken" state seems to be the default behavior of a Java table.)

>> #4631 (Plugin download broken) [3090] should have addressed most
>> points of this ticket.
>> 
>> #4401 (JOSM does not remember what has been uploaded) It's more
>> like an enhancement. Too complicated, will be fixed after release.
> 
> I've used JOSM a lot recently to upload objects in the "one object at
>  a time" mode, if it fails with a conflict it will start the whole 
> thing over again (even if it doesn't need to).

This is news to me. Just tried the little "test script" from Karl in 
"one object at a time" mode and it worked well. (I.e. it created a 
conflict and the objects that had been uploaded before, where not marked 
as "modified" anymore.

I would appreciate, if you could describe a way to reproduce.

>> #4371 (Changeset comment reverts to previous when switching
>> options) The blocker flag wasn't set by a developer. Should be
>> fixed, but isn't all that serious.
> 
> FWIW I have at least 10 large changesets uploaded to the main API
> that have inaccurate changeset summaries because of this and related
> bugs.

I attempted to fix this once, but gave up soon. All these listeners
firing back and forth - it was frustrating to debug. Maybe you could 
have a look, Karl? :)

__

Sebastian

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 8, 2010 at 16:15, Apollinaris Schoell  wrote:
>
> On 8 Mar 2010, at 7:04 , Sebastian Klein wrote:
>
>>
>> #4401 (JOSM does not remember what has been uploaded)
>>   It's more like an enhancement. Too complicated, will be fixed after
>> release.
>>
>
> for me this is really a bug not an enhancement. Josm is used for semi 
> automatic imports a lot and this creates big mess of duplicates on 
> server/network interrupts. I know it wasn't designed for that but Josm is 
> just such a great workhorse.
> on normal editing this can leave a user with  conflicts after a partial 
> upload, maybe we should add a comment that uploads should be done in 1 
> transaction only until this bug is fixed.
>
> Anyway thanks for the great work and it's better to have a stable again.
> Josm is improving big with every release:)

The problem with recommending that is that the only reason for using
one object at a time uploading is to narrow down conflicts you may be
having, right now due to this bug at the cost of adding lots of
duplicates to the database.

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Apollinaris Schoell

On 8 Mar 2010, at 7:04 , Sebastian Klein wrote:

> 
> #4401 (JOSM does not remember what has been uploaded)
>   It's more like an enhancement. Too complicated, will be fixed after
> release.
> 

for me this is really a bug not an enhancement. Josm is used for semi automatic 
imports a lot and this creates big mess of duplicates on server/network 
interrupts. I know it wasn't designed for that but Josm is just such a great 
workhorse.
on normal editing this can leave a user with  conflicts after a partial upload, 
maybe we should add a comment that uploads should be done in 1 transaction only 
until this bug is fixed.

Anyway thanks for the great work and it's better to have a stable again. 
Josm is improving big with every release:)

> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 8, 2010 at 15:04, Sebastian Klein  wrote:
> #4366 (validator: repair: overlapping ways distroys data)
>   Plugin issue, can be fixed after release.
>
> #4584 (cursor not show in textfields of relations-editor)
>   Cannot reproduce. We don't have enough info to fix this.

I think this is the same issue as I've just described in this bug
report: https://josm.openstreetmap.de/ticket/4686

I've made the old one a duplicate of this new report.

> #4631 (Plugin download broken)
>   [3090] should have addressed most points of this ticket.
>
> #4401 (JOSM does not remember what has been uploaded)
>   It's more like an enhancement. Too complicated, will be fixed after
> release.

I've used JOSM a lot recently to upload objects in the "one object at
a time" mode, if it fails with a conflict it will start the whole
thing over again (even if it doesn't need to).

I'm not 100% sure but I think that #4401 has been causing a lot of
duplicate data created by JOSM that I've had to clean up. Uploading
duplicates is definitely a bug.

> #4371 (Changeset comment reverts to previous when switching options)
>   The blocker flag wasn't set by a developer. Should be fixed, but isn't
> all that serious.

FWIW I have at least 10 large changesets uploaded to the main API that
have inaccurate changeset summaries because of this and related bugs.

> So, I'd say it was OK to release, but tested version should be updated
> before next development cycle.
>
>> I think tested should be a version without any blocker/critical bug
>> reported on and being tested as unstable/latest for a week.
>
> This is how we try to do it, but some critical bus are not easy to fix,
> so we postpone these issues and move on.

Aren't all these bugs already in the latest tested? A new tested with
the same bugs (+ unrelated fixes) wouldn't be any worse would it?

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread colliar
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256



Dirk Stöcker schrieb:
[flaming removed]

> There has been no progress with the remaining blocker entries in the last 
> 2 weeks. The question was whether we nevertheless make a tested or not. 
> There was only comment in this list and it was "Yes", so 3070 got new 
> tested.

I was outdoor mapping and did not check my mails in total -> my fault.
Never the less I would like to have at least r3081 as tested. ( even better
would be after the update-plugin bugs are fixed !!)
Any possibility? Any reasons why not ?

> I also wrote that I'm not 100% happy with current version, but 
> nevertheless we need to move on or we will have no new version next year.

I wonder if there will be a 100% since world changes quite rapidly and I hope
there will always be action within a movement otherwise it won't exist anymore.

I think tested should be a bit more stable then it is right now.
I need a backup revision without the new indroduced bugs that I can  trust
especially on upload and conflict management.


Thanks a lot for your work, especially bastik.
I can upload again, without that many problems. Thanks

Colliar
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEAREIAAYFAkuVEs0ACgkQalWTFLzqsCtj0ACg5xrKMxPPulppdCt/j+Qvy/IQ
7rwAoORlHMh0S7bMev+FOayNJ5d9Kbrf
=OXqS
-END PGP SIGNATURE-

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Dirk Stöcker
On Mon, 8 Mar 2010, Sebastian Klein wrote:

> Dirk suggested that we "maybe make comming saturday version tested
> again". (Which would be last Saturday, by now.)

I now changed it to 3094 (there have been mainly bug-fixes, so this should 
be without trouble).

> #4631 (Plugin download broken)
>   [3090] should have addressed most points of this ticket.

There is a new one #4679, so the plugin issue is still not really working 
as expected.

Major problem is still that Windows release does not build, as launch4j 
contains a 32bit binary (windres) which does not work on new 64 bit 
server. Suggestions welcome, the code is in OSM-JOSM-SVN (directory nsis).

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Sebastian Klein
colliar wrote:
> I still wonder how the transition to tested works. As bug #4666
> is/was really annoying but is fixed now exists still in r3070. This
> has also effects on "update data" (see #4663). Please update tested
> to r3081.

Dirk suggested that we "maybe make comming saturday version tested
again". (Which would be last Saturday, by now.)

There seem to be no updates on that, so who knows what will happen.

> I also find 5 bugs left with keyword: "r-2010-01-blocker". Are you
> planning to solve them before working on upstream ?

Short comments on the "r-2010-01-blocker" tickets:

#4366 (validator: repair: overlapping ways distroys data)
   Plugin issue, can be fixed after release.

#4584 (cursor not show in textfields of relations-editor)
   Cannot reproduce. We don't have enough info to fix this.

#4631 (Plugin download broken)
   [3090] should have addressed most points of this ticket.

#4401 (JOSM does not remember what has been uploaded)
   It's more like an enhancement. Too complicated, will be fixed after
release.

#4371 (Changeset comment reverts to previous when switching options)
   The blocker flag wasn't set by a developer. Should be fixed, but isn't
all that serious.

So, I'd say it was OK to release, but tested version should be updated 
before next development cycle.

> I think tested should be a version without any blocker/critical bug
> reported on and being tested as unstable/latest for a week.

This is how we try to do it, but some critical bus are not easy to fix,
so we postpone these issues and move on.

__

Sebastian

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Dirk Stöcker
On Mon, 8 Mar 2010, Karl Guggisberg wrote:

[flaming removed]

> Please forget about the "r-2010-01-blocker"s. They've been introduced in 
> an attempt to prepare and stabilize a release when the current 
> "maintainer" handed over responsibility to two of us, because he didn't 
> have time.

There has been no progress with the remaining blocker entries in the last 
2 weeks. The question was whether we nevertheless make a tested or not. 
There was only comment in this list and it was "Yes", so 3070 got new 
tested.

I also wrote that I'm not 100% happy with current version, but 
nevertheless we need to move on or we will have no new version next year.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Karl Guggisberg
Hi Colliar

Yes, you're right, that's how how most professionals in most other 
commercial and OS projects work,
or at least try to work. Unfortunately, JOSM is different. The JOSM 
release process is one of the
many JOSMisms which are often hard to understand for both JOSM users and 
JOSM contributors.

Please forget about the "r-2010-01-blocker"s. They've been introduced in 
an attempt to prepare and
stabilize a release when the current "maintainer" handed over 
responsibility  to two of us, because he didn't have time.
Just ignore them. The current "maintainer" is apparently back in business.

Actually, "two of us" is wrong. bastik took over responsibility and did 
most of the work for the last "tested" build, thanks!

Regards
Karl

Am 08.03.2010 12:33, schrieb colliar:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Hi
>
> Thanks a lot for your work.
>
> I still wonder how the transition to tested works. As bug #4666 is/was really
> annoying but is fixed now exists still in r3070. This has also effects on
> "update data" (see #4663).
> Please update tested to r3081.
>
> I also find 5 bugs left with keyword: "r-2010-01-blocker". Are you planning to
> solve them before working on upstream ?
>
> I think tested should be a version without any blocker/critical bug reported 
> on
> and being tested as unstable/latest for a week.
>
> cu co
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEAREIAAYFAkuU4HQACgkQalWTFLzqsCvMywCgs8SAs189fgYDMY+gekkB0dB9
> TaQAn2mUVrBjnhUcp65UukpXrA2YvCCz
> =5hlO
> -END PGP SIGNATURE-
>
> ___
> josm-dev mailing list
> josm-dev@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev
>
>

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] how does the transition to tested work ?

2010-03-08 Thread Dirk Stöcker
On Mon, 8 Mar 2010, colliar wrote:

> I think tested should be a version without any blocker/critical bug reported 
> on
> and being tested as unstable/latest for a week.

Theoretically it would be fine, practically this is no requirement.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


[josm-dev] how does the transition to tested work ?

2010-03-08 Thread colliar
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi

Thanks a lot for your work.

I still wonder how the transition to tested works. As bug #4666 is/was really
annoying but is fixed now exists still in r3070. This has also effects on
"update data" (see #4663).
Please update tested to r3081.

I also find 5 bugs left with keyword: "r-2010-01-blocker". Are you planning to
solve them before working on upstream ?

I think tested should be a version without any blocker/critical bug reported on
and being tested as unstable/latest for a week.

cu co
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEAREIAAYFAkuU4HQACgkQalWTFLzqsCvMywCgs8SAs189fgYDMY+gekkB0dB9
TaQAn2mUVrBjnhUcp65UukpXrA2YvCCz
=5hlO
-END PGP SIGNATURE-

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev