[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Any news about multiple tr tags in a thead ? tlphipps wrote: Personally I would prefer the metadata approach since I'm already using metadata to control other tablesorter parameters. Thanks for tackling this issue! On Sep 19, 10:22 am, Christian Bach [EMAIL PROTECTED] wrote: Hi, I can take a look into this issue on Thursday. One way to solve this would either to have a option in the plugin constructor that would allow you to specify a row index or use the metadata plugin. Do you have a preferred way? /christian 2007/9/19, tlphipps [EMAIL PROTECTED]: Christian, have you had a chance to look into the issue with multiple tr tags in a thead? I've verified that this issue still exists with the 2.0.1 version of the tablesorter code. Any help or insight you could provide on this issue would be greatly appreciated. I sent the following off-list a few weeks ago: === I've setup an example page at: http://www.garethphipps.com/tablesorttest/index.html I've enabled debug mode for simplicity. Just to recap: This table has two tr tags in the thead. What is happening is that the checkCellColSpan() function is not properly filling the array of ths in this case. If I bypass that function and just create the array of ths myself, everything in the tablesorter works correctly. One note: Currently the second tr actually utilizes a colspan, but I originally was NOT using them in either tr. The issue existed before I added the colspan. As a side note, I couldn't figure out why you are passing 4 arguments to the checkCellColSpan() function. That could just be my lack of JavaScript knowledge. Also, I setup a second page with my modified tablesorter code that simply bypasses the checkCellColSpan() function so you can see the result I'm looking for. It's:http://www.garethphipps.com/tablesorttest/index2.html = On Sep 18, 6:02 am, Christian Bach [EMAIL PROTECTED] wrote: Thanks Kia, saved a few more bytes! Removed and updated tablesorter.com with the latest version. /christian 2007/9/18, Kia Niskavaara [EMAIL PROTECTED]: Thanks for the update!! I've noticed that you've included two almost identical sorters: $.tablesorter.addParser({ id: integer, is: function(s) { return s.match(new RegExp(/^\d+$/)); }, format: function(s) { return $.tablesorter.formatInt(s); }, type: numeric }); $.tablesorter.addParser({ id: integer, is: function(s) { return /^\d+$/.test(s); }, format: function(s) { return $.tablesorter.formatFloat(s); }, type: numeric }); Christian Bach wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2 release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all athttp://tablesorter.com Enjoy! /christian -- View this message in context: http://www.nabble.com/Announce%3A-jQuery-Tablesorter-2.0.1-Released-tp12740887s27240p15204434.html Sent from the jQuery General Discussion mailing list archive at Nabble.com.
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Bill, Try the updated version, it fixes this issue: http://tablesorter.com/jquery.tablesorter.pack.js /christian 2007/9/20, Bill Huber [EMAIL PROTECTED]: Thanks for the great work Christian! I did find that the 2.0.1 packed version does not work for me. It complains about a missing semi-colon. I ran the code through online lint(http://www.javascriptlint.com/online_lint.php) and it points at line 235. The unpacked and minified version worked since they are less particular about semi-colons. Enjoy! Bill -- View this message in context: http://www.nabble.com/Announce%3A-jQuery-Tablesorter-2.0.1-Released-tf4468417s15494.html#a12801762 Sent from the JQuery mailing list archive at Nabble.com.
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Thanks for the great work Christian! I did find that the 2.0.1 packed version does not work for me. It complains about a missing semi-colon. I ran the code through online lint(http://www.javascriptlint.com/online_lint.php) and it points at line 235. The unpacked and minified version worked since they are less particular about semi-colons. Enjoy! Bill -- View this message in context: http://www.nabble.com/Announce%3A-jQuery-Tablesorter-2.0.1-Released-tf4468417s15494.html#a12801762 Sent from the JQuery mailing list archive at Nabble.com.
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Christian, have you had a chance to look into the issue with multiple tr tags in a thead? I've verified that this issue still exists with the 2.0.1 version of the tablesorter code. Any help or insight you could provide on this issue would be greatly appreciated. I sent the following off-list a few weeks ago: === I've setup an example page at: http://www.garethphipps.com/tablesorttest/index.html I've enabled debug mode for simplicity. Just to recap: This table has two tr tags in the thead. What is happening is that the checkCellColSpan() function is not properly filling the array of ths in this case. If I bypass that function and just create the array of ths myself, everything in the tablesorter works correctly. One note: Currently the second tr actually utilizes a colspan, but I originally was NOT using them in either tr. The issue existed before I added the colspan. As a side note, I couldn't figure out why you are passing 4 arguments to the checkCellColSpan() function. That could just be my lack of JavaScript knowledge. Also, I setup a second page with my modified tablesorter code that simply bypasses the checkCellColSpan() function so you can see the result I'm looking for. It's: http://www.garethphipps.com/tablesorttest/index2.html = On Sep 18, 6:02 am, Christian Bach [EMAIL PROTECTED] wrote: Thanks Kia, saved a few more bytes! Removed and updated tablesorter.com with the latest version. /christian 2007/9/18, Kia Niskavaara [EMAIL PROTECTED]: Thanks for the update!! I've noticed that you've included two almost identical sorters: $.tablesorter.addParser({ id: integer, is: function(s) { return s.match(new RegExp(/^\d+$/)); }, format: function(s) { return $.tablesorter.formatInt(s); }, type: numeric }); $.tablesorter.addParser({ id: integer, is: function(s) { return /^\d+$/.test(s); }, format: function(s) { return $.tablesorter.formatFloat(s); }, type: numeric }); Christian Bach wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2 release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all athttp://tablesorter.com Enjoy! /christian
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Hi, I can take a look into this issue on Thursday. One way to solve this would either to have a option in the plugin constructor that would allow you to specify a row index or use the metadata plugin. Do you have a preferred way? /christian 2007/9/19, tlphipps [EMAIL PROTECTED]: Christian, have you had a chance to look into the issue with multiple tr tags in a thead? I've verified that this issue still exists with the 2.0.1 version of the tablesorter code. Any help or insight you could provide on this issue would be greatly appreciated. I sent the following off-list a few weeks ago: === I've setup an example page at: http://www.garethphipps.com/tablesorttest/index.html I've enabled debug mode for simplicity. Just to recap: This table has two tr tags in the thead. What is happening is that the checkCellColSpan() function is not properly filling the array of ths in this case. If I bypass that function and just create the array of ths myself, everything in the tablesorter works correctly. One note: Currently the second tr actually utilizes a colspan, but I originally was NOT using them in either tr. The issue existed before I added the colspan. As a side note, I couldn't figure out why you are passing 4 arguments to the checkCellColSpan() function. That could just be my lack of JavaScript knowledge. Also, I setup a second page with my modified tablesorter code that simply bypasses the checkCellColSpan() function so you can see the result I'm looking for. It's: http://www.garethphipps.com/tablesorttest/index2.html = On Sep 18, 6:02 am, Christian Bach [EMAIL PROTECTED] wrote: Thanks Kia, saved a few more bytes! Removed and updated tablesorter.com with the latest version. /christian 2007/9/18, Kia Niskavaara [EMAIL PROTECTED]: Thanks for the update!! I've noticed that you've included two almost identical sorters: $.tablesorter.addParser({ id: integer, is: function(s) { return s.match(new RegExp(/^\d+$/)); }, format: function(s) { return $.tablesorter.formatInt(s); }, type: numeric }); $.tablesorter.addParser({ id: integer, is: function(s) { return /^\d+$/.test(s); }, format: function(s) { return $.tablesorter.formatFloat(s); }, type: numeric }); Christian Bach wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2 release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all athttp://tablesorter.com Enjoy! /christian
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Personally I would prefer the metadata approach since I'm already using metadata to control other tablesorter parameters. Thanks for tackling this issue! On Sep 19, 10:22 am, Christian Bach [EMAIL PROTECTED] wrote: Hi, I can take a look into this issue on Thursday. One way to solve this would either to have a option in the plugin constructor that would allow you to specify a row index or use the metadata plugin. Do you have a preferred way? /christian 2007/9/19, tlphipps [EMAIL PROTECTED]: Christian, have you had a chance to look into the issue with multiple tr tags in a thead? I've verified that this issue still exists with the 2.0.1 version of the tablesorter code. Any help or insight you could provide on this issue would be greatly appreciated. I sent the following off-list a few weeks ago: === I've setup an example page at: http://www.garethphipps.com/tablesorttest/index.html I've enabled debug mode for simplicity. Just to recap: This table has two tr tags in the thead. What is happening is that the checkCellColSpan() function is not properly filling the array of ths in this case. If I bypass that function and just create the array of ths myself, everything in the tablesorter works correctly. One note: Currently the second tr actually utilizes a colspan, but I originally was NOT using them in either tr. The issue existed before I added the colspan. As a side note, I couldn't figure out why you are passing 4 arguments to the checkCellColSpan() function. That could just be my lack of JavaScript knowledge. Also, I setup a second page with my modified tablesorter code that simply bypasses the checkCellColSpan() function so you can see the result I'm looking for. It's:http://www.garethphipps.com/tablesorttest/index2.html = On Sep 18, 6:02 am, Christian Bach [EMAIL PROTECTED] wrote: Thanks Kia, saved a few more bytes! Removed and updated tablesorter.com with the latest version. /christian 2007/9/18, Kia Niskavaara [EMAIL PROTECTED]: Thanks for the update!! I've noticed that you've included two almost identical sorters: $.tablesorter.addParser({ id: integer, is: function(s) { return s.match(new RegExp(/^\d+$/)); }, format: function(s) { return $.tablesorter.formatInt(s); }, type: numeric }); $.tablesorter.addParser({ id: integer, is: function(s) { return /^\d+$/.test(s); }, format: function(s) { return $.tablesorter.formatFloat(s); }, type: numeric }); Christian Bach wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2 release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all athttp://tablesorter.com Enjoy! /christian
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Hi Chris, Nope there is no reason other than that i forgot to delete it. Its removed now. Thanks for the feedback. /christian 2007/9/17, Chris [EMAIL PROTECTED]: Is there a reason jquery-1.1.3.js is included in the Zip file when 1.2.1 is required? On Sep 17, 12:37 pm, Christian Bach [EMAIL PROTECTED] wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all athttp://tablesorter.com Enjoy! /christian
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Thanks for the update!! I've noticed that you've included two almost identical sorters: $.tablesorter.addParser({ id: integer, is: function(s) { return s.match(new RegExp(/^\d+$/)); }, format: function(s) { return $.tablesorter.formatInt(s); }, type: numeric }); $.tablesorter.addParser({ id: integer, is: function(s) { return /^\d+$/.test(s); }, format: function(s) { return $.tablesorter.formatFloat(s); }, type: numeric }); Christian Bach wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2 release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all at http://tablesorter.com Enjoy! /christian
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Thanks Kia, saved a few more bytes! Removed and updated tablesorter.com with the latest version. /christian 2007/9/18, Kia Niskavaara [EMAIL PROTECTED]: Thanks for the update!! I've noticed that you've included two almost identical sorters: $.tablesorter.addParser({ id: integer, is: function(s) { return s.match(new RegExp(/^\d+$/)); }, format: function(s) { return $.tablesorter.formatInt(s); }, type: numeric }); $.tablesorter.addParser({ id: integer, is: function(s) { return /^\d+$/.test(s); }, format: function(s) { return $.tablesorter.formatFloat(s); }, type: numeric }); Christian Bach wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2 release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all at http://tablesorter.com Enjoy! /christian
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Great stuff Christian thanks! -- View this message in context: http://www.nabble.com/Announce%3A-jQuery-Tablesorter-2.0.1-Released-tf4468417s15494.html#a12742917 Sent from the JQuery mailing list archive at Nabble.com.
[jQuery] Re: Announce: jQuery Tablesorter 2.0.1 Released
Is there a reason jquery-1.1.3.js is included in the Zip file when 1.2.1 is required? On Sep 17, 12:37 pm, Christian Bach [EMAIL PROTECTED] wrote: Hi list! Just uploaded the new version of tablesorter that works with the 1.2 release of jQuery. Here are the main changes in version tablesorter 2.0.1 General * Removed the need for Dimensions plugin when using the pagination plugin thanks to offset being included in the jQuery 1.2 core. * Added support for jQuery 1.2 * Added new Minified version of tablesorter * Updated documenation and website with new examples Bug fixes * If row values are identical the original order is kept (Thanks to David hull) * If thead includes a table $('tbody:first', table) breaks (Thanks to David Hull) Speed improvements: * appendToTable, setting innerHTML to before appending new content to table body. * zebra widget. (Thanks to James Dempster) Get it all athttp://tablesorter.com Enjoy! /christian