[Review Queue] storage (encryption) and nfs (trusty)
I reviewed Chris's addition to the storage charm to add encrypted file-system support. He added tests per Tim's request, which were good, but I had issues running them as we as encountering a few small test breakages in the existing tests. I also reviewed Matt's test additions to get the nfs charm promoted to trusty, but I also ran into a test failure there, as well. [1]: https://launchpad.net/~chris-gondolin/charms/trusty/storage/trunk/+merge/234452 [2]: https://bugs.launchpad.net/charms/+bug/1387460 -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
[Review Queue] storage
https://code.launchpad.net/~tribaal/charms/precise/storage/refactor-mount-volume/+merge/232236 Needs Fixing: Failing some deployments scenerios, but the idea and refactor seem sound at this point. Spoke with Chris in the review and on IRC. -- David Britton david.brit...@canonical.com -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
[Review Queue] storage and zabbix-agent (personal namespace) followup
https://code.launchpad.net/~tribaal/charms/precise/storage/refactor-mount-volume/+merge/232236 I had some back-and-forth discussion with Chris and David regarding this refactor, which looks like a great change to me. I have personally reserved my +1 due to some tests that were necessarily removed from the `make test` target due to this change, but Chris makes a good point that reintegrating them will further complicate an already complex review, and it appears that he and David have discussed it at length. So my review was more of a +0 than a -1 (pending an issue with testing this with the postgres charm that David uncovered). https://bugs.launchpad.net/charms/+bug/1369892 I did a follow-up on my previous review for Samuel. I felt like there was still some lack of clarity regarding how personal namespaces work, so I tried to explain it further, with links, as well as responding to Samuel's direct points. This highlights the need to better describe in the documentation the distinction between Recommended charms and personal namespace charms, as well as precisely when a review is required vs when one can be optionally requested simply for feedback or advice. -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
Re: [Review Queue] storage and zabbix-agent (personal namespace) followup
On Fri, Sep 26, 2014 at 09:46:44PM +0300, Christopher Glass wrote: Back to the hammer and anvil for this one! Looking forward to seeing it again. Thanks Chris for your willingness to take this one on! :) -- David Britton david.brit...@canonical.com -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
