Re: charm build - transpose configs

[James Beedy]

Thanks, Seuart. Here's the bug ->
https://github.com/juju/charm-tools/issues/240

On Tue, Aug 2, 2016 at 1:11 AM, Stuart Bishop 
wrote:

>
>
> On 1 August 2016 at 01:16, James Beedy  wrote:
>
>> Team,
>>
>> I'm having a few issues I could use some insight on.
>>
>> 1. Config default values defined in my layer's config.yaml
>>  don't
>> seem to be making it into the built charm.
>> * The config values are defined to provide default values to the
>> subordinate layer-apt config params.
>> * The config definitions seem to make it into my built charm's
>> config.yaml , just not the specified
>> default values from layer-gitlab config.yaml
>> . <-
>> This is strikingly odd, because when I include another layer, say
>> juju-layer-node ,
>> following which build my top layer into a charm, I get the default configs
>> for layer-apt, defined by layer-node in my built charm. This is different
>> than what happens when I build my charm-gitlab
>> , which includes layer-gitlab
>> , which has the default
>> values specified to satisfy the params for the layer-apt.
>>
>> Where am I going wrong here?
>>
>
> You're doing it right. Looks like charm-build isn't merging config.yaml
> the way that is needed. I think an issue on
> https://github.com/juju/charm-tools is in order.
>
>
>
>> 2. How are the merging configs into a built charm handled when multiple
>> layers included by the built charm include the same layer, and define
>> default config params for that layer?
>>
>
> Should be like any other merge, with the higher layers overriding the
> lower layers in a reasonably standard multiple-inheritance style way. I'm
> not sure how it could work at all otherwise.
>
>
>
> --
> Stuart Bishop 
>
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

Re: charm build - transpose configs

[Stuart Bishop]

On 1 August 2016 at 01:16, James Beedy  wrote:

> Team,
>
> I'm having a few issues I could use some insight on.
>
> 1. Config default values defined in my layer's config.yaml
>  don't
> seem to be making it into the built charm.
> * The config values are defined to provide default values to the
> subordinate layer-apt config params.
> * The config definitions seem to make it into my built charm's
> config.yaml , just not the specified
> default values from layer-gitlab config.yaml
> . <-
> This is strikingly odd, because when I include another layer, say
> juju-layer-node ,
> following which build my top layer into a charm, I get the default configs
> for layer-apt, defined by layer-node in my built charm. This is different
> than what happens when I build my charm-gitlab
> , which includes layer-gitlab
> , which has the default
> values specified to satisfy the params for the layer-apt.
>
> Where am I going wrong here?
>

You're doing it right. Looks like charm-build isn't merging config.yaml the
way that is needed. I think an issue on https://github.com/juju/charm-tools
is in order.



> 2. How are the merging configs into a built charm handled when multiple
> layers included by the built charm include the same layer, and define
> default config params for that layer?
>

Should be like any other merge, with the higher layers overriding the lower
layers in a reasonably standard multiple-inheritance style way. I'm not
sure how it could work at all otherwise.



-- 
Stuart Bishop 
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

charm build - transpose configs

[James Beedy]

Team,

I'm having a few issues I could use some insight on.

1. Config default values defined in my layer's config.yaml
 don't
seem to be making it into the built charm.
* The config values are defined to provide default values to the
subordinate layer-apt config params.
* The config definitions seem to make it into my built charm's
config.yaml , just not the specified
default values from layer-gitlab config.yaml
. <-
This is strikingly odd, because when I include another layer, say
juju-layer-node ,
following which build my top layer into a charm, I get the default configs
for layer-apt, defined by layer-node in my built charm. This is different
than what happens when I build my charm-gitlab
, which includes layer-gitlab
, which has the default values
specified to satisfy the params for the layer-apt.

Where am I going wrong here?


2. How are the merging configs into a built charm handled when multiple
layers included by the built charm include the same layer, and define
default config params for that layer?


Thanks in advance for your feedback,


~James
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju