Re: Preparations for juju-core 1.17.0
On Wed, Nov 13, 2013 at 2:46 AM, Andrew Wilkins < andrew.wilk...@canonical.com> wrote: > I'd really like to get this one in, which I *hope* to have done by end of > next week at the latest (preferably sooner): > #1238948 manual provider client cache prevents reuse of env by name > That one is "make destroy manual env work", right? Good feature, I'd like that too, and am provisionally happy to gate 1.17 on it. > And I have a MP waiting review for this, which I'd like to get in, but > depends on people reviewing it (hint hint) ;) > #1236691 null provider bootstrap fails if default-series does not match > target > > This one probably should be deferred, as it requires some more thought: > #1239550 juju should warn if .jenv doesn't match environments.yaml > I'm less keen on gating it on these. > > > Cheers, > Andrew > > > On Wed, Nov 13, 2013 at 4:23 AM, Curtis Hovey-Canonical < > cur...@canonical.com> wrote: > >> Gentleman, engineers, et al. >> >> When do you want release juju-core 1.17.0? There is still a >> significant amount of work in progress that we want to complete. >> https://launchpad.net/juju-core/+milestone/1.17.0 >> >> I am happy to defer the unstarted issues to another milestone. >> >> juju-core 1.17.0 will require streams.canonical.com to be fully >> operational. Juju-QA will be adding support for signed json and >> mirrors this week. We believe streams.canonical.com will be tested >> and ready next week. >> >> -- >> Curtis Hovey >> Canonical Cloud Development and Operations >> http://launchpad.net/~sinzui >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> > > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Preparations for juju-core 1.17.0
On Thu, Nov 14, 2013 at 5:35 PM, William Reade wrote: > On Wed, Nov 13, 2013 at 2:46 AM, Andrew Wilkins < > andrew.wilk...@canonical.com> wrote: > >> I'd really like to get this one in, which I *hope* to have done by end of >> next week at the latest (preferably sooner): >> #1238948 manual provider client cache prevents reuse of env by name >> > > That one is "make destroy manual env work", right? Good feature, I'd like > that too, and am provisionally happy to gate 1.17 on it. > Correct. > And I have a MP waiting review for this, which I'd like to get in, but >> depends on people reviewing it (hint hint) ;) >> #1236691 null provider bootstrap fails if default-series does not >> match target >> >> This one probably should be deferred, as it requires some more thought: >> #1239550 juju should warn if .jenv doesn't match environments.yaml >> > > I'm less keen on gating it on these. > No worries, 1236691 is more easily worked around. >> >> Cheers, >> Andrew >> >> >> On Wed, Nov 13, 2013 at 4:23 AM, Curtis Hovey-Canonical < >> cur...@canonical.com> wrote: >> >>> Gentleman, engineers, et al. >>> >>> When do you want release juju-core 1.17.0? There is still a >>> significant amount of work in progress that we want to complete. >>> https://launchpad.net/juju-core/+milestone/1.17.0 >>> >>> I am happy to defer the unstarted issues to another milestone. >>> >>> juju-core 1.17.0 will require streams.canonical.com to be fully >>> operational. Juju-QA will be adding support for signed json and >>> mirrors this week. We believe streams.canonical.com will be tested >>> and ready next week. >>> >>> -- >>> Curtis Hovey >>> Canonical Cloud Development and Operations >>> http://launchpad.net/~sinzui >>> >>> -- >>> Juju-dev mailing list >>> Juju-dev@lists.ubuntu.com >>> Modify settings or unsubscribe at: >>> https://lists.ubuntu.com/mailman/listinfo/juju-dev >>> >> >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> >> > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Preparations for juju-core 1.17.0
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2013-11-13 0:23, Curtis Hovey-Canonical wrote: > Gentleman, engineers, et al. > > When do you want release juju-core 1.17.0? There is still a > significant amount of work in progress that we want to complete. > https://launchpad.net/juju-core/+milestone/1.17.0 > > I am happy to defer the unstarted issues to another milestone. > > juju-core 1.17.0 will require streams.canonical.com to be fully > operational. Juju-QA will be adding support for signed json and > mirrors this week. We believe streams.canonical.com will be > tested and ready next week. > So we do have 1 Critical-to-1.17 bug now (we broke tools-url and upgrade). Otherwise, I'd rather us get into more of a rhythm for Dev releases (1.ODD series). I think we need to be more careful about what we call the next stable, but I don't think releasing 1.17 means it is immediately a 1.18 release candidate. If we *did* want to treat it as a 1.18 candidate, then there is a bunch of stuff like getting the rest of the CLI into the API that we are waiting for. John =:-> -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.13 (Cygwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlKEq6AACgkQJdeBCYSNAAP+MgCaAg/x/d+VhwRUeM//z46U51fR c+gAniqFANZnVH1rfhweq8SFg3UN/uHr =9ruh -END PGP SIGNATURE- -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Deleting code from goyaml
wallyworld_: i fixed the bug, tests all pass by deleting code i'm not sure how gustavo will like that :) davecheney: ah, ok. good luck :-) For the record, please don't delete apparently unused logic from the *c.go files in goyaml, unless you went deep into the subject and justified accordingly in the proposal. There is certainly a non-trivial number of uncovered paths, because these files were ported from the C libyaml. For that reason, goyaml will definitely have uncovered paths, not only because we may be lacking paths, but also because we may be lacking the feature itself at the moment (for example, multi-document parsing). We should evolve towards having more tests and more of these features covered, instead of nuking the logic without proper analysis that it was unnecessary in C also. gustavo @ http://niemeyer.net -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Deleting code from goyaml
There was no deleted code the the mp that I saw: https://code.launchpad.net/~dave-cheney/goyaml/goyaml/+merge/195162 Dave may have been referring on irc to an earlier iteration of his work. His approach was also discussed at the Juju team meeting, and unless I mis-remember, there was broad approval of the approach taken. On 14/11/13 21:33, Gustavo Niemeyer wrote: > wallyworld_: i fixed the bug, tests all pass > by deleting code > i'm not sure how gustavo will like that :) > davecheney: ah, ok. good luck :-) > > For the record, please don't delete apparently unused logic from the > *c.go files in goyaml, unless you went deep into the subject and > justified accordingly in the proposal. > > There is certainly a non-trivial number of uncovered paths, because > these files were ported from the C libyaml. For that reason, goyaml > will definitely have uncovered paths, not only because we may be > lacking paths, but also because we may be lacking the feature itself > at the moment (for example, multi-document parsing). We should evolve > towards having more tests and more of these features covered, instead > of nuking the logic without proper analysis that it was unnecessary in > C also. > > > gustavo @ http://niemeyer.net > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Deleting code from goyaml
I don't think the facts I brought up were clear, independently from
what the MP does ("For the record ...").
On Thu, Nov 14, 2013 at 9:48 AM, Ian Booth wrote:
> There was no deleted code the the mp that I saw:
>
> https://code.launchpad.net/~dave-cheney/goyaml/goyaml/+merge/195162
>
> Dave may have been referring on irc to an earlier iteration of his work.
> His approach was also discussed at the Juju team meeting, and unless I
> mis-remember, there was broad approval of the approach taken.
>
> On 14/11/13 21:33, Gustavo Niemeyer wrote:
>> wallyworld_: i fixed the bug, tests all pass
>> by deleting code
>> i'm not sure how gustavo will like that :)
>> davecheney: ah, ok. good luck :-)
>>
>> For the record, please don't delete apparently unused logic from the
>> *c.go files in goyaml, unless you went deep into the subject and
>> justified accordingly in the proposal.
>>
>> There is certainly a non-trivial number of uncovered paths, because
>> these files were ported from the C libyaml. For that reason, goyaml
>> will definitely have uncovered paths, not only because we may be
>> lacking paths, but also because we may be lacking the feature itself
>> at the moment (for example, multi-document parsing). We should evolve
>> towards having more tests and more of these features covered, instead
>> of nuking the logic without proper analysis that it was unnecessary in
>> C also.
>>
>>
>> gustavo @ http://niemeyer.net
>>
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
--
gustavo @ http://niemeyer.net
--
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Deleting code from goyaml
Never believe what you read on IRC :-D
On 14/11/13 21:53, Gustavo Niemeyer wrote:
> I don't think the facts I brought up were clear, independently from
> what the MP does ("For the record ...").
>
> On Thu, Nov 14, 2013 at 9:48 AM, Ian Booth wrote:
>> There was no deleted code the the mp that I saw:
>>
>> https://code.launchpad.net/~dave-cheney/goyaml/goyaml/+merge/195162
>>
>> Dave may have been referring on irc to an earlier iteration of his work.
>> His approach was also discussed at the Juju team meeting, and unless I
>> mis-remember, there was broad approval of the approach taken.
>>
>> On 14/11/13 21:33, Gustavo Niemeyer wrote:
>>> wallyworld_: i fixed the bug, tests all pass
>>> by deleting code
>>> i'm not sure how gustavo will like that :)
>>> davecheney: ah, ok. good luck :-)
>>>
>>> For the record, please don't delete apparently unused logic from the
>>> *c.go files in goyaml, unless you went deep into the subject and
>>> justified accordingly in the proposal.
>>>
>>> There is certainly a non-trivial number of uncovered paths, because
>>> these files were ported from the C libyaml. For that reason, goyaml
>>> will definitely have uncovered paths, not only because we may be
>>> lacking paths, but also because we may be lacking the feature itself
>>> at the moment (for example, multi-document parsing). We should evolve
>>> towards having more tests and more of these features covered, instead
>>> of nuking the logic without proper analysis that it was unnecessary in
>>> C also.
>>>
>>>
>>> gustavo @ http://niemeyer.net
>>>
>>
>> --
>> Juju-dev mailing list
>> Juju-dev@lists.ubuntu.com
>> Modify settings or unsubscribe at:
>> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
>
>
--
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju-dev
