Re: Consistent test failures with saucy

2013-09-29 Thread David Cheney
Have a hunt in the code, i bet there is something that lists all the
series from P through to R, but doesn't include saucy, possibly in
fixtures or the dummy provider

On Mon, Sep 30, 2013 at 9:31 AM, Tim Penhey  wrote:
> Hi folks,
>
> Most of the upgrade worked fine.
>
> I am however finding some problems with the test suite.  I have one test
> that consistently fails:
>
> bootstrap_test.go:78:
> s.runAllowRetriesTest(c, test)
> bootstrap_test.go:99:
> c.Check(findToolsRetryValues, gc.DeepEquals, test.expectedAllowRetry)
> ... obtained []bool = []bool{true, true}
> ... expected []bool = []bool{true}
>
> bootstrap_test.go:78:
> s.runAllowRetriesTest(c, test)
> bootstrap_test.go:100:
> c.Assert(err, gc.ErrorMatches, test.err)
> ... error string = "tools not found"
> ... regex string = "no matching tools available"
>
> OOPS: 164 passed, 1 FAILED
>
>
> Anyone else getting this?
>
> Tim
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at: 
> https://lists.ubuntu.com/mailman/listinfo/juju-dev

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Re: Consistent test failures with saucy

2013-09-29 Thread John Arbash Meinel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 2013-09-30 5:11, David Cheney wrote:
> Have a hunt in the code, i bet there is something that lists all
> the series from P through to R, but doesn't include saucy, possibly
> in fixtures or the dummy provider
> 
It isn't just Saucy. The bot is now broken as well.

What happened is that the test actually contacts
juju-dist.s3.amazonaws.com. Prior to releasing 1.15.0 and uploading
the tools, it was searching for the 1.15 tools and not finding any,
which made the test happy.

After Curtis uploaded the tools, the *test suite* now saw them, which
meant it was doing something different. (And triggering the function
twice, which caused it to fail).

Tim and I worked out the isolation issue, though I think we need a
deeper audit that none of our tests are going to non-local IP addresses.

John
=:->

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlJJDfcACgkQJdeBCYSNAANdkgCgtJ8ZJ8qzNr0ROhHbycwDHUHi
OnYAnjqqpY+FUvFb6wQjs6hLIh2dU+bT
=QoR/
-END PGP SIGNATURE-

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev