Re: Unit test failure in juju/errors

2015-02-09 Thread Tim Penhey
Actually it is testing the DeferredAnnotatef method, so yes it does need
to use the defer.

Strange that the line number is changing though.

Tim

On 07/02/15 07:58, roger peppe wrote:
 Interesting. It seems that the line reported for a defer has changed in 1.4.
 
 That said, I'm not really sure why that test needs to use defer. The
 functionality
 being tested doesn't rely on defer at all.
 
 On 6 February 2015 at 09:14, Matthew Williams
 matthew.willi...@canonical.com wrote:
 Hi Folks,

 It appears that juju/errors has a failing unit test:
 http://paste.ubuntu.com/10085832/

 It also appears that it only fails in go1.4

 Matty

 --
 Juju-dev mailing list
 Juju-dev@lists.ubuntu.com
 Modify settings or unsubscribe at:
 https://lists.ubuntu.com/mailman/listinfo/juju-dev

 


-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Re: Unit test failure in juju/errors

2015-02-06 Thread roger peppe
On 6 February 2015 at 09:14, Matthew Williams
matthew.willi...@canonical.com wrote:
 Hi Folks,

 It appears that juju/errors has a failing unit test:
 http://paste.ubuntu.com/10085832/

 It also appears that it only fails in go1.4

Interesting. It seems that the line reported for a defer has changed in 1.4.

That said, I'm not really sure why that test needs to use defer. The
functionality being tested doesn't rely on defer at all.

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Re: Unit test failure in juju/errors

2015-02-06 Thread roger peppe
Interesting. It seems that the line reported for a defer has changed in 1.4.

That said, I'm not really sure why that test needs to use defer. The
functionality
being tested doesn't rely on defer at all.

On 6 February 2015 at 09:14, Matthew Williams
matthew.willi...@canonical.com wrote:
 Hi Folks,

 It appears that juju/errors has a failing unit test:
 http://paste.ubuntu.com/10085832/

 It also appears that it only fails in go1.4

 Matty

 --
 Juju-dev mailing list
 Juju-dev@lists.ubuntu.com
 Modify settings or unsubscribe at:
 https://lists.ubuntu.com/mailman/listinfo/juju-dev


-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Unit test failure in juju/errors

2015-02-06 Thread Matthew Williams
Hi Folks,

It appears that juju/errors has a failing unit test:
http://paste.ubuntu.com/10085832/

It also appears that it only fails in go1.4

Matty
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev