Re: Versioning juju run (juju-run)?

2014-09-16 Thread William Reade
I think this comes down to checking whether the target unit's
agent-version is one that supports invoking relation contexts, and
failing nicely if it isn't -- ie I don't *think* it's to do with the
version of cmd/juju, but the version of cmd/juju*d* in play. Helpful?

On Fri, Sep 12, 2014 at 3:20 PM, Wayne Witzel
 wrote:
> Hi all,
>
> During the review of my PR https://github.com/juju/juju/pull/705 to add
> --relation to juju run, it was suggested that the cmd/juju be versioned.
>
> I spoke to a couple folks and was directed to
> https://github.com/juju/juju/pull/746 as an example of versioning an API.
> This makes sense, but I don't see how it applies to the cmd/juju parts of
> the code?
>
> I'm just failing to understand how to version the command-line options. Also
> the juju run client doesn't seem to have gone through the Facade refactoring
> that the other APIs have gone through.
>
> I'd appreciate some hand holding here as I'm failing to grok what needs to
> be done.
>
> Thanks,
>
> --
> Wayne Witzel III
> wayne.wit...@canonical.com
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev


Versioning juju run (juju-run)?

2014-09-12 Thread Wayne Witzel
Hi all,

During the review of my PR https://github.com/juju/juju/pull/705 to add
--relation to juju run, it was suggested that the cmd/juju be versioned.

I spoke to a couple folks and was directed to
https://github.com/juju/juju/pull/746 as an example of versioning an API.
This makes sense, but I don't see how it applies to the cmd/juju parts of
the code?

I'm just failing to understand how to version the command-line options.
Also the juju run client doesn't seem to have gone through the Facade
refactoring that the other APIs have gone through.

I'd appreciate some hand holding here as I'm failing to grok what needs to
be done.

Thanks,

-- 
Wayne Witzel III
wayne.wit...@canonical.com
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev