Re: [JPP-Devel] 'import' statements in OJ
I would suggest to remove the duplicates and the needless ones. The unfolding of the star imports can be done later. I'm willing to do this. If you do the next JUMP/OJ merge rerun the script to find out which new defects are introduced. - Sascha Stefan Steiniger schrieb: > i have no concern. > > But I have to add, that I left the imports as they have been in the Jump > cvs, to avoid to much confusion when i do updates/sync with the original > Jump by Vividsolutions (using the eclipse diff tool). But as they don't > develop further since 5 months.. > > stefan > > Sascha L. Teichmann schrieb: >> Hi together, >> >> I run a little script [1] against the source of OpenJUMP >> to find out the improper use of 'import' statements. >> >> Here's the result: >> >> '*' import(s): 507 >> Star imports are name space polluters and should be better >> written as a list of explicit imports. Star imports are >> often used for convenience only. >> >> needless import(s): 286 >> Importing things that are not really needed introduce >> extra source level dependencies. >> If you import e.g. >> 'com.vividsolutions.jump.workbench.plugin.ThreadedBasePlugIn' >> and don't use it in the rest of the source file it can be >> avoided. >> >> duplicated import(s): 4 >> simply redundant imports. e.g. importing >> 'com.vividsolutions.jump.feature.Feature' twice is not necessary. >> >> For details see the attached file 'import-flaws.txt' >> >> You may call this only a 'cosmetical' weakness but I see >> it a context of cleaner source code. >> >> Nevertheless I would like to correct it. Anyone against it? >> >> There are other weaknesses as well: >> - Wrong JavaDoc syntax. contently wrong JavaDoc, missing JavaDoc. >> - source code encoding flaws. Some of the french and german sources >> are not stored in UTF-8 e.g. >> >> These issues need a more detailed analysis. >> >> Kind regards, Sascha >> >> [1] intevation.de/~teichmann/stuff/check-imports.py >> >> >> >> >> src/com/vividsolutions/jump/algorithm/EuclideanDistanceToPoint.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> src/com/vividsolutions/jump/algorithm/LengthSubstring.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> src/com/vividsolutions/jump/algorithm/LengthToPoint.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> src/com/vividsolutions/jump/algorithm/LocatePoint.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> src/com/vividsolutions/jump/algorithm/PointPairDistance.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> src/com/vividsolutions/jump/algorithm/VertexHausdorffDistance.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> # needless import(s): >> com.vividsolutions.jump.geom.LineSegmentUtil >> src/com/vividsolutions/jump/coordsys/Reprojector.java >> # needless import(s): >> com.vividsolutions.jump.feature.Feature >> src/com/vividsolutions/jump/coordsys/impl/Albers.java >> # '*' imports(s) >> com.vividsolutions.jump.coordsys.* >> src/com/vividsolutions/jump/coordsys/impl/Mercator.java >> # '*' imports(s) >> com.vividsolutions.jump.coordsys.* >> src/com/vividsolutions/jump/coordsys/impl/MeridianArcLength.java >> # '*' imports(s) >> com.vividsolutions.jump.coordsys.* >> src/com/vividsolutions/jump/coordsys/impl/Polyconic.java >> # '*' imports(s) >> com.vividsolutions.jump.coordsys.* >> src/com/vividsolutions/jump/coordsys/impl/TransverseMercator.java >> # '*' imports(s) >> com.vividsolutions.jump.coordsys.* >> src/com/vividsolutions/jump/coordsys/impl/UniversalTransverseMercator.java >> # '*' imports(s) >> com.vividsolutions.jump.coordsys.* >> src/com/vividsolutions/jump/datastore/DataStoreDriver.java >> # needless import(s): >> com.vividsolutions.jump.workbench.datastore.ConnectionManager >> src/com/vividsolutions/jump/datastore/FilterQuery.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> src/com/vividsolutions/jump/datastore/jdbc/JDBCUtil.java >> # '*' imports(s) >> com.vividsolutions.jump.datastore.* >> java.sql.* >> src/com/vividsolutions/jump/datastore/jdbc/ResultSetBlock.java >> # '*' imports(s) >> java.sql.* >> src/com/vividsolutions/jump/datastore/jdbc/ValueConverter.java >> # '*' imports(s) >> com.vividsolutions.jump.feature.* >> java.sql.* >> src/com/vividsolutions/jump/datastore/jdbc/ValueConverterFactory.java >> # '*' imports(s) >> com.vividsolutions.jts.geom.* >> com.vividsolutions.jts.io.* >> com.vividsolutions.jump.datastore.* >> com.vividsolutions.jump.feature.* >> java.io.* >> java.sql.* >> src/com/vividsolutions/jump/datastore/postgis/PostgisDSConnection.java >> # '*' imports(s) >> java.sql.* >> # needless import(s): >> org.postgresql.
Re: [JPP-Devel] 'import' statements in OJ
i have no concern. But I have to add, that I left the imports as they have been in the Jump cvs, to avoid to much confusion when i do updates/sync with the original Jump by Vividsolutions (using the eclipse diff tool). But as they don't develop further since 5 months.. stefan Sascha L. Teichmann schrieb: > Hi together, > > I run a little script [1] against the source of OpenJUMP > to find out the improper use of 'import' statements. > > Here's the result: > > '*' import(s): 507 > Star imports are name space polluters and should be better > written as a list of explicit imports. Star imports are > often used for convenience only. > > needless import(s): 286 > Importing things that are not really needed introduce > extra source level dependencies. > If you import e.g. > 'com.vividsolutions.jump.workbench.plugin.ThreadedBasePlugIn' > and don't use it in the rest of the source file it can be > avoided. > > duplicated import(s): 4 > simply redundant imports. e.g. importing > 'com.vividsolutions.jump.feature.Feature' twice is not necessary. > > For details see the attached file 'import-flaws.txt' > > You may call this only a 'cosmetical' weakness but I see > it a context of cleaner source code. > > Nevertheless I would like to correct it. Anyone against it? > > There are other weaknesses as well: > - Wrong JavaDoc syntax. contently wrong JavaDoc, missing JavaDoc. > - source code encoding flaws. Some of the french and german sources > are not stored in UTF-8 e.g. > > These issues need a more detailed analysis. > > Kind regards, Sascha > > [1] intevation.de/~teichmann/stuff/check-imports.py > > > > > src/com/vividsolutions/jump/algorithm/EuclideanDistanceToPoint.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > src/com/vividsolutions/jump/algorithm/LengthSubstring.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > src/com/vividsolutions/jump/algorithm/LengthToPoint.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > src/com/vividsolutions/jump/algorithm/LocatePoint.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > src/com/vividsolutions/jump/algorithm/PointPairDistance.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > src/com/vividsolutions/jump/algorithm/VertexHausdorffDistance.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > # needless import(s): > com.vividsolutions.jump.geom.LineSegmentUtil > src/com/vividsolutions/jump/coordsys/Reprojector.java > # needless import(s): > com.vividsolutions.jump.feature.Feature > src/com/vividsolutions/jump/coordsys/impl/Albers.java > # '*' imports(s) > com.vividsolutions.jump.coordsys.* > src/com/vividsolutions/jump/coordsys/impl/Mercator.java > # '*' imports(s) > com.vividsolutions.jump.coordsys.* > src/com/vividsolutions/jump/coordsys/impl/MeridianArcLength.java > # '*' imports(s) > com.vividsolutions.jump.coordsys.* > src/com/vividsolutions/jump/coordsys/impl/Polyconic.java > # '*' imports(s) > com.vividsolutions.jump.coordsys.* > src/com/vividsolutions/jump/coordsys/impl/TransverseMercator.java > # '*' imports(s) > com.vividsolutions.jump.coordsys.* > src/com/vividsolutions/jump/coordsys/impl/UniversalTransverseMercator.java > # '*' imports(s) > com.vividsolutions.jump.coordsys.* > src/com/vividsolutions/jump/datastore/DataStoreDriver.java > # needless import(s): > com.vividsolutions.jump.workbench.datastore.ConnectionManager > src/com/vividsolutions/jump/datastore/FilterQuery.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > src/com/vividsolutions/jump/datastore/jdbc/JDBCUtil.java > # '*' imports(s) > com.vividsolutions.jump.datastore.* > java.sql.* > src/com/vividsolutions/jump/datastore/jdbc/ResultSetBlock.java > # '*' imports(s) > java.sql.* > src/com/vividsolutions/jump/datastore/jdbc/ValueConverter.java > # '*' imports(s) > com.vividsolutions.jump.feature.* > java.sql.* > src/com/vividsolutions/jump/datastore/jdbc/ValueConverterFactory.java > # '*' imports(s) > com.vividsolutions.jts.geom.* > com.vividsolutions.jts.io.* > com.vividsolutions.jump.datastore.* > com.vividsolutions.jump.feature.* > java.io.* > java.sql.* > src/com/vividsolutions/jump/datastore/postgis/PostgisDSConnection.java > # '*' imports(s) > java.sql.* > # needless import(s): > org.postgresql.PGConnection > src/com/vividsolutions/jump/datastore/postgis/PostgisDataStoreDriver.java > # '*' imports(s) > com.vividsolutions.jump.datastore.* > java.sql.* > # needless import(s): > org.postgresql.PGConnection > src/com/vividsolutions/jump/datastore/postgis/PostgisFeatureInputStream.java > # '*' imports(
[JPP-Devel] 'import' statements in OJ
Hi together, I run a little script [1] against the source of OpenJUMP to find out the improper use of 'import' statements. Here's the result: '*' import(s): 507 Star imports are name space polluters and should be better written as a list of explicit imports. Star imports are often used for convenience only. needless import(s): 286 Importing things that are not really needed introduce extra source level dependencies. If you import e.g. 'com.vividsolutions.jump.workbench.plugin.ThreadedBasePlugIn' and don't use it in the rest of the source file it can be avoided. duplicated import(s): 4 simply redundant imports. e.g. importing 'com.vividsolutions.jump.feature.Feature' twice is not necessary. For details see the attached file 'import-flaws.txt' You may call this only a 'cosmetical' weakness but I see it a context of cleaner source code. Nevertheless I would like to correct it. Anyone against it? There are other weaknesses as well: - Wrong JavaDoc syntax. contently wrong JavaDoc, missing JavaDoc. - source code encoding flaws. Some of the french and german sources are not stored in UTF-8 e.g. These issues need a more detailed analysis. Kind regards, Sascha [1] intevation.de/~teichmann/stuff/check-imports.py src/com/vividsolutions/jump/algorithm/EuclideanDistanceToPoint.java # '*' imports(s) com.vividsolutions.jts.geom.* src/com/vividsolutions/jump/algorithm/LengthSubstring.java # '*' imports(s) com.vividsolutions.jts.geom.* src/com/vividsolutions/jump/algorithm/LengthToPoint.java # '*' imports(s) com.vividsolutions.jts.geom.* src/com/vividsolutions/jump/algorithm/LocatePoint.java # '*' imports(s) com.vividsolutions.jts.geom.* src/com/vividsolutions/jump/algorithm/PointPairDistance.java # '*' imports(s) com.vividsolutions.jts.geom.* src/com/vividsolutions/jump/algorithm/VertexHausdorffDistance.java # '*' imports(s) com.vividsolutions.jts.geom.* # needless import(s): com.vividsolutions.jump.geom.LineSegmentUtil src/com/vividsolutions/jump/coordsys/Reprojector.java # needless import(s): com.vividsolutions.jump.feature.Feature src/com/vividsolutions/jump/coordsys/impl/Albers.java # '*' imports(s) com.vividsolutions.jump.coordsys.* src/com/vividsolutions/jump/coordsys/impl/Mercator.java # '*' imports(s) com.vividsolutions.jump.coordsys.* src/com/vividsolutions/jump/coordsys/impl/MeridianArcLength.java # '*' imports(s) com.vividsolutions.jump.coordsys.* src/com/vividsolutions/jump/coordsys/impl/Polyconic.java # '*' imports(s) com.vividsolutions.jump.coordsys.* src/com/vividsolutions/jump/coordsys/impl/TransverseMercator.java # '*' imports(s) com.vividsolutions.jump.coordsys.* src/com/vividsolutions/jump/coordsys/impl/UniversalTransverseMercator.java # '*' imports(s) com.vividsolutions.jump.coordsys.* src/com/vividsolutions/jump/datastore/DataStoreDriver.java # needless import(s): com.vividsolutions.jump.workbench.datastore.ConnectionManager src/com/vividsolutions/jump/datastore/FilterQuery.java # '*' imports(s) com.vividsolutions.jts.geom.* src/com/vividsolutions/jump/datastore/jdbc/JDBCUtil.java # '*' imports(s) com.vividsolutions.jump.datastore.* java.sql.* src/com/vividsolutions/jump/datastore/jdbc/ResultSetBlock.java # '*' imports(s) java.sql.* src/com/vividsolutions/jump/datastore/jdbc/ValueConverter.java # '*' imports(s) com.vividsolutions.jump.feature.* java.sql.* src/com/vividsolutions/jump/datastore/jdbc/ValueConverterFactory.java # '*' imports(s) com.vividsolutions.jts.geom.* com.vividsolutions.jts.io.* com.vividsolutions.jump.datastore.* com.vividsolutions.jump.feature.* java.io.* java.sql.* src/com/vividsolutions/jump/datastore/postgis/PostgisDSConnection.java # '*' imports(s) java.sql.* # needless import(s): org.postgresql.PGConnection src/com/vividsolutions/jump/datastore/postgis/PostgisDataStoreDriver.java # '*' imports(s) com.vividsolutions.jump.datastore.* java.sql.* # needless import(s): org.postgresql.PGConnection src/com/vividsolutions/jump/datastore/postgis/PostgisFeatureInputStream.java # '*' imports(s) java.sql.* org.postgresql.* src/com/vividsolutions/jump/datastore/postgis/PostgisResultSetConverter.java # '*' imports(s) com.vividsolutions.jump.datastore.* com.vividsolutions.jump.datastore.jdbc.* com.vividsolutions.jump.feature.* java.sql.* org.postgresql.* src/com/vividsolutions/jump/datastore/postgis/PostgisSQLBuilder.java # needless import(s): com.vividsolutions.jts.geom.Coordinate src/com/vividsolutions/jump/datastore/postgis/Po
