Re: [JPP-Devel] OpenJUMP extensions migration - Measure and color chooser plugins code

[Giuseppe Aruta]

Hi Michael,
in t6his folder:
https://sourceforge.net/projects/opensit/files/Openjump/CadTools/
I uploaded codes for the following plugins:

- Color Chooser
- Measure Plugin
 and, Cad Plugin

all ported to JTS 1.8 and (partially) tested

Peppe

Il giorno dom 18 apr 2021 alle ore 22:44 Michaud Michael <
m.michael.mich...@orange.fr> ha scritto:

> Hi Jumpers,
>
> Some news about the migration :
>
> I have refactored most extensions included in OpenJUMP PLUS and included
> them in the distribution (r4834). The work is still on-going but I wanted
> to let you know so that you can begin to test and report any problem (using
> the list or the github issue tracker) :
>
> https://sourceforge.net/projects/jump-pilot/files/OpenJUMP2_snapshots/
>
> Extensions which are supposed to be included are listed in the readme on
>
> https://github.com/openjump-gis/openjump
>
> All of them have been uploaded to openjump-gis group and mavenized.
>
> I want to include some more extensions like color-chooser or concave-hull,
> but for extensions which were not included in OJ-1.16-PLUS, maybe I'll wait
> for someone to ask.
>
> For database, I'd like to avoid maintaining dbquery if the same work can
> be achieved with openjump datastore framework. Maybe jukka or someone else
> know better than me what dbquery can actually achieve which cannot be done
> with the main framework.
>
>
> Michaël
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] OpenJUMP extensions migration - Measure and color chooser plugins code

[Michaud Michael]

Thank for the work Peppe,I'll upload CadTool and Measure tools this week-end.Color chooser is already uploaded (and checked in the list of the readme page). Did you do significative modification on it ? Do you use a recent working release of OJ2 ?Michaëlenvoyé : 30 avril 2021 à 08:45de : Giuseppe Aruta à : Michaud Michael , OpenJump develop and use objet : Re: [JPP-Devel] OpenJUMP extensions migration - Measure and color chooser plugins codeHi Michael,in t6his folder:https://sourceforge.net/projects/opensit/files/Openjump/CadTools/I uploaded codes for the following plugins:- Color Chooser- Measure Plugin and, Cad Pluginall ported to JTS 1.8 and (partially) testedPeppeIl giorno dom 18 apr 2021 alle ore 22:44 Michaud Michael  ha scritto:Hi Jumpers,Some news about the migration :I have refactored most extensions included in OpenJUMP PLUS and included them in the distribution (r4834). The work is still on-going but I wanted to let you know so that you can begin to test and report any problem (using the list or the github issue tracker) :https://sourceforge.net/projects/jump-pilot/files/OpenJUMP2_snapshots/Extensions which are supposed to be included are listed in the readme on https://github.com/openjump-gis/openjumpAll of them have been uploaded to openjump-gis group and mavenized.I want to include some more extensions like color-chooser or concave-hull, but for extensions which were not included in OJ-1.16-PLUS, maybe I'll wait for someone to ask.For database, I'd like to avoid maintaining dbquery if the same work can be achieved with openjump datastore framework. Maybe jukka or someone else know better than me what dbquery can actually achieve which cannot be done with the main framework. Michaël ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] OpenJUMP extensions migration - Measure and color chooser plugins code

[Michaud Michael]

Hi Peppe,Measure toolbox is now commited and should appear in next snapshot,I had a quick review of the code as I did for all extensions and I have a few recommandations for next contributions :- Comments for javadoc should be placed before the documented class/method, not inside as in pythonhttps://www.oracle.com/fr/technical-resources/articles/java/javadoc-tool.html- Convention for method names is camelCase (avoid uppercase on first letter and _ separator to keep code homogeneous)- I simplified a number of :new Double(new Long(Math.round(value * 1)).doubleValue() / 1.0)toMath.round(value * 1)/1.0Hope it is correct.- I found also several lenght variables (should be length)- I moved static I18N sArea, sLength... from the tools to the parent class Measure_MultiClickTool as they were the same for all the tools Please, let me know if you observe any regressionMichaël  envoyé : 30 avril 2021 à 08:45de : Giuseppe Aruta à : Michaud Michael , OpenJump develop and use objet : Re: [JPP-Devel] OpenJUMP extensions migration - Measure and color chooser plugins codeHi Michael,in t6his folder:https://sourceforge.net/projects/opensit/files/Openjump/CadTools/I uploaded codes for the following plugins:- Color Chooser- Measure Plugin and, Cad Pluginall ported to JTS 1.8 and (partially) testedPeppeIl giorno dom 18 apr 2021 alle ore 22:44 Michaud Michael  ha scritto:Hi Jumpers,Some news about the migration :I have refactored most extensions included in OpenJUMP PLUS and included them in the distribution (r4834). The work is still on-going but I wanted to let you know so that you can begin to test and report any problem (using the list or the github issue tracker) :https://sourceforge.net/projects/jump-pilot/files/OpenJUMP2_snapshots/Extensions which are supposed to be included are listed in the readme on https://github.com/openjump-gis/openjumpAll of them have been uploaded to openjump-gis group and mavenized.I want to include some more extensions like color-chooser or concave-hull, but for extensions which were not included in OJ-1.16-PLUS, maybe I'll wait for someone to ask.For database, I'd like to avoid maintaining dbquery if the same work can be achieved with openjump datastore framework. Maybe jukka or someone else know better than me what dbquery can actually achieve which cannot be done with the main framework. Michaël ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel