Issue #149: Showing pullrequest failed : revision None does not exists (conservancy/kallithea)

2015-07-28 Thread Mathieu Clabaut
New issue 149: Showing pullrequest failed : revision None does not exists
https://bitbucket.org/conservancy/kallithea/issues/149/showing-pullrequest-failed-revision-none

Mathieu Clabaut:

Showing a pull request between tip and branch 1.0 leads to the following stack 
trace
```
2015-07-28 12:13:52.448 INFO  [kallithea.lib.auth] user 
AuthUser('id:2[clabaut] auth:True') authenticated with regular auth @ 
PullrequestsController:show
Error - class 'kallithea.lib.vcs.exceptions.ChangesetDoesNotExistError': 
Revision None does not exist for MercurialRepository at /tmp_dsk/attic2
URL: http://127.0.0.1:5000/attic2/pull-request/3/_/1.0
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/WebError-0.10.3-py2.7.egg/weberror/errormiddleware.py',
 line 162 in __call__
  app_iter = self.application(environ, sr_checker)
File 
'/home/clabaut/contrib/kallithea/kallithea/lib/middleware/sessionmiddleware.py',
 line 62 in __call__
  return self.wrap_app(environ, session_start_response)
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/Routes-1.13-py2.7.egg/routes/middleware.py',
 line 131 in __call__
  response = self.app(environ, start_response)
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/pylons/wsgiapp.py',
 line 107 in __call__
  response = self.dispatch(controller, environ, start_response)
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/pylons/wsgiapp.py',
 line 312 in dispatch
  return controller(environ, start_response)
File '/home/clabaut/contrib/kallithea/kallithea/lib/base.py', line 397 in 
__call__
  return WSGIController.__call__(self, environ, start_response)
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/pylons/controllers/core.py',
 line 211 in __call__
  response = self._dispatch_call()
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/pylons/controllers/core.py',
 line 162 in _dispatch_call
  response = self._inspect_call(func)
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/pylons/controllers/core.py',
 line 105 in _inspect_call
  result = self._perform_call(func, args)
File 
'/home/clabaut/.virtualenvs/kallithea/lib/python2.7/site-packages/pylons/controllers/core.py',
 line 57 in _perform_call
  return func(**args)
File 'string', line 2 in show
File '/home/clabaut/contrib/kallithea/kallithea/lib/auth.py', line 763 in 
__wrapper
  return func(*fargs, **fkwargs)
File 'string', line 2 in show
File '/home/clabaut/contrib/kallithea/kallithea/lib/auth.py', line 810 in 
__wrapper
  return func(*fargs, **fkwargs)
File '/home/clabaut/contrib/kallithea/kallithea/controllers/pullrequests.py', 
line 646 in show
  context=line_context)
File 
'/home/clabaut/contrib/kallithea/kallithea/lib/vcs/backends/hg/repository.py', 
line 258 in get_diff
  self.get_changeset(rev1)
File 
'/home/clabaut/contrib/kallithea/kallithea/lib/vcs/backends/hg/repository.py', 
line 500 in get_changeset
  revision = self._get_revision(revision)
File 
'/home/clabaut/contrib/kallithea/kallithea/lib/vcs/backends/hg/repository.py', 
line 429 in _get_revision
  raise ChangesetDoesNotExistError(msg)
ChangesetDoesNotExistError: Revision None does not exist for 
MercurialRepository at /tmp_dsk/attic2


CGI Variables
-
  CONTENT_TYPE: '; charset=utf-8'
  HTTP_ACCEPT: 
'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8'
  HTTP_ACCEPT_ENCODING: 'gzip, deflate, sdch'
  HTTP_ACCEPT_LANGUAGE: 'fr'
  HTTP_CONNECTION: 'keep-alive'
  HTTP_COOKIE: 
'kallithea=96a5ae7d18ac6b7e0374375a2c29c27e2e4a4875827e6a9df6064ce9b791efa8f968700a'
  HTTP_HOST: '127.0.0.1:5000'
  HTTP_REFERER: 'http://127.0.0.1:5000/attic2/pull-request'
  HTTP_USER_AGENT: 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, 
like Gecko) Chrome/43.0.2357.134 Safari/537.36'
  PATH_INFO: '/attic2/pull-request/3/_/1.0'
  REMOTE_ADDR: '127.0.0.1'
  REQUEST_METHOD: 'GET'
  SERVER_NAME: 'localhost.localdomain'
  SERVER_PORT: '5000'
  SERVER_PROTOCOL: 'HTTP/1.1'
  SERVER_SOFTWARE: 'waitress'


WSGI Variables
--
  application: 
kallithea.lib.middleware.sessionmiddleware.SecureSessionMiddleware object at 
0x7f6ef6ee3490
  beaker.get_session: bound method SecureSessionMiddleware._get_session of 
kallithea.lib.middleware.sessionmiddleware.SecureSessionMiddleware object at 
0x7f6ef6ee3490
  beaker.session: {'_authentication_token': 
'246234190613261990002291801955806687529', 'authuser': {'username': u'clabaut', 
'is_authenticated': True, 'user_id': 2}, '_accessed_time': 1438078432.407353, 
'_creation_time': 1435673266.713354}
  paste.registry: paste.registry.Registry object at 0x7f6edef55710
  paste.throw_errors: True
  pylons.action_method: bound method PullrequestsController.show of 
kallithea.controllers.pullrequests.PullrequestsController object at 
0x7f6edefe6110
  pylons.controller: kallithea.controllers.pullrequests.PullrequestsController 
object at 0x7f6edefe6110

Issue #144: Add ability to review a full file and not only a changeset (conservancy/kallithea)

2015-06-30 Thread Mathieu Clabaut
New issue 144: Add ability to review a full file and not only a changeset
https://bitbucket.org/conservancy/kallithea/issue/144/add-ability-to-review-a-full-file-and-not

Mathieu Clabaut:

Doing review of changesets works well when the review process was set up at the 
beginning of the project, but for rojects, where the reviewing is set up upon 
existing history, it is cumbersome to review all changesets. 

It would be nice to be able to review a full file at a given revision, at which 
point the team will be able to go with a changeset review scheme.


___
kallithea-general mailing list
kallithea-general@sfconservancy.org
http://lists.sfconservancy.org/mailman/listinfo/kallithea-general