[kbuild] drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1777 try_add_to_existing_fg() error: double unlocked 'fte->node.lock' (orig line 1775)
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Paul Blakey CC: Saeed Mahameed CC: Roi Dayan CC: Mark Bloch CC: Maor Gottlieb tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 729e3d091984487f7aa1ebfabfe594e5b317ed0f commit: 49c0355d301b4e0e01e0f19ddbb023bd7d0ee48c net/mlx5: Wait for inactive autogroups date: 4 months ago :: branch date: 8 hours ago :: commit date: 4 months ago config: powerpc-randconfig-m031-20200911 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1777 try_add_to_existing_fg() error: double unlocked 'fte->node.lock' (orig line 1775) Old smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1584 dest_is_valid() error: we previously assumed 'dest' could be null (see line 1574) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1835 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1827) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1851 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1827) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1857 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1827) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1863 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1827) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1876 _mlx5_add_flow_rules() error: double unlocked 'fte->node.lock' (orig line 1874) # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=49c0355d301b4e0e01e0f19ddbb023bd7d0ee48c git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 49c0355d301b4e0e01e0f19ddbb023bd7d0ee48c vim +1777 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c 7dee607ed0e0450 Parav Pandit 2019-09-18 1688 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1689 static struct mlx5_flow_handle * 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1690 try_add_to_existing_fg(struct mlx5_flow_table *ft, bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1691 struct list_head *match_head, 5233794b179136d Arnd Bergmann 2019-06-18 1692 const struct mlx5_flow_spec *spec, 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1693 struct mlx5_flow_act *flow_act, 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1694 struct mlx5_flow_destination *dest, bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1695 int dest_num, bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1696 int ft_version) 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1697 { a369d4ac4dff921 Maor Gottlieb 2017-08-27 1698 struct mlx5_flow_steering *steering = get_steering(>node); 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1699 struct mlx5_flow_group *g; 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1700 struct mlx5_flow_handle *rule; 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1701 struct match_list *iter; bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1702 bool take_write = false; bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1703 struct fs_fte *fte; dc638d1122d25d4 Eli Cohen 2020-03-04 1704 u64 version = 0; f5c2ff179f51101 Maor Gottlieb 2017-08-29 1705 int err; f5c2ff179f51101 Maor Gottlieb 2017-08-29 1706 bb0ee7dcc4ecd6a Jianbo Liu2019-06-25 1707 fte = alloc_fte(ft, spec, flow_act); f5c2ff179f51101 Maor Gottlieb 2017-08-29 1708 if (IS_ERR(fte)) f5c2ff179f51101 Maor Gottlieb 2017-08-29 1709 return ERR_PTR(-ENOMEM); 46719d77d5f38b8 Maor Gottlieb 2017-07-25 1710 bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1711 search_again_locked: d5634fee245f9e9 Paul Blakey 2018-09-20 1712 if (flow_act->flags & FLOW_ACT_NO_APPEND) d5634fee245f9e9 Paul Blakey 2018-09-20 1713 goto skip_search; dc638d1122d25d4 Eli Cohen 2020-03-04 1714 version = matched_fgs_get_version(match_head); dc638d1122d25d4 Eli Cohen 2020-03-04 1715 /* Try to find an fte with identical match value and attempt update its dc638d1122d25d4 Eli Cohen 2020-03-04 1716 * action. dc638d1122d25d4 Eli Cohen 2020-03-04 1717 */ bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1718 list_for_each_entry(iter, match_head, list) { bd71b08ec2ee450 Maor Gottlieb 2017-08-27 1719 struct fs_fte *fte_tmp; 693c6883bbc4f76 Matan Barak 2017-05-28 1720 693c6883bbc4f76 Matan Barak 2017-05-28 1721 g = iter->g; ad9421e36a77056 Roi Dayan 2018-08-20 1722 fte_tmp = lookup_fte_locked(g
[kbuild] [dhowells-fs:fscache-iter 25/55] include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode to unsigned int enum fscache_cookie_stage
CC: kbuild-...@lists.01.org TO: David Howells tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-iter head: f6ac6a6db767d26c3330f0cecadd4f331ee6d291 commit: 1a31bac9fae197781cf11fea38e3b352c7945362 [25/55] fscache: Replace the object management state machine :: branch date: 28 hours ago :: commit date: 35 hours ago config: i386-randconfig-s001-20200909 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty git checkout 1a31bac9fae197781cf11fea38e3b352c7945362 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) fs/nfs/client.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/dir.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/file.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/inode.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/super.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/read.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/write.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/nfs4proc.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/nfs/nfs4file.c: note: in included file (through fs/nfs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/cifs/cifsfs.c: note: in included file (through fs/cifs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/cifs/cifssmb.c: note: in included file (through fs/cifs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/cifs/connect.c: note: in included file (through fs/cifs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/cifs/file.c: note: in included file (through fs/cifs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/cifs/inode.c: note: in included file (through fs/cifs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/cifs/smb2inode.c: note: in included file (through fs/cifs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage -- fs/cifs/smb2file.c: note: in included file (through fs/cifs/fscache.h): >> include/linux/fscache.h:84:30: sparse: sparse: don't know how to apply mode >> to unsigned int enum fscache_cookie_stage # https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=1a31bac9fae197781cf11fea38e3b352c7945362 git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git git fetch --no-tags dhowells-fs fscache-iter git checkout 1a31bac9fae197781cf11fea38e3b352c7945362 vim +84 include/linux/fscache.h 2d6fff637037395 David Howells 2009-04-03 68 1a31bac9fae1977 David Howells 2020-02-06 69 /* 1a31bac9fae1977 David Howells 2020-02-06 70 * Data object state. 1a31bac9fae1977 David Howells 2020-02-06 71 */ 1a31bac9fae1977 David Howells 2020-02-06 72 enum fscache_cookie_stage { 1a31bac9fae1977 David Howells 2020-02-06 73FSCACHE_COOKIE_STAGE_INDEX, /* The cookie is an index cookie */ 1a31bac9fae1977 David Howells 2020-02-06 74FSCACHE_COOKIE_STAGE_QUIESCENT, /* The cookie is uncached */ 1a31bac9fae1977
[kbuild] drivers/gpu/drm/nouveau/nouveau_bo.c:1323 nouveau_bo_move_ntfy() warn: should 'new_reg->start << (12)' be a 64 bit
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Nirmoy Das CC: "Christian König" tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e8878ab825450c9ac07a0fc22e1f66fdb62b4f72 commit: 0dc9b286b8d2c219a55f6ad05d144aa4da495e97 drm/nouveau: don't use ttm bo->offset v3 date: 3 months ago :: branch date: 7 hours ago :: commit date: 3 months ago config: riscv-randconfig-m031-20200911 (attached as .config) compiler: riscv32-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/gpu/drm/nouveau/nouveau_bo.c:1323 nouveau_bo_move_ntfy() warn: should 'new_reg->start << (12)' be a 64 bit type? Old smatch warnings: drivers/gpu/drm/nouveau/nouveau_bo.c:430 nouveau_bo_pin() warn: should '1 << bo->mem.mem_type' be a 64 bit type? include/drm/ttm/ttm_bo_driver.h:658 __ttm_bo_reserve() warn: inconsistent returns '*bo->base.resv'. drivers/gpu/drm/nouveau/nouveau_bo.c:947 nv50_bo_move_m2mf() warn: should 'new_reg->num_pages << (12)' be a 64 bit type? drivers/gpu/drm/nouveau/nouveau_bo.c:1337 nouveau_bo_vm_bind() warn: should 'new_reg->start << (12)' be a 64 bit type? # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0dc9b286b8d2c219a55f6ad05d144aa4da495e97 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 0dc9b286b8d2c219a55f6ad05d144aa4da495e97 vim +1323 drivers/gpu/drm/nouveau/nouveau_bo.c 6ee738610f41b5 Ben Skeggs 2009-12-11 1296 a4154bbffdc9f6 Ben Skeggs 2011-02-10 1297 static void 66257db7a5276d Nicolai Hähnle 2016-12-15 1298 nouveau_bo_move_ntfy(struct ttm_buffer_object *bo, bool evict, 605f9ccd7d0ad6 Ben Skeggs 2016-05-17 1299 struct ttm_mem_reg *new_reg) a4154bbffdc9f6 Ben Skeggs 2011-02-10 1300 { 9ce523cc3bf2ac Ben Skeggs 2017-11-01 1301 struct nouveau_mem *mem = new_reg ? nouveau_mem(new_reg) : NULL; a4154bbffdc9f6 Ben Skeggs 2011-02-10 1302 struct nouveau_bo *nvbo = nouveau_bo(bo); 24e8375b1bfdf7 Ben Skeggs 2017-11-01 1303 struct nouveau_vma *vma; a4154bbffdc9f6 Ben Skeggs 2011-02-10 1304 9f1feed2e16652 Ben Skeggs 2012-01-25 1305 /* ttm can now (stupidly) pass the driver bos it didn't create... */ 9f1feed2e16652 Ben Skeggs 2012-01-25 1306 if (bo->destroy != nouveau_bo_del_ttm) 9f1feed2e16652 Ben Skeggs 2012-01-25 1307 return; 9f1feed2e16652 Ben Skeggs 2012-01-25 1308 425b34f7df63a2 Ben Skeggs 2017-11-01 1309 if (mem && new_reg->mem_type != TTM_PL_SYSTEM && 9ce523cc3bf2ac Ben Skeggs 2017-11-01 1310 mem->mem.page == nvbo->page) { a48296ab9dbe8b Ben Skeggs 2017-11-01 1311 list_for_each_entry(vma, >vma_list, head) { 24e8375b1bfdf7 Ben Skeggs 2017-11-01 1312 nouveau_vma_map(vma, mem); a48296ab9dbe8b Ben Skeggs 2017-11-01 1313 } d2f9c56a50 Ben Skeggs 2011-06-06 1314 } else { a48296ab9dbe8b Ben Skeggs 2017-11-01 1315 list_for_each_entry(vma, >vma_list, head) { 10dcab3e7f477b Ben Skeggs 2016-12-12 1316 WARN_ON(ttm_bo_wait(bo, false, false)); 24e8375b1bfdf7 Ben Skeggs 2017-11-01 1317 nouveau_vma_unmap(vma); fd2871af3d2dad Ben Skeggs 2011-06-06 1318 } a4154bbffdc9f6 Ben Skeggs 2011-02-10 1319 } 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 1320 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 1321 if (new_reg) { 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 1322 if (new_reg->mm_node) 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 @1323 nvbo->offset = (new_reg->start << PAGE_SHIFT); 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 1324 else 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 1325 nvbo->offset = 0; 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 1326 } 0dc9b286b8d2c2 Nirmoy Das 2020-06-24 1327 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [chrome-os:chromeos-5.4 64/158] fs/proc/task_mmu.c:1879:28: sparse: sparse: context imbalance in 'deactivate_pte_range' - unexpected unlock
CC: kbuild-...@lists.01.org TO: cros-kernel-buildrepo...@googlegroups.com TO: Guenter Roeck tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4 head: 59cae41f4fcd3f1d266be2b63a13973486562f2e commit: 4c3ad28b9c913ffe3146c439648f2ba50138a0ae [64/158] CHROMIUM: mm: per-process reclaim :: branch date: 3 weeks ago :: commit date: 3 weeks ago config: i386-randconfig-s001-20200912 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty git checkout 4c3ad28b9c913ffe3146c439648f2ba50138a0ae # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) fs/proc/task_mmu.c:671:28: sparse: sparse: context imbalance in 'smaps_pte_range' - unexpected unlock fs/proc/task_mmu.c:1258:28: sparse: sparse: context imbalance in 'clear_refs_pte_range' - unexpected unlock fs/proc/task_mmu.c:1611:28: sparse: sparse: context imbalance in 'pagemap_pmd_range' - unexpected unlock >> fs/proc/task_mmu.c:1879:28: sparse: sparse: context imbalance in >> 'deactivate_pte_range' - unexpected unlock >> fs/proc/task_mmu.c:1982:28: sparse: sparse: context imbalance in >> 'reclaim_pte_range' - unexpected unlock git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel git fetch --no-tags chrome-os chromeos-5.4 git checkout 4c3ad28b9c913ffe3146c439648f2ba50138a0ae vim +/deactivate_pte_range +1879 fs/proc/task_mmu.c 4c3ad28b9c913f Minchan Kim 2015-01-09 1839 4c3ad28b9c913f Minchan Kim 2015-01-09 1840 static int deactivate_pte_range(pmd_t *pmd, unsigned long addr, 4c3ad28b9c913f Minchan Kim 2015-01-09 1841 unsigned long end, struct mm_walk *walk) 4c3ad28b9c913f Minchan Kim 2015-01-09 1842 { 4c3ad28b9c913f Minchan Kim 2015-01-09 1843 pte_t *orig_pte, *pte, ptent; 4c3ad28b9c913f Minchan Kim 2015-01-09 1844 spinlock_t *ptl; 4c3ad28b9c913f Minchan Kim 2015-01-09 1845 struct page *page; 4c3ad28b9c913f Minchan Kim 2015-01-09 1846 struct vm_area_struct *vma = walk->vma; 4c3ad28b9c913f Minchan Kim 2015-01-09 1847 struct mm_struct *mm = vma->vm_mm; 4c3ad28b9c913f Minchan Kim 2015-01-09 1848 unsigned long next = pmd_addr_end(addr, end); 4c3ad28b9c913f Minchan Kim 2015-01-09 1849 4c3ad28b9c913f Minchan Kim 2015-01-09 1850 ptl = pmd_trans_huge_lock(pmd, vma); 4c3ad28b9c913f Minchan Kim 2015-01-09 1851 if (ptl) { 4c3ad28b9c913f Minchan Kim 2015-01-09 1852 if (!pmd_present(*pmd)) 4c3ad28b9c913f Minchan Kim 2015-01-09 1853 goto huge_unlock; 4c3ad28b9c913f Minchan Kim 2015-01-09 1854 4c3ad28b9c913f Minchan Kim 2015-01-09 1855 if (is_huge_zero_pmd(*pmd)) 4c3ad28b9c913f Minchan Kim 2015-01-09 1856 goto huge_unlock; 4c3ad28b9c913f Minchan Kim 2015-01-09 1857 4c3ad28b9c913f Minchan Kim 2015-01-09 1858 page = pmd_page(*pmd); 4c3ad28b9c913f Minchan Kim 2015-01-09 1859 if (page_mapcount(page) > 1) 4c3ad28b9c913f Minchan Kim 2015-01-09 1860 goto huge_unlock; 4c3ad28b9c913f Minchan Kim 2015-01-09 1861 4c3ad28b9c913f Minchan Kim 2015-01-09 1862 if (next - addr != HPAGE_PMD_SIZE) { 4c3ad28b9c913f Minchan Kim 2015-01-09 1863 int err; 4c3ad28b9c913f Minchan Kim 2015-01-09 1864 4c3ad28b9c913f Minchan Kim 2015-01-09 1865 get_page(page); 4c3ad28b9c913f Minchan Kim 2015-01-09 1866 spin_unlock(ptl); 4c3ad28b9c913f Minchan Kim 2015-01-09 1867 lock_page(page); 4c3ad28b9c913f Minchan Kim 2015-01-09 1868 err = split_huge_page(page); 4c3ad28b9c913f Minchan Kim 2015-01-09 1869 unlock_page(page); 4c3ad28b9c913f Minchan Kim 2015-01-09 1870 put_page(page); 4c3ad28b9c913f Minchan Kim 2015-01-09 1871 if (!err) 4c3ad28b9c913f Minchan Kim 2015-01-09 1872 goto regular_page; 4c3ad28b9c913f Minchan Kim 2015-01-09 1873 return 0; 4c3ad28b9c913f Minchan Kim 2015-01-09 1874 } 4c3ad28b9c913f Minchan Kim 2015-01-09 1875 4c3ad28b9c913f Minchan Kim 2015-01-09 1876 pmdp_test_and_clear_young(vma, addr, pmd); 4c3ad28b9c913f Minchan Kim 2015-01-09 1877 deactivate_page(page); 4c3ad28b9c913f Minchan Kim 2015-01-09 1878 huge_unlock: 4c3ad28b9c913f Minchan Kim 2015-01-09 @1879 spin_unlock(ptl); 4c3ad28b9c913f Minchan Kim 2015-01-09 1880 return 0; 4c3ad28b9c913f Minchan Kim 2015-01-09 1881 } 4c3ad28b9c913f Minchan Kim 2015-01-09 1882 4c3ad28b9c913f Minchan Kim 2015-01-09 1883 if
[kbuild] kernel/dma/pool.c:62:6: warning: Variable 'ret' is reassigned a value before the old one has been used.
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: David Rientjes CC: Christoph Hellwig tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e8878ab825450c9ac07a0fc22e1f66fdb62b4f72 commit: 54adadf9b08571fb8b11dc9d0d3a2ddd39825efd dma-pool: dynamically expanding atomic pools date: 5 months ago :: branch date: 3 hours ago :: commit date: 5 months ago compiler: nds32le-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck warnings: (new ones prefixed by >>) >> kernel/dma/pool.c:62:6: warning: Variable 'ret' is reassigned a value before >> the old one has been used. [redundantAssignment] ret = gen_pool_add_virt(pool, (unsigned long)addr, page_to_phys(page), ^ kernel/dma/pool.c:37:0: note: Variable 'ret' is reassigned a value before the old one has been used. int ret = -ENOMEM; ^ kernel/dma/pool.c:62:6: note: Variable 'ret' is reassigned a value before the old one has been used. ret = gen_pool_add_virt(pool, (unsigned long)addr, page_to_phys(page), ^ # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=54adadf9b08571fb8b11dc9d0d3a2ddd39825efd git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 54adadf9b08571fb8b11dc9d0d3a2ddd39825efd vim +/ret +62 kernel/dma/pool.c e860c299ac0d73 David Rientjes 2020-04-14 30 54adadf9b08571 David Rientjes 2020-04-20 31 static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, 54adadf9b08571 David Rientjes 2020-04-20 32 gfp_t gfp) e860c299ac0d73 David Rientjes 2020-04-14 33 { 54adadf9b08571 David Rientjes 2020-04-20 34unsigned int order; e860c299ac0d73 David Rientjes 2020-04-14 35struct page *page; e860c299ac0d73 David Rientjes 2020-04-14 36void *addr; 54adadf9b08571 David Rientjes 2020-04-20 37int ret = -ENOMEM; 54adadf9b08571 David Rientjes 2020-04-20 38 54adadf9b08571 David Rientjes 2020-04-20 39/* Cannot allocate larger than MAX_ORDER-1 */ 54adadf9b08571 David Rientjes 2020-04-20 40order = min(get_order(pool_size), MAX_ORDER-1); 54adadf9b08571 David Rientjes 2020-04-20 41 54adadf9b08571 David Rientjes 2020-04-20 42do { 54adadf9b08571 David Rientjes 2020-04-20 43pool_size = 1 << (PAGE_SHIFT + order); e860c299ac0d73 David Rientjes 2020-04-14 44 e860c299ac0d73 David Rientjes 2020-04-14 45if (dev_get_cma_area(NULL)) 54adadf9b08571 David Rientjes 2020-04-20 46page = dma_alloc_from_contiguous(NULL, 1 << order, 54adadf9b08571 David Rientjes 2020-04-20 47 order, false); e860c299ac0d73 David Rientjes 2020-04-14 48else c84dc6e68a1d24 David Rientjes 2020-04-14 49page = alloc_pages(gfp, order); 54adadf9b08571 David Rientjes 2020-04-20 50} while (!page && order-- > 0); e860c299ac0d73 David Rientjes 2020-04-14 51if (!page) e860c299ac0d73 David Rientjes 2020-04-14 52goto out; e860c299ac0d73 David Rientjes 2020-04-14 53 c84dc6e68a1d24 David Rientjes 2020-04-14 54arch_dma_prep_coherent(page, pool_size); e860c299ac0d73 David Rientjes 2020-04-14 55 c84dc6e68a1d24 David Rientjes 2020-04-14 56addr = dma_common_contiguous_remap(page, pool_size, e860c299ac0d73 David Rientjes 2020-04-14 57 pgprot_dmacoherent(PAGE_KERNEL), e860c299ac0d73 David Rientjes 2020-04-14 58 __builtin_return_address(0)); e860c299ac0d73 David Rientjes 2020-04-14 59if (!addr) 54adadf9b08571 David Rientjes 2020-04-20 60goto free_page; e860c299ac0d73 David Rientjes 2020-04-14 61 54adadf9b08571 David Rientjes 2020-04-20 @62ret = gen_pool_add_virt(pool, (unsigned long)addr, page_to_phys(page), 54adadf9b08571 David Rientjes 2020-04-20 63 pool_size, NUMA_NO_NODE); e860c299ac0d73 David Rientjes 2020-04-14 64if (ret) e860c299ac0d73 David Rientjes 2020-04-14 65goto remove_mapping; e860c299ac0d73 David Rientjes 2020-04-14 66 e860c299ac0d73 David Rientjes 2020-04-14 67return 0; e860c299ac0d73 David Rientjes 2020-04-14 68 e860c299ac0d73 David Rientjes 2020-04-14 69 remove_mapping: c84dc6e68a1d24 David Rientjes 2020-04-14 70dma_common_free_remap(addr, pool_size); e860c299ac0d73 David Rientjes 2020-04-14 71 free_page: 54adadf9b08571 David Rientjes 2020-04-20 72if (!dma_release_from_contiguous(NULL, page, 1 << order)) c84dc6e68a1d24 David Rientjes 2020-04-14 73__free_pages(page, order); e860c299ac0d73 David Rientjes 2020-04-14 74 out: 54adadf9b08571 David Rientjes 2020-04-20 75return ret; 54adadf9b08571 David Rientjes 2020-04-20 76 } 54adadf9b08571 David Rientjes 2020-04-20 77 ---
[kbuild] drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:816 amdgpu_ttm_io_mem_pfn() warn: should 'page_offset << (12)' be a 64 bit
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: "Christian König" CC: Alex Deucher CC: Felix Kuehling CC: Huang Rui tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: f0ee63cbc5264dbbdb994e87504b0b033149da55 drm/amdgpu: cleanup amdgpu_ttm_copy_mem_to_mem and amdgpu_map_buffer v2 date: 5 months ago :: branch date: 22 hours ago :: commit date: 5 months ago config: riscv-randconfig-m031-20200911 (attached as .config) compiler: riscv32-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:816 amdgpu_ttm_io_mem_pfn() warn: should 'page_offset << (12)' be a 64 bit type? Old smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:511 amdgpu_move_blit() warn: should 'new_mem->num_pages << (12)' be a 64 bit type? arch/riscv/include/asm/current.h:30 get_current() error: uninitialized symbol 'tp'. # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f0ee63cbc5264dbbdb994e87504b0b033149da55 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout f0ee63cbc5264dbbdb994e87504b0b033149da55 vim +816 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c d38ceaf99ed015 Alex Deucher 2015-04-20 812 9bbdcc0fbc392e Christian König2017-03-29 813 static unsigned long amdgpu_ttm_io_mem_pfn(struct ttm_buffer_object *bo, 9bbdcc0fbc392e Christian König2017-03-29 814 unsigned long page_offset) 9bbdcc0fbc392e Christian König2017-03-29 815 { f0ee63cbc5264d Christian König2020-03-18 @816 uint64_t offset = (page_offset << PAGE_SHIFT); e1d515052f9075 Harish Kasiviswanathan 2017-10-06 817 struct drm_mm_node *mm; 9bbdcc0fbc392e Christian König2017-03-29 818 e1d515052f9075 Harish Kasiviswanathan 2017-10-06 819 mm = amdgpu_find_mm_node(>mem, ); e1d515052f9075 Harish Kasiviswanathan 2017-10-06 820 return (bo->mem.bus.base >> PAGE_SHIFT) + mm->start + e1d515052f9075 Harish Kasiviswanathan 2017-10-06 821 (offset >> PAGE_SHIFT); 9bbdcc0fbc392e Christian König2017-03-29 822 } 9bbdcc0fbc392e Christian König2017-03-29 823 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/net/ethernet/mellanox/mlx5/core/en/port.c:453 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: 2132b71f78d207b63974fc7d6eced9c5e886c405 net/mlx5e: Advertise globaly supported FEC modes config: powerpc-randconfig-m031-20200911 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/en/port.c:453 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)' # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2132b71f78d207b63974fc7d6eced9c5e886c405 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 2132b71f78d207b63974fc7d6eced9c5e886c405 vim +453 drivers/net/ethernet/mellanox/mlx5/core/en/port.c 2132b71f78d207 Aya Levin 2020-02-11 444 bool mlx5e_fec_in_caps(struct mlx5_core_dev *dev, int fec_policy) 2095b264147753 Shay Agroskin 2018-10-10 445 { 2095b264147753 Shay Agroskin 2018-10-10 446u32 out[MLX5_ST_SZ_DW(pplm_reg)] = {}; 2095b264147753 Shay Agroskin 2018-10-10 447u32 in[MLX5_ST_SZ_DW(pplm_reg)] = {}; 2095b264147753 Shay Agroskin 2018-10-10 448int sz = MLX5_ST_SZ_BYTES(pplm_reg); 2095b264147753 Shay Agroskin 2018-10-10 449int err; 2132b71f78d207 Aya Levin 2020-02-11 450int i; 2095b264147753 Shay Agroskin 2018-10-10 451 2095b264147753 Shay Agroskin 2018-10-10 452if (!MLX5_CAP_GEN(dev, pcam_reg)) 2095b264147753 Shay Agroskin 2018-10-10 @453return -EOPNOTSUPP; ^^ 2095b264147753 Shay Agroskin 2018-10-10 454 2095b264147753 Shay Agroskin 2018-10-10 455if (!MLX5_CAP_PCAM_REG(dev, pplm)) 2095b264147753 Shay Agroskin 2018-10-10 456return -EOPNOTSUPP; ^^ These become "return true;" 2095b264147753 Shay Agroskin 2018-10-10 457 2095b264147753 Shay Agroskin 2018-10-10 458MLX5_SET(pplm_reg, in, local_port, 1); 2095b264147753 Shay Agroskin 2018-10-10 459err = mlx5_core_access_reg(dev, in, sz, out, sz, MLX5_REG_PPLM, 0, 0); 2095b264147753 Shay Agroskin 2018-10-10 460if (err) 2132b71f78d207 Aya Levin 2020-02-11 461return false; 2095b264147753 Shay Agroskin 2018-10-10 462 2132b71f78d207 Aya Levin 2020-02-11 463for (i = 0; i < MLX5E_FEC_SUPPORTED_SPEEDS; i++) { 2132b71f78d207 Aya Levin 2020-02-11 464u8 fec_caps; 2095b264147753 Shay Agroskin 2018-10-10 465 2132b71f78d207 Aya Levin 2020-02-11 466 mlx5e_get_fec_cap_field(out, _caps, fec_supported_speeds[i]); 2132b71f78d207 Aya Levin 2020-02-11 467if (fec_caps & fec_policy) 2132b71f78d207 Aya Levin 2020-02-11 468return true; 2132b71f78d207 Aya Levin 2020-02-11 469} 2132b71f78d207 Aya Levin 2020-02-11 470return false; 2095b264147753 Shay Agroskin 2018-10-10 471 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [mptcp:export 654/660] include/net/sock.h:1610:31: sparse: sparse: context imbalance in 'mptcp_rcv_space_adjust' - unexpected unlock
CC: kbuild-...@lists.01.org CC: mp...@lists.01.org TO: Paolo Abeni CC: Mat Martineau tree: https://github.com/multipath-tcp/mptcp_net-next.git export head: 38c882ee9a77d857355a8dd2a220156ba7df73bc commit: 37f6e2313ae90097187b574f1c143a42bd263f88 [654/660] mptcp: call tcp_cleanup_rbuf on subflows :: branch date: 4 hours ago :: commit date: 4 hours ago config: i386-randconfig-s001-20200911 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty git checkout 37f6e2313ae90097187b574f1c143a42bd263f88 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) net/mptcp/protocol.c: note: in included file: >> include/net/sock.h:1610:31: sparse: sparse: context imbalance in >> 'mptcp_rcv_space_adjust' - unexpected unlock net/mptcp/protocol.c:2042:24: sparse: sparse: context imbalance in 'mptcp_sk_clone' - unexpected unlock # https://github.com/multipath-tcp/mptcp_net-next/commit/37f6e2313ae90097187b574f1c143a42bd263f88 git remote add mptcp https://github.com/multipath-tcp/mptcp_net-next.git git fetch --no-tags mptcp export git checkout 37f6e2313ae90097187b574f1c143a42bd263f88 vim +/mptcp_rcv_space_adjust +1610 include/net/sock.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 1595 69336bd2d3ddce Joe Perches2013-09-22 1596 bool lock_sock_fast(struct sock *sk); 8a74ad60a546b1 Eric Dumazet 2010-05-26 1597 /** 8a74ad60a546b1 Eric Dumazet 2010-05-26 1598 * unlock_sock_fast - complement of lock_sock_fast 8a74ad60a546b1 Eric Dumazet 2010-05-26 1599 * @sk: socket 8a74ad60a546b1 Eric Dumazet 2010-05-26 1600 * @slow: slow mode 8a74ad60a546b1 Eric Dumazet 2010-05-26 1601 * 8a74ad60a546b1 Eric Dumazet 2010-05-26 1602 * fast unlock socket for user context. 8a74ad60a546b1 Eric Dumazet 2010-05-26 1603 * If slow mode is on, we call regular release_sock() 8a74ad60a546b1 Eric Dumazet 2010-05-26 1604 */ 8a74ad60a546b1 Eric Dumazet 2010-05-26 1605 static inline void unlock_sock_fast(struct sock *sk, bool slow) 4b0b72f7dd617b Eric Dumazet 2010-04-28 1606 { 8a74ad60a546b1 Eric Dumazet 2010-05-26 1607 if (slow) 8a74ad60a546b1 Eric Dumazet 2010-05-26 1608 release_sock(sk); 8a74ad60a546b1 Eric Dumazet 2010-05-26 1609 else 4b0b72f7dd617b Eric Dumazet 2010-04-28 @1610 spin_unlock_bh(>sk_lock.slock); 4b0b72f7dd617b Eric Dumazet 2010-04-28 1611 } 4b0b72f7dd617b Eric Dumazet 2010-04-28 1612 :: The code at line 1610 was first introduced by commit :: 4b0b72f7dd617b13abd1b04c947e15873e011a24 net: speedup udp receive path :: TO: Eric Dumazet :: CC: David S. Miller --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/net/ethernet/mellanox/mlx5/core/en/port.c:453 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)'
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Aya Levin CC: Saeed Mahameed CC: Eran Ben Elisha tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: 2132b71f78d207b63974fc7d6eced9c5e886c405 net/mlx5e: Advertise globaly supported FEC modes date: 7 months ago :: branch date: 20 hours ago :: commit date: 7 months ago config: powerpc-randconfig-m031-20200911 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/en/port.c:453 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)' Old smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/en/port.c:456 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)' # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2132b71f78d207b63974fc7d6eced9c5e886c405 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 2132b71f78d207b63974fc7d6eced9c5e886c405 vim +453 drivers/net/ethernet/mellanox/mlx5/core/en/port.c 2095b264147753 Shay Agroskin 2018-10-10 443 2132b71f78d207 Aya Levin 2020-02-11 444 bool mlx5e_fec_in_caps(struct mlx5_core_dev *dev, int fec_policy) 2095b264147753 Shay Agroskin 2018-10-10 445 { 2095b264147753 Shay Agroskin 2018-10-10 446u32 out[MLX5_ST_SZ_DW(pplm_reg)] = {}; 2095b264147753 Shay Agroskin 2018-10-10 447u32 in[MLX5_ST_SZ_DW(pplm_reg)] = {}; 2095b264147753 Shay Agroskin 2018-10-10 448int sz = MLX5_ST_SZ_BYTES(pplm_reg); 2095b264147753 Shay Agroskin 2018-10-10 449int err; 2132b71f78d207 Aya Levin 2020-02-11 450int i; 2095b264147753 Shay Agroskin 2018-10-10 451 2095b264147753 Shay Agroskin 2018-10-10 452if (!MLX5_CAP_GEN(dev, pcam_reg)) 2095b264147753 Shay Agroskin 2018-10-10 @453return -EOPNOTSUPP; 2095b264147753 Shay Agroskin 2018-10-10 454 2095b264147753 Shay Agroskin 2018-10-10 455if (!MLX5_CAP_PCAM_REG(dev, pplm)) 2095b264147753 Shay Agroskin 2018-10-10 456return -EOPNOTSUPP; 2095b264147753 Shay Agroskin 2018-10-10 457 2095b264147753 Shay Agroskin 2018-10-10 458MLX5_SET(pplm_reg, in, local_port, 1); 2095b264147753 Shay Agroskin 2018-10-10 459err = mlx5_core_access_reg(dev, in, sz, out, sz, MLX5_REG_PPLM, 0, 0); 2095b264147753 Shay Agroskin 2018-10-10 460if (err) 2132b71f78d207 Aya Levin 2020-02-11 461return false; 2095b264147753 Shay Agroskin 2018-10-10 462 2132b71f78d207 Aya Levin 2020-02-11 463for (i = 0; i < MLX5E_FEC_SUPPORTED_SPEEDS; i++) { 2132b71f78d207 Aya Levin 2020-02-11 464u8 fec_caps; 2095b264147753 Shay Agroskin 2018-10-10 465 2132b71f78d207 Aya Levin 2020-02-11 466 mlx5e_get_fec_cap_field(out, _caps, fec_supported_speeds[i]); 2132b71f78d207 Aya Levin 2020-02-11 467if (fec_caps & fec_policy) 2132b71f78d207 Aya Levin 2020-02-11 468return true; 2132b71f78d207 Aya Levin 2020-02-11 469} 2132b71f78d207 Aya Levin 2020-02-11 470return false; 2095b264147753 Shay Agroskin 2018-10-10 471 } 2095b264147753 Shay Agroskin 2018-10-10 472 :: The code at line 453 was first introduced by commit :: 2095b264147753eee0f122b8c0c9f035a32f0a25 net/mlx5e: Add port FEC get/set functions :: TO: Shay Agroskin :: CC: Saeed Mahameed --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/net/ethernet/mellanox/mlx5/core/en/health.c:226 mlx5e_health_rsc_fmsg_binary() error: uninitialized symbol 'err'.
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Aya Levin CC: Saeed Mahameed CC: Moshe Shemesh tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: 5f29458b77d51c104554575b73184c243930aa87 net/mlx5e: Support dump callback in TX reporter date: 7 months ago :: branch date: 17 hours ago :: commit date: 7 months ago config: powerpc-randconfig-m031-20200911 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/en/health.c:226 mlx5e_health_rsc_fmsg_binary() error: uninitialized symbol 'err'. # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f29458b77d51c104554575b73184c243930aa87 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 5f29458b77d51c104554575b73184c243930aa87 vim +/err +226 drivers/net/ethernet/mellanox/mlx5/core/en/health.c 5f29458b77d51c Aya Levin 2020-02-11 208 5f29458b77d51c Aya Levin 2020-02-11 209 #define MLX5_HEALTH_DEVLINK_MAX_SIZE 1024 5f29458b77d51c Aya Levin 2020-02-11 210 static int mlx5e_health_rsc_fmsg_binary(struct devlink_fmsg *fmsg, 5f29458b77d51c Aya Levin 2020-02-11 211 const void *value, u32 value_len) 5f29458b77d51c Aya Levin 2020-02-11 212 5f29458b77d51c Aya Levin 2020-02-11 213 { 5f29458b77d51c Aya Levin 2020-02-11 214u32 data_size; 5f29458b77d51c Aya Levin 2020-02-11 215u32 offset; 5f29458b77d51c Aya Levin 2020-02-11 216int err; 5f29458b77d51c Aya Levin 2020-02-11 217 5f29458b77d51c Aya Levin 2020-02-11 218for (offset = 0; offset < value_len; offset += data_size) { 5f29458b77d51c Aya Levin 2020-02-11 219data_size = value_len - offset; 5f29458b77d51c Aya Levin 2020-02-11 220if (data_size > MLX5_HEALTH_DEVLINK_MAX_SIZE) 5f29458b77d51c Aya Levin 2020-02-11 221data_size = MLX5_HEALTH_DEVLINK_MAX_SIZE; 5f29458b77d51c Aya Levin 2020-02-11 222err = devlink_fmsg_binary_put(fmsg, value + offset, data_size); 5f29458b77d51c Aya Levin 2020-02-11 223if (err) 5f29458b77d51c Aya Levin 2020-02-11 224break; 5f29458b77d51c Aya Levin 2020-02-11 225} 5f29458b77d51c Aya Levin 2020-02-11 @226return err; 5f29458b77d51c Aya Levin 2020-02-11 227 } 5f29458b77d51c Aya Levin 2020-02-11 228 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [leon-rdma:rdma-next 67/76] drivers/infiniband/core/uverbs_std_types_device.c:290 copy_gid_entries_to_user() warn: passing a valid pointer to 'PTR_ERR'
CC: kbuild-...@lists.01.org TO: Avihai Horon CC: Leon Romanovsky tree: https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git rdma-next head: fb60ce5917ddd769e17552ae421d056c0bb151a5 commit: 320a6a2fef0b62d96bcd8dfb182e91a1e8dc137b [67/76] RDMA/uverbs: Expose the new GID query API to user space :: branch date: 25 hours ago :: commit date: 25 hours ago config: i386-randconfig-m021-20200911 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/infiniband/core/uverbs_std_types_device.c:290 copy_gid_entries_to_user() warn: passing a valid pointer to 'PTR_ERR' Old smatch warnings: include/rdma/uverbs_ioctl.h:708 uverbs_attr_get_len() warn: passing a valid pointer to 'PTR_ERR' # https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?id=320a6a2fef0b62d96bcd8dfb182e91a1e8dc137b git remote add leon-rdma https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git git fetch --no-tags leon-rdma rdma-next git checkout 320a6a2fef0b62d96bcd8dfb182e91a1e8dc137b vim +/PTR_ERR +290 drivers/infiniband/core/uverbs_std_types_device.c 1c8fb1ea5a1dbd Yishai Hadas 2020-06-30 269 320a6a2fef0b62 Avihai Horon 2020-08-31 270 static int copy_gid_entries_to_user(struct uverbs_attr_bundle *attrs, 320a6a2fef0b62 Avihai Horon 2020-08-31 271 struct ib_uverbs_gid_entry *entries, 320a6a2fef0b62 Avihai Horon 2020-08-31 272 size_t num_entries, size_t user_entry_size) 320a6a2fef0b62 Avihai Horon 2020-08-31 273 { 320a6a2fef0b62 Avihai Horon 2020-08-31 274 const struct uverbs_attr *attr; 320a6a2fef0b62 Avihai Horon 2020-08-31 275 void __user *user_entries; 320a6a2fef0b62 Avihai Horon 2020-08-31 276 size_t copy_len; 320a6a2fef0b62 Avihai Horon 2020-08-31 277 int ret; 320a6a2fef0b62 Avihai Horon 2020-08-31 278 int i; 320a6a2fef0b62 Avihai Horon 2020-08-31 279 320a6a2fef0b62 Avihai Horon 2020-08-31 280 if (user_entry_size == sizeof(*entries)) { 320a6a2fef0b62 Avihai Horon 2020-08-31 281 ret = uverbs_copy_to(attrs, 320a6a2fef0b62 Avihai Horon 2020-08-31 282 UVERBS_ATTR_QUERY_GID_TABLE_RESP_ENTRIES, 320a6a2fef0b62 Avihai Horon 2020-08-31 283 entries, sizeof(*entries) * num_entries); 320a6a2fef0b62 Avihai Horon 2020-08-31 284 return ret; 320a6a2fef0b62 Avihai Horon 2020-08-31 285 } 320a6a2fef0b62 Avihai Horon 2020-08-31 286 320a6a2fef0b62 Avihai Horon 2020-08-31 287 copy_len = min_t(size_t, user_entry_size, sizeof(*entries)); 320a6a2fef0b62 Avihai Horon 2020-08-31 288 attr = uverbs_attr_get(attrs, UVERBS_ATTR_QUERY_GID_TABLE_RESP_ENTRIES); 320a6a2fef0b62 Avihai Horon 2020-08-31 289 if (IS_ERR(attr)) 320a6a2fef0b62 Avihai Horon 2020-08-31 @290 return PTR_ERR(attr); 320a6a2fef0b62 Avihai Horon 2020-08-31 291 320a6a2fef0b62 Avihai Horon 2020-08-31 292 user_entries = u64_to_user_ptr(attr->ptr_attr.data); 320a6a2fef0b62 Avihai Horon 2020-08-31 293 for (i = 0; i < num_entries; i++) { 320a6a2fef0b62 Avihai Horon 2020-08-31 294 if (copy_to_user(user_entries, entries, copy_len)) 320a6a2fef0b62 Avihai Horon 2020-08-31 295 return -EFAULT; 320a6a2fef0b62 Avihai Horon 2020-08-31 296 320a6a2fef0b62 Avihai Horon 2020-08-31 297 if (user_entry_size > sizeof(*entries)) { 320a6a2fef0b62 Avihai Horon 2020-08-31 298 if (clear_user(user_entries + sizeof(*entries), 320a6a2fef0b62 Avihai Horon 2020-08-31 299 user_entry_size - sizeof(*entries))) 320a6a2fef0b62 Avihai Horon 2020-08-31 300 return -EFAULT; 320a6a2fef0b62 Avihai Horon 2020-08-31 301 } 320a6a2fef0b62 Avihai Horon 2020-08-31 302 320a6a2fef0b62 Avihai Horon 2020-08-31 303 entries++; 320a6a2fef0b62 Avihai Horon 2020-08-31 304 user_entries += user_entry_size; 320a6a2fef0b62 Avihai Horon 2020-08-31 305 } 320a6a2fef0b62 Avihai Horon 2020-08-31 306 320a6a2fef0b62 Avihai Horon 2020-08-31 307 return uverbs_output_written(attrs, 320a6a2fef0b62 Avihai Horon 2020-08-31 308 UVERBS_ATTR_QUERY_GID_TABLE_RESP_ENTRIES); 320a6a2fef0b62 Avihai Horon 2020-08-31 309 } 320a6a2fef0b62 Avihai Horon 2020-08-31 310 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 6051/6654] net/rxrpc/conn_client.c:494 rxrpc_maybe_add_conn() warn: inconsistent returns 'bundle->channel_lock'.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7ce53e3a447bced7b85ed181c4d027e93c062e07 commit: 245500d853e9f20036cec7df4f6984ece4c6bf26 [6051/6654] rxrpc: Rewrite the client connection manager config: i386-randconfig-m021-20200911 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: net/rxrpc/conn_client.c:722 rxrpc_connect_call() error: 'bundle' dereferencing possible ERR_PTR() # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=245500d853e9f20036cec7df4f6984ece4c6bf26 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 245500d853e9f20036cec7df4f6984ece4c6bf26 vim +494 net/rxrpc/conn_client.c 697 int rxrpc_connect_call(struct rxrpc_sock *rx, 698 struct rxrpc_call *call, 699 struct rxrpc_conn_parameters *cp, 700 struct sockaddr_rxrpc *srx, 701 gfp_t gfp) 702 { 703 struct rxrpc_bundle *bundle; 704 struct rxrpc_net *rxnet = cp->local->rxnet; 705 int ret = 0; 706 707 _enter("{%d,%lx},", call->debug_id, call->user_call_ID); 708 709 rxrpc_discard_expired_client_conns(>client_conn_reaper); 710 711 bundle = rxrpc_prep_call(rx, call, cp, srx, gfp); 712 if (IS_ERR(bundle)) { 713 ret = PTR_ERR(bundle); 714 goto out; 715 } 716 717 if (call->state == RXRPC_CALL_CLIENT_AWAIT_CONN) { 718 ret = rxrpc_wait_for_channel(bundle, call, gfp); 719 if (ret < 0) 720 goto wait_failed; 721 } 722 723 granted_channel: 724 /* Paired with the write barrier in rxrpc_activate_one_channel(). */ 725 smp_rmb(); 726 727 out: 728 rxrpc_put_bundle(bundle); ^^ Dereferenced inside function. 729 _leave(" = %d", ret); 730 return ret; 731 732 wait_failed: 733 spin_lock(>channel_lock); 734 list_del_init(>chan_wait_link); 735 spin_unlock(>channel_lock); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [leon-rdma:rdma-next 8/76] drivers/infiniband/core/umem.c:263 __ib_umem_get() warn: impossible condition '(npages > (~0)) => (0-u32max > u32max)'
CC: kbuild-...@lists.01.org TO: Jason Gunthorpe CC: Leon Romanovsky CC: Yishai Hadas CC: Feras Daoud tree: https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git rdma-next head: fb60ce5917ddd769e17552ae421d056c0bb151a5 commit: 4e8a381066e9ae0c1f958fc879151012e9fb7f82 [8/76] RDMA/core: Introduce peer memory interface :: branch date: 23 hours ago :: commit date: 24 hours ago config: i386-randconfig-m021-20200911 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/infiniband/core/umem.c:263 __ib_umem_get() warn: impossible condition '(npages > (~0)) => (0-u32max > u32max)' # https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?id=4e8a381066e9ae0c1f958fc879151012e9fb7f82 git remote add leon-rdma https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git git fetch --no-tags leon-rdma rdma-next git checkout 4e8a381066e9ae0c1f958fc879151012e9fb7f82 vim +263 drivers/infiniband/core/umem.c 4a35339958f16d drivers/infiniband/core/umem.c Shiraz Saleem2019-05-06 201 f7c6a7b5d59980 drivers/infiniband/core/umem.c Roland Dreier2007-03-04 202 /** 4e8a381066e9ae drivers/infiniband/core/umem.c Jason Gunthorpe 2016-10-27 203 * __ib_umem_get - Pin and DMA map userspace memory. 8ada2c1c0c1d75 drivers/infiniband/core/umem.c Shachar Raindel 2014-12-11 204 * c320e527e15483 drivers/infiniband/core/umem.c Moni Shoua 2020-01-15 205 * @device: IB device to connect UMEM f7c6a7b5d59980 drivers/infiniband/core/umem.c Roland Dreier2007-03-04 206 * @addr: userspace virtual address to start at f7c6a7b5d59980 drivers/infiniband/core/umem.c Roland Dreier2007-03-04 207 * @size: length of region to pin f7c6a7b5d59980 drivers/infiniband/core/umem.c Roland Dreier2007-03-04 208 * @access: IB_ACCESS_xxx flags for memory being pinned 4e8a381066e9ae drivers/infiniband/core/umem.c Jason Gunthorpe 2016-10-27 209 * @peer_mem_flags: IB_PEER_MEM_xxx flags for memory being used f7c6a7b5d59980 drivers/infiniband/core/umem.c Roland Dreier2007-03-04 210 */ 4e8a381066e9ae drivers/infiniband/core/umem.c Jason Gunthorpe 2016-10-27 211 static struct ib_umem *__ib_umem_get(struct ib_device *device, 4e8a381066e9ae drivers/infiniband/core/umem.c Jason Gunthorpe 2016-10-27 212unsigned long addr, size_t size, int access, 4e8a381066e9ae drivers/infiniband/core/umem.c Jason Gunthorpe 2016-10-27 213unsigned long peer_mem_flags) eb8ffbfed50e79 drivers/infiniband/core/uverbs_mem.c Roland Dreier2005-07-07 214 { f7c6a7b5d59980 drivers/infiniband/core/umem.c Roland Dreier2007-03-04 215struct ib_umem *umem; eb8ffbfed50e79 drivers/infiniband/core/uverbs_mem.c Roland Dreier2005-07-07 216struct page **page_list; eb8ffbfed50e79 drivers/infiniband/core/uverbs_mem.c Roland Dreier2005-07-07 217unsigned long lock_limit; c6ce580716372d drivers/infiniband/core/umem.c Doug Ledford 2018-09-21 218unsigned long new_pinned; eb8ffbfed50e79 drivers/infiniband/core/uverbs_mem.c Roland Dreier2005-07-07 219unsigned long cur_base; f03d9fadfe13a7 drivers/infiniband/core/umem.c Michael Guralnik 2020-02-12 220unsigned long dma_attr = 0; d4b4dd1b9706e4 drivers/infiniband/core/umem.c Jason Gunthorpe 2018-09-16 221struct mm_struct *mm; eb8ffbfed50e79 drivers/infiniband/core/uverbs_mem.c Roland Dreier2005-07-07 222unsigned long npages; f7c6a7b5d59980 drivers/infiniband/core/umem.c Roland Dreier2007-03-04 223int ret; d10bcf947a3ea2 drivers/infiniband/core/umem.c Shiraz Saleem2019-04-02 224struct scatterlist *sg; 768ae309a96103 drivers/infiniband/core/umem.c Lorenzo Stoakes 2016-10-13 225unsigned int gup_flags = FOLL_WRITE; cb9fbc5c37b69a drivers/infiniband/core/umem.c Arthur Kepner2008-04-29 226 8494057ab5e40d drivers/infiniband/core/umem.c Shachar Raindel 2015-03-18 227/* 8494057ab5e40d drivers/infiniband/core/umem.c Shachar Raindel 2015-03-18 228 * If the combination of the addr and size requested for this memory 8494057ab5e40d drivers/infiniband/core/umem.c Shachar Raindel 2015-03-18 229 * region causes an integer overflow, return error. 8494057ab5e40d drivers/infiniband/core/umem.c Shachar Raindel 2015-03-18 230 */ 66578b0b2f6965 drivers/infiniband/core/umem.c Yann Droneaud2015-04-13 231if (((addr + size) < addr) || 66578b0b2f6965 drivers/infiniband/core/umem.c Yann Droneaud2015-04-13 232PAGE_ALIGN(addr + size) < (addr + size)) 8494057ab5e40d drivers/infiniband/core/umem.c Shachar Rain
[kbuild] drivers/misc/uacce/uacce.c:414 region_mmio_size_show() warn: should << (12)' be a 64 bit
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Kenneth Lee CC: Herbert Xu CC: "Greg Kroah-Hartman" CC: Jonathan Cameron CC: Zaibo Xu CC: Zhou Wang CC: "Jean-Philippe Brucker" CC: Zhangfei Gao tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: 015d239ac0142ad0e26567fd890ef8d171f13709 uacce: add uacce driver date: 7 months ago :: branch date: 15 hours ago :: commit date: 7 months ago config: riscv-randconfig-m031-20200911 (attached as .config) compiler: riscv32-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/misc/uacce/uacce.c:414 region_mmio_size_show() warn: should 'uacce->qf_pg_num[0] << (12)' be a 64 bit type? drivers/misc/uacce/uacce.c:423 region_dus_size_show() warn: should 'uacce->qf_pg_num[1] << (12)' be a 64 bit type? Old smatch warnings: arch/riscv/include/asm/current.h:30 get_current() error: uninitialized symbol 'tp'. # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=015d239ac0142ad0e26567fd890ef8d171f13709 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 015d239ac0142ad0e26567fd890ef8d171f13709 vim +414 drivers/misc/uacce/uacce.c 015d239ac0142a Kenneth Lee 2020-02-11 407 015d239ac0142a Kenneth Lee 2020-02-11 408 static ssize_t region_mmio_size_show(struct device *dev, 015d239ac0142a Kenneth Lee 2020-02-11 409 struct device_attribute *attr, char *buf) 015d239ac0142a Kenneth Lee 2020-02-11 410 { 015d239ac0142a Kenneth Lee 2020-02-11 411 struct uacce_device *uacce = to_uacce_device(dev); 015d239ac0142a Kenneth Lee 2020-02-11 412 015d239ac0142a Kenneth Lee 2020-02-11 413 return sprintf(buf, "%lu\n", 015d239ac0142a Kenneth Lee 2020-02-11 @414 uacce->qf_pg_num[UACCE_QFRT_MMIO] << PAGE_SHIFT); 015d239ac0142a Kenneth Lee 2020-02-11 415 } 015d239ac0142a Kenneth Lee 2020-02-11 416 015d239ac0142a Kenneth Lee 2020-02-11 417 static ssize_t region_dus_size_show(struct device *dev, 015d239ac0142a Kenneth Lee 2020-02-11 418 struct device_attribute *attr, char *buf) 015d239ac0142a Kenneth Lee 2020-02-11 419 { 015d239ac0142a Kenneth Lee 2020-02-11 420 struct uacce_device *uacce = to_uacce_device(dev); 015d239ac0142a Kenneth Lee 2020-02-11 421 015d239ac0142a Kenneth Lee 2020-02-11 422 return sprintf(buf, "%lu\n", 015d239ac0142a Kenneth Lee 2020-02-11 @423 uacce->qf_pg_num[UACCE_QFRT_DUS] << PAGE_SHIFT); 015d239ac0142a Kenneth Lee 2020-02-11 424 } 015d239ac0142a Kenneth Lee 2020-02-11 425 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1555 dest_is_valid() error: we previously assumed 'dest' could be null (see line 1545)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: ff189b43568216c6211e9e7ddd9026cb8295e744 net/mlx5: Add ignore level support fwd to table rules config: powerpc-randconfig-m031-20200911 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1555 dest_is_valid() error: we previously assumed 'dest' could be null (see line 1545) # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff189b43568216c6211e9e7ddd9026cb8295e744 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout ff189b43568216c6211e9e7ddd9026cb8295e744 vim +/dest +1555 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c d63cd28608bb563 Maor Gottlieb 2016-04-29 1538 static bool dest_is_valid(struct mlx5_flow_destination *dest, ff189b43568216c Paul Blakey 2020-01-05 1539 struct mlx5_flow_act *flow_act, d63cd28608bb563 Maor Gottlieb 2016-04-29 1540 struct mlx5_flow_table *ft) d63cd28608bb563 Maor Gottlieb 2016-04-29 1541 { ff189b43568216c Paul Blakey 2020-01-05 1542 bool ignore_level = flow_act->flags & FLOW_ACT_IGNORE_FLOW_LEVEL; ff189b43568216c Paul Blakey 2020-01-05 1543 u32 action = flow_act->action; ff189b43568216c Paul Blakey 2020-01-05 1544 bd5251dbf156b6b Amir Vadai2016-05-13 @1545 if (dest && (dest->type == MLX5_FLOW_DESTINATION_TYPE_COUNTER)) Check for NULL. 171c7625bef9998 Mark Bloch2018-10-03 1546 return counter_is_valid(action); bd5251dbf156b6b Amir Vadai2016-05-13 1547 d63cd28608bb563 Maor Gottlieb 2016-04-29 1548 if (!(action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST)) d63cd28608bb563 Maor Gottlieb 2016-04-29 1549 return true; d63cd28608bb563 Maor Gottlieb 2016-04-29 1550 ff189b43568216c Paul Blakey 2020-01-05 1551 if (ignore_level) { ff189b43568216c Paul Blakey 2020-01-05 1552 if (ft->type != FS_FT_FDB) ff189b43568216c Paul Blakey 2020-01-05 1553 return false; ff189b43568216c Paul Blakey 2020-01-05 1554 ff189b43568216c Paul Blakey 2020-01-05 @1555 if (dest->type == MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE && ^^ Unchecked dereference. ff189b43568216c Paul Blakey 2020-01-05 1556 dest->ft->type != FS_FT_FDB) ff189b43568216c Paul Blakey 2020-01-05 1557 return false; ff189b43568216c Paul Blakey 2020-01-05 1558 } ff189b43568216c Paul Blakey 2020-01-05 1559 d63cd28608bb563 Maor Gottlieb 2016-04-29 1560 if (!dest || ((dest->type == ^ Check. d63cd28608bb563 Maor Gottlieb 2016-04-29 1561 MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE) && ff189b43568216c Paul Blakey 2020-01-05 1562 (dest->ft->level <= ft->level && !ignore_level))) d63cd28608bb563 Maor Gottlieb 2016-04-29 1563 return false; d63cd28608bb563 Maor Gottlieb 2016-04-29 1564 return true; d63cd28608bb563 Maor Gottlieb 2016-04-29 1565 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] drivers/infiniband/hw/mlx5/main.c:1189 mlx5_ib_query_device() error: we previously assumed 'uhw' could be null (see line 837)
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Leon Romanovsky tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: 4835709176e8ccf6561abc9f5c405293e008095f RDMA/mlx5: Don't fake udata for kernel path date: 8 months ago :: branch date: 14 hours ago :: commit date: 8 months ago config: powerpc-randconfig-m031-20200911 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/infiniband/hw/mlx5/main.c:1189 mlx5_ib_query_device() error: we previously assumed 'uhw' could be null (see line 837) Old smatch warnings: drivers/infiniband/hw/mlx5/main.c:614 set_roce_addr() error: we previously assumed 'gid' could be null (see line 590) drivers/infiniband/hw/mlx5/main.c:1939 mlx5_ib_alloc_ucontext() error: uninitialized symbol 'dump_fill_mkey'. # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4835709176e8ccf6561abc9f5c405293e008095f git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 4835709176e8ccf6561abc9f5c405293e008095f vim +/uhw +1189 drivers/infiniband/hw/mlx5/main.c 1b5daf11b01512 Majd Dibbiny 2015-06-04 813 e126ba97dba9ed Eli Cohen2013-07-07 814 static int mlx5_ib_query_device(struct ib_device *ibdev, 2528e33e680921 Matan Barak 2015-06-11 815 struct ib_device_attr *props, 2528e33e680921 Matan Barak 2015-06-11 816 struct ib_udata *uhw) e126ba97dba9ed Eli Cohen2013-07-07 817 { 4835709176e8cc Leon Romanovsky 2020-01-15 818size_t uhw_outlen = (uhw) ? uhw->outlen : 0; e126ba97dba9ed Eli Cohen2013-07-07 819struct mlx5_ib_dev *dev = to_mdev(ibdev); 938fe83c8dcbbf Saeed Mahameed 2015-05-28 820struct mlx5_core_dev *mdev = dev->mdev; e126ba97dba9ed Eli Cohen2013-07-07 821int err = -ENOMEM; 288c01b746aab4 Eli Cohen2016-10-27 822int max_sq_desc; e126ba97dba9ed Eli Cohen2013-07-07 823int max_rq_sg; e126ba97dba9ed Eli Cohen2013-07-07 824int max_sq_sg; e0238a6a369eaa Sagi Grimberg2015-07-21 825u64 min_page_size = 1ull << MLX5_CAP_GEN(mdev, log_pg_sz); 85c7c01499a9eb Daniel Jurgens 2018-01-04 826bool raw_support = !mlx5_core_mp_enabled(mdev); 402ca53644ff19 Bodong Wang 2016-06-17 827struct mlx5_ib_query_device_resp resp = {}; 402ca53644ff19 Bodong Wang 2016-06-17 828size_t resp_len; 402ca53644ff19 Bodong Wang 2016-06-17 829u64 max_tso; e126ba97dba9ed Eli Cohen2013-07-07 830 402ca53644ff19 Bodong Wang 2016-06-17 831resp_len = sizeof(resp.comp_mask) + sizeof(resp.response_length); 4835709176e8cc Leon Romanovsky 2020-01-15 832if (uhw_outlen && uhw_outlen < resp_len) 402ca53644ff19 Bodong Wang 2016-06-17 833return -EINVAL; 6f26b2ac699cc5 Erez Alfasi 2019-10-02 834 402ca53644ff19 Bodong Wang 2016-06-17 835resp.response_length = resp_len; 402ca53644ff19 Bodong Wang 2016-06-17 836 4835709176e8cc Leon Romanovsky 2020-01-15 837if (uhw && uhw->inlen && !ib_is_udata_cleared(uhw, 0, uhw->inlen)) 2528e33e680921 Matan Barak 2015-06-11 838return -EINVAL; 2528e33e680921 Matan Barak 2015-06-11 839 1b5daf11b01512 Majd Dibbiny 2015-06-04 840memset(props, 0, sizeof(*props)); 1b5daf11b01512 Majd Dibbiny 2015-06-04 841err = mlx5_query_system_image_guid(ibdev, 1b5daf11b01512 Majd Dibbiny 2015-06-04 842 >sys_image_guid); 1b5daf11b01512 Majd Dibbiny 2015-06-04 843if (err) 1b5daf11b01512 Majd Dibbiny 2015-06-04 844return err; e126ba97dba9ed Eli Cohen2013-07-07 845 1b5daf11b01512 Majd Dibbiny 2015-06-04 846err = mlx5_query_max_pkeys(ibdev, >max_pkeys); e126ba97dba9ed Eli Cohen2013-07-07 847if (err) 1b5daf11b01512 Majd Dibbiny 2015-06-04 848return err; e126ba97dba9ed Eli Cohen2013-07-07 849 1b5daf11b01512 Majd Dibbiny 2015-06-04 850err = mlx5_query_vendor_id(ibdev, >vendor_id); 1b5daf11b01512 Majd Dibbiny 2015-06-04 851if (err) 1b5daf11b01512 Majd Dibbiny 2015-06-04 852return err; e126ba97dba9ed Eli Cohen2013-07-07 853 9603b61de1eee9 Jack Morgenstein 2014-07-28 854props->fw_ver = ((u64)fw_rev_maj(dev->mdev) << 32) | 9603b61de1eee9 Jack Morgenstein 2014-07-28 855 (fw_rev_min(de
[kbuild] [linux-next:master 6051/6654] net/rxrpc/conn_client.c:494 rxrpc_maybe_add_conn() warn: inconsistent returns 'bundle->channel_lock'.
CC: kbuild-...@lists.01.org TO: David Howells tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7ce53e3a447bced7b85ed181c4d027e93c062e07 commit: 245500d853e9f20036cec7df4f6984ece4c6bf26 [6051/6654] rxrpc: Rewrite the client connection manager :: branch date: 26 hours ago :: commit date: 3 days ago config: i386-randconfig-m021-20200911 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: net/rxrpc/conn_client.c:494 rxrpc_maybe_add_conn() warn: inconsistent returns 'bundle->channel_lock'. net/rxrpc/conn_client.c:722 rxrpc_connect_call() error: 'bundle' dereferencing possible ERR_PTR() # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=245500d853e9f20036cec7df4f6984ece4c6bf26 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 245500d853e9f20036cec7df4f6984ece4c6bf26 vim +494 net/rxrpc/conn_client.c 45025bceef17ed David Howells 2016-08-24 459 45025bceef17ed David Howells 2016-08-24 460 /* 245500d853e9f2 David Howells 2020-07-01 461 * Add a connection to a bundle if there are no usable connections or we have 245500d853e9f2 David Howells 2020-07-01 462 * connections waiting for extra capacity. 45025bceef17ed David Howells 2016-08-24 463 */ 245500d853e9f2 David Howells 2020-07-01 464 static void rxrpc_maybe_add_conn(struct rxrpc_bundle *bundle, gfp_t gfp) 45025bceef17ed David Howells 2016-08-24 465 { 245500d853e9f2 David Howells 2020-07-01 466struct rxrpc_call *call; 245500d853e9f2 David Howells 2020-07-01 467int i, usable; 45025bceef17ed David Howells 2016-08-24 468 245500d853e9f2 David Howells 2020-07-01 469_enter(""); 245500d853e9f2 David Howells 2020-07-01 470 245500d853e9f2 David Howells 2020-07-01 471 spin_lock(>channel_lock); 245500d853e9f2 David Howells 2020-07-01 472 245500d853e9f2 David Howells 2020-07-01 473/* See if there are any usable connections. */ 245500d853e9f2 David Howells 2020-07-01 474usable = 0; 245500d853e9f2 David Howells 2020-07-01 475for (i = 0; i < ARRAY_SIZE(bundle->conns); i++) 245500d853e9f2 David Howells 2020-07-01 476if (rxrpc_may_reuse_conn(bundle->conns[i])) 245500d853e9f2 David Howells 2020-07-01 477usable++; 245500d853e9f2 David Howells 2020-07-01 478 245500d853e9f2 David Howells 2020-07-01 479if (!usable && !list_empty(>waiting_calls)) { 245500d853e9f2 David Howells 2020-07-01 480call = list_first_entry(>waiting_calls, 245500d853e9f2 David Howells 2020-07-01 481 struct rxrpc_call, chan_wait_link); 245500d853e9f2 David Howells 2020-07-01 482if (test_bit(RXRPC_CALL_UPGRADE, >flags)) 245500d853e9f2 David Howells 2020-07-01 483 bundle->try_upgrade = true; 245500d853e9f2 David Howells 2020-07-01 484} 245500d853e9f2 David Howells 2020-07-01 485 245500d853e9f2 David Howells 2020-07-01 486if (!usable) 245500d853e9f2 David Howells 2020-07-01 487goto alloc_conn; 245500d853e9f2 David Howells 2020-07-01 488 245500d853e9f2 David Howells 2020-07-01 489 spin_unlock(>channel_lock); 245500d853e9f2 David Howells 2020-07-01 490_leave(""); 245500d853e9f2 David Howells 2020-07-01 491return; 245500d853e9f2 David Howells 2020-07-01 492 245500d853e9f2 David Howells 2020-07-01 493 alloc_conn: 245500d853e9f2 David Howells 2020-07-01 @494return rxrpc_add_conn_to_bundle(bundle, gfp); 45025bceef17ed David Howells 2016-08-24 495 } 45025bceef17ed David Howells 2016-08-24 496 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 1952/6654] arch/arm/mach-s3c/irq-s3c24xx.c:399:14: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour. See condition at line 396.
CC: kbuild-...@lists.01.org TO: Arnd Bergmann CC: Krzysztof Kozlowski tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7ce53e3a447bced7b85ed181c4d027e93c062e07 commit: 71b9114d2c13a648fbe6523dd859e611c316ad90 [1952/6654] ARM: s3c: move into a common directory :: branch date: 26 hours ago :: commit date: 3 weeks ago compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck warnings: (new ones prefixed by >>) >> arch/arm/mach-s3c/irq-s3c24xx.c:399:14: warning: Shifting signed 32-bit >> value by 31 bits is undefined behaviour. See condition at line 396. >> [shiftTooManyBitsSigned] intmod = 1 << offs; ^ arch/arm/mach-s3c/irq-s3c24xx.c:396:12: note: Assuming that condition 'offs>31' is not redundant if (offs > 31) ^ arch/arm/mach-s3c/irq-s3c24xx.c:399:14: note: Shift intmod = 1 << offs; ^ # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=71b9114d2c13a648fbe6523dd859e611c316ad90 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 71b9114d2c13a648fbe6523dd859e611c316ad90 vim +399 arch/arm/mach-s3c/irq-s3c24xx.c 17453dd2e7df20 arch/arm/mach-s3c24xx/irq.c Heiko Stuebner 2013-03-07 374 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 375 #ifdef CONFIG_FIQ 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 376 /** 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 377 * s3c24xx_set_fiq - set the FIQ routing 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 378 * @irq: IRQ number to route to FIQ on processor. cd4bd8f9435ddf arch/arm/mach-s3c24xx/irq-s3c24xx.c Arnd Bergmann 2020-08-06 379 * @ack_ptr: pointer to a location for storing the bit mask 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 380 * @on: Whether to route @irq to the FIQ, or to remove the FIQ routing. 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 381 * 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 382 * Change the state of the IRQ to FIQ routing depending on @irq and @on. If 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 383 * @on is true, the @irq is checked to see if it can be routed and the 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 384 * interrupt controller updated to route the IRQ. If @on is false, the FIQ 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 385 * routing is cleared, regardless of which @irq is specified. cd4bd8f9435ddf arch/arm/mach-s3c24xx/irq-s3c24xx.c Arnd Bergmann 2020-08-06 386 * cd4bd8f9435ddf arch/arm/mach-s3c24xx/irq-s3c24xx.c Arnd Bergmann 2020-08-06 387 * returns the mask value for the register. 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 388 */ cd4bd8f9435ddf arch/arm/mach-s3c24xx/irq-s3c24xx.c Arnd Bergmann 2020-08-06 389 int s3c24xx_set_fiq(unsigned int irq, u32 *ack_ptr, bool on) 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 390 { 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 391 u32 intmod; 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 392 unsigned offs; 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 393 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 394 if (on) { 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 395 offs = irq - FIQ_START; 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 @396 if (offs > 31) cd4bd8f9435ddf arch/arm/mach-s3c24xx/irq-s3c24xx.c Arnd Bergmann 2020-08-06 397 return 0; 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 398 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 @399 intmod = 1 << offs; 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 400 } else { 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 401 intmod = 0; 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 402 } 229fd8ffba57df arch/arm/plat-s3c24xx/irq.c Ben Dooks 2009-08-03 403 cd4bd8f9435ddf arch/arm/mach-s3c24xx/irq-s3c24xx.c Arnd Bergmann 2020-08-06 404 if (ack_ptr) cd4bd8f9435ddf arch/arm/mach-s3c24xx/irq-s3c24xx.c Arnd Bergmann 2020-08-06 405 *ack_ptr = intmod; 353332855eef20
[kbuild] [linux-next:master 2507/6654] kernel/rcu/rcuscale.c:407:19-22: ERROR: reference preceded by free on line 413
CC: kbuild-...@lists.01.org TO: "Paul E. McKenney" tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7ce53e3a447bced7b85ed181c4d027e93c062e07 commit: 4e88ec4a9eb17527e640b063f79e5b875733eb53 [2507/6654] rcuperf: Change rcuperf to rcuscale :: branch date: 25 hours ago :: commit date: 2 weeks ago config: ia64-randconfig-c004-20200911 (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Julia Lawall coccinelle warnings: (new ones prefixed by >>) >> kernel/rcu/rcuscale.c:407:19-22: ERROR: reference preceded by free on line >> 413 kernel/rcu/rcuscale.c:413:10-13: ERROR: reference preceded by free on line 413 # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4e88ec4a9eb17527e640b063f79e5b875733eb53 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 4e88ec4a9eb17527e640b063f79e5b875733eb53 vim +407 kernel/rcu/rcuscale.c 881ed593a323c83 kernel/rcu/rcuperf.c Paul E. McKenney2017-04-17 353 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 354 /* 4e88ec4a9eb1752 kernel/rcu/rcuscale.c Paul E. McKenney2020-08-11 355 * RCU scale writer kthread. Repeatedly does a grace period. 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 356 */ 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 357 static int 4e88ec4a9eb1752 kernel/rcu/rcuscale.c Paul E. McKenney2020-08-11 358 rcu_scale_writer(void *arg) 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 359 { 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 360 int i = 0; 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 361 int i_max; 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 362 long me = (long)arg; 881ed593a323c83 kernel/rcu/rcuperf.c Paul E. McKenney2017-04-17 363 struct rcu_head *rhp = NULL; 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 364 bool started = false, done = false, alldone = false; 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 365 u64 t; 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 366 u64 *wdp; 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 367 u64 *wdpp = writer_durations[me]; 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 368 4e88ec4a9eb1752 kernel/rcu/rcuscale.c Paul E. McKenney2020-08-11 369 VERBOSE_SCALEOUT_STRING("rcu_scale_writer task started"); 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 370 WARN_ON(!wdpp); 6b558c4c7a4ba41 kernel/rcu/rcuperf.c Paul E. McKenney2016-01-12 371 set_cpus_allowed_ptr(current, cpumask_of(me % nr_cpu_ids)); b1433395c4cc078 kernel/rcu/rcuperf.c Peter Zijlstra 2020-04-21 372 sched_set_fifo_low(current); df37e66bfdbb57e kernel/rcu/rcuperf.c Paul E. McKenney2016-01-30 373 df37e66bfdbb57e kernel/rcu/rcuperf.c Paul E. McKenney2016-01-30 374 if (holdoff) df37e66bfdbb57e kernel/rcu/rcuperf.c Paul E. McKenney2016-01-30 375 schedule_timeout_uninterruptible(holdoff * HZ); df37e66bfdbb57e kernel/rcu/rcuperf.c Paul E. McKenney2016-01-30 376 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 377) /* 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 378) * Wait until rcu_end_inkernel_boot() is called for normal GP tests 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 379) * so that RCU is not always expedited for normal GP tests. 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 380) * The system_state test is approximate, but works well in practice. 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 381) */ 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 382) while (!gp_exp && system_state != SYSTEM_RUNNING) 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 383) schedule_timeout_uninterruptible(1); 77e9752ce69f36f kernel/rcu/rcuperf.c Joel Fernandes (Google 2019-07-04 384) 8704baab9bc848b kernel/rcu/rcuperf.c Paul E. McKenney2015-12-31 385 t = ktime_get_mono_fast_ns(); 4e88ec4a9eb1752 kernel/rcu/rcuscale.c Paul E. McKenney2020-08-11 386 if (atomic_inc_return(_rcu_scale_writer_started) >= nrealwriters) { 4e88ec4a9eb1752 kernel/rcu/rcuscale.c Paul E. McKenney2020-08-11 387 t_rcu_scale_writer_started = t; 8704baab9bc848b kernel/rcu/r
[kbuild] drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1555 dest_is_valid() error: we previously assumed 'dest' could be null (see line 1545)
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Paul Blakey CC: Saeed Mahameed CC: Mark Bloch tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: ff189b43568216c6211e9e7ddd9026cb8295e744 net/mlx5: Add ignore level support fwd to table rules date: 8 months ago :: branch date: 12 hours ago :: commit date: 8 months ago config: powerpc-randconfig-m031-20200911 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1555 dest_is_valid() error: we previously assumed 'dest' could be null (see line 1545) Old smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1818 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1810) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1834 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1810) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1840 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1810) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1846 _mlx5_add_flow_rules() error: double unlocked 'ft->node.lock' (orig line 1810) drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:1859 _mlx5_add_flow_rules() error: double unlocked 'fte->node.lock' (orig line 1857) # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ff189b43568216c6211e9e7ddd9026cb8295e744 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout ff189b43568216c6211e9e7ddd9026cb8295e744 vim +/dest +1555 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c bd5251dbf156b6b Amir Vadai2016-05-13 1537 d63cd28608bb563 Maor Gottlieb 2016-04-29 1538 static bool dest_is_valid(struct mlx5_flow_destination *dest, ff189b43568216c Paul Blakey 2020-01-05 1539 struct mlx5_flow_act *flow_act, d63cd28608bb563 Maor Gottlieb 2016-04-29 1540 struct mlx5_flow_table *ft) d63cd28608bb563 Maor Gottlieb 2016-04-29 1541 { ff189b43568216c Paul Blakey 2020-01-05 1542 bool ignore_level = flow_act->flags & FLOW_ACT_IGNORE_FLOW_LEVEL; ff189b43568216c Paul Blakey 2020-01-05 1543 u32 action = flow_act->action; ff189b43568216c Paul Blakey 2020-01-05 1544 bd5251dbf156b6b Amir Vadai2016-05-13 @1545 if (dest && (dest->type == MLX5_FLOW_DESTINATION_TYPE_COUNTER)) 171c7625bef9998 Mark Bloch2018-10-03 1546 return counter_is_valid(action); bd5251dbf156b6b Amir Vadai2016-05-13 1547 d63cd28608bb563 Maor Gottlieb 2016-04-29 1548 if (!(action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST)) d63cd28608bb563 Maor Gottlieb 2016-04-29 1549 return true; d63cd28608bb563 Maor Gottlieb 2016-04-29 1550 ff189b43568216c Paul Blakey 2020-01-05 1551 if (ignore_level) { ff189b43568216c Paul Blakey 2020-01-05 1552 if (ft->type != FS_FT_FDB) ff189b43568216c Paul Blakey 2020-01-05 1553 return false; ff189b43568216c Paul Blakey 2020-01-05 1554 ff189b43568216c Paul Blakey 2020-01-05 @1555 if (dest->type == MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE && ff189b43568216c Paul Blakey 2020-01-05 1556 dest->ft->type != FS_FT_FDB) ff189b43568216c Paul Blakey 2020-01-05 1557 return false; ff189b43568216c Paul Blakey 2020-01-05 1558 } ff189b43568216c Paul Blakey 2020-01-05 1559 d63cd28608bb563 Maor Gottlieb 2016-04-29 1560 if (!dest || ((dest->type == d63cd28608bb563 Maor Gottlieb 2016-04-29 1561 MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE) && ff189b43568216c Paul Blakey 2020-01-05 1562 (dest->ft->level <= ft->level && !ignore_level))) d63cd28608bb563 Maor Gottlieb 2016-04-29 1563 return false; d63cd28608bb563 Maor Gottlieb 2016-04-29 1564 return true; d63cd28608bb563 Maor Gottlieb 2016-04-29 1565 } d63cd28608bb563 Maor Gottlieb 2016-04-29 1566 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 6050/6654] net/rxrpc/call_object.c:375 rxrpc_new_client_call() warn: inconsistent returns
CC: kbuild-...@lists.01.org TO: David Howells tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7ce53e3a447bced7b85ed181c4d027e93c062e07 commit: b7a7d67408032843c14071711d6259aada9392f0 [6050/6654] rxrpc: Impose a maximum number of client calls :: branch date: 24 hours ago :: commit date: 2 days ago config: i386-randconfig-m021-20200911 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: net/rxrpc/call_object.c:375 rxrpc_new_client_call() warn: inconsistent returns '*limiter'. Old smatch warnings: net/rxrpc/call_object.c:375 rxrpc_new_client_call() warn: inconsistent returns 'call->user_mutex'. # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b7a7d67408032843c14071711d6259aada9392f0 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout b7a7d67408032843c14071711d6259aada9392f0 vim +375 net/rxrpc/call_object.c b7a7d6740803284 net/rxrpc/call_object.c David Howells 2020-07-02 244 17926a79320afa9 net/rxrpc/ar-call.c David Howells 2007-04-26 245 /* 540b1c48c37ac0a net/rxrpc/call_object.c David Howells 2017-02-27 246 * Set up a call for the given parameters. 540b1c48c37ac0a net/rxrpc/call_object.c David Howells 2017-02-27 247 * - Called with the socket lock held, which it must release. 540b1c48c37ac0a net/rxrpc/call_object.c David Howells 2017-02-27 248 * - If it returns a call, the call's lock will need releasing by the caller. 17926a79320afa9 net/rxrpc/ar-call.c David Howells 2007-04-26 249 */ 2341e0775747864 net/rxrpc/ar-call.c David Howells 2016-06-09 250 struct rxrpc_call *rxrpc_new_client_call(struct rxrpc_sock *rx, 19ffa01c9c45861 net/rxrpc/call_object.c David Howells 2016-04-04 251 struct rxrpc_conn_parameters *cp, 999b69f89241c93 net/rxrpc/call_object.c David Howells 2016-06-17 252 struct sockaddr_rxrpc *srx, 4812417894770f8 net/rxrpc/call_object.c David Howells 2017-11-24 253 struct rxrpc_call_params *p, a25e21f0bcd2567 net/rxrpc/call_object.c David Howells 2018-03-27 254 gfp_t gfp, a25e21f0bcd2567 net/rxrpc/call_object.c David Howells 2018-03-27 255 unsigned int debug_id) 540b1c48c37ac0a net/rxrpc/call_object.c David Howells 2017-02-27 256 __releases(>sk.sk_lock.slock) 88f2a8257c9aa7d net/rxrpc/call_object.c David Howells 2018-03-30 257 __acquires(>user_mutex) 17926a79320afa9 net/rxrpc/ar-call.c David Howells 2007-04-26 258 { 2341e0775747864 net/rxrpc/ar-call.c David Howells 2016-06-09 259 struct rxrpc_call *call, *xcall; d3be4d244330f7e net/rxrpc/call_object.c David Howells 2018-03-30 260 struct rxrpc_net *rxnet; b7a7d6740803284 net/rxrpc/call_object.c David Howells 2020-07-02 261 struct semaphore *limiter; 2341e0775747864 net/rxrpc/ar-call.c David Howells 2016-06-09 262 struct rb_node *parent, **pp; e34d4234b0b77a8 net/rxrpc/call_object.c David Howells 2016-08-30 263 const void *here = __builtin_return_address(0); 999b69f89241c93 net/rxrpc/call_object.c David Howells 2016-06-17 264 int ret; 17926a79320afa9 net/rxrpc/ar-call.c David Howells 2007-04-26 265 4812417894770f8 net/rxrpc/call_object.c David Howells 2017-11-24 266 _enter("%p,%lx", rx, p->user_call_ID); 17926a79320afa9 net/rxrpc/ar-call.c David Howells 2007-04-26 267 b7a7d6740803284 net/rxrpc/call_object.c David Howells 2020-07-02 268 limiter = rxrpc_get_call_slot(p, gfp); b7a7d6740803284 net/rxrpc/call_object.c David Howells 2020-07-02 269 if (!limiter) b7a7d6740803284 net/rxrpc/call_object.c David Howells 2020-07-02 270 return ERR_PTR(-ERESTARTSYS); b7a7d6740803284 net/rxrpc/call_object.c David Howells 2020-07-02 271 a25e21f0bcd2567 net/rxrpc/call_object.c David Howells 2018-03-27 272 call = rxrpc_alloc_client_call(rx, srx, gfp, debug_id); 2341e0775747864 net/rxrpc/ar-call.c David Howells 2016-06-09 273 if (IS_ERR(call)) { 540b1c48c37ac0a net/rxrpc/call_object.c David Howells 2017-02-27 274 release_sock(>sk); b7a7d6740803284 net/rxrpc/call_object.c David Howells 2020-07-02 275 up(limiter); 2341e0775747864 net/rxrpc/ar-call.c David Howells 2016-06-09 276 _leave(" = %ld", PTR_ERR(call)); 2341e0775747864 net/rxrpc/ar-call.c David Howells 2016-06-09 277 return call; 17926a79320afa9 net/rxrpc/ar-call.c David Howells 2007-04-26 278 } 17926a79320afa9 net/rxrpc/ar-call.c David Howells 2007-04-26 279 e138aa7d3271ac1 net/rxrpc/call_object.c David Howells 2020-03-13 280 call->interruptibility = p-
[kbuild] include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in 'am335x_tscadc_need_adc' - unexpected unlock
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Nicholas Piggin CC: Peter Zijlstra CC: "Steven Rostedt (VMware)" CC: Thomas Gleixner tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: 044d0d6de9f50192f9697583504a382347ee95ca lockdep: Only trace IRQ edges date: 2 weeks ago :: branch date: 11 hours ago :: commit date: 2 weeks ago config: parisc-randconfig-s031-20200911 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty git checkout 044d0d6de9f50192f9697583504a382347ee95ca # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) drivers/mfd/ti_am335x_tscadc.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/umh.h, include/linux/kmod.h, ...): >> include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in >> 'am335x_tscadc_need_adc' - unexpected unlock # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=044d0d6de9f50192f9697583504a382347ee95ca git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 044d0d6de9f50192f9697583504a382347ee95ca vim +/am335x_tscadc_need_adc +404 include/linux/spinlock.h c2f21ce2e31286 Thomas Gleixner 2009-12-02 401 3490565b633c70 Denys Vlasenko 2015-07-13 402 static __always_inline void spin_unlock_irq(spinlock_t *lock) c2f21ce2e31286 Thomas Gleixner 2009-12-02 403 { c2f21ce2e31286 Thomas Gleixner 2009-12-02 @404 raw_spin_unlock_irq(>rlock); c2f21ce2e31286 Thomas Gleixner 2009-12-02 405 } c2f21ce2e31286 Thomas Gleixner 2009-12-02 406 :: The code at line 404 was first introduced by commit :: c2f21ce2e31286a0a32f8da0a7856e9ca1122ef3 locking: Implement new raw_spinlock :: TO: Thomas Gleixner :: CC: Thomas Gleixner --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] include/linux/spinlock.h:408:9: sparse: sparse: context imbalance in 'destroy_id_handler_unlock' - wrong count at exit
CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Jason Gunthorpe CC: Leon Romanovsky tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 581cb3a26baf846ee9636214afaa5333919875b1 commit: f6a9d47ae6854980fc4b1676f1fe9f9fa45ea4e2 RDMA/cma: Execute rdma_cm destruction from a handler properly date: 6 weeks ago :: branch date: 10 hours ago :: commit date: 6 weeks ago config: parisc-randconfig-s031-20200911 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty git checkout f6a9d47ae6854980fc4b1676f1fe9f9fa45ea4e2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) drivers/infiniband/core/cma.c: note: in included file (through include/linux/swait.h, include/linux/completion.h): >> include/linux/spinlock.h:408:9: sparse: sparse: context imbalance in >> 'destroy_id_handler_unlock' - wrong count at exit drivers/infiniband/core/cma.c:1876:6: sparse: sparse: context imbalance in 'rdma_destroy_id' - unexpected unlock drivers/infiniband/core/cma.c:2016:17: sparse: sparse: context imbalance in 'cma_ib_handler' - unexpected unlock drivers/infiniband/core/cma.c:2207:17: sparse: sparse: context imbalance in 'cma_ib_req_handler' - unexpected unlock drivers/infiniband/core/cma.c:2331:17: sparse: sparse: context imbalance in 'cma_iw_handler' - unexpected unlock drivers/infiniband/core/cma.c:2379:17: sparse: sparse: context imbalance in 'iw_conn_req_handler' - unexpected unlock drivers/infiniband/core/cma.c:2647:17: sparse: sparse: context imbalance in 'cma_work_handler' - unexpected unlock drivers/infiniband/core/cma.c:2670:17: sparse: sparse: context imbalance in 'cma_ndev_work_handler' - unexpected unlock drivers/infiniband/core/cma.c:3154:17: sparse: sparse: context imbalance in 'addr_handler' - unexpected unlock drivers/infiniband/core/cma.c:3808:17: sparse: sparse: context imbalance in 'cma_sidr_rep_handler' - unexpected unlock drivers/infiniband/core/cma.c:4339:17: sparse: sparse: context imbalance in 'cma_ib_mc_handler' - unexpected unlock # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f6a9d47ae6854980fc4b1676f1fe9f9fa45ea4e2 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout f6a9d47ae6854980fc4b1676f1fe9f9fa45ea4e2 vim +/destroy_id_handler_unlock +408 include/linux/spinlock.h c2f21ce2e31286 Thomas Gleixner 2009-12-02 405 3490565b633c70 Denys Vlasenko 2015-07-13 406 static __always_inline void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags) c2f21ce2e31286 Thomas Gleixner 2009-12-02 407 { c2f21ce2e31286 Thomas Gleixner 2009-12-02 @408 raw_spin_unlock_irqrestore(>rlock, flags); c2f21ce2e31286 Thomas Gleixner 2009-12-02 409 } c2f21ce2e31286 Thomas Gleixner 2009-12-02 410 :: The code at line 408 was first introduced by commit :: c2f21ce2e31286a0a32f8da0a7856e9ca1122ef3 locking: Implement new raw_spinlock :: TO: Thomas Gleixner :: CC: Thomas Gleixner --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org