[kbuild] Re: [RFC PATCH 2/2] iov_iter: Drop the X argument from iterate_all_kinds() and use B instead
CC: kbuild-...@lists.01.org
In-Reply-To:
<161799186664.847742.14555840742293852768.st...@warthog.procyon.org.uk>
References:
<161799186664.847742.14555840742293852768.st...@warthog.procyon.org.uk>
TO: David Howells
Hi David,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on next-20210409]
[cannot apply to linus/master v5.12-rc6 v5.12-rc5 v5.12-rc4 v5.12-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/David-Howells/iov_iter-Remove-iov_iter_for_each_range/20210410-021151
base:e99d8a8495175df8cb8b739f8cf9b0fc9d0cd3b5
:: branch date: 5 hours ago
:: commit date: 5 hours ago
config: microblaze-randconfig-s031-20210409 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
#
https://github.com/0day-ci/linux/commit/3a86123438f2aac6764901c8462752f378c958c0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
David-Howells/iov_iter-Remove-iov_iter_for_each_range/20210410-021151
git checkout 3a86123438f2aac6764901c8462752f378c958c0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> lib/iov_iter.c:1481:9: sparse: sparse: context imbalance in
>> 'iov_iter_get_pages' - different lock contexts for basic block
>> lib/iov_iter.c:1607:9: sparse: sparse: context imbalance in
>> 'iov_iter_get_pages_alloc' - different lock contexts for basic block
lib/iov_iter.c: note: in included file:
include/net/checksum.h:31:39: sparse: sparse: incorrect type in argument 3
(different base types) @@ expected restricted __wsum [usertype] sum @@
got unsigned int @@
include/net/checksum.h:31:39: sparse: expected restricted __wsum
[usertype] sum
include/net/checksum.h:31:39: sparse: got unsigned int
include/net/checksum.h:39:45: sparse: sparse: incorrect type in argument 3
(different base types) @@ expected restricted __wsum [usertype] sum @@
got unsigned int @@
include/net/checksum.h:39:45: sparse: expected restricted __wsum
[usertype] sum
include/net/checksum.h:39:45: sparse: got unsigned int
>> lib/iov_iter.c:1818:5: sparse: sparse: context imbalance in
>> 'iov_iter_npages' - different lock contexts for basic block
vim +/iov_iter_get_pages +1481 lib/iov_iter.c
788abcfb66c10d lib/iov_iter.c David Howells 2020-02-10 1480
62a8067a7f35db mm/iov_iter.c Al Viro2014-04-04 @1481 ssize_t
iov_iter_get_pages(struct iov_iter *i,
2c80929c4c4d54 mm/iov_iter.c Miklos Szeredi 2014-09-24 1482
struct page **pages, size_t maxsize, unsigned maxpages,
62a8067a7f35db mm/iov_iter.c Al Viro2014-04-04 1483
size_t *start)
62a8067a7f35db mm/iov_iter.c Al Viro2014-04-04 1484 {
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1485 if (maxsize >
i->count)
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1486 maxsize
= i->count;
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1487
00e23707442a75 lib/iov_iter.c David Howells 2018-10-22 1488 if
(unlikely(iov_iter_is_pipe(i)))
241699cd72a848 lib/iov_iter.c Al Viro2016-09-22 1489 return
pipe_get_pages(i, pages, maxsize, maxpages, start);
788abcfb66c10d lib/iov_iter.c David Howells 2020-02-10 1490 if
(unlikely(iov_iter_is_xarray(i)))
788abcfb66c10d lib/iov_iter.c David Howells 2020-02-10 1491 return
iter_xarray_get_pages(i, pages, maxsize, maxpages, start);
9ea9ce0427aab0 lib/iov_iter.c David Howells 2018-10-20 1492 if
(unlikely(iov_iter_is_discard(i)))
9ea9ce0427aab0 lib/iov_iter.c David Howells 2018-10-20 1493 return
-EFAULT;
9ea9ce0427aab0 lib/iov_iter.c David Howells 2018-10-20 1494
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1495
iterate_all_kinds(i, maxsize, v, ({
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1496
unsigned long addr = (unsigned long)v.iov_base;
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1497 size_t
len = v.iov_len + (*start = addr & (PAGE_SIZE - 1));
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1498 int n;
e5393fae3b49e8 mm/iov_iter.c Al Viro2014-11-27 1499 int
[kbuild] [linux-next:master 615/11648] drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
CC: kbuild-...@lists.01.org
CC: Linux Memory Management List
TO: Maxime Ripard
CC: Laurent Pinchart
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e99d8a8495175df8cb8b739f8cf9b0fc9d0cd3b5
commit: dec92020671c48da231189eb06a5f755f492f87f [615/11648] drm: Use the state
pointer directly in planes atomic_check
:: branch date: 11 hours ago
:: commit date: 6 weeks ago
config: arm-randconfig-m031-20210409 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn:
variable dereferenced before check 'state' (see line 111)
vim +/state +124 drivers/gpu/drm/armada/armada_plane.c
d40af7b1ae23da7 Russell King 2018-07-30 107
d40af7b1ae23da7 Russell King 2018-07-30 108 int
armada_drm_plane_atomic_check(struct drm_plane *plane,
7c11b99a8e58c08 Maxime Ripard 2021-02-19 109 struct drm_atomic_state *state)
d40af7b1ae23da7 Russell King 2018-07-30 110 {
7c11b99a8e58c08 Maxime Ripard 2021-02-19 @111 struct drm_plane_state
*new_plane_state = drm_atomic_get_new_plane_state(state,
7c11b99a8e58c08 Maxime Ripard 2021-02-19 112
plane);
ba5c1649465d40a Maxime Ripard 2021-02-19 113 struct armada_plane_state *st =
to_armada_plane_state(new_plane_state);
ba5c1649465d40a Maxime Ripard 2021-02-19 114 struct drm_crtc *crtc =
new_plane_state->crtc;
d40af7b1ae23da7 Russell King 2018-07-30 115 struct drm_crtc_state
*crtc_state;
1d1547ec12bc7d4 Russell King 2019-01-25 116 bool interlace;
1d1547ec12bc7d4 Russell King 2019-01-25 117 int ret;
1d1547ec12bc7d4 Russell King 2019-01-25 118
ba5c1649465d40a Maxime Ripard 2021-02-19 119 if (!new_plane_state->fb ||
WARN_ON(!new_plane_state->crtc)) {
ba5c1649465d40a Maxime Ripard 2021-02-19 120
new_plane_state->visible = false;
1d1547ec12bc7d4 Russell King 2019-01-25 121 return 0;
1d1547ec12bc7d4 Russell King 2019-01-25 122 }
d40af7b1ae23da7 Russell King 2018-07-30 123
dec92020671c48d Maxime Ripard 2021-02-19 @124 if (state)
dec92020671c48d Maxime Ripard 2021-02-19 125 crtc_state =
drm_atomic_get_existing_crtc_state(state,
ba5c1649465d40a Maxime Ripard 2021-02-19 126
crtc);
d40af7b1ae23da7 Russell King 2018-07-30 127 else
d40af7b1ae23da7 Russell King 2018-07-30 128 crtc_state =
crtc->state;
1d1547ec12bc7d4 Russell King 2019-01-25 129
ba5c1649465d40a Maxime Ripard 2021-02-19 130 ret =
drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
ba5c1649465d40a Maxime Ripard 2021-02-19 131
0,
1d1547ec12bc7d4 Russell King 2019-01-25 132
INT_MAX, true, false);
1d1547ec12bc7d4 Russell King 2019-01-25 133 if (ret)
1d1547ec12bc7d4 Russell King 2019-01-25 134 return ret;
1d1547ec12bc7d4 Russell King 2019-01-25 135
1d1547ec12bc7d4 Russell King 2019-01-25 136 interlace =
crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE;
1d1547ec12bc7d4 Russell King 2019-01-25 137 if (interlace) {
ba5c1649465d40a Maxime Ripard 2021-02-19 138 if
((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1)
1d1547ec12bc7d4 Russell King 2019-01-25 139 return -EINVAL;
ba5c1649465d40a Maxime Ripard 2021-02-19 140 st->src_hw =
drm_rect_height(_plane_state->src) >> 17;
ba5c1649465d40a Maxime Ripard 2021-02-19 141 st->dst_yx =
new_plane_state->dst.y1 >> 1;
ba5c1649465d40a Maxime Ripard 2021-02-19 142 st->dst_hw =
drm_rect_height(_plane_state->dst) >> 1;
d40af7b1ae23da7 Russell King 2018-07-30 143 } else {
ba5c1649465d40a Maxime Ripard 2021-02-19 144 st->src_hw =
drm_rect_height(_plane_state->src) >> 16;
ba5c1649465d40a Maxime Ripard 2021-02-19 145 st->dst_yx =
new_plane_state->dst.y1;
ba5c1649465d40a Maxime Ripard 2021-02-19 146 st->dst_hw =
drm_rect_height(_plane_state->dst);
d40af7b1ae23da7 Russell King 2018-07-30 147 }
1d1547ec12bc7d4 Russell King 2019-01-25 148
1d1547ec12bc7d4 Russell King 2019-01-25 149 st->src_hw <<= 16;
ba5c1649465d40a Maxime Ripard 2021-02-19 150 st->src_hw |=
drm_rect_width(_plane_state->src) >> 16;
1d1547ec12bc7d4 Russell King 2019-01-25 151 st->dst_yx <<= 16;
ba5c1649465d40a Maxime Ripard 2021-02-19 152 st->dst_yx |=
new_plane_state->dst.x1 & 0x;
1d1547ec12bc7d4 Russell King 2019-01-25 153 st->dst_hw <<= 16;
ba5c1649465d40a Maxime Ripard 2021-02-19 154 st->dst_hw |
[kbuild] [xlnx:master 59/60] drivers/mtd/spi-nor/spi-nor.c:2642:3-19: duplicated argument to & or |
CC: kbuild-...@lists.01.org
CC: linux-arm-ker...@lists.infradead.org
TO: Vishal Sagar
CC: Michal Simek
CC: Hyun Kwon
Hi Vishal,
First bad commit (maybe != root cause):
tree: https://github.com/Xilinx/linux-xlnx master
head: 043f8a226a752a1dd11f7ff64cee6dbe7334d394
commit: c0b33b8ccd38096c815f2dd39746044d0aa079d3 [59/60] staging: xlnxsync: Fix
the uapi header license
:: branch date: 11 months ago
:: commit date: 11 months ago
config: i386-randconfig-c001-20210409 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Julia Lawall
cocci warnings: (new ones prefixed by >>)
>> drivers/mtd/spi-nor/spi-nor.c:2642:3-19: duplicated argument to & or |
vim +2642 drivers/mtd/spi-nor/spi-nor.c
48e4d973aefeea Boris Brezillon 2019-08-24 2447
b199489d37b21c Huang Shijie 2014-02-24 2448 /* NOTE: double
check command sets and memory organization when you add
b199489d37b21c Huang Shijie 2014-02-24 2449 * more nor chips.
This current list focusses on newer chips, which
b199489d37b21c Huang Shijie 2014-02-24 2450 * have been
converging on command sets which including JEDEC ID.
c19900edff983c Rafał Miłecki 2015-04-25 2451 *
c19900edff983c Rafał Miłecki 2015-04-25 2452 * All newly added
entries should describe *hardware* and should use SECT_4K
c19900edff983c Rafał Miłecki 2015-04-25 2453 * (or SECT_4K_PMC)
if hardware supports erasing 4 KiB sectors. For usage
c19900edff983c Rafał Miłecki 2015-04-25 2454 * scenarios
excluding small sectors there is config option that can be
c19900edff983c Rafał Miłecki 2015-04-25 2455 * disabled:
CONFIG_MTD_SPI_NOR_USE_4K_SECTORS.
c19900edff983c Rafał Miłecki 2015-04-25 2456 * For historical
(and compatibility) reasons (before we got above config) some
c19900edff983c Rafał Miłecki 2015-04-25 2457 * old entries may
be missing 4K flag.
b199489d37b21c Huang Shijie 2014-02-24 2458 */
06bb6f5a69dfc5 Rafał Miłecki 2015-08-10 2459 static const struct
flash_info spi_nor_ids[] = {
b199489d37b21c Huang Shijie 2014-02-24 2460 /* Atmel --
some are (confusingly) marketed as "DataFlash" */
b199489d37b21c Huang Shijie 2014-02-24 2461 { "at25fs010",
INFO(0x1f6601, 0, 32 * 1024, 4, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2462 { "at25fs040",
INFO(0x1f6604, 0, 64 * 1024, 8, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2463
b199489d37b21c Huang Shijie 2014-02-24 2464 { "at25df041a",
INFO(0x1f4401, 0, 64 * 1024, 8, SECT_4K) },
b08618c929b289 Jagan Teki2016-07-26 2465 { "at25df321",
INFO(0x1f4700, 0, 64 * 1024, 64, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2466 { "at25df321a",
INFO(0x1f4701, 0, 64 * 1024, 64, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2467 { "at25df641",
INFO(0x1f4800, 0, 64 * 1024, 128, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2468
b199489d37b21c Huang Shijie 2014-02-24 2469 { "at26f004",
INFO(0x1f0400, 0, 64 * 1024, 8, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2470 { "at26df081a",
INFO(0x1f4501, 0, 64 * 1024, 16, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2471 { "at26df161a",
INFO(0x1f4601, 0, 64 * 1024, 32, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2472 { "at26df321",
INFO(0x1f4700, 0, 64 * 1024, 64, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2473
b199489d37b21c Huang Shijie 2014-02-24 2474 { "at45db081d",
INFO(0x1f2500, 0, 64 * 1024, 16, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2475
b199489d37b21c Huang Shijie 2014-02-24 2476 /* EON --
en25xxx */
b199489d37b21c Huang Shijie 2014-02-24 2477 { "en25f32",
INFO(0x1c3116, 0, 64 * 1024, 64, SECT_4K) },
b199489d37b21c Huang Shijie 2014-02-24 2478 { "en25p32",
INFO(0x1c2016, 0, 64 * 1024, 64, 0) },
b199489d37b21c Huang Shijie 2014-02-24 2479 { "en25q32b",
INFO(0x1c3016, 0, 64 * 1024, 64, 0) },
b199489d37b21c Huang Shijie 2014-02-24 2480 { "en25p64",
INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
b199489d37b21c Huang Shijie 2014-02-24 2481 { "en25q64",
INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },
08326d8a9472c0 Frieder Schrempf 2019-02-18 2482 { &q
[kbuild] [intel-linux-intel-lts:4.19/android_r 19120/22631] arch/x86/kernel/smp.c:273:1: sparse: sparse: unused label 'finish'
CC: kbuild-...@lists.01.org
TO: Alistair Delva
CC: "Pan, Kris"
tree: https://github.com/intel/linux-intel-lts.git 4.19/android_r
head: 072f407465e8e25a3c2c22590e1ab72ccf335151
commit: b652a52d36a85d1b731921ba08e701d7150ce200 [19120/22631] Merge branch
'aosp/android-4.19-stable' into android_r
:: branch date: 10 days ago
:: commit date: 8 months ago
config: x86_64-randconfig-s021-20210409 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
#
https://github.com/intel/linux-intel-lts/commit/b652a52d36a85d1b731921ba08e701d7150ce200
git remote add intel-linux-intel-lts
https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 4.19/android_r
git checkout b652a52d36a85d1b731921ba08e701d7150ce200
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/smp.c:273:1: sparse: sparse: unused label 'finish'
arch/x86/kernel/smp.c:190:16: warning: no previous prototype for
'smp_reboot_interrupt' [-Wmissing-prototypes]
190 | __visible void smp_reboot_interrupt(struct pt_regs *regs)
|^~~~
arch/x86/kernel/smp.c: In function 'native_stop_other_cpus':
arch/x86/kernel/smp.c:273:1: warning: label 'finish' defined but not used
[-Wunused-label]
273 | finish:
| ^~
arch/x86/kernel/smp.c: At top level:
arch/x86/kernel/smp.c:285:28: warning: no previous prototype for
'smp_reschedule_interrupt' [-Wmissing-prototypes]
285 | __visible void __irq_entry smp_reschedule_interrupt(struct pt_regs
*regs)
|^~~~
arch/x86/kernel/smp.c:306:28: warning: no previous prototype for
'smp_call_function_interrupt' [-Wmissing-prototypes]
306 | __visible void __irq_entry smp_call_function_interrupt(struct
pt_regs *regs)
|^~~
arch/x86/kernel/smp.c:316:28: warning: no previous prototype for
'smp_call_function_single_interrupt' [-Wmissing-prototypes]
316 | __visible void __irq_entry smp_call_function_single_interrupt(struct
pt_regs *r)
|^~
vim +/finish +273 arch/x86/kernel/smp.c
ce7fdd5cd83e0a Grzegorz Halat 2019-06-28 204
5d2b86d90f7cc4 Don Zickus 2012-05-11 205 static void
native_stop_other_cpus(int wait)
f9e47a126be2ea Glauber Costa 2008-03-03 206 {
f9e47a126be2ea Glauber Costa 2008-03-03 207 unsigned long flags;
76fac077db6b34 Alok Kataria 2010-10-11 208 unsigned long timeout;
f9e47a126be2ea Glauber Costa 2008-03-03 209
f9e47a126be2ea Glauber Costa 2008-03-03 210 if (reboot_force)
f9e47a126be2ea Glauber Costa 2008-03-03 211 return;
f9e47a126be2ea Glauber Costa 2008-03-03 212
4ef702c10b5df1 Andi Kleen 2009-05-27 213 /*
4ef702c10b5df1 Andi Kleen 2009-05-27 214* Use an own vector here
because smp_call_function
4ef702c10b5df1 Andi Kleen 2009-05-27 215* does lots of things not
suitable in a panic situation.
7d007d21e539db Don Zickus 2012-05-11 216*/
7d007d21e539db Don Zickus 2012-05-11 217
7d007d21e539db Don Zickus 2012-05-11 218 /*
7d007d21e539db Don Zickus 2012-05-11 219* We start by using the
REBOOT_VECTOR irq.
7d007d21e539db Don Zickus 2012-05-11 220* The irq is treated as a sync
point to allow critical
7d007d21e539db Don Zickus 2012-05-11 221* regions of code on other
cpus to release their spin locks
7d007d21e539db Don Zickus 2012-05-11 222* and re-enable irqs. Jumping
straight to an NMI might
7d007d21e539db Don Zickus 2012-05-11 223* accidentally cause deadlocks
with further shutdown/panic
7d007d21e539db Don Zickus 2012-05-11 224* code. By syncing, we give
the cpus up to one second to
7d007d21e539db Don Zickus 2012-05-11 225* finish their work before we
force them off with the NMI.
4ef702c10b5df1 Andi Kleen 2009-05-27 226*/
4ef702c10b5df1 Andi Kleen 2009-05-27 227 if (num_online_cpus() > 1) {
7d007d21e539db Don Zickus 2012-05-11 228 /* did someone beat us
here? */
7d007d21e539db Don Zickus 2012-05-11 229 if
(atomic_cmpxchg(_cpu, -1, safe_smp_processor_id()) != -1)
7d007d21e539db Don Zickus 2012-05-11 230 return;
7d007d21e539db Don Zickus 2012-05-11 231
7d007d21e539db Don Zickus 2012-05-11 232 /* sync above data
before sending IRQ */
7d007d21e539db Don Zickus 2012-05-11 233 wmb();
7d007d21e539db Don Zickus 2012-05-11 234
4ef702c10b5df1 Andi
[kbuild] [ext4:dev 16/17] fs/ext4/mballoc.c:2966:13: sparse: sparse: context imbalance in 'ext4_mb_seq_structs_summary_start' - wrong count at exit
CC: kbuild-...@lists.01.org
CC: linux-e...@vger.kernel.org
TO: Harshad Shirwadkar
CC: "Theodore Ts'o"
CC: Andreas Dilger
CC: Ritesh Harjani
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
head: 21175ca434c5d49509b73cf473618b01b0b85437
commit: f68f4063855903fd3a279e646451eab04db0655f [16/17] ext4: add proc files
to monitor new structures
:: branch date: 4 hours ago
:: commit date: 4 hours ago
config: x86_64-randconfig-s021-20210409 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?id=f68f4063855903fd3a279e646451eab04db0655f
git remote add ext4
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
git fetch --no-tags ext4 dev
git checkout f68f4063855903fd3a279e646451eab04db0655f
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
fs/ext4/mballoc.c:2532:9: sparse: sparse: context imbalance in
'ext4_mb_good_group_nolock' - different lock contexts for basic block
>> fs/ext4/mballoc.c:2966:13: sparse: sparse: context imbalance in
>> 'ext4_mb_seq_structs_summary_start' - wrong count at exit
fs/ext4/mballoc.c:3038:13: sparse: sparse: context imbalance in
'ext4_mb_seq_structs_summary_stop' - unexpected unlock
vim +/ext4_mb_seq_structs_summary_start +2966 fs/ext4/mballoc.c
a6c75eaf11032f Harshad Shirwadkar 2021-04-01 2965
f68f4063855903 Harshad Shirwadkar 2021-04-01 @2966 static void
*ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos)
f68f4063855903 Harshad Shirwadkar 2021-04-01 2967 {
f68f4063855903 Harshad Shirwadkar 2021-04-01 2968 struct super_block *sb
= PDE_DATA(file_inode(seq->file));
f68f4063855903 Harshad Shirwadkar 2021-04-01 2969 unsigned long position;
f68f4063855903 Harshad Shirwadkar 2021-04-01 2970
f68f4063855903 Harshad Shirwadkar 2021-04-01 2971
read_lock(_SB(sb)->s_mb_rb_lock);
f68f4063855903 Harshad Shirwadkar 2021-04-01 2972
f68f4063855903 Harshad Shirwadkar 2021-04-01 2973 if (*pos < 0 || *pos >=
MB_NUM_ORDERS(sb) + 1)
f68f4063855903 Harshad Shirwadkar 2021-04-01 2974 return NULL;
f68f4063855903 Harshad Shirwadkar 2021-04-01 2975 position = *pos + 1;
f68f4063855903 Harshad Shirwadkar 2021-04-01 2976 return (void *)
((unsigned long) position);
f68f4063855903 Harshad Shirwadkar 2021-04-01 2977 }
f68f4063855903 Harshad Shirwadkar 2021-04-01 2978
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 8382/11648] mm/shmem.c:2478:9: sparse: sparse: context imbalance in 'shmem_mcopy_atomic_pte' - different lock contexts for basic block
CC: kbuild-...@lists.01.org
CC: Linux Memory Management List
TO: Axel Rasmussen
CC: Andrew Morton
CC: Linux Memory Management List
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e99d8a8495175df8cb8b739f8cf9b0fc9d0cd3b5
commit: a311f80f1475642eea71c635c368043783c22f4a [8382/11648] userfaultfd:
support minor fault handling for shmem
:: branch date: 6 hours ago
:: commit date: 9 days ago
config: parisc-randconfig-s031-20210409 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a311f80f1475642eea71c635c368043783c22f4a
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout a311f80f1475642eea71c635c368043783c22f4a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> mm/shmem.c:2478:9: sparse: sparse: context imbalance in
>> 'shmem_mcopy_atomic_pte' - different lock contexts for basic block
vim +/shmem_mcopy_atomic_pte +2478 mm/shmem.c
^1da177e4c3f41 Linus Torvalds2005-04-16 2361
a311f80f147564 Axel Rasmussen2021-04-01 2362 int
shmem_mcopy_atomic_pte(struct mm_struct *dst_mm, pmd_t *dst_pmd,
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2363
struct vm_area_struct *dst_vma,
a311f80f147564 Axel Rasmussen2021-04-01 2364
unsigned long dst_addr, unsigned long src_addr,
a311f80f147564 Axel Rasmussen2021-04-01 2365 enum
mcopy_atomic_mode mode, struct page **pagep)
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2366 {
a311f80f147564 Axel Rasmussen2021-04-01 2367 bool is_continue =
(mode == MCOPY_ATOMIC_CONTINUE);
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2368 struct inode *inode =
file_inode(dst_vma->vm_file);
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2369 struct shmem_inode_info
*info = SHMEM_I(inode);
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2370 struct address_space
*mapping = inode->i_mapping;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2371 gfp_t gfp =
mapping_gfp_mask(mapping);
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2372 pgoff_t pgoff =
linear_page_index(dst_vma, dst_addr);
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2373 spinlock_t *ptl;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2374 void *page_kaddr;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2375 struct page *page;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2376 pte_t _dst_pte,
*dst_pte;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2377 int ret;
e2a50c1f64145a Andrea Arcangeli 2018-11-30 2378 pgoff_t offset, max_off;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2379
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2380 ret = -ENOMEM;
0f0796945614b7 Mike Rapoport 2017-09-06 2381 if
(!shmem_inode_acct_block(inode, 1))
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2382 goto out;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2383
a311f80f147564 Axel Rasmussen2021-04-01 2384 if (is_continue) {
a311f80f147564 Axel Rasmussen2021-04-01 2385 ret = -EFAULT;
a311f80f147564 Axel Rasmussen2021-04-01 2386 page =
find_lock_page(mapping, pgoff);
a311f80f147564 Axel Rasmussen2021-04-01 2387 if (!page)
a311f80f147564 Axel Rasmussen2021-04-01 2388 goto
out_unacct_blocks;
a311f80f147564 Axel Rasmussen2021-04-01 2389 } else if (!*pagep) {
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2390 page =
shmem_alloc_page(gfp, info, pgoff);
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2391 if (!page)
0f0796945614b7 Mike Rapoport 2017-09-06 2392 goto
out_unacct_blocks;
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2393
a311f80f147564 Axel Rasmussen2021-04-01 2394 if (mode ==
MCOPY_ATOMIC_NORMAL) { /* mcopy_atomic */
4c27fe4c4c84f3 Mike Rapoport 2017-02-22 2395
page_kaddr = kmap_atomic(page);
8d10396342063c Mike Rapoport 2017-09-06 2396 ret =
copy_from_user(page_kaddr,
8d10396342063c Mike Rapoport 2017-09-06 2397
(const void __user *)src_addr,
4c27fe4c4c84f3 Mike
[kbuild] [PATCH] powerpc/64: fix debugfs_simple_attr.cocci warnings
CC: kbuild-...@lists.01.org
CC: Linux Memory Management List
TO: Michael Ellerman
CC: Benjamin Herrenschmidt
CC: Paul Mackerras
CC: Nicholas Piggin
CC: Jordan Niethe
CC: Alistair Popple
CC: Gustavo Walbon
CC: linuxppc-...@lists.ozlabs.org
CC: linux-ker...@vger.kernel.org
From: kernel test robot
arch/powerpc/kernel/security.c:807:0-23: WARNING: fops_entry_flush should be
defined with DEFINE_DEBUGFS_ATTRIBUTE
arch/powerpc/kernel/security.c:781:0-23: WARNING: fops_rfi_flush should be
defined with DEFINE_DEBUGFS_ATTRIBUTE
arch/powerpc/kernel/security.c:833:0-23: WARNING: fops_uaccess_flush should be
defined with DEFINE_DEBUGFS_ATTRIBUTE
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Fixes: c6b4c9147f8b ("powerpc/64: Move security code into security.c")
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e99d8a8495175df8cb8b739f8cf9b0fc9d0cd3b5
commit: c6b4c9147f8b85d159f670d7bce71a93d16062a2 [11082/11648] powerpc/64: Move
security code into security.c
:: branch date: 5 hours ago
:: commit date: 29 hours ago
Please take the patch only if it's a positive warning. Thanks!
security.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
--- a/arch/powerpc/kernel/security.c
+++ b/arch/powerpc/kernel/security.c
@@ -778,7 +778,8 @@ static int rfi_flush_get(void *data, u64
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(fops_rfi_flush, rfi_flush_get, rfi_flush_set,
"%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_rfi_flush, rfi_flush_get, rfi_flush_set,
+"%llu\n");
static int entry_flush_set(void *data, u64 val)
{
@@ -804,7 +805,8 @@ static int entry_flush_get(void *data, u
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(fops_entry_flush, entry_flush_get, entry_flush_set,
"%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_entry_flush, entry_flush_get, entry_flush_set,
+"%llu\n");
static int uaccess_flush_set(void *data, u64 val)
{
@@ -830,13 +832,18 @@ static int uaccess_flush_get(void *data,
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(fops_uaccess_flush, uaccess_flush_get,
uaccess_flush_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_uaccess_flush, uaccess_flush_get,
+uaccess_flush_set, "%llu\n");
static __init int rfi_flush_debugfs_init(void)
{
- debugfs_create_file("rfi_flush", 0600, powerpc_debugfs_root, NULL,
_rfi_flush);
- debugfs_create_file("entry_flush", 0600, powerpc_debugfs_root, NULL,
_entry_flush);
- debugfs_create_file("uaccess_flush", 0600, powerpc_debugfs_root, NULL,
_uaccess_flush);
+ debugfs_create_file_unsafe("rfi_flush", 0600, powerpc_debugfs_root,
+ NULL, _rfi_flush);
+ debugfs_create_file_unsafe("entry_flush", 0600, powerpc_debugfs_root,
+ NULL, _entry_flush);
+ debugfs_create_file_unsafe("uaccess_flush", 0600,
+ powerpc_debugfs_root, NULL,
+ _uaccess_flush);
return 0;
}
device_initcall(rfi_flush_debugfs_init);
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 11082/11648] arch/powerpc/kernel/security.c:807:0-23: WARNING: fops_entry_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE
CC: kbuild-...@lists.01.org CC: Linux Memory Management List TO: Michael Ellerman tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e99d8a8495175df8cb8b739f8cf9b0fc9d0cd3b5 commit: c6b4c9147f8b85d159f670d7bce71a93d16062a2 [11082/11648] powerpc/64: Move security code into security.c :: branch date: 5 hours ago :: commit date: 29 hours ago config: powerpc64-randconfig-c024-20210409 (attached as .config) compiler: powerpc64le-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Julia Lawall cocci warnings: (new ones prefixed by >>) >> arch/powerpc/kernel/security.c:807:0-23: WARNING: fops_entry_flush should be >> defined with DEFINE_DEBUGFS_ATTRIBUTE >> arch/powerpc/kernel/security.c:781:0-23: WARNING: fops_rfi_flush should be >> defined with DEFINE_DEBUGFS_ATTRIBUTE >> arch/powerpc/kernel/security.c:833:0-23: WARNING: fops_uaccess_flush should >> be defined with DEFINE_DEBUGFS_ATTRIBUTE Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 8257/11648] mm/vmalloc.c:214:17: sparse: sparse: context imbalance in 'vmap_pages_pte_range' - different lock contexts for basic block
CC: kbuild-...@lists.01.org
CC: Linux Memory Management List
TO: Nicholas Piggin
CC: Miaohe Lin
CC: Christoph Hellwig
CC: Andrew Morton
CC: Linux Memory Management List
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e99d8a8495175df8cb8b739f8cf9b0fc9d0cd3b5
commit: 0bdcf521468e8d8b2592922fd2bde0d69e651c69 [8257/11648] mm/vmalloc:
rename vmap_*_range vmap_pages_*_range
:: branch date: 4 hours ago
:: commit date: 8 days ago
config: parisc-randconfig-s031-20210409 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0bdcf521468e8d8b2592922fd2bde0d69e651c69
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 0bdcf521468e8d8b2592922fd2bde0d69e651c69
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
mm/vmalloc.c: note: in included file (through include/linux/pgtable.h,
include/linux/mm.h):
arch/parisc/include/asm/pgtable.h:451:9: sparse: sparse: context imbalance
in 'vunmap_pte_range' - different lock contexts for basic block
>> mm/vmalloc.c:214:17: sparse: sparse: context imbalance in
>> 'vmap_pages_pte_range' - different lock contexts for basic block
vim +/vmap_pages_pte_range +214 mm/vmalloc.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 191
0bdcf521468e8d Nicholas Piggin 2021-04-01 192 static int
vmap_pages_pte_range(pmd_t *pmd, unsigned long addr,
2ba3e6947aed9b Joerg Roedel2020-06-01 193 unsigned long
end, pgprot_t prot, struct page **pages, int *nr,
2ba3e6947aed9b Joerg Roedel2020-06-01 194 pgtbl_mod_mask
*mask)
^1da177e4c3f41 Linus Torvalds 2005-04-16 195 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 196 pte_t *pte;
^1da177e4c3f41 Linus Torvalds 2005-04-16 197
db64fe02258f15 Nick Piggin 2008-10-18 198 /*
db64fe02258f15 Nick Piggin 2008-10-18 199 * nr is a running
index into the array which helps higher level
db64fe02258f15 Nick Piggin 2008-10-18 200 * callers keep track
of where we're up to.
db64fe02258f15 Nick Piggin 2008-10-18 201 */
db64fe02258f15 Nick Piggin 2008-10-18 202
2ba3e6947aed9b Joerg Roedel2020-06-01 203 pte =
pte_alloc_kernel_track(pmd, addr, mask);
^1da177e4c3f41 Linus Torvalds 2005-04-16 204 if (!pte)
^1da177e4c3f41 Linus Torvalds 2005-04-16 205 return -ENOMEM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 206 do {
db64fe02258f15 Nick Piggin 2008-10-18 207 struct page
*page = pages[*nr];
db64fe02258f15 Nick Piggin 2008-10-18 208
db64fe02258f15 Nick Piggin 2008-10-18 209 if
(WARN_ON(!pte_none(*pte)))
db64fe02258f15 Nick Piggin 2008-10-18 210 return
-EBUSY;
db64fe02258f15 Nick Piggin 2008-10-18 211 if
(WARN_ON(!page))
^1da177e4c3f41 Linus Torvalds 2005-04-16 212 return
-ENOMEM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 213
set_pte_at(_mm, addr, pte, mk_pte(page, prot));
db64fe02258f15 Nick Piggin 2008-10-18 @214 (*nr)++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 215 } while (pte++, addr +=
PAGE_SIZE, addr != end);
2ba3e6947aed9b Joerg Roedel2020-06-01 216 *mask |=
PGTBL_PTE_MODIFIED;
^1da177e4c3f41 Linus Torvalds 2005-04-16 217 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 218 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 219
:: The code at line 214 was first introduced by commit
:: db64fe02258f1507e13fe5212a989922323685ce mm: rewrite vmap layer
:: TO: Nick Piggin
:: CC: Linus Torvalds
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [chrome-os:chromeos-5.4 12/43] drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c:723 vdec_h264_slice_decode() warn: missing error code 'err'
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel
chromeos-5.4
head: 885f54059e5be0bbd38287623c841b1e4db1aa57
commit: 5fa56a01339db0586f27519d81aa226f1bb49f03 [12/43] FROMLIST: media:
mtk-vcodec: vdec: support stateless H.264 decoding
config: xtensa-randconfig-m031-20210401 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c:723
vdec_h264_slice_decode() warn: missing error code 'err'
vim +/err +723 drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c
5fa56a01339db0 Yunfei Dong 2021-02-26 695 static int
vdec_h264_slice_decode(void *h_vdec, struct mtk_vcodec_mem *bs,
5fa56a01339db0 Yunfei Dong 2021-02-26 696
struct vdec_fb *fb, bool *res_chg)
5fa56a01339db0 Yunfei Dong 2021-02-26 697 {
5fa56a01339db0 Yunfei Dong 2021-02-26 698 struct vdec_h264_slice_inst
*inst =
5fa56a01339db0 Yunfei Dong 2021-02-26 699 (struct
vdec_h264_slice_inst *)h_vdec;
5fa56a01339db0 Yunfei Dong 2021-02-26 700 struct vdec_vpu_inst *vpu =
>vpu;
5fa56a01339db0 Yunfei Dong 2021-02-26 701 struct mtk_video_dec_buf
*src_buf_info;
5fa56a01339db0 Yunfei Dong 2021-02-26 702 int nal_start_idx = 0, err = 0;
5fa56a01339db0 Yunfei Dong 2021-02-26 703 uint32_t nal_type, data[2];
5fa56a01339db0 Yunfei Dong 2021-02-26 704 unsigned char *buf;
5fa56a01339db0 Yunfei Dong 2021-02-26 705 uint64_t y_fb_dma;
5fa56a01339db0 Yunfei Dong 2021-02-26 706 uint64_t c_fb_dma;
5fa56a01339db0 Yunfei Dong 2021-02-26 707
5fa56a01339db0 Yunfei Dong 2021-02-26 708 mtk_vcodec_debug(inst, "+ [%d]
FB y_dma=%llx c_dma=%llx va=%p",
5fa56a01339db0 Yunfei Dong 2021-02-26 709
++inst->num_nalu, y_fb_dma, c_fb_dma, fb);
5fa56a01339db0 Yunfei Dong 2021-02-26 710
5fa56a01339db0 Yunfei Dong 2021-02-26 711 /* bs NULL means flush decoder
*/
5fa56a01339db0 Yunfei Dong 2021-02-26 712 if (bs == NULL)
5fa56a01339db0 Yunfei Dong 2021-02-26 713 return
vpu_dec_reset(vpu);
5fa56a01339db0 Yunfei Dong 2021-02-26 714
5fa56a01339db0 Yunfei Dong 2021-02-26 715 src_buf_info = container_of(bs,
struct mtk_video_dec_buf, bs_buffer);
5fa56a01339db0 Yunfei Dong 2021-02-26 716
5fa56a01339db0 Yunfei Dong 2021-02-26 717 y_fb_dma = fb ?
(u64)fb->base_y.dma_addr : 0;
5fa56a01339db0 Yunfei Dong 2021-02-26 718 c_fb_dma = fb ?
(u64)fb->base_c.dma_addr : 0;
5fa56a01339db0 Yunfei Dong 2021-02-26 719
5fa56a01339db0 Yunfei Dong 2021-02-26 720 buf = (unsigned char *)bs->va;
5fa56a01339db0 Yunfei Dong 2021-02-26 721 nal_start_idx =
find_start_code(buf, bs->size);
5fa56a01339db0 Yunfei Dong 2021-02-26 722 if (nal_start_idx < 0)
5fa56a01339db0 Yunfei Dong 2021-02-26 @723 goto err_free_fb_out;
"err = nal_start_idx;"
5fa56a01339db0 Yunfei Dong 2021-02-26 724
5fa56a01339db0 Yunfei Dong 2021-02-26 725 data[0] = bs->size;
5fa56a01339db0 Yunfei Dong 2021-02-26 726 data[1] = buf[nal_start_idx];
5fa56a01339db0 Yunfei Dong 2021-02-26 727 nal_type =
NAL_TYPE(buf[nal_start_idx]);
5fa56a01339db0 Yunfei Dong 2021-02-26 728 mtk_vcodec_debug(inst, "\n +
NALU[%d] type %d +\n", inst->num_nalu,
5fa56a01339db0 Yunfei Dong 2021-02-26 729 nal_type);
5fa56a01339db0 Yunfei Dong 2021-02-26 730
5fa56a01339db0 Yunfei Dong 2021-02-26 731 inst->vsi_ctx.dec.bs_dma =
(uint64_t)bs->dma_addr;
5fa56a01339db0 Yunfei Dong 2021-02-26 732 inst->vsi_ctx.dec.y_fb_dma =
y_fb_dma;
5fa56a01339db0 Yunfei Dong 2021-02-26 733 inst->vsi_ctx.dec.c_fb_dma =
c_fb_dma;
5fa56a01339db0 Yunfei Dong 2021-02-26 734 inst->vsi_ctx.dec.vdec_fb_va =
(u64)(uintptr_t)fb;
5fa56a01339db0 Yunfei Dong 2021-02-26 735
5fa56a01339db0 Yunfei Dong 2021-02-26 736
get_vdec_decode_parameters(inst);
5fa56a01339db0 Yunfei Dong 2021-02-26 737 *res_chg =
inst->vsi_ctx.dec.resolution_changed;
5fa56a01339db0 Yunfei Dong 2021-02-26 738 if (*res_chg) {
5fa56a01339db0 Yunfei Dong 2021-02-26 739 mtk_vcodec_debug(inst,
"- resolution changed -");
5fa56a01339db0 Yunfei Dong 2021-02-26 740 if
(inst->vsi_ctx.dec.realloc_mv_buf) {
5fa56a01339db0 Yunfei Dong 2021-02-26 741 err =
alloc_mv_buf(inst, &(inst->ctx->picinfo));
5fa56a01339db0 Yunfei Dong 2021-02-26 742
inst->vsi_ctx.dec.realloc_mv_buf = false;
5fa56a01339db0 Yunfei Dong 2021-02-26 743 if (err)
5fa56a01339db0 Yunfei Dong 2021-02-26 744 goto
err_free_fb_out;
5fa56a01339db0 Yunfei Dong 2021-02-26 745 }
5fa56a01339db0 Yunfei Dong 2021-02-26 746 *res_chg = false;
5fa56a01339db0 Yunfei Dong 2021-02-26 747 }
5fa56a01339db0
[kbuild] [mkp-scsi:for-next 304/324] drivers/scsi/smartpqi/smartpqi_sas_transport.c:97 pqi_sas_port_add_rphy() warn: variable dereferenced before check 'pqi_sas_port->device' (see line 95)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head: 857a80bbd7321161f986588160d97815d1b1206a
commit: ec504b23df9d33260602affc50389cf070707c9b [304/324] scsi: smartpqi: Add
phy ID support for the physical drives
config: i386-randconfig-m021-20210406 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/scsi/smartpqi/smartpqi_sas_transport.c:97 pqi_sas_port_add_rphy() warn:
variable dereferenced before check 'pqi_sas_port->device' (see line 95)
vim +97 drivers/scsi/smartpqi/smartpqi_sas_transport.c
6c223761eb5482 Kevin Barnett 2016-06-27 88 static int
pqi_sas_port_add_rphy(struct pqi_sas_port *pqi_sas_port,
6c223761eb5482 Kevin Barnett 2016-06-27 89struct sas_rphy *rphy)
6c223761eb5482 Kevin Barnett 2016-06-27 90 {
6c223761eb5482 Kevin Barnett 2016-06-27 91struct sas_identify *identify;
6c223761eb5482 Kevin Barnett 2016-06-27 92
6c223761eb5482 Kevin Barnett 2016-06-27 93identify = >identify;
6c223761eb5482 Kevin Barnett 2016-06-27 94identify->sas_address =
pqi_sas_port->sas_address;
ec504b23df9d33 Murthy Bhat 2021-03-11 @95identify->phy_identifier =
pqi_sas_port->device->phy_id;
New dereference
3d46a59a191e81 Don Brace 2018-12-07 96
3d46a59a191e81 Don Brace 2018-12-07 @97if (pqi_sas_port->device &&
Checked too late.
3d46a59a191e81 Don Brace 2018-12-07 98
pqi_sas_port->device->is_expander_smp_device) {
3d46a59a191e81 Don Brace 2018-12-07 99
identify->initiator_port_protocols = SAS_PROTOCOL_SMP;
3d46a59a191e81 Don Brace 2018-12-07 100
identify->target_port_protocols = SAS_PROTOCOL_SMP;
3d46a59a191e81 Don Brace 2018-12-07 101} else {
6c223761eb5482 Kevin Barnett 2016-06-27 102
identify->initiator_port_protocols = SAS_PROTOCOL_STP;
6c223761eb5482 Kevin Barnett 2016-06-27 103
identify->target_port_protocols = SAS_PROTOCOL_STP;
3d46a59a191e81 Don Brace 2018-12-07 104}
6c223761eb5482 Kevin Barnett 2016-06-27 105
6c223761eb5482 Kevin Barnett 2016-06-27 106return sas_rphy_add(rphy);
6c223761eb5482 Kevin Barnett 2016-06-27 107 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [hch-block:nvme-generic 13/13] drivers/nvme/host/core.c:4532 nvme_core_init() warn: passing zero to 'PTR_ERR'
tree: git://git.infradead.org/users/hch/block.git nvme-generic
head: 51d5434458b4f2182f4d108c9016ac9402529ee7
commit: 51d5434458b4f2182f4d108c9016ac9402529ee7 [13/13] nvme: introduce
generic per-namespace chardev
config: mips-randconfig-m031-20210408 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/nvme/host/core.c:4532 nvme_core_init() warn: passing zero to 'PTR_ERR'
Old smatch warnings:
drivers/nvme/host/core.c:705 nvme_configure_directives() warn: missing error
code 'ret'
vim +/PTR_ERR +4532 drivers/nvme/host/core.c
893a74b7a76e6e Christoph Hellwig 2019-04-30 4486 static int __init
nvme_core_init(void)
5bae7f73d378a9 Christoph Hellwig 2015-11-28 4487 {
b227c59b9b5b8a Roy Shterman 2018-01-14 4488 int result = -ENOMEM;
5bae7f73d378a9 Christoph Hellwig 2015-11-28 4489
811015409fd4af Christoph Hellwig 2019-04-30 4490 _nvme_check_size();
811015409fd4af Christoph Hellwig 2019-04-30 4491
9a6327d2f25b14 Sagi Grimberg 2017-06-07 4492 nvme_wq =
alloc_workqueue("nvme-wq",
9a6327d2f25b14 Sagi Grimberg 2017-06-07 4493
WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_SYSFS, 0);
9a6327d2f25b14 Sagi Grimberg 2017-06-07 4494 if (!nvme_wq)
b227c59b9b5b8a Roy Shterman 2018-01-14 4495 goto out;
b227c59b9b5b8a Roy Shterman 2018-01-14 4496
b227c59b9b5b8a Roy Shterman 2018-01-14 4497 nvme_reset_wq =
alloc_workqueue("nvme-reset-wq",
b227c59b9b5b8a Roy Shterman 2018-01-14 4498
WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_SYSFS, 0);
b227c59b9b5b8a Roy Shterman 2018-01-14 4499 if (!nvme_reset_wq)
b227c59b9b5b8a Roy Shterman 2018-01-14 4500 goto destroy_wq;
b227c59b9b5b8a Roy Shterman 2018-01-14 4501
b227c59b9b5b8a Roy Shterman 2018-01-14 4502 nvme_delete_wq =
alloc_workqueue("nvme-delete-wq",
b227c59b9b5b8a Roy Shterman 2018-01-14 4503
WQ_UNBOUND | WQ_MEM_RECLAIM | WQ_SYSFS, 0);
b227c59b9b5b8a Roy Shterman 2018-01-14 4504 if (!nvme_delete_wq)
b227c59b9b5b8a Roy Shterman 2018-01-14 4505 goto
destroy_reset_wq;
9a6327d2f25b14 Sagi Grimberg 2017-06-07 4506
f68abd9cc00cce Javier González 2020-12-01 4507 result =
alloc_chrdev_region(_ctrl_base_chr_devt, 0,
f68abd9cc00cce Javier González 2020-12-01 4508
NVME_MINORS, "nvme");
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4509 if (result < 0)
b227c59b9b5b8a Roy Shterman 2018-01-14 4510 goto
destroy_delete_wq;
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4511
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4512 nvme_class =
class_create(THIS_MODULE, "nvme");
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4513 if (IS_ERR(nvme_class))
{
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4514 result =
PTR_ERR(nvme_class);
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4515 goto
unregister_chrdev;
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4516 }
a42f42e5bb84d8 Sagi Grimberg 2019-09-04 4517 nvme_class->dev_uevent
= nvme_class_uevent;
f3ca80fc11c3af Christoph Hellwig 2015-11-28 4518
ab9e00cc72fa4c Christoph Hellwig 2017-11-09 4519 nvme_subsys_class =
class_create(THIS_MODULE, "nvme-subsystem");
ab9e00cc72fa4c Christoph Hellwig 2017-11-09 4520 if
(IS_ERR(nvme_subsys_class)) {
ab9e00cc72fa4c Christoph Hellwig 2017-11-09 4521 result =
PTR_ERR(nvme_subsys_class);
ab9e00cc72fa4c Christoph Hellwig 2017-11-09 4522 goto
destroy_class;
ab9e00cc72fa4c Christoph Hellwig 2017-11-09 4523 }
51d5434458b4f2 Minwoo Im 2021-04-07 4524
51d5434458b4f2 Minwoo Im 2021-04-07 4525 result =
alloc_chrdev_region(_ns_chr_devt, 0, NVME_MINORS,
51d5434458b4f2 Minwoo Im 2021-04-07 4526
"nvme-generic");
51d5434458b4f2 Minwoo Im 2021-04-07 4527 if (result < 0)
51d5434458b4f2 Minwoo Im 2021-04-07 4528 goto
destroy_subsys_class;
51d5434458b4f2 Minwoo Im 2021-04-07 4529
51d5434458b4f2 Minwoo Im 2021-04-07 4530 nvme_ns_chr_class =
class_create(THIS_MODULE, "nvme-generic");
51d5434458b4f2 Minwoo Im 2021-04-07 4531 if
(IS_ERR(nvme_ns_chr_class)) {
51d5434458b4f2 Minwoo Im 2021-04-07 @4532 result =
PTR_ERR(nvme_subsys_class);
This is a copy and paste error. It should be nvme_ns_chr_class.
51d5434458b4f2 Minwoo Im 2021-04-07 4533 goto
unregister_generic_ns;
51d5434458b4f2 Minwoo Im 2021-04-07 4534 }
51d5434458b4f2 Minwoo Im 2021-04-07 4535
5bae7f73d378a9 Christoph Hellwig 2015-11-28 4536 return 0;
f3ca80fc11c3af
[kbuild] Re: [PATCH 1/1] of: unittest: overlay: ensure proper alignment of copied FDT
Hi,
url:
https://github.com/0day-ci/linux/commits/frowand-list-gmail-com/of-unittest-overlay-ensure-proper-alignment-of-copied-FDT/20210408-045317
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-m021-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/of/overlay.c:1045 of_overlay_fdt_apply() warn: overwrite may leak
'new_fdt'
vim +/new_fdt +1045 drivers/of/overlay.c
39a751a4cb7e47 Frank Rowand 2018-02-12 1015 int
of_overlay_fdt_apply(const void *overlay_fdt, u32 overlay_fdt_size,
39a751a4cb7e47 Frank Rowand 2018-02-12 1016int
*ovcs_id)
39a751a4cb7e47 Frank Rowand 2018-02-12 1017 {
7a18fbf9013a19 Frank Rowand 2021-04-07 1018 void *new_fdt;
39a751a4cb7e47 Frank Rowand 2018-02-12 1019 int ret;
39a751a4cb7e47 Frank Rowand 2018-02-12 1020 u32 size;
39a751a4cb7e47 Frank Rowand 2018-02-12 1021 struct device_node
*overlay_root;
39a751a4cb7e47 Frank Rowand 2018-02-12 1022
39a751a4cb7e47 Frank Rowand 2018-02-12 1023 *ovcs_id = 0;
39a751a4cb7e47 Frank Rowand 2018-02-12 1024 ret = 0;
39a751a4cb7e47 Frank Rowand 2018-02-12 1025
39a751a4cb7e47 Frank Rowand 2018-02-12 1026 if (overlay_fdt_size <
sizeof(struct fdt_header) ||
39a751a4cb7e47 Frank Rowand 2018-02-12 1027
fdt_check_header(overlay_fdt)) {
39a751a4cb7e47 Frank Rowand 2018-02-12 1028 pr_err("Invalid
overlay_fdt header\n");
39a751a4cb7e47 Frank Rowand 2018-02-12 1029 return -EINVAL;
39a751a4cb7e47 Frank Rowand 2018-02-12 1030 }
39a751a4cb7e47 Frank Rowand 2018-02-12 1031
39a751a4cb7e47 Frank Rowand 2018-02-12 1032 size =
fdt_totalsize(overlay_fdt);
39a751a4cb7e47 Frank Rowand 2018-02-12 1033 if (overlay_fdt_size <
size)
39a751a4cb7e47 Frank Rowand 2018-02-12 1034 return -EINVAL;
39a751a4cb7e47 Frank Rowand 2018-02-12 1035
39a751a4cb7e47 Frank Rowand 2018-02-12 1036 /*
39a751a4cb7e47 Frank Rowand 2018-02-12 1037* Must create
permanent copy of FDT because of_fdt_unflatten_tree()
39a751a4cb7e47 Frank Rowand 2018-02-12 1038* will create pointers
to the passed in FDT in the unflattened tree.
39a751a4cb7e47 Frank Rowand 2018-02-12 1039*/
7a18fbf9013a19 Frank Rowand 2021-04-07 1040 size += FDT_ALIGN_SIZE;
7a18fbf9013a19 Frank Rowand 2021-04-07 1041 new_fdt = kmalloc(size,
GFP_KERNEL);
39a751a4cb7e47 Frank Rowand 2018-02-12 1042 if (!new_fdt)
39a751a4cb7e47 Frank Rowand 2018-02-12 1043 return -ENOMEM;
39a751a4cb7e47 Frank Rowand 2018-02-12 1044
7a18fbf9013a19 Frank Rowand 2021-04-07 @1045 new_fdt =
PTR_ALIGN(new_fdt, FDT_ALIGN_SIZE);
^^^
We're not freeing the exact same pointer that we allocated.
7a18fbf9013a19 Frank Rowand 2021-04-07 1046 memcpy(new_fdt,
overlay_fdt, size);
7a18fbf9013a19 Frank Rowand 2021-04-07 1047
39a751a4cb7e47 Frank Rowand 2018-02-12 1048
of_fdt_unflatten_tree(new_fdt, NULL, _root);
39a751a4cb7e47 Frank Rowand 2018-02-12 1049 if (!overlay_root) {
39a751a4cb7e47 Frank Rowand 2018-02-12 1050 pr_err("unable
to unflatten overlay_fdt\n");
39a751a4cb7e47 Frank Rowand 2018-02-12 1051 ret = -EINVAL;
39a751a4cb7e47 Frank Rowand 2018-02-12 1052 goto
out_free_new_fdt;
39a751a4cb7e47 Frank Rowand 2018-02-12 1053 }
39a751a4cb7e47 Frank Rowand 2018-02-12 1054
39a751a4cb7e47 Frank Rowand 2018-02-12 1055 ret =
of_overlay_apply(new_fdt, overlay_root, ovcs_id);
39a751a4cb7e47 Frank Rowand 2018-02-12 1056 if (ret < 0) {
39a751a4cb7e47 Frank Rowand 2018-02-12 1057 /*
39a751a4cb7e47 Frank Rowand 2018-02-12 1058* new_fdt and
overlay_root now belong to the overlay
39a751a4cb7e47 Frank Rowand 2018-02-12 1059* changeset.
39a751a4cb7e47 Frank Rowand 2018-02-12 1060* overlay
changeset code is responsible for freeing them.
39a751a4cb7e47 Frank Rowand 2018-02-12 1061*/
39a751a4cb7e47 Frank Rowand 2018-02-12 1062 goto out;
39a751a4cb7e47 Frank Rowand 2018-02-12 1063 }
39a751a4cb7e47 Frank Rowand 2018-02-12 1064
39a751a4cb7e47 Frank Rowand 2018-02-12 1065 return 0;
39a751a4cb7e47 Frank Rowand 2018-02-12 1066
39a751a4cb7e47 Frank Rowand 2018-02-12 1067
39a751a4cb7e47 Frank Rowand 2018-02-12 1068 out_free_new_fdt:
39a751a4cb7e47 Frank Rowand
[kbuild] drivers/gpu/drm/msm/adreno/a3xx_gpu.c:600 a3xx_gpu_init() error: passing non negative 1 to ERR_PTR
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 2d743660786ec51f5c1fefd5782bbdee7b227db0
commit: 5785dd7a8ef0de8049f40a1a109de6a1bf17b479 drm/msm: Fix duplicate gpu
node in icc summary
config: arm64-randconfig-m031-20210407 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/msm/adreno/a3xx_gpu.c:600 a3xx_gpu_init() error: passing non
negative 1 to ERR_PTR
drivers/gpu/drm/msm/adreno/a4xx_gpu.c:727 a4xx_gpu_init() error: passing non
negative 1 to ERR_PTR
vim +600 drivers/gpu/drm/msm/adreno/a3xx_gpu.c
7198e6b03155f6 Rob Clark 2013-07-19 515 struct msm_gpu
*a3xx_gpu_init(struct drm_device *dev)
7198e6b03155f6 Rob Clark 2013-07-19 516 {
7198e6b03155f6 Rob Clark 2013-07-19 517 struct a3xx_gpu *a3xx_gpu =
NULL;
55459968176f13 Rob Clark 2013-12-05 518 struct adreno_gpu *adreno_gpu;
7198e6b03155f6 Rob Clark 2013-07-19 519 struct msm_gpu *gpu;
060530f1ea6740 Rob Clark 2014-03-03 520 struct msm_drm_private *priv =
dev->dev_private;
060530f1ea6740 Rob Clark 2014-03-03 521 struct platform_device *pdev =
priv->gpu_pdev;
5785dd7a8ef0de Akhil P Oommen 2020-10-28 522 struct icc_path *ocmem_icc_path;
5785dd7a8ef0de Akhil P Oommen 2020-10-28 523 struct icc_path *icc_path;
7198e6b03155f6 Rob Clark 2013-07-19 524 int ret;
7198e6b03155f6 Rob Clark 2013-07-19 525
7198e6b03155f6 Rob Clark 2013-07-19 526 if (!pdev) {
6a41da17e87dee Mamta Shukla 2018-10-20 527 DRM_DEV_ERROR(dev->dev,
"no a3xx device\n");
7198e6b03155f6 Rob Clark 2013-07-19 528 ret = -ENXIO;
7198e6b03155f6 Rob Clark 2013-07-19 529 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 530 }
7198e6b03155f6 Rob Clark 2013-07-19 531
7198e6b03155f6 Rob Clark 2013-07-19 532 a3xx_gpu =
kzalloc(sizeof(*a3xx_gpu), GFP_KERNEL);
7198e6b03155f6 Rob Clark 2013-07-19 533 if (!a3xx_gpu) {
7198e6b03155f6 Rob Clark 2013-07-19 534 ret = -ENOMEM;
7198e6b03155f6 Rob Clark 2013-07-19 535 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 536 }
7198e6b03155f6 Rob Clark 2013-07-19 537
55459968176f13 Rob Clark 2013-12-05 538 adreno_gpu = _gpu->base;
55459968176f13 Rob Clark 2013-12-05 539 gpu = _gpu->base;
7198e6b03155f6 Rob Clark 2013-07-19 540
70c70f091b1ffd Rob Clark 2014-05-30 541 gpu->perfcntrs = perfcntrs;
70c70f091b1ffd Rob Clark 2014-05-30 542 gpu->num_perfcntrs =
ARRAY_SIZE(perfcntrs);
70c70f091b1ffd Rob Clark 2014-05-30 543
3bcefb0497f9fc Rob Clark 2014-09-05 544 adreno_gpu->registers =
a3xx_registers;
3bcefb0497f9fc Rob Clark 2014-09-05 545
f97decac5f4c2d Jordan Crouse 2017-10-20 546 ret = adreno_gpu_init(dev,
pdev, adreno_gpu, , 1);
7198e6b03155f6 Rob Clark 2013-07-19 547 if (ret)
7198e6b03155f6 Rob Clark 2013-07-19 548 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 549
55459968176f13 Rob Clark 2013-12-05 550 /* if needed, allocate gmem: */
55459968176f13 Rob Clark 2013-12-05 551 if (adreno_is_a330(adreno_gpu))
{
26c0b26dcd005d Brian Masney 2019-08-23 552 ret =
adreno_gpu_ocmem_init(_gpu->base.pdev->dev,
26c0b26dcd005d Brian Masney 2019-08-23 553
adreno_gpu, _gpu->ocmem);
26c0b26dcd005d Brian Masney 2019-08-23 554 if (ret)
26c0b26dcd005d Brian Masney 2019-08-23 555 goto fail;
55459968176f13 Rob Clark 2013-12-05 556 }
55459968176f13 Rob Clark 2013-12-05 557
667ce33e57d0de Rob Clark 2016-09-28 558 if (!gpu->aspace) {
871d812aa43e63 Rob Clark 2013-11-16 559 /* TODO we think it is
possible to configure the GPU to
871d812aa43e63 Rob Clark 2013-11-16 560* restrict access to
VRAM carveout. But the required
871d812aa43e63 Rob Clark 2013-11-16 561* registers are
unknown. For now just bail out and
871d812aa43e63 Rob Clark 2013-11-16 562* limp along with just
modesetting. If it turns out
871d812aa43e63 Rob Clark 2013-11-16 563* to not be possible
to restrict access, then we must
871d812aa43e63 Rob Clark 2013-11-16 564* implement a
cmdstream validator.
871d812aa43e63 Rob Clark 2013-11-16 565*/
6a41da17e87dee Mamta Shukla 2018-10-20 566 DRM_DEV_ERROR(dev->dev,
"No memory protection without IOMMU\n");
871d812aa43e63 Rob Clark 2013-11-16 567 ret = -ENXIO;
871d812aa43e63 Rob Clark 2013-11-16 568 goto fail;
871d812aa43e63 Rob Clark 2013-11-16 569 }
871d812aa43e63 Rob Clark 2013-11-16 570
5785dd7a8ef0de Akhil P Oommen 2020-10-28 571 icc_path =
[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()
Hi Michael,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
cc0626c2aaed8e475efdd85fa374b497a7192e35
config: x86_64-randconfig-m001-20210406 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2069 axienet_probe() warn:
passing a valid pointer to 'PTR_ERR'
vim +/PTR_ERR +2069 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
2be586205ca2b8 Srikanth Thokala2015-05-05 1832 static int
axienet_probe(struct platform_device *pdev)
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1833 {
8495659bf93c8e Srikanth Thokala2015-05-05 1834 int ret;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1835 struct device_node *np;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1836 struct axienet_local
*lp;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1837 struct net_device *ndev;
28ef9ebdb64c6f Robert Hancock 2019-06-06 1838 struct resource *ethres;
411b125c6ace1f Michael Walle 2021-04-06 1839 u8 mac_addr[ETH_ALEN];
^^
5fff0151b3244d Andre Przywara 2020-03-24 1840 int addr_width = 32;
8495659bf93c8e Srikanth Thokala2015-05-05 1841 u32 value;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1842
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1843 ndev =
alloc_etherdev(sizeof(*lp));
41de8d4cff21a2 Joe Perches 2012-01-29 1844 if (!ndev)
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1845 return -ENOMEM;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1846
95219aa538e11d Srikanth Thokala2015-05-05 1847
platform_set_drvdata(pdev, ndev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1848
95219aa538e11d Srikanth Thokala2015-05-05 1849 SET_NETDEV_DEV(ndev,
>dev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1850 ndev->flags &=
~IFF_MULTICAST; /* clear multicast */
28e24c62ab3062 Eric Dumazet2013-12-02 1851 ndev->features =
NETIF_F_SG;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1852 ndev->netdev_ops =
_netdev_ops;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1853 ndev->ethtool_ops =
_ethtool_ops;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1854
d894be57ca92c8 Jarod Wilson2016-10-20 1855 /* MTU range: 64 - 9000
*/
d894be57ca92c8 Jarod Wilson2016-10-20 1856 ndev->min_mtu = 64;
d894be57ca92c8 Jarod Wilson2016-10-20 1857 ndev->max_mtu =
XAE_JUMBO_MTU;
d894be57ca92c8 Jarod Wilson2016-10-20 1858
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1859 lp = netdev_priv(ndev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1860 lp->ndev = ndev;
95219aa538e11d Srikanth Thokala2015-05-05 1861 lp->dev = >dev;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 1862 lp->options =
XAE_OPTION_DEFAULTS;
8b09ca823ffb4e Robert Hancock 2019-06-06 1863 lp->rx_bd_num =
RX_BD_NUM_DEFAULT;
8b09ca823ffb4e Robert Hancock 2019-06-06 1864 lp->tx_bd_num =
TX_BD_NUM_DEFAULT;
57baf8cc70ea4c Robert Hancock 2021-02-12 1865
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1866 lp->axi_clk =
devm_clk_get_optional(>dev, "s_axi_lite_clk");
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1867 if (!lp->axi_clk) {
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1868 /* For backward
compatibility, if named AXI clock is not present,
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1869 * treat the
first clock specified as the AXI clock.
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1870 */
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1871 lp->axi_clk =
devm_clk_get_optional(>dev, NULL);
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1872 }
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1873 if
(IS_ERR(lp->axi_clk)) {
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1874 ret =
PTR_ERR(lp->axi_clk);
57baf8cc70ea4c Robert Hancock 2021-02-12 1875 goto
free_netdev;
57baf8cc70ea4c Robert Hancock 2021-02-12 1876 }
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1877 ret =
clk_prepare_enable(lp->axi_clk);
57baf8cc70ea4c Robert Hancock 2021-02-12 1878 if (ret) {
b11bfb9a19f9d7 Robert Hancock 2021-03-25 1879
dev_err(>dev, "Unable to enable AXI clock: %d\n", ret);
57baf8cc70ea4c Robert Hancock 2021-02-12 1880 goto
free_netdev;
57baf8cc70ea4c Robert Hancock 2021-02-12 1881 }
57baf8cc70ea4c Robert Hancock 2021-02-12 1882
[kbuild] drivers/vdpa/mlx5/core/mr.c:282 map_direct_mr() warn: missing error code 'err'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: e49d033bddf5b565044e2abe4241353959bc9120
commit: 94abbccdf2916cb03f9626f2d36c6e9971490c12 vdpa/mlx5: Add shared memory
registration code
config: microblaze-randconfig-m031-20210405 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/vdpa/mlx5/core/mr.c:282 map_direct_mr() warn: missing error code 'err'
Old smatch warnings:
drivers/vdpa/mlx5/core/mr.c:350 add_direct_chain() error: uninitialized symbol
'err'.
drivers/vdpa/mlx5/core/mr.c:483 mlx5_vdpa_handle_set_map() error: uninitialized
symbol 'err'.
vim +/err +282 drivers/vdpa/mlx5/core/mr.c
94abbccdf2916c Eli Cohen 2020-08-04 226 static int map_direct_mr(struct
mlx5_vdpa_dev *mvdev, struct mlx5_vdpa_direct_mr *mr,
94abbccdf2916c Eli Cohen 2020-08-04 227 struct
vhost_iotlb *iotlb)
94abbccdf2916c Eli Cohen 2020-08-04 228 {
94abbccdf2916c Eli Cohen 2020-08-04 229struct vhost_iotlb_map *map;
94abbccdf2916c Eli Cohen 2020-08-04 230unsigned long lgcd = 0;
94abbccdf2916c Eli Cohen 2020-08-04 231int log_entity_size;
94abbccdf2916c Eli Cohen 2020-08-04 232unsigned long size;
94abbccdf2916c Eli Cohen 2020-08-04 233u64 start = 0;
94abbccdf2916c Eli Cohen 2020-08-04 234int err;
94abbccdf2916c Eli Cohen 2020-08-04 235struct page *pg;
94abbccdf2916c Eli Cohen 2020-08-04 236unsigned int nsg;
94abbccdf2916c Eli Cohen 2020-08-04 237int sglen;
94abbccdf2916c Eli Cohen 2020-08-04 238u64 pa;
94abbccdf2916c Eli Cohen 2020-08-04 239u64 paend;
94abbccdf2916c Eli Cohen 2020-08-04 240struct scatterlist *sg;
94abbccdf2916c Eli Cohen 2020-08-04 241struct device *dma =
mvdev->mdev->device;
94abbccdf2916c Eli Cohen 2020-08-04 242int ret;
94abbccdf2916c Eli Cohen 2020-08-04 243
94abbccdf2916c Eli Cohen 2020-08-04 244for (map =
vhost_iotlb_itree_first(iotlb, mr->start, mr->end - 1);
94abbccdf2916c Eli Cohen 2020-08-04 245 map; map =
vhost_iotlb_itree_next(map, start, mr->end - 1)) {
94abbccdf2916c Eli Cohen 2020-08-04 246size = maplen(map, mr);
94abbccdf2916c Eli Cohen 2020-08-04 247lgcd = gcd(lgcd, size);
94abbccdf2916c Eli Cohen 2020-08-04 248start += size;
94abbccdf2916c Eli Cohen 2020-08-04 249}
94abbccdf2916c Eli Cohen 2020-08-04 250log_entity_size = ilog2(lgcd);
94abbccdf2916c Eli Cohen 2020-08-04 251
94abbccdf2916c Eli Cohen 2020-08-04 252sglen = 1 << log_entity_size;
94abbccdf2916c Eli Cohen 2020-08-04 253nsg =
MLX5_DIV_ROUND_UP_POW2(mr->end - mr->start, log_entity_size);
94abbccdf2916c Eli Cohen 2020-08-04 254
94abbccdf2916c Eli Cohen 2020-08-04 255err =
sg_alloc_table(>sg_head, nsg, GFP_KERNEL);
94abbccdf2916c Eli Cohen 2020-08-04 256if (err)
94abbccdf2916c Eli Cohen 2020-08-04 257return err;
94abbccdf2916c Eli Cohen 2020-08-04 258
94abbccdf2916c Eli Cohen 2020-08-04 259sg = mr->sg_head.sgl;
94abbccdf2916c Eli Cohen 2020-08-04 260for (map =
vhost_iotlb_itree_first(iotlb, mr->start, mr->end - 1);
94abbccdf2916c Eli Cohen 2020-08-04 261 map; map =
vhost_iotlb_itree_next(map, mr->start, mr->end - 1)) {
94abbccdf2916c Eli Cohen 2020-08-04 262paend = map->addr +
maplen(map, mr);
94abbccdf2916c Eli Cohen 2020-08-04 263for (pa = map->addr; pa
< paend; pa += sglen) {
94abbccdf2916c Eli Cohen 2020-08-04 264pg =
pfn_to_page(__phys_to_pfn(pa));
94abbccdf2916c Eli Cohen 2020-08-04 265if (!sg) {
94abbccdf2916c Eli Cohen 2020-08-04 266
mlx5_vdpa_warn(mvdev, "sg null. start 0x%llx, end 0x%llx\n",
94abbccdf2916c Eli Cohen 2020-08-04 267
map->start, map->last + 1);
94abbccdf2916c Eli Cohen 2020-08-04 268err =
-ENOMEM;
94abbccdf2916c Eli Cohen 2020-08-04 269goto
err_map;
94abbccdf2916c Eli Cohen 2020-08-04 270}
94abbccdf2916c Eli Cohen 2020-08-04 271sg_set_page(sg,
pg, sglen, 0);
94abbccdf2916c Eli Cohen 2020-08-04 272sg =
sg_next(sg);
94abbccdf2916c Eli Cohen 2020-08-04 273if (!sg)
94abbccdf2916c Eli Cohen 2020-08-04 274goto
done;
94abbccdf2916c Eli Cohen 2020-08-04 275}
94abbccdf2916c Eli Cohen 2020-08-04 276}
94abbccdf2916c Eli Cohen 2020-08-04 277 done:
94abbccdf2916c Eli Cohen 2020-08-04 278mr->log_size = log_entity_size;
94abbccdf2916c Eli Cohen 2020-08-04 279mr->nsg = nsg;
[kbuild] Re: [PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs
Hi Xiaofei,
url:
https://github.com/0day-ci/linux/commits/Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
tty-testing
config: x86_64-randconfig-m001-20210405 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/tty/sysrq.c:558 __sysrq_get_key_op() warn: curly braces intended?
vim +558 drivers/tty/sysrq.c
23cbedf812ff7c drivers/tty/sysrq.c Emil Velikov2020-05-13 549 static
const struct sysrq_key_op *__sysrq_get_key_op(int key)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 550 {
23cbedf812ff7c drivers/tty/sysrq.c Emil Velikov2020-05-13 551 const
struct sysrq_key_op *op_p = NULL;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 552 int i;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 553
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 554 i =
sysrq_key_table_key2index(key);
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 555 if (i
!= -1)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 556
op_p = sysrq_key_table[i];
97f5f0cd8cd0a0 drivers/char/sysrq.c Dmitry Torokhov 2010-03-21 557
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 @558
return op_p;
^^^
indented too far.
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 559 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 317/9190] drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || B' [redundantCondi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d
commit: b64d6c51380b7dea17d5503a250ca9cc84025453 [317/9190] drm/i915/display:
Support PSR Multiple Instances
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant
>> condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A ||
>> B' [redundantCondition]
if (!intel_dp->psr.enabled ||
^
drivers/gpu/drm/i915/display/intel_psr.c:362:11: warning: Same expression on
both sides of '-'. [duplicateExpression]
[3] = 1 - 1,
^
vim +1517 drivers/gpu/drm/i915/display/intel_psr.c
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1503 void intel_psr_wait_for_idle(const struct intel_crtc_state
*new_crtc_state)
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1504 {
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1505struct drm_i915_private *dev_priv =
to_i915(new_crtc_state->uapi.crtc->dev);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1506struct intel_encoder *encoder;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1507
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1508if (!new_crtc_state->has_psr)
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1509return;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1510
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1511for_each_intel_encoder_mask_can_psr(_priv->drm,
encoder,
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1512
new_crtc_state->uapi.encoder_mask) {
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1513struct intel_dp *intel_dp =
enc_to_intel_dp(encoder);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1514u32 psr_status;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1515
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1516mutex_lock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 @1517if (!intel_dp->psr.enabled ||
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1518(intel_dp->psr.enabled &&
intel_dp->psr.psr2_enabled)) {
^
More clear to write:
if (!intel_dp->psr.enabled || intel_dp->psr.psr2_enabled) {
mutex_unlock(_dp->psr.lock);
continue;
}
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1519mutex_unlock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1520continue;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1521}
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1522
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1523/* when the PSR1 is enabled */
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1524if (psr_wait_for_idle(intel_dp, _status))
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1525drm_err(_priv->drm,
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1526"PSR idle timed out 0x%x,
atomic update may fail\n",
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1527psr_status);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1528mutex_unlock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1529}
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun
2021-02-04 1530 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
[kbuild] [robh:for-next 7/57] arch/powerpc/kexec/elf_64.c:153 elf64_load() error: uninitialized symbol 'fdt'.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
head: 8d3a1cb32124eaeb3f2efe4889de214d3b658d8d
commit: 3c985d31ad661a2cc0ad0a55105046fc56a7b1fd [7/57] powerpc: Use common
of_kexec_alloc_and_setup_fdt()
config: powerpc-randconfig-m031-20210403 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
arch/powerpc/kexec/elf_64.c:153 elf64_load() error: uninitialized symbol 'fdt'.
vim +/fdt +153 arch/powerpc/kexec/elf_64.c
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 27 static void *elf64_load(struct kimage *image, char *kernel_buf,
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 28 unsigned long kernel_len, char *initrd,
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 29 unsigned long initrd_len, char *cmdline,
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 30 unsigned long cmdline_len)
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 31 {
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 32 int ret;
3be3f61d25e04e arch/powerpc/kernel/kexec_elf_64.c Philipp Rudo
2018-04-13 33 unsigned long kernel_load_addr;
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 34 unsigned long initrd_load_addr = 0, fdt_load_addr;
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 35 void *fdt;
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 36 const void *slave_code;
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 37 struct elfhdr ehdr;
cb350c1f1f867d arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 38 char *modified_cmdline = NULL;
175fca3bf91a11 arch/powerpc/kernel/kexec_elf_64.c Sven Schnelle
2019-08-23 39 struct kexec_elf_info elf_info;
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 40 struct kexec_buf kbuf = { .image = image, .buf_min = 0,
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 41 .buf_max = ppc64_rma_size };
3be3f61d25e04e arch/powerpc/kernel/kexec_elf_64.c Philipp Rudo
2018-04-13 42 struct kexec_buf pbuf = { .image = image, .buf_min = 0,
8b909e3548706c arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2019-05-22 43 .buf_max = ppc64_rma_size,
.top_down = true,
8b909e3548706c arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2019-05-22 44 .mem = KEXEC_BUF_MEM_UNKNOWN
};
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 45
175fca3bf91a11 arch/powerpc/kernel/kexec_elf_64.c Sven Schnelle
2019-08-23 46 ret = kexec_build_elf_info(kernel_buf, kernel_len,
, _info);
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 47 if (ret)
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 48 goto out;
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 49
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 50 if (image->type == KEXEC_TYPE_CRASH) {
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 51 /* min & max buffer values for kdump case */
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 52 kbuf.buf_min = pbuf.buf_min = crashk_res.start;
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 53 kbuf.buf_max = pbuf.buf_max =
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 54 ((crashk_res.end <
ppc64_rma_size) ?
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 55 crashk_res.end :
(ppc64_rma_size - 1));
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 56 }
b8e55a3e5c2088 arch/powerpc/kexec/elf_64.cHari Bathini
2020-07-29 57
175fca3bf91a11 arch/powerpc/kernel/kexec_elf_64.c Sven Schnelle
2019-08-23 58 ret = kexec_elf_load(image, , _info, ,
_load_addr);
a0458284f0625a arch/powerpc/kernel/kexec_elf_64.c Thiago Jung Bauermann
2016-11-29 59 if (ret)
a0458284f0625a
