[kbuild] [vireshk-pm:opp/linux-next 52/52] drivers/opp/core.c:858 dev_pm_opp_config_clks_simple() error: uninitialized symbol 'ret'.
CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Viresh Kumar
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git
opp/linux-next
head: 76c4db9b37866c60306d39ed982cba56af15ff00
commit: 76c4db9b37866c60306d39ed982cba56af15ff00 [52/52] OPP: Provide a simple
implementation to configure multiple clocks
:: branch date: 14 hours ago
:: commit date: 14 hours ago
config: x86_64-randconfig-m001
(https://download.01.org/0day-ci/archive/20220611/202206110613.ltphanzv-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
drivers/opp/core.c:858 dev_pm_opp_config_clks_simple() error: uninitialized
symbol 'ret'.
Old smatch warnings:
drivers/opp/core.c:2283 _opp_attach_genpd() warn: passing zero to 'PTR_ERR'
vim +/ret +858 drivers/opp/core.c
947355850fcb3b drivers/base/power/opp/core.c Viresh Kumar 2016-12-01 827
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 828 /*
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 829 *
Simple implementation for configuring multiple clocks. Configure clocks in
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 830 *
the order in which they are present in the array while scaling up.
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 831 */
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 832 int
dev_pm_opp_config_clks_simple(struct device *dev,
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 833
struct opp_table *opp_table, struct dev_pm_opp *opp, void *data,
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 834
bool scaling_down)
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 835 {
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 836
int ret, i;
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 837
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 838
if (scaling_down) {
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 839
for (i = opp_table->clk_count - 1; i >= 0; i--) {
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 840
ret = clk_set_rate(opp_table->clks[i], opp->rates[i]);
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 841
if (ret) {
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 842
dev_err(dev, "%s: failed to set clock rate: %d\n",
__func__,
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 843
ret);
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 844
return ret;
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 845
}
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 846
}
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 847
} else {
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 848
for (i = 0; i < opp_table->clk_count; i++) {
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 849
ret = clk_set_rate(opp_table->clks[i], opp->rates[i]);
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 850
if (ret) {
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 851
dev_err(dev, "%s: failed to set clock rate: %d\n",
__func__,
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 852
ret);
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 853
return ret;
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 854
}
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 855
}
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 856
}
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 857
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 @858
return ret;
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 859 }
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 860
EXPORT_SYMBOL_GPL(dev_pm_opp_config_clks_simple);
76c4db9b37866c drivers/opp/core.cViresh Kumar 2022-06-10 861
--
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe se
[kbuild] [linux-next:master 2027/2566] drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put.
CC: kbuild-...@lists.01.org BCC: l...@intel.com CC: Linux Memory Management List TO: Paul Kocialkowski CC: Maxime Ripard tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 6d0c806803170f120f8cb97b321de7bd89d3a791 commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller :: branch date: 17 hours ago :: commit date: 31 hours ago config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206110640.ylzgsgmf-...@intel.com/config) compiler: mips-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot Reported-by: Julia Lawall cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put. -- >> drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant because >> platform_get_irq() already prints an error -- 0-DAY CI Kernel Test Service https://01.org/lkp ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [PATCH] drm: fix platform_get_irq.cocci warnings
CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: Linux Memory Management List
TO: Paul Kocialkowski
CC: Maxime Ripard
CC: David Airlie
CC: Daniel Vetter
CC: dri-de...@lists.freedesktop.org
CC: linux-ker...@vger.kernel.org
From: kernel test robot
drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant because
platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 6d0c806803170f120f8cb97b321de7bd89d3a791
commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support
for the LogiCVC display controller
:: branch date: 17 hours ago
:: commit date: 31 hours ago
Please take the patch only if it's a positive warning. Thanks!
drivers/gpu/drm/logicvc/logicvc_drm.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/gpu/drm/logicvc/logicvc_drm.c
+++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
@@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct plat
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "Failed to get IRQ\n");
ret = -ENODEV;
goto error_reserved_mem;
}
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [PATCH] drm: fix device_node_continue.cocci warnings
CC: kbuild-...@lists.01.org BCC: l...@intel.com CC: Linux Memory Management List TO: Paul Kocialkowski CC: Maxime Ripard CC: David Airlie CC: Daniel Vetter CC: dri-de...@lists.freedesktop.org CC: linux-ker...@vger.kernel.org From: kernel test robot drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put. Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 6d0c806803170f120f8cb97b321de7bd89d3a791 commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller :: branch date: 17 hours ago :: commit date: 31 hours ago Please take the patch only if it's a positive warning. Thanks! drivers/gpu/drm/logicvc/logicvc_layer.c |2 -- 1 file changed, 2 deletions(-) --- a/drivers/gpu/drm/logicvc/logicvc_layer.c +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c @@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d ret = logicvc_layer_init(logicvc, layer_node, index); if (ret) goto error; - - of_node_put(layer_node); } of_node_put(layers_node); ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [PATCH 5/5] vfio/iommu_type1: Simplify group attachment
CC: kbuild-...@lists.01.org
BCC: l...@intel.com
In-Reply-To: <20220606061927.26049-6-nicol...@nvidia.com>
References: <20220606061927.26049-6-nicol...@nvidia.com>
TO: Nicolin Chen
TO: j...@nvidia.com
TO: j...@8bytes.org
TO: w...@kernel.org
TO: mar...@marcan.st
TO: s...@svenpeter.dev
TO: robin.mur...@arm.com
TO: robdcl...@gmail.com
TO: m.szyprow...@samsung.com
TO: krzysztof.kozlow...@linaro.org
TO: baolu...@linux.intel.com
TO: agr...@kernel.org
TO: bjorn.anders...@linaro.org
TO: matthias@gmail.com
TO: he...@sntech.de
TO: orsonz...@gmail.com
TO: baolin.wa...@gmail.com
TO: zhang.l...@gmail.com
TO: w...@csie.org
TO: jernej.skra...@gmail.com
TO: sam...@sholland.org
TO: jean-phili...@linaro.org
TO: alex.william...@redhat.com
CC: suravee.suthikulpa...@amd.com
CC: aly...@rosenzweig.io
CC: alim.akh...@samsung.com
CC: dw...@infradead.org
CC: yong...@mediatek.com
CC: mjros...@linux.ibm.com
CC: gerald.schae...@linux.ibm.com
CC: thierry.red...@gmail.com
Hi Nicolin,
I love your patch! Perhaps something to improve:
[auto build test WARNING on joro-iommu/next]
[also build test WARNING on tegra/for-next v5.19-rc1 next-20220610]
[cannot apply to awilliam-vfio/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/intel-lab-lkp/linux/commits/Nicolin-Chen/Simplify-vfio_iommu_type1-attach-detach-routine/20220606-143004
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
:: branch date: 4 days ago
:: commit date: 4 days ago
config: i386-randconfig-m021
(https://download.01.org/0day-ci/archive/20220611/202206110041.8caoevuj-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/vfio/vfio_iommu_type1.c:2229 vfio_iommu_alloc_attach_domain() error: we
previously assumed 'domain' could be null (see line 2191)
drivers/vfio/vfio_iommu_type1.c:2229 vfio_iommu_alloc_attach_domain() error:
dereferencing freed memory 'domain'
vim +/domain +2229 drivers/vfio/vfio_iommu_type1.c
572f64c71e0fe3 Zenghui Yu 2020-10-22 2156
c1a4076891cf18 Nicolin Chen 2022-06-05 2157 static struct vfio_domain *
c1a4076891cf18 Nicolin Chen 2022-06-05 2158
vfio_iommu_alloc_attach_domain(struct bus_type *bus, struct vfio_iommu *iommu,
c1a4076891cf18 Nicolin Chen 2022-06-05 2159 struct
vfio_iommu_group *group)
c1a4076891cf18 Nicolin Chen 2022-06-05 2160 {
c1a4076891cf18 Nicolin Chen 2022-06-05 2161struct iommu_domain *new_domain;
c1a4076891cf18 Nicolin Chen 2022-06-05 2162struct vfio_domain *domain;
c1a4076891cf18 Nicolin Chen 2022-06-05 2163int ret = 0;
c1a4076891cf18 Nicolin Chen 2022-06-05 2164
c1a4076891cf18 Nicolin Chen 2022-06-05 2165/* Try to match an existing
compatible domain */
c1a4076891cf18 Nicolin Chen 2022-06-05 2166list_for_each_entry (domain,
&iommu->domain_list, next) {
c1a4076891cf18 Nicolin Chen 2022-06-05 2167ret =
iommu_attach_group(domain->domain, group->iommu_group);
c1a4076891cf18 Nicolin Chen 2022-06-05 2168if (ret == -EMEDIUMTYPE)
c1a4076891cf18 Nicolin Chen 2022-06-05 2169continue;
c1a4076891cf18 Nicolin Chen 2022-06-05 2170if (ret)
c1a4076891cf18 Nicolin Chen 2022-06-05 2171return
ERR_PTR(ret);
c1a4076891cf18 Nicolin Chen 2022-06-05 2172list_add(&group->next,
&domain->group_list);
c1a4076891cf18 Nicolin Chen 2022-06-05 2173return domain;
c1a4076891cf18 Nicolin Chen 2022-06-05 2174}
c1a4076891cf18 Nicolin Chen 2022-06-05 2175
c1a4076891cf18 Nicolin Chen 2022-06-05 2176new_domain =
iommu_domain_alloc(bus);
c1a4076891cf18 Nicolin Chen 2022-06-05 2177if (!new_domain)
c1a4076891cf18 Nicolin Chen 2022-06-05 2178return ERR_PTR(-EIO);
c1a4076891cf18 Nicolin Chen 2022-06-05 2179
c1a4076891cf18 Nicolin Chen 2022-06-05 2180if (iommu->nesting) {
c1a4076891cf18 Nicolin Chen 2022-06-05 2181ret =
iommu_enable_nesting(new_domain);
c1a4076891cf18 Nicolin Chen 2022-06-05 2182if (ret)
c1a4076891cf18 Nicolin Chen 2022-06-05 2183goto
out_free_iommu_domain;
c1a4076891cf18 Nicolin Chen 2022-06-05 2184}
c1a4076891cf18 Nicolin Chen 2022-06-05 2185
c1a4076891cf18 Nicolin Chen 2022-06-05 2186ret =
iommu_attach_group(new_domain, group->iommu_group);
c1a4076891cf18 Nicolin Chen 2022-06-05 2187if (ret)
c1a4076891cf18 Nicolin Chen 2022-06-05 2188goto
out_free_iommu_domain;
c1a4076891cf18 Nicolin Chen 2022-06-05 2189
c1a4076891cf18 Nicolin Chen 2022-06-05 2190domain =
kzalloc(sizeof(*domain), GFP_KERNEL);
c1a4076891cf18 Nicol
[kbuild] [tip:x86/fpu 1/2] arch/x86/kernel/fpu/core.c:863 fpu_idle_fpregs() warn: bitwise AND condition is false here
CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
CC: x...@kernel.org
TO: "Chang S. Bae"
CC: Dave Hansen
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/fpu
head: 43843d58393026fef4a43d192b641a4fabdc42bf
commit: 407f1fd0780e39d60778a66c6a157d8c8c832729 [1/2] x86/fpu: Add a helper to
prepare AMX state for low-power CPU idle
:: branch date: 2 days ago
:: commit date: 2 days ago
config: i386-randconfig-m021
(https://download.01.org/0day-ci/archive/20220610/202206102129.qghd6pfg-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
arch/x86/kernel/fpu/core.c:863 fpu_idle_fpregs() warn: bitwise AND condition is
false here
vim +863 arch/x86/kernel/fpu/core.c
407f1fd0780e39 Chang S. Bae 2022-06-08 854
407f1fd0780e39 Chang S. Bae 2022-06-08 855 /*
407f1fd0780e39 Chang S. Bae 2022-06-08 856 * Initialize register state that
may prevent from entering low-power idle.
407f1fd0780e39 Chang S. Bae 2022-06-08 857 * This function will be invoked
from the cpuidle driver only when needed.
407f1fd0780e39 Chang S. Bae 2022-06-08 858 */
407f1fd0780e39 Chang S. Bae 2022-06-08 859 void fpu_idle_fpregs(void)
407f1fd0780e39 Chang S. Bae 2022-06-08 860 {
407f1fd0780e39 Chang S. Bae 2022-06-08 861 /* Note: AMX_TILE being enabled
implies XGETBV1 support */
407f1fd0780e39 Chang S. Bae 2022-06-08 862 if
(cpu_feature_enabled(X86_FEATURE_AMX_TILE) &&
407f1fd0780e39 Chang S. Bae 2022-06-08 @863 (xfeatures_in_use() &
XFEATURE_MASK_XTILE)) {
--
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [esmil:visionfive 21/54] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error
CC: kbuild-...@lists.01.org BCC: l...@intel.com CC: linux-ker...@vger.kernel.org TO: Huan Feng CC: Emil Renner Berthing tree: https://github.com/esmil/linux visionfive head: 906be7ef2fb9e2f1fcb740d3d506768cddfc52ca commit: b422a122c72a7448306ad60808c748d57b98da71 [21/54] drivers/hw_random: Add StarFive JH7100 Random Number Generator driver :: branch date: 3 days ago :: commit date: 4 days ago config: riscv-randconfig-c004-20220609 (https://download.01.org/0day-ci/archive/20220610/202206102133.rjwlnzls-...@intel.com/config) compiler: riscv32-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot Reported-by: Julia Lawall cocci warnings: (new ones prefixed by >>) >> drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant >> because platform_get_irq() already prints an error -- 0-DAY CI Kernel Test Service https://01.org/lkp ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings
CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Huan Feng
CC: Emil Renner Berthing
From: kernel test robot
drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant
because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
CC: Huan Feng
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
tree: https://github.com/esmil/linux visionfive
head: 906be7ef2fb9e2f1fcb740d3d506768cddfc52ca
commit: b422a122c72a7448306ad60808c748d57b98da71 [21/54] drivers/hw_random: Add
StarFive JH7100 Random Number Generator driver
:: branch date: 3 days ago
:: commit date: 4 days ago
Please take the patch only if it's a positive warning. Thanks!
drivers/char/hw_random/starfive-vic-rng.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/char/hw_random/starfive-vic-rng.c
+++ b/drivers/char/hw_random/starfive-vic-rng.c
@@ -206,7 +206,6 @@ static int vic_rng_probe(struct platform
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
- dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
return irq;
}
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
