date:20220821

[kbuild] Re: [PATCH 01/31] crypto: Introduce crypto_pool

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
In-Reply-To: <20220818170005.747015-2-d...@arista.com>
References: <20220818170005.747015-2-d...@arista.com>
TO: Dmitry Safonov 
TO: Eric Dumazet 
TO: "David S. Miller" 
CC: net...@vger.kernel.org
TO: linux-ker...@vger.kernel.org
CC: Dmitry Safonov 
CC: Andy Lutomirski 
CC: Ard Biesheuvel 
CC: Bob Gilligan 
CC: David Ahern 
CC: Eric Biggers 
CC: Francesco Ruggeri 
CC: Herbert Xu 
CC: Hideaki YOSHIFUJI 
CC: Ivan Delalande 
CC: Jakub Kicinski 
CC: Leonard Crestez 
CC: Paolo Abeni 
CC: Salam Noureddine 
CC: Shuah Khan 
CC: linux-cry...@vger.kernel.org

Hi Dmitry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on e34cfee65ec891a319ce79797dda18083af33a76]

url:
https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628
base:   e34cfee65ec891a319ce79797dda18083af33a76
:: branch date: 4 days ago
:: commit date: 4 days ago
config: x86_64-randconfig-m001 
(https://download.01.org/0day-ci/archive/20220822/202208221327.pd3smurp-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
crypto/crypto_pool.c:161 crypto_pool_alloc_ahash() error: testing array offset 
'i' after use.

vim +/i +161 crypto/crypto_pool.c

f4c3873630fc8c4 Dmitry Safonov 2022-08-18  130  
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  131  /**
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  132   * crypto_pool_alloc_ahash - 
allocates pool for ahash requests
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  133   * @alg: name of async hash 
algorithm
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  134   */
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  135  int 
crypto_pool_alloc_ahash(const char *alg)
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  136  {
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  137  unsigned int i;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  138  int err;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  139  
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  140  /* slow-path */
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  141  
mutex_lock(_mutex);
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  142  err = 
crypto_pool_scratch_alloc();
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  143  if (err)
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  144  goto out;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  145  
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  146  for (i = 0; i < 
last_allocated; i++) {
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  147  if 
(cpool[i].alg && !strcmp(cpool[i].alg, alg)) {
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  148  if 
(kref_read([i].kref) > 0) {
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  149  
kref_get([i].kref);
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  150  
goto out;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  151  } else {
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  152  
break;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  153  }
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  154  }
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  155  }
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  156  
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  157  for (i = 0; i < 
last_allocated; i++) {
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  158  if 
(!cpool[i].alg)
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  159  break;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  160  }
f4c3873630fc8c4 Dmitry Safonov 2022-08-18 @161  if (i >= CPOOL_SIZE) {
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  162  err = -ENOSPC;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  163  goto out;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  164  }
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  165  
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  166  err = 
__cpool_alloc_ahash([i], alg);
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  167  if (!err && 
last_allocated <= i)
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  168  
last_allocated++;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  169  out:
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  170  
mutex_unlock(_mutex);
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  171  return err ?: (int)i;
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  172  }
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  173  
EXPORT_SYMBOL_GPL(crypto_pool_alloc_ahash);
f4c3873630fc8c4 Dmitry Safonov 2022-08-18  174  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/soundwire/qcom.c:478 qcom_swrm_enumerate() error: buffer overflow 'ctrl->status' 11 <= 11

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Srinivas Kandagatla 
CC: Vinod Koul 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   1c23f9e627a7b412978b4e852793c5e3c3efc555
commit: aa1262ca66957183ea1fb32a067e145b995f3744 soundwire: qcom: Check device 
status before reading devid
date:   7 weeks ago
:: branch date: 5 hours ago
:: commit date: 7 weeks ago
config: riscv-randconfig-m031-20220819 
(https://download.01.org/0day-ci/archive/20220822/202208221349.svvfmjzv-...@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

New smatch warnings:
drivers/soundwire/qcom.c:478 qcom_swrm_enumerate() error: buffer overflow 
'ctrl->status' 11 <= 11

Old smatch warnings:
arch/riscv/include/asm/atomic.h:204 arch_atomic_fetch_add_unless() warn: 
inconsistent indenting
drivers/soundwire/qcom.c:1323 qcom_swrm_probe() warn: passing zero to 'PTR_ERR'

vim +478 drivers/soundwire/qcom.c

a6e6581942caa0 Srinivas Kandagatla 2021-03-30  464  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  465  static int 
qcom_swrm_enumerate(struct sdw_bus *bus)
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  466  {
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  467  struct qcom_swrm_ctrl 
*ctrl = to_qcom_sdw(bus);
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  468  struct sdw_slave 
*slave, *_s;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  469  struct sdw_slave_id id;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  470  u32 val1, val2;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  471  bool found;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  472  u64 addr;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  473  int i;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  474  char *buf1 = (char 
*), *buf2 = (char *)
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  475  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  476  for (i = 1; i <= 
SDW_MAX_DEVICES; i++) {
aa1262ca669571 Srinivas Kandagatla 2022-07-06  477  /* do not 
continue if the status is Not Present  */
aa1262ca669571 Srinivas Kandagatla 2022-07-06 @478  if 
(!ctrl->status[i])
aa1262ca669571 Srinivas Kandagatla 2022-07-06  479  
continue;
aa1262ca669571 Srinivas Kandagatla 2022-07-06  480  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  481  /*SCP_Devid5 - 
Devid 4*/
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  482  
ctrl->reg_read(ctrl, SWRM_ENUMERATOR_SLAVE_DEV_ID_1(i), );
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  483  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  484  /*SCP_Devid3 - 
DevId 2 Devid 1 Devid 0*/
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  485  
ctrl->reg_read(ctrl, SWRM_ENUMERATOR_SLAVE_DEV_ID_2(i), );
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  486  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  487  if (!val1 && 
!val2)
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  488  break;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  489  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  490  addr = buf2[1] 
| (buf2[0] << 8) | (buf1[3] << 16) |
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  491  
((u64)buf1[2] << 24) | ((u64)buf1[1] << 32) |
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  492  
((u64)buf1[0] << 40);
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  493  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  494  
sdw_extract_slave_id(bus, addr, );
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  495  found = false;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  496  /* Now compare 
with entries */
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  497  
list_for_each_entry_safe(slave, _s, >slaves, node) {
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  498  if 
(sdw_compare_devid(slave, id) == 0) {
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  499  
qcom_swrm_set_slave_dev_num(bus, slave, i);
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  500  
found = true;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  501  
break;
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  502  }
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  503  }
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  504  
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  505  if (!found) {
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  506  
qcom_swrm_set_slave_dev_num(bus, NULL, i);
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  507  
sdw_slave_add(bus, , NULL);
a6e6581942caa0 Srinivas Kandagatla 2021-03-30  508  }
a6e6581942caa0 Srinivas Kandagatla

[kbuild] [leon-rdma:rdma-next 12/27] drivers/vfio/vfio_main.c:1756 vfio_ioctl_device_feature_logging_report() warn: comparison of a potentially tagged address (vfio_ioctl_device_feature_logging_report

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Yishai Hadas 
CC: Leon Romanovsky 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git 
rdma-next
head:   4320b084b9047a5eb52a5cbc3cfe1801517866ad
commit: 7c9d8c9c4d4373a87864e5caaf6d02e7d243f3df [12/27] vfio: Introduce the 
DMA logging feature support
:: branch date: 3 days ago
:: commit date: 5 days ago
config: arm64-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220822/202208220607.xyc72xkd-...@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/vfio/vfio_main.c:1756 vfio_ioctl_device_feature_logging_report() warn: 
comparison of a potentially tagged address 
(vfio_ioctl_device_feature_logging_report, -2, report.page_size)

vim +1756 drivers/vfio/vfio_main.c

7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1731  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1732  static int
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1733  
vfio_ioctl_device_feature_logging_report(struct vfio_device *device,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1734
 u32 flags, void __user *arg,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1735
 size_t argsz)
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1736  {
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1737size_t minsz =
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1738offsetofend(struct 
vfio_device_feature_dma_logging_report,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1739bitmap);
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1740struct 
vfio_device_feature_dma_logging_report report;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1741struct iova_bitmap_iter iter;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1742int ret;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1743  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1744if (!device->log_ops)
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1745return -ENOTTY;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1746  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1747ret = vfio_check_feature(flags, 
argsz,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1748 
VFIO_DEVICE_FEATURE_GET,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1749 
sizeof(report));
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1750if (ret != 1)
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1751return ret;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1752  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1753if (copy_from_user(, 
arg, minsz))
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1754return -EFAULT;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1755  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31 @1756if (report.page_size < 
PAGE_SIZE || !is_power_of_2(report.page_size))
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1757return -EINVAL;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1758  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1759ret = 
iova_bitmap_iter_init(, report.iova, report.length,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1760
report.page_size,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1761
u64_to_user_ptr(report.bitmap));
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1762if (ret)
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1763return ret;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1764  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1765for (; 
!iova_bitmap_iter_done() && !ret;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1766 ret = 
iova_bitmap_iter_advance()) {
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1767ret = 
device->log_ops->log_read_and_clear(device,
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1768
iova_bitmap_iova(),
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1769
iova_bitmap_length(), );
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1770if (ret)
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1771break;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1772}
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1773  
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1774iova_bitmap_iter_free();
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1775return ret;
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1776  }
7c9d8c9c4d4373 Yishai Hadas 2022-05-31  1777  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
In-Reply-To: 

References: 

TO: Arminder Singh 
TO: linux-ker...@vger.kernel.org
CC: Sven Peter 
CC: Alyssa Rosenzweig 
CC: Hector Martin 
CC: Michael Ellerman 
CC: Benjamin Herrenschmidt 
CC: Paul Mackerras 
CC: linux-arm-ker...@lists.infradead.org
CC: linuxppc-...@lists.ozlabs.org
CC: linux-...@vger.kernel.org
CC: Arminder Singh 

Hi Arminder,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on linus/master v6.0-rc1 next-20220819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:
https://github.com/intel-lab-lkp/linux/commits/Arminder-Singh/i2c-pasemi-Add-IRQ-support-for-Apple-Silicon/20220821-034703
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
:: branch date: 23 hours ago
:: commit date: 23 hours ago
config: parisc-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220822/202208220231.f88sizqa-...@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/i2c/busses/i2c-pasemi-core.c:92 pasemi_smb_waitready() error: 
uninitialized symbol 'status'.

vim +/status +92 drivers/i2c/busses/i2c-pasemi-core.c

beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
79  
8032214346c0c8 drivers/i2c/busses/i2c-pasemi.c  Julia Lawall   2010-09-05   
80  static int pasemi_smb_waitready(struct pasemi_smbus *smbus)
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
81  {
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
82  int timeout = 10;
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
83  unsigned int status;
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
84  unsigned int bitmask = SMSTA_XEN | SMSTA_MTN;
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
85  
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
86  if (smbus->use_irq) {
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
87  reinit_completion(>irq_completion);
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
88  reg_write(smbus, REG_IMASK, bitmask);
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
89  wait_for_completion_timeout(>irq_completion, 
msecs_to_jiffies(10));
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
90  status = reg_read(smbus, REG_SMSTA);
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
91  } else {
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13  
@92  while (!(status & SMSTA_XEN) && timeout--) {
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
93  msleep(1);
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
94  status = reg_read(smbus, REG_SMSTA);
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
95  }
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
96  }
98584b2b51d808 drivers/i2c/busses/i2c-pasemi-core.c Arminder Singh 2022-08-20   
97  
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13   
98  
be8a1f7cd4501c drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-11-15   
99  /* Got NACK? */
be8a1f7cd4501c drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-11-15  
100  if (status & SMSTA_MTN)
be8a1f7cd4501c drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-11-15  
101  return -ENXIO;
be8a1f7cd4501c drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-11-15  
102  
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13  
103  if (timeout < 0) {
c06f50ed36cc0a drivers/i2c/busses/i2c-pasemi.c  Sven Peter 2021-10-08  
104  dev_warn(smbus->dev, "Timeout, status 0x%08x\n", status);
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13  
105  reg_write(smbus, REG_SMSTA, status);
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13  
106  return -ETIME;
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13  
107  }
beb58aa39e6e5a drivers/i2c/busses/i2c-pasemi.c  Olof Johansson 2007-02-13  
108  
beb58aa39e6e5a drivers/i2c/busses/i2

[kbuild] Re: [PATCH v9 3/4] pwm: add microchip soft ip corePWM driver

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
In-Reply-To: <20220819085703.4161266-4-conor.doo...@microchip.com>
References: <20220819085703.4161266-4-conor.doo...@microchip.com>
TO: Conor Dooley 
TO: Thierry Reding 
TO: "Uwe Kleine-König" 
TO: Rob Herring 
TO: Krzysztof Kozlowski 
CC: Daire McNamara 
CC: devicet...@vger.kernel.org
CC: linux-ker...@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-ri...@lists.infradead.org
CC: Conor Dooley 

Hi Conor,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 568035b01cfb107af8d2e4bd2fb9aea22cf5b868]

url:
https://github.com/intel-lab-lkp/linux/commits/Conor-Dooley/Microchip-soft-ip-corePWM-driver/20220819-170106
base:   568035b01cfb107af8d2e4bd2fb9aea22cf5b868
:: branch date: 2 days ago
:: commit date: 2 days ago
config: arm64-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208212329.xetz1mt0-...@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/pwm/pwm-microchip-core.c:295 mchp_core_pwm_apply() warn: inconsistent 
returns '_core_pwm->lock'.

vim +295 drivers/pwm/pwm-microchip-core.c

ae39414af22131 Conor Dooley 2022-08-19  199  
ae39414af22131 Conor Dooley 2022-08-19  200  static int 
mchp_core_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
ae39414af22131 Conor Dooley 2022-08-19  201const 
struct pwm_state *state)
ae39414af22131 Conor Dooley 2022-08-19  202  {
ae39414af22131 Conor Dooley 2022-08-19  203 struct mchp_core_pwm_chip 
*mchp_core_pwm = to_mchp_core_pwm(chip);
ae39414af22131 Conor Dooley 2022-08-19  204 struct pwm_state current_state 
= pwm->state;
ae39414af22131 Conor Dooley 2022-08-19  205 bool period_locked;
ae39414af22131 Conor Dooley 2022-08-19  206 u64 duty_steps;
ae39414af22131 Conor Dooley 2022-08-19  207 u16 prescale;
ae39414af22131 Conor Dooley 2022-08-19  208 u8 period_steps;
ae39414af22131 Conor Dooley 2022-08-19  209 int ret;
ae39414af22131 Conor Dooley 2022-08-19  210  
ae39414af22131 Conor Dooley 2022-08-19  211 
mutex_lock(_core_pwm->lock);
ae39414af22131 Conor Dooley 2022-08-19  212  
ae39414af22131 Conor Dooley 2022-08-19  213 if (!state->enabled) {
ae39414af22131 Conor Dooley 2022-08-19  214 
mchp_core_pwm_enable(chip, pwm, false, current_state.period);
ae39414af22131 Conor Dooley 2022-08-19  215 
mutex_unlock(_core_pwm->lock);
ae39414af22131 Conor Dooley 2022-08-19  216 return 0;
ae39414af22131 Conor Dooley 2022-08-19  217 }
ae39414af22131 Conor Dooley 2022-08-19  218  
ae39414af22131 Conor Dooley 2022-08-19  219 /*
ae39414af22131 Conor Dooley 2022-08-19  220  * If the only thing that has 
changed is the duty cycle or the polarity,
ae39414af22131 Conor Dooley 2022-08-19  221  * we can shortcut the 
calculations and just compute/apply the new duty
ae39414af22131 Conor Dooley 2022-08-19  222  * cycle pos & neg edges
ae39414af22131 Conor Dooley 2022-08-19  223  * As all the channels share 
the same period, do not allow it to be
ae39414af22131 Conor Dooley 2022-08-19  224  * changed if any other 
channels are enabled.
ae39414af22131 Conor Dooley 2022-08-19  225  * If the period is locked, it 
may not be possible to use a period
ae39414af22131 Conor Dooley 2022-08-19  226  * less than that requested. In 
that case, we just abort.
ae39414af22131 Conor Dooley 2022-08-19  227  */
ae39414af22131 Conor Dooley 2022-08-19  228 period_locked = 
mchp_core_pwm->channel_enabled & ~(1 << pwm->hwpwm);
ae39414af22131 Conor Dooley 2022-08-19  229  
ae39414af22131 Conor Dooley 2022-08-19  230 if (period_locked) {
ae39414af22131 Conor Dooley 2022-08-19  231 u16 hw_prescale;
ae39414af22131 Conor Dooley 2022-08-19  232 u8 hw_period_steps;
ae39414af22131 Conor Dooley 2022-08-19  233  
ae39414af22131 Conor Dooley 2022-08-19  234 
mchp_core_pwm_calc_period(chip, state, (u8 *), _steps);
ae39414af22131 Conor Dooley 2022-08-19  235 hw_prescale = 
readb_relaxed(mchp_core_pwm->base + MCHPCOREPWM_PRESCALE);
ae39414af22131 Conor Dooley 2022-08-19  236 hw_period_steps = 
readb_relaxed(mchp_core_pwm->base + MCHPCOREPWM_PERIOD);
ae39414af22131 Conor Dooley 2022-08-19  237  
ae39414af22131 Conor Dooley 2022-08-19  238 if ((period_steps + 1) 
* (prescale + 1) <
ae39414af22131 Conor Dooley 2022-08-19  239 (hw_period_steps + 
1) * (hw_prescale + 1)) {
ae39414af22131 Conor Dooley 2022-08-19  240 
mutex_unlock(_core_pwm->lock);
ae39414af22131 Conor Dooley 2022-08-19  241 return -EINVAL;
ae39414af22131 Conor Dooley 2022-08-19  242 }
ae39414af22131 Conor

[kbuild] drivers/comedi/drivers/comedi_8254.c:164 __i8254_write() warn: ignoring unreachable code.

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Bart Van Assche 
CC: Helge Deller 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 6968e707d371ef80511448c6771daf445b4a5cf5 parisc: io: Improve the 
outb(), outw() and outl() macros
date:   8 months ago
:: branch date: 17 hours ago
:: commit date: 8 months ago
config: parisc-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208212223.cwmkj1mz-...@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

New smatch warnings:
drivers/comedi/drivers/comedi_8254.c:164 __i8254_write() warn: ignoring 
unreachable code.
drivers/comedi/drivers/pcl730.c:223 pcl730_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/pcl726.c:294 pcl726_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/pcm3724.c:156 enable_chan() warn: ignoring unreachable 
code.
drivers/comedi/drivers/das16m1.c:304 das16m1_ai_cancel() warn: ignoring 
unreachable code.
drivers/comedi/drivers/das16m1.c:367 das16m1_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/rti800.c:245 rti800_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/das16.c:894 das16_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2814.c:214 dt2814_ai_cmd() warn: ignoring unreachable 
code.
drivers/comedi/drivers/dt2814.c:235 dt2814_ai_cancel() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2814.c:295 dt2814_interrupt() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2817.c:65 dt2817_dio_insn_config() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2817.c:82 dt2817_dio_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2817.c:125 dt2817_attach() warn: ignoring unreachable 
code.
drivers/comedi/drivers/dt2811.c:209 dt2811_interrupt() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2811.c:237 dt2811_ai_cancel() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2811.c:248 dt2811_ai_set_chanspec() warn: ignoring 
unreachable code.
drivers/comedi/drivers/dt2811.c:531 dt2811_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/aio_iiro_16.c:81 aio_iiro_enable_irq() warn: ignoring 
unreachable code.
drivers/comedi/drivers/c6xdigio.c:66 c6xdigio_write_data() warn: ignoring 
unreachable code.
drivers/comedi/drivers/adq12b.c:166 adq12b_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_at_a2150.c:217 a2150_interrupt() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_at_a2150.c:767 a2150_detach() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_at_ao.c:123 atao_select_reg_group() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_at_ao.c:159 atao_dio_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_at_ao.c:194 atao_dio_insn_config() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_atmio16d.c:534 atmio16d_dio_insn_bits() warn: 
ignoring unreachable code.
drivers/comedi/drivers/ni_atmio16d.c:565 atmio16d_dio_insn_config() warn: 
ignoring unreachable code.
drivers/comedi/drivers/multiq3.c:77 multiq3_set_ctrl() warn: ignoring 
unreachable code.
drivers/comedi/drivers/multiq3.c:167 multiq3_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/s526.c:507 s526_dio_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/s526.c:545 s526_dio_insn_config() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_mio_common.c:227 ni_writel() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_mio_common.c:235 ni_writew() warn: ignoring 
unreachable code.
drivers/comedi/drivers/ni_mio_common.c:243 ni_writeb() warn: ignoring 
unreachable code.
drivers/comedi/drivers/das08.c:296 das08jr_do_insn_bits() warn: ignoring 
unreachable code.
drivers/comedi/drivers/amplc_dio200_common.c:114 dio200_write8() warn: ignoring 
unreachable code.
drivers/comedi/drivers/amplc_dio200_common.c:141 dio200_write32() warn: 
ignoring unreachable code.
drivers/comedi/drivers/ni_labpc_common.c:90 labpc_outb() warn: ignoring 
unreachable code.
drivers/i2c/busses/i2c-ocores.c:141 oc_setreg_io_8() warn: ignoring unreachable 
code.
drivers/misc/altera-stapl/altera-lpt.c:20 byteblaster_write() warn: ignoring 
unreachable code.
drivers/tty/serial/8250/serial_cs.c:148 quirk_wakeup_oxsemi() warn: ignoring 
unreachable code.
drivers/tty/serial/8250/8250_port.c:390 hub6_serial_in() warn: ignoring 
unreachable code.
drivers/tty/serial/8250/8250_port.c:458 io_serial_out() warn: ignoring 
unreachable code.
arch/parisc/lib/iomap.c:89 ioport_write8() warn: ignoring unreachable code.
arch/parisc/lib/iomap.c:94 ioport_write16() warn: ignoring unreachable code.
arch/parisc/lib/iomap.c:99

[kbuild] drivers/soundwire/qcom.c:1319 qcom_swrm_probe() warn: passing zero to 'PTR_ERR'

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Srinivasa Rao Mandadapu 
CC: Vinod Koul 
CC: Srinivas Kandagatla 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 1fd0d85affe4d64e54b81d04bf9577e57172a341 soundwire: qcom: Add flag for 
software clock gating check
date:   7 weeks ago
:: branch date: 16 hours ago
:: commit date: 7 weeks ago
config: riscv-randconfig-m031-20220819 
(https://download.01.org/0day-ci/archive/20220821/202208212101.d8rsp83p-...@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

New smatch warnings:
drivers/soundwire/qcom.c:1319 qcom_swrm_probe() warn: passing zero to 'PTR_ERR'

Old smatch warnings:
arch/riscv/include/asm/atomic.h:204 arch_atomic_fetch_add_unless() warn: 
inconsistent indenting

vim +/PTR_ERR +1319 drivers/soundwire/qcom.c

abd9a6049bb59a Srinivas Kandagatla 2021-09-07  1279  
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1280  static int 
qcom_swrm_probe(struct platform_device *pdev)
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1281  {
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1282 struct device 
*dev = >dev;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1283 struct 
sdw_master_prop *prop;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1284 struct 
sdw_bus_params *params;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1285 struct 
qcom_swrm_ctrl *ctrl;
8cb3b4e74cd810 Srinivas Kandagatla 2020-09-17  1286 const struct 
qcom_swrm_data *data;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1287 int ret;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1288 u32 val;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1289  
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1290 ctrl = 
devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1291 if (!ctrl)
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1292 return 
-ENOMEM;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1293  
8cb3b4e74cd810 Srinivas Kandagatla 2020-09-17  1294 data = 
of_device_get_match_data(dev);
8cb3b4e74cd810 Srinivas Kandagatla 2020-09-17  1295 
ctrl->rows_index = sdw_find_row_index(data->default_rows);
8cb3b4e74cd810 Srinivas Kandagatla 2020-09-17  1296 
ctrl->cols_index = sdw_find_col_index(data->default_cols);
47edc0104c61d6 Vinod Koul  2020-11-25  1297  #if 
IS_REACHABLE(CONFIG_SLIMBUS)
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1298 if 
(dev->parent->bus == _bus) {
5bd773242f75da Jonathan Marek  2020-09-05  1299  #else
5bd773242f75da Jonathan Marek  2020-09-05  1300 if (false) {
5bd773242f75da Jonathan Marek  2020-09-05  1301  #endif
d1df23fe688b58 Jonathan Marek  2020-09-05  1302 
ctrl->reg_read = qcom_swrm_ahb_reg_read;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1303 
ctrl->reg_write = qcom_swrm_ahb_reg_write;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1304 
ctrl->regmap = dev_get_regmap(dev->parent, NULL);
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1305 if 
(!ctrl->regmap)
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1306 
return -EINVAL;
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1307 } else {
82f5c70c26511b Jonathan Marek  2020-09-05  1308 
ctrl->reg_read = qcom_swrm_cpu_reg_read;
82f5c70c26511b Jonathan Marek  2020-09-05  1309 
ctrl->reg_write = qcom_swrm_cpu_reg_write;
82f5c70c26511b Jonathan Marek  2020-09-05  1310 
ctrl->mmio = devm_platform_ioremap_resource(pdev, 0);
82f5c70c26511b Jonathan Marek  2020-09-05  1311 if 
(IS_ERR(ctrl->mmio))
82f5c70c26511b Jonathan Marek  2020-09-05  1312 
return PTR_ERR(ctrl->mmio);
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1313 }
02efb49aa805ce Srinivas Kandagatla 2020-01-13  1314  
1fd0d85affe4d6 Srinivasa Rao Mandadapu 2022-07-01  1315 if 
(data->sw_clk_gate_required) {
1fd0d85affe4d6 Srinivasa Rao Mandadapu 2022-07-01  1316 
ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, "swr_audio_cgcr");
1fd0d85affe4d6 Srinivasa Rao Mandadapu 2022-07-01  1317 if 
(IS_ERR_OR_NULL(ctrl->audio_cgcr)) {
1fd0d85affe4d6 Srinivasa Rao Mandadapu 2022-07-01  1318 
dev_err(dev, "Failed to get cgcr reset ctrl required for SW gating\n");
1fd0d85affe4d6 Srinivasa Rao Mandadapu 2022-07-01 @1319

[kbuild] Re: [PATCH] clk: Add Sunplus SP7021 clock driver

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
In-Reply-To: <20220817070113.415971-1-qinj...@cqplus1.com>
References: <20220817070113.415971-1-qinj...@cqplus1.com>
TO: Qin Jian 
TO: sb...@kernel.org
CC: mturque...@baylibre.com
CC: linux-ker...@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-arm-ker...@lists.infradead.org
CC: Qin Jian 

Hi Qin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 568035b01cfb107af8d2e4bd2fb9aea22cf5b868]

url:
https://github.com/intel-lab-lkp/linux/commits/Qin-Jian/clk-Add-Sunplus-SP7021-clock-driver/20220817-151010
base:   568035b01cfb107af8d2e4bd2fb9aea22cf5b868
:: branch date: 4 days ago
:: commit date: 4 days ago
config: arm64-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208212144.auofulut-...@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/clk/clk-sp7021.c:171 plltv_integer_div() error: buffer overflow 
'm_table' 19 <= 19 (assuming for loop doesn't break)

vim +171 drivers/clk/clk-sp7021.c

5673230d6a56d6 Qin Jian 2022-08-17  144  
5673230d6a56d6 Qin Jian 2022-08-17  145  static long plltv_integer_div(struct 
sp_pll *clk, unsigned long freq)
5673230d6a56d6 Qin Jian 2022-08-17  146  {
5673230d6a56d6 Qin Jian 2022-08-17  147 /* valid m values: 27M must be 
divisible by m */
5673230d6a56d6 Qin Jian 2022-08-17  148 static const u32 m_table[] = {
5673230d6a56d6 Qin Jian 2022-08-17  149 1, 2, 3, 4, 5, 6, 8, 9, 
10, 12, 15, 16, 18, 20, 24, 25, 27, 30, 32
5673230d6a56d6 Qin Jian 2022-08-17  150 };
5673230d6a56d6 Qin Jian 2022-08-17  151 u32 m, n, r;
5673230d6a56d6 Qin Jian 2022-08-17  152 unsigned long fvco, nf;
5673230d6a56d6 Qin Jian 2022-08-17  153 long ret;
5673230d6a56d6 Qin Jian 2022-08-17  154  
5673230d6a56d6 Qin Jian 2022-08-17  155 freq = clamp(freq, F_MIN, 
F_MAX);
5673230d6a56d6 Qin Jian 2022-08-17  156  
5673230d6a56d6 Qin Jian 2022-08-17  157 /* DIVR 0~3 */
5673230d6a56d6 Qin Jian 2022-08-17  158 for (r = 0; r <= 3; r++) {
5673230d6a56d6 Qin Jian 2022-08-17  159 fvco = freq << r;
5673230d6a56d6 Qin Jian 2022-08-17  160 if (fvco <= FVCO_MAX)
5673230d6a56d6 Qin Jian 2022-08-17  161 break;
5673230d6a56d6 Qin Jian 2022-08-17  162 }
5673230d6a56d6 Qin Jian 2022-08-17  163  
5673230d6a56d6 Qin Jian 2022-08-17  164 /* DIVM */
5673230d6a56d6 Qin Jian 2022-08-17  165 for (m = 0; m < 
ARRAY_SIZE(m_table); m++) {
5673230d6a56d6 Qin Jian 2022-08-17  166 nf = fvco * m_table[m];
5673230d6a56d6 Qin Jian 2022-08-17  167 n = nf / F_27M;
5673230d6a56d6 Qin Jian 2022-08-17  168 if ((n * F_27M) == nf)
5673230d6a56d6 Qin Jian 2022-08-17  169 break;
5673230d6a56d6 Qin Jian 2022-08-17  170 }
5673230d6a56d6 Qin Jian 2022-08-17 @171 m = m_table[m];
5673230d6a56d6 Qin Jian 2022-08-17  172  
5673230d6a56d6 Qin Jian 2022-08-17  173 if (!m) {
5673230d6a56d6 Qin Jian 2022-08-17  174 ret = -EINVAL;
5673230d6a56d6 Qin Jian 2022-08-17  175 goto err_not_found;
5673230d6a56d6 Qin Jian 2022-08-17  176 }
5673230d6a56d6 Qin Jian 2022-08-17  177  
5673230d6a56d6 Qin Jian 2022-08-17  178 /* save parameters */
5673230d6a56d6 Qin Jian 2022-08-17  179 clk->p[SEL_FRA] = 0;
5673230d6a56d6 Qin Jian 2022-08-17  180 clk->p[DIVR]= r;
5673230d6a56d6 Qin Jian 2022-08-17  181 clk->p[DIVN]= n;
5673230d6a56d6 Qin Jian 2022-08-17  182 clk->p[DIVM]= m;
5673230d6a56d6 Qin Jian 2022-08-17  183  
5673230d6a56d6 Qin Jian 2022-08-17  184 return freq;
5673230d6a56d6 Qin Jian 2022-08-17  185  
5673230d6a56d6 Qin Jian 2022-08-17  186  err_not_found:
5673230d6a56d6 Qin Jian 2022-08-17  187 pr_err("%s: %s freq:%lu not 
found a valid setting\n",
5673230d6a56d6 Qin Jian 2022-08-17  188__func__, 
clk_hw_get_name(>hw), freq);
5673230d6a56d6 Qin Jian 2022-08-17  189  
5673230d6a56d6 Qin Jian 2022-08-17  190 return ret;
5673230d6a56d6 Qin Jian 2022-08-17  191  }
5673230d6a56d6 Qin Jian 2022-08-17  192  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer to 'PTR_ERR'

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: SeongJae Park 
CC: Andrew Morton 
CC: Linux Memory Management List 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 90bebce9fcd6488ba6b010af3a16a0a0d7e44cb6 mm/damon/dbgfs: allow users to 
set initial monitoring target regions
date:   10 months ago
:: branch date: 14 hours ago
:: commit date: 10 months ago
config: parisc-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208212035.pgllmhdc-...@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer 
to 'PTR_ERR'

vim +/PTR_ERR +525 mm/damon/dbgfs.c

90bebce9fcd648 SeongJae Park 2021-11-05  513  
90bebce9fcd648 SeongJae Park 2021-11-05  514  static ssize_t 
dbgfs_init_regions_write(struct file *file,
90bebce9fcd648 SeongJae Park 2021-11-05  515
  const char __user *buf, size_t count,
90bebce9fcd648 SeongJae Park 2021-11-05  516
  loff_t *ppos)
90bebce9fcd648 SeongJae Park 2021-11-05  517  {
90bebce9fcd648 SeongJae Park 2021-11-05  518struct damon_ctx *ctx = 
file->private_data;
90bebce9fcd648 SeongJae Park 2021-11-05  519char *kbuf;
90bebce9fcd648 SeongJae Park 2021-11-05  520ssize_t ret = count;
90bebce9fcd648 SeongJae Park 2021-11-05  521int err;
90bebce9fcd648 SeongJae Park 2021-11-05  522  
90bebce9fcd648 SeongJae Park 2021-11-05  523kbuf = user_input_str(buf, 
count, ppos);
90bebce9fcd648 SeongJae Park 2021-11-05  524if (IS_ERR(kbuf))
90bebce9fcd648 SeongJae Park 2021-11-05 @525return PTR_ERR(kbuf);
90bebce9fcd648 SeongJae Park 2021-11-05  526  
90bebce9fcd648 SeongJae Park 2021-11-05  527mutex_lock(>kdamond_lock);
90bebce9fcd648 SeongJae Park 2021-11-05  528if (ctx->kdamond) {
90bebce9fcd648 SeongJae Park 2021-11-05  529ret = -EBUSY;
90bebce9fcd648 SeongJae Park 2021-11-05  530goto unlock_out;
90bebce9fcd648 SeongJae Park 2021-11-05  531}
90bebce9fcd648 SeongJae Park 2021-11-05  532  
90bebce9fcd648 SeongJae Park 2021-11-05  533err = set_init_regions(ctx, 
kbuf, ret);
90bebce9fcd648 SeongJae Park 2021-11-05  534if (err)
90bebce9fcd648 SeongJae Park 2021-11-05  535ret = err;
90bebce9fcd648 SeongJae Park 2021-11-05  536  
90bebce9fcd648 SeongJae Park 2021-11-05  537  unlock_out:
90bebce9fcd648 SeongJae Park 2021-11-05  538
mutex_unlock(>kdamond_lock);
90bebce9fcd648 SeongJae Park 2021-11-05  539kfree(kbuf);
90bebce9fcd648 SeongJae Park 2021-11-05  540return ret;
90bebce9fcd648 SeongJae Park 2021-11-05  541  }
90bebce9fcd648 SeongJae Park 2021-11-05  542  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] net/mctp/test/route-test.c:296:24: warning: use of uninitialized value '' [CWE-457]

2022-08-21 Thread kernel test robot

:: 
:: Manual check reason: "low confidence bisect report"
:: Manual check reason: "low confidence static check warning: 
net/mctp/test/route-test.c:296:24: warning: use of uninitialized value 
'' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]"
:: 

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Jeremy Kerr 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 8892c0490779d6de921eb684e5504708fdbbcb68 mctp: Add route input to 
socket tests
date:   11 months ago
:: branch date: 14 hours ago
:: commit date: 11 months ago
config: arm-randconfig-c002-20220820 
(https://download.01.org/0day-ci/archive/20220821/202208211931.8afmvusf-...@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8892c0490779d6de921eb684e5504708fdbbcb68
git remote add linus 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 8892c0490779d6de921eb684e5504708fdbbcb68
# save the config file
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross 
ARCH=arm KBUILD_USERCFLAGS='-fanalyzer -Wno-error' 

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 

gcc-analyzer warnings: (new ones prefixed by >>)
  |  | ~~~
  |  | |
  |  | (22) calling 'skb_orphan' from 'mctp_route_input'
  |
  +--> 'skb_orphan': events 23-25
 |
 |include/linux/skbuff.h:2781:20:
 | 2781 | static inline void skb_orphan(struct sk_buff *skb)
 |  |^~
 |  ||
 |  |(23) entry to 'skb_orphan'
 | 2782 | {
 | 2783 | if (skb->destructor) {
 |  |~
 |  ||
 |  |(24) following 'true' branch...
 | 2784 | skb->destructor(skb);
 |  | 
 |  | |
 |  | (25) ...to here
 |
  <--+
  |
'mctp_route_input': events 26-27
  |
  |net/mctp/route.c:278:9:
  |  278 | skb_orphan(skb);
  |  | ^~~
  |  | |
  |  | (26) returning to 'mctp_route_input' from 
'skb_orphan'
  |..
  |  281 | if (skb->len < sizeof(struct mctp_hdr) + 1)
  |  | 
  |  ||
  |  |(27) dereference of NULL 'skb'
  |
   net/mctp/route.c: In function 'mctp_newroute':
   net/mctp/route.c:1039:20: warning: use of uninitialized value '' 
[CWE-457] [-Wanalyzer-use-of-uninitialized-value]
1039 | mctp_eid_t daddr_start;
 |^~~
 'mctp_newroute': event 1
   |
   | 1039 | mctp_eid_t daddr_start;
   |  |^~~
   |  ||
   |  |(1) use of uninitialized value '' 
here
   |
   net/mctp/route.c:1040:26: warning: use of uninitialized value '' 
[CWE-457] [-Wanalyzer-use-of-uninitialized-value]
1040 | struct mctp_dev *mdev;
 |  ^~~~
 'mctp_newroute': event 1
   |
   | 1040 | struct mctp_dev *mdev;
   |  |  ^~~~
   |  |  |
   |  |  (1) use of uninitialized value 
'' here
   |
   net/mctp/route.c:1041:23: warning: use of uninitialized value '' 
[CWE-457] [-Wanalyzer-use-of-uninitialized-value]
1041 | struct rtmsg *rtm;
 |   ^~~
 'mctp_newroute': event 1
   |
   | 1041 | struct rtmsg *rtm;
   |  |   ^~~
   |  |   |
   |  |   (1) use of uninitialized value 
'' here
   |
   net/mctp/route.c: In function 'mctp_delroute':
   net/mctp/route.c:1077:20: warning: use of uninitialized value '' 
[CWE-457] [-Wanalyzer-use-of-uninit

[kbuild] [jgunthorpe:vfio_iommufd 27/29] drivers/vfio/vfio_main.c:1497 vfio_pin_pages() warn: impossible condition '(iova > (~0)) => (0-u32max > u32max)'

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Jason Gunthorpe 

tree:   https://github.com/jgunthorpe/linux vfio_iommufd
head:   d2ab4343c9f524e9404059830828188b0f8a15b6
commit: 56e95c20bf11a9c515cc81a5a367bf7417459651 [27/29] vfio-iommufd: Support 
iommufd for emulated VFIO devices
:: branch date: 2 days ago
:: commit date: 2 days ago
config: openrisc-randconfig-m041-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208211931.y3egh3ei-...@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/vfio/vfio_main.c:1497 vfio_pin_pages() warn: impossible condition 
'(iova > (~0)) => (0-u32max > u32max)'
drivers/vfio/vfio_main.c:1557 vfio_dma_rw() warn: impossible condition '(iova > 
(~0)) => (0-u32max > u32max)'

vim +1497 drivers/vfio/vfio_main.c

c747f08aea847c drivers/vfio/vfio.c  Kirti Wankhede  2016-11-17  1477  
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1478  /*
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1479   * 
Pin contiguous user pages and return their associated host pages for local
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1480   * 
domain only.
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1481   * 
@device [in]  : device
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1482   * 
@iova [in]: starting IOVA of user pages to be pinned.
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1483   * 
@npage [in]   : count of pages to be pinned.  This count should not
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1484   *
   be greater than VFIO_PIN_PAGES_MAX_ENTRIES.
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1485   * 
@prot [in]: protection flags
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1486   * 
@pages[out]   : array of host pages
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1487   * 
Return error or number of pages pinned.
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1488   */
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1489  int 
vfio_pin_pages(struct vfio_device *device, dma_addr_t iova,
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1490
   int npage, int prot, struct page **pages)
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1491  {
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1492
if (!pages || !npage || !vfio_assert_device_open(device))
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1493
return -EINVAL;
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1494
if (device->group->container)
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1495
return vfio_container_pin_pages(device, iova, npage, prot, pages);
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1496
if (device->iommufd_access) {
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11 @1497
if (iova > ULONG_MAX)
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1498
return -EINVAL;
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1499
return iommufd_access_pin_pages(device->iommufd_access, iova,
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1500
npage * PAGE_SIZE, pages,
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1501
prot & IOMMU_WRITE);
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1502
}
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1503
return -EINVAL;
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1504  }
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1505  
EXPORT_SYMBOL(vfio_pin_pages);
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1506  
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1507  /*
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1508   * 
Unpin contiguous host pages for local domain only.
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1509   * 
@device [in]  : device
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1510   * 
@iova [in]: starting address of user pages to be unpinned.
56e95c20bf11a9 drivers/vfio/vfio_main.c Jason Gunthorpe 2022-08-11  1511   * 
@npage [in]   : count of pages to be unpinned.  This count s

[kbuild] drivers/pci/endpoint/functions/pci-epf-vntb.c:907 epf_ntb_mw1_show() warn: potential spectre issue 'ntb->mws_size' [w]

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Dan Carpenter 
CC: Jon Mason 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: b8c0aa9b16bb2f4d5966b87fbf1f36f3280e1f60 NTB: EPF: Tidy up some bounds 
checks
date:   12 days ago
:: branch date: 13 hours ago
:: commit date: 12 days ago
config: arm64-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208211805.4b8ykdji-...@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

New smatch warnings:
drivers/pci/endpoint/functions/pci-epf-vntb.c:907 epf_ntb_mw1_show() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:909 epf_ntb_mw2_show() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:911 epf_ntb_mw3_show() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:913 epf_ntb_mw4_show() warn: 
potential spectre issue 'ntb->mws_size' [w]

Old smatch warnings:
drivers/pci/endpoint/functions/pci-epf-vntb.c:908 epf_ntb_mw1_store() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:910 epf_ntb_mw2_store() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:912 epf_ntb_mw3_store() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:914 epf_ntb_mw4_store() warn: 
potential spectre issue 'ntb->mws_size' [w]

vim +907 drivers/pci/endpoint/functions/pci-epf-vntb.c

e35f56bb03304a Frank Li 2022-02-22  895  
e35f56bb03304a Frank Li 2022-02-22  896  EPF_NTB_R(spad_count)
e35f56bb03304a Frank Li 2022-02-22  897  EPF_NTB_W(spad_count)
e35f56bb03304a Frank Li 2022-02-22  898  EPF_NTB_R(db_count)
e35f56bb03304a Frank Li 2022-02-22  899  EPF_NTB_W(db_count)
e35f56bb03304a Frank Li 2022-02-22  900  EPF_NTB_R(num_mws)
e35f56bb03304a Frank Li 2022-02-22  901  EPF_NTB_R(vbus_number)
e35f56bb03304a Frank Li 2022-02-22  902  EPF_NTB_W(vbus_number)
e35f56bb03304a Frank Li 2022-02-22  903  EPF_NTB_R(vntb_pid)
e35f56bb03304a Frank Li 2022-02-22  904  EPF_NTB_W(vntb_pid)
e35f56bb03304a Frank Li 2022-02-22  905  EPF_NTB_R(vntb_vid)
e35f56bb03304a Frank Li 2022-02-22  906  EPF_NTB_W(vntb_vid)
e35f56bb03304a Frank Li 2022-02-22 @907  EPF_NTB_MW_R(mw1)
e35f56bb03304a Frank Li 2022-02-22  908  EPF_NTB_MW_W(mw1)
e35f56bb03304a Frank Li 2022-02-22 @909  EPF_NTB_MW_R(mw2)
e35f56bb03304a Frank Li 2022-02-22  910  EPF_NTB_MW_W(mw2)
e35f56bb03304a Frank Li 2022-02-22 @911  EPF_NTB_MW_R(mw3)
e35f56bb03304a Frank Li 2022-02-22  912  EPF_NTB_MW_W(mw3)
e35f56bb03304a Frank Li 2022-02-22 @913  EPF_NTB_MW_R(mw4)
e35f56bb03304a Frank Li 2022-02-22  914  EPF_NTB_MW_W(mw4)
e35f56bb03304a Frank Li 2022-02-22  915  

:: The code at line 907 was first introduced by commit
:: e35f56bb03304abc92c928b641af41ca372966bb PCI: endpoint: Support NTB 
transfer between RC and EP

:: TO: Frank Li 
:: CC: Jon Mason 

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] [intel-lts:5.10/preempt-rt 17467/26241] net/core/rtnetlink.c:1500 rtnl_xdp_fill() warn: missing error code 'err'

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
TO: Muhammad Husaini Zulkifli 
CC: Zhou Furong 

tree:   https://github.com/intel/linux-intel-lts.git 5.10/preempt-rt
head:   b97f048cafa8075c428c7e576fd2ee5c28538898
commit: 1be929fc6b6c1e732163f5c3ab53d055a3429bca [17467/26241] rtnetlink: Fix 
unchecked return value of dev_xdp_query_md_btf()
:: branch date: 6 days ago
:: commit date: 12 months ago
config: x86_64-randconfig-m001 
(https://download.01.org/0day-ci/archive/20220821/202208211704.wsrnj8wo-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
net/core/rtnetlink.c:1500 rtnl_xdp_fill() warn: missing error code 'err'

vim +/err +1500 net/core/rtnetlink.c

d67b9cd28c1d7f Daniel Borkmann   2017-05-12  1460  
d1fdd9138682e0 Brenden Blanco2016-07-19  1461  static int 
rtnl_xdp_fill(struct sk_buff *skb, struct net_device *dev)
d1fdd9138682e0 Brenden Blanco2016-07-19  1462  {
26ce18bde6b36f Muhammad Husaini Zulkifli 2021-06-14  1463   u32 prog_id, 
md_btf_id;
26ce18bde6b36f Muhammad Husaini Zulkifli 2021-06-14  1464   u8 
md_btf_enabled = 0;
d1fdd9138682e0 Brenden Blanco2016-07-19  1465   struct nlattr 
*xdp;
d1fdd9138682e0 Brenden Blanco2016-07-19  1466   int err;
4f91da26c81145 Jakub Kicinski2018-07-11  1467   u8 mode;
d1fdd9138682e0 Brenden Blanco2016-07-19  1468  
ae0be8de9a53cd Michal Kubecek2019-04-26  1469   xdp = 
nla_nest_start_noflag(skb, IFLA_XDP);
d1fdd9138682e0 Brenden Blanco2016-07-19  1470   if (!xdp)
d1fdd9138682e0 Brenden Blanco2016-07-19  1471   return 
-EMSGSIZE;
d1fdd9138682e0 Brenden Blanco2016-07-19  1472  
a25717d2b60434 Jakub Kicinski2018-07-11  1473   prog_id = 0;
a25717d2b60434 Jakub Kicinski2018-07-11  1474   mode = 
XDP_ATTACHED_NONE;
202aabe84a8fd8 Jakub Kicinski2018-07-16  1475   err = 
rtnl_xdp_report_one(skb, dev, _id, , XDP_ATTACHED_SKB,
202aabe84a8fd8 Jakub Kicinski2018-07-16  1476   
  IFLA_XDP_SKB_PROG_ID, rtnl_xdp_prog_skb);
202aabe84a8fd8 Jakub Kicinski2018-07-16  1477   if (err)
b5cdae3291f7be David S. Miller   2017-04-18  1478   goto 
err_cancel;
202aabe84a8fd8 Jakub Kicinski2018-07-16  1479   err = 
rtnl_xdp_report_one(skb, dev, _id, , XDP_ATTACHED_DRV,
202aabe84a8fd8 Jakub Kicinski2018-07-16  1480   
  IFLA_XDP_DRV_PROG_ID, rtnl_xdp_prog_drv);
202aabe84a8fd8 Jakub Kicinski2018-07-16  1481   if (err)
a25717d2b60434 Jakub Kicinski2018-07-11  1482   goto 
err_cancel;
202aabe84a8fd8 Jakub Kicinski2018-07-16  1483   err = 
rtnl_xdp_report_one(skb, dev, _id, , XDP_ATTACHED_HW,
202aabe84a8fd8 Jakub Kicinski2018-07-16  1484   
  IFLA_XDP_HW_PROG_ID, rtnl_xdp_prog_hw);
202aabe84a8fd8 Jakub Kicinski2018-07-16  1485   if (err)
58038695e62b44 Martin KaFai Lau  2017-06-15  1486   goto 
err_cancel;
4f91da26c81145 Jakub Kicinski2018-07-11  1487  
a25717d2b60434 Jakub Kicinski2018-07-11  1488   err = 
nla_put_u8(skb, IFLA_XDP_ATTACHED, mode);
b5cdae3291f7be David S. Miller   2017-04-18  1489   if (err)
b5cdae3291f7be David S. Miller   2017-04-18  1490   goto 
err_cancel;
d67b9cd28c1d7f Daniel Borkmann   2017-05-12  1491  
a25717d2b60434 Jakub Kicinski2018-07-11  1492   if (prog_id && 
mode != XDP_ATTACHED_MULTI) {
58038695e62b44 Martin KaFai Lau  2017-06-15  1493   err = 
nla_put_u32(skb, IFLA_XDP_PROG_ID, prog_id);
58038695e62b44 Martin KaFai Lau  2017-06-15  1494   if (err)
58038695e62b44 Martin KaFai Lau  2017-06-15  1495   
goto err_cancel;
58038695e62b44 Martin KaFai Lau  2017-06-15  1496   }
58038695e62b44 Martin KaFai Lau  2017-06-15  1497  
26ce18bde6b36f Muhammad Husaini Zulkifli 2021-06-14  1498   md_btf_id = 
dev_xdp_query_md_btf(dev, _btf_enabled);
1be929fc6b6c1e Muhammad Husaini Zulkifli 2021-07-30  1499   if (!md_btf_id)
1be929fc6b6c1e Muhammad Husaini Zulkifli 2021-07-30 @1500   goto 
err_cancel;
1be929fc6b6c1e Muhammad Husaini Zulkifli 2021-07-30  1501  
26ce18bde6b36f Muhammad Husaini Zulkifli 2021-06-14  1502   
nla_put_u32(skb, IFLA_XDP_MD_BTF_ID, md_btf_id);
26ce18bde6b36f Muhammad Husaini Zulkifli 2021-06-14  1503   nla_put_u8(skb, 
IFLA_XDP_MD_BTF_STATE, md_btf_enabled);
26ce18bde6b36f Muhammad Husaini Zulkifli 2021-06-14  1504  
d1fdd9138682e0 Brenden Blanco2016-07-19  1505   
nla_nest_end(skb, xdp);
d1fdd9

[kbuild] mm/damon/dbgfs.c:227 dbgfs_schemes_write() warn: passing a valid pointer to 'PTR_ERR'

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: SeongJae Park 
CC: Andrew Morton 
CC: Linux Memory Management List 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: af122dd8f3c0099349bc98ff69f0d90efd8b149f mm/damon/dbgfs: support 
DAMON-based Operation Schemes
date:   10 months ago
:: branch date: 11 hours ago
:: commit date: 10 months ago
config: parisc-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208211602.0nj8xuw7-...@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
mm/damon/dbgfs.c:227 dbgfs_schemes_write() warn: passing a valid pointer to 
'PTR_ERR'

vim +/PTR_ERR +227 mm/damon/dbgfs.c

af122dd8f3c009 SeongJae Park 2021-11-05  215  
af122dd8f3c009 SeongJae Park 2021-11-05  216  static ssize_t 
dbgfs_schemes_write(struct file *file, const char __user *buf,
af122dd8f3c009 SeongJae Park 2021-11-05  217size_t count, loff_t 
*ppos)
af122dd8f3c009 SeongJae Park 2021-11-05  218  {
af122dd8f3c009 SeongJae Park 2021-11-05  219struct damon_ctx *ctx = 
file->private_data;
af122dd8f3c009 SeongJae Park 2021-11-05  220char *kbuf;
af122dd8f3c009 SeongJae Park 2021-11-05  221struct damos **schemes;
af122dd8f3c009 SeongJae Park 2021-11-05  222ssize_t nr_schemes = 0, ret = 
count;
af122dd8f3c009 SeongJae Park 2021-11-05  223int err;
af122dd8f3c009 SeongJae Park 2021-11-05  224  
af122dd8f3c009 SeongJae Park 2021-11-05  225kbuf = user_input_str(buf, 
count, ppos);
af122dd8f3c009 SeongJae Park 2021-11-05  226if (IS_ERR(kbuf))
af122dd8f3c009 SeongJae Park 2021-11-05 @227return PTR_ERR(kbuf);
af122dd8f3c009 SeongJae Park 2021-11-05  228  
af122dd8f3c009 SeongJae Park 2021-11-05  229schemes = str_to_schemes(kbuf, 
ret, _schemes);
af122dd8f3c009 SeongJae Park 2021-11-05  230if (!schemes) {
af122dd8f3c009 SeongJae Park 2021-11-05  231ret = -EINVAL;
af122dd8f3c009 SeongJae Park 2021-11-05  232goto out;
af122dd8f3c009 SeongJae Park 2021-11-05  233}
af122dd8f3c009 SeongJae Park 2021-11-05  234  
af122dd8f3c009 SeongJae Park 2021-11-05  235mutex_lock(>kdamond_lock);
af122dd8f3c009 SeongJae Park 2021-11-05  236if (ctx->kdamond) {
af122dd8f3c009 SeongJae Park 2021-11-05  237ret = -EBUSY;
af122dd8f3c009 SeongJae Park 2021-11-05  238goto unlock_out;
af122dd8f3c009 SeongJae Park 2021-11-05  239}
af122dd8f3c009 SeongJae Park 2021-11-05  240  
af122dd8f3c009 SeongJae Park 2021-11-05  241err = damon_set_schemes(ctx, 
schemes, nr_schemes);
af122dd8f3c009 SeongJae Park 2021-11-05  242if (err)
af122dd8f3c009 SeongJae Park 2021-11-05  243ret = err;
af122dd8f3c009 SeongJae Park 2021-11-05  244else
af122dd8f3c009 SeongJae Park 2021-11-05  245nr_schemes = 0;
af122dd8f3c009 SeongJae Park 2021-11-05  246  unlock_out:
af122dd8f3c009 SeongJae Park 2021-11-05  247
mutex_unlock(>kdamond_lock);
af122dd8f3c009 SeongJae Park 2021-11-05  248free_schemes_arr(schemes, 
nr_schemes);
af122dd8f3c009 SeongJae Park 2021-11-05  249  out:
af122dd8f3c009 SeongJae Park 2021-11-05  250kfree(kbuf);
af122dd8f3c009 SeongJae Park 2021-11-05  251return ret;
af122dd8f3c009 SeongJae Park 2021-11-05  252  }
af122dd8f3c009 SeongJae Park 2021-11-05  253  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/pci/endpoint/functions/pci-epf-vntb.c:891 epf_ntb_mw1_store() warn: potential spectre issue 'ntb->mws_size' [w]

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Frank Li 
CC: Jon Mason 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: e35f56bb03304abc92c928b641af41ca372966bb PCI: endpoint: Support NTB 
transfer between RC and EP
date:   11 days ago
:: branch date: 10 hours ago
:: commit date: 11 days ago
config: arm64-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208211553.oqhmwzdj-...@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

New smatch warnings:
drivers/pci/endpoint/functions/pci-epf-vntb.c:891 epf_ntb_mw1_store() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:893 epf_ntb_mw2_store() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:895 epf_ntb_mw3_store() warn: 
potential spectre issue 'ntb->mws_size' [w]
drivers/pci/endpoint/functions/pci-epf-vntb.c:897 epf_ntb_mw4_store() warn: 
potential spectre issue 'ntb->mws_size' [w]

Old smatch warnings:
drivers/pci/endpoint/functions/pci-epf-vntb.c:1316 epf_ntb_bind() warn: missing 
error code 'ret'

vim +891 drivers/pci/endpoint/functions/pci-epf-vntb.c

e35f56bb03304a Frank Li 2022-02-22  878  
e35f56bb03304a Frank Li 2022-02-22  879  EPF_NTB_R(spad_count)
e35f56bb03304a Frank Li 2022-02-22  880  EPF_NTB_W(spad_count)
e35f56bb03304a Frank Li 2022-02-22  881  EPF_NTB_R(db_count)
e35f56bb03304a Frank Li 2022-02-22  882  EPF_NTB_W(db_count)
e35f56bb03304a Frank Li 2022-02-22  883  EPF_NTB_R(num_mws)
e35f56bb03304a Frank Li 2022-02-22  884  EPF_NTB_R(vbus_number)
e35f56bb03304a Frank Li 2022-02-22  885  EPF_NTB_W(vbus_number)
e35f56bb03304a Frank Li 2022-02-22  886  EPF_NTB_R(vntb_pid)
e35f56bb03304a Frank Li 2022-02-22  887  EPF_NTB_W(vntb_pid)
e35f56bb03304a Frank Li 2022-02-22  888  EPF_NTB_R(vntb_vid)
e35f56bb03304a Frank Li 2022-02-22  889  EPF_NTB_W(vntb_vid)
e35f56bb03304a Frank Li 2022-02-22  890  EPF_NTB_MW_R(mw1)
e35f56bb03304a Frank Li 2022-02-22 @891  EPF_NTB_MW_W(mw1)
e35f56bb03304a Frank Li 2022-02-22  892  EPF_NTB_MW_R(mw2)
e35f56bb03304a Frank Li 2022-02-22 @893  EPF_NTB_MW_W(mw2)
e35f56bb03304a Frank Li 2022-02-22  894  EPF_NTB_MW_R(mw3)
e35f56bb03304a Frank Li 2022-02-22 @895  EPF_NTB_MW_W(mw3)
e35f56bb03304a Frank Li 2022-02-22  896  EPF_NTB_MW_R(mw4)
e35f56bb03304a Frank Li 2022-02-22 @897  EPF_NTB_MW_W(mw4)
e35f56bb03304a Frank Li 2022-02-22  898  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]

2022-08-21 Thread kernel test robot

:: 
:: Manual check reason: "low confidence static check warning: 
drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: 
entity->id [uninitvar]"
:: 

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Haijun Liu 
CC: Chandrashekar Devegowda 
CC: Ricardo Martinez 
CC: "Ilpo Järvinen" 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 46e8f49ed7b3063f51e28f3ea2084b3da29c1503 net: wwan: t7xx: Introduce 
power management
date:   3 months ago
:: branch date: 10 hours ago
:: commit date: 3 months ago
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (cppcheck warning):
# apt-get install cppcheck
git checkout 46e8f49ed7b3063f51e28f3ea2084b3da29c1503
cppcheck --quiet --enable=style,performance,portability --template=gcc 
FILE

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: 
>> entity->id [uninitvar]
 if (entity->id == pm_entity->id) {
 ^
   drivers/net/wwan/t7xx/t7xx_pci.c:141:15: warning: Uninitialized variable: 
entity->id [uninitvar]
 if (entity->id == pm_entity->id) {
 ^
>> drivers/net/wwan/t7xx/t7xx_pci.c:382:15: warning: Uninitialized variable: 
>> entity->resume_early [uninitvar]
 if (entity->resume_early)
 ^
   drivers/net/wwan/t7xx/t7xx_pci.c:309:42: note: Assuming condition is false
if (atomic_read(_dev->md_pm_state) <= MTK_PM_INIT) {
^
   drivers/net/wwan/t7xx/t7xx_pci.c:382:15: note: Uninitialized variable: 
entity->resume_early
 if (entity->resume_early)
 ^
--
>> drivers/net/wwan/t7xx/t7xx_port_proxy.c:325:33: warning: Uninitialized 
>> variable: port_conf [uninitvar]
 if (queue->md_ctrl->hif_id == port_conf->path_id &&
   ^
   drivers/net/wwan/t7xx/t7xx_port_proxy.c:323:48: note: Assignment 
'port_conf=port->port_conf', assigned value is 
 const struct t7xx_port_conf *port_conf = port->port_conf;
  ^
   drivers/net/wwan/t7xx/t7xx_port_proxy.c:325:33: note: Uninitialized 
variable: port_conf
 if (queue->md_ctrl->hif_id == port_conf->path_id &&
   ^
>> drivers/net/wwan/t7xx/t7xx_port_proxy.c:327:11: warning: Uninitialized 
>> variables: port.port_conf, port.wwan_port, port.t7xx_dev, port.dev, 
>> port.usage_cnt, port.entry, port.queue_entry, port.rx_skb_list, 
>> port.port_update_lock, port.rx_wq, port.rx_length_th, port.chan_enable, 
>> port.thread [uninitvar]
  return port;
 ^

vim +124 drivers/net/wwan/t7xx/t7xx_pci.c

46e8f49ed7b306 Haijun Liu 2022-05-06  117  
46e8f49ed7b306 Haijun Liu 2022-05-06  118  int 
t7xx_pci_pm_entity_register(struct t7xx_pci_dev *t7xx_dev, struct md_pm_entity 
*pm_entity)
46e8f49ed7b306 Haijun Liu 2022-05-06  119  {
46e8f49ed7b306 Haijun Liu 2022-05-06  120   struct md_pm_entity *entity;
46e8f49ed7b306 Haijun Liu 2022-05-06  121  
46e8f49ed7b306 Haijun Liu 2022-05-06  122   
mutex_lock(_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06  123   list_for_each_entry(entity, 
_dev->md_pm_entities, entity) {
46e8f49ed7b306 Haijun Liu 2022-05-06 @124   if (entity->id == 
pm_entity->id) {
46e8f49ed7b306 Haijun Liu 2022-05-06  125   
mutex_unlock(_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06  126   return -EEXIST;
46e8f49ed7b306 Haijun Liu 2022-05-06  127   }
46e8f49ed7b306 Haijun Liu 2022-05-06  128   }
46e8f49ed7b306 Haijun Liu 2022-05-06  129  
46e8f49ed7b306 Haijun Liu 2022-05-06  130   
list_add_tail(_entity->entity, _dev->md_pm_entities);
46e8f49ed7b306 Haijun Liu 2022-05-06  131   
mutex_unlock(_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06  132   return 0;
46e8f49ed7b306 Haijun Liu 2022-05-06  133  }
46e8f49ed7b306 Haijun Liu 2022-05-06  134  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] mm/damon/dbgfs.c:396 dbgfs_mk_context_write() warn: passing a valid pointer to 'PTR_ERR'

2022-08-21 Thread kernel test robot

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: SeongJae Park 
CC: Fernand Sieber 
CC: Andrew Morton 
CC: Linux Memory Management List 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 75c1c2b53c78bf3b3188ebb7b3508dadbf98bba1 mm/damon/dbgfs: support 
multiple contexts
date:   12 months ago
:: branch date: 9 hours ago
:: commit date: 12 months ago
config: parisc-randconfig-m031-20220821 
(https://download.01.org/0day-ci/archive/20220821/202208211443.txmkztg3-...@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
mm/damon/dbgfs.c:396 dbgfs_mk_context_write() warn: passing a valid pointer to 
'PTR_ERR'
mm/damon/dbgfs.c:487 dbgfs_rm_context_write() warn: passing a valid pointer to 
'PTR_ERR'

vim +/PTR_ERR +396 mm/damon/dbgfs.c

75c1c2b53c78bf SeongJae Park 2021-09-07  385  
75c1c2b53c78bf SeongJae Park 2021-09-07  386  static ssize_t 
dbgfs_mk_context_write(struct file *file,
75c1c2b53c78bf SeongJae Park 2021-09-07  387const char __user *buf, 
size_t count, loff_t *ppos)
75c1c2b53c78bf SeongJae Park 2021-09-07  388  {
75c1c2b53c78bf SeongJae Park 2021-09-07  389char *kbuf;
75c1c2b53c78bf SeongJae Park 2021-09-07  390char *ctx_name;
75c1c2b53c78bf SeongJae Park 2021-09-07  391ssize_t ret = count;
75c1c2b53c78bf SeongJae Park 2021-09-07  392int err;
75c1c2b53c78bf SeongJae Park 2021-09-07  393  
75c1c2b53c78bf SeongJae Park 2021-09-07  394kbuf = user_input_str(buf, 
count, ppos);
75c1c2b53c78bf SeongJae Park 2021-09-07  395if (IS_ERR(kbuf))
75c1c2b53c78bf SeongJae Park 2021-09-07 @396return PTR_ERR(kbuf);
75c1c2b53c78bf SeongJae Park 2021-09-07  397ctx_name = kmalloc(count + 1, 
GFP_KERNEL);
75c1c2b53c78bf SeongJae Park 2021-09-07  398if (!ctx_name) {
75c1c2b53c78bf SeongJae Park 2021-09-07  399kfree(kbuf);
75c1c2b53c78bf SeongJae Park 2021-09-07  400return -ENOMEM;
75c1c2b53c78bf SeongJae Park 2021-09-07  401}
75c1c2b53c78bf SeongJae Park 2021-09-07  402  
75c1c2b53c78bf SeongJae Park 2021-09-07  403/* Trim white space */
75c1c2b53c78bf SeongJae Park 2021-09-07  404if (sscanf(kbuf, "%s", 
ctx_name) != 1) {
75c1c2b53c78bf SeongJae Park 2021-09-07  405ret = -EINVAL;
75c1c2b53c78bf SeongJae Park 2021-09-07  406goto out;
75c1c2b53c78bf SeongJae Park 2021-09-07  407}
75c1c2b53c78bf SeongJae Park 2021-09-07  408  
75c1c2b53c78bf SeongJae Park 2021-09-07  409mutex_lock(_dbgfs_lock);
75c1c2b53c78bf SeongJae Park 2021-09-07  410err = 
dbgfs_mk_context(ctx_name);
75c1c2b53c78bf SeongJae Park 2021-09-07  411if (err)
75c1c2b53c78bf SeongJae Park 2021-09-07  412ret = err;
75c1c2b53c78bf SeongJae Park 2021-09-07  413mutex_unlock(_dbgfs_lock);
75c1c2b53c78bf SeongJae Park 2021-09-07  414  
75c1c2b53c78bf SeongJae Park 2021-09-07  415  out:
75c1c2b53c78bf SeongJae Park 2021-09-07  416kfree(kbuf);
75c1c2b53c78bf SeongJae Park 2021-09-07  417kfree(ctx_name);
75c1c2b53c78bf SeongJae Park 2021-09-07  418return ret;
75c1c2b53c78bf SeongJae Park 2021-09-07  419  }
75c1c2b53c78bf SeongJae Park 2021-09-07  420  
75c1c2b53c78bf SeongJae Park 2021-09-07  421  /*
75c1c2b53c78bf SeongJae Park 2021-09-07  422   * Remove a context of @name and 
its debugfs directory.
75c1c2b53c78bf SeongJae Park 2021-09-07  423   *
75c1c2b53c78bf SeongJae Park 2021-09-07  424   * This function should be called 
while holding damon_dbgfs_lock.
75c1c2b53c78bf SeongJae Park 2021-09-07  425   *
75c1c2b53c78bf SeongJae Park 2021-09-07  426   * Return 0 on success, negative 
error code otherwise.
75c1c2b53c78bf SeongJae Park 2021-09-07  427   */
75c1c2b53c78bf SeongJae Park 2021-09-07  428  static int dbgfs_rm_context(char 
*name)
75c1c2b53c78bf SeongJae Park 2021-09-07  429  {
75c1c2b53c78bf SeongJae Park 2021-09-07  430struct dentry *root, *dir, 
**new_dirs;
75c1c2b53c78bf SeongJae Park 2021-09-07  431struct damon_ctx **new_ctxs;
75c1c2b53c78bf SeongJae Park 2021-09-07  432int i, j;
75c1c2b53c78bf SeongJae Park 2021-09-07  433  
75c1c2b53c78bf SeongJae Park 2021-09-07  434if (damon_nr_running_ctxs())
75c1c2b53c78bf SeongJae Park 2021-09-07  435return -EBUSY;
75c1c2b53c78bf SeongJae Park 2021-09-07  436  
75c1c2b53c78bf SeongJae Park 2021-09-07  437root = dbgfs_dirs[0];
75c1c2b53c78bf SeongJae Park 2021-09-07  438if (!root)
75c1c2b53c78bf SeongJae Park 2021-09-07  439return -ENOENT;
75c1c2b53c78bf SeongJae Park 2021-09-07  440  
75c1c2b53c78bf SeongJae Park 2021-09-07  441dir = debugfs_lookup(name, 
root);
75c1c2b53c78bf SeongJae Park 2021-09-07  442if (!dir)
75c1c2b53c78bf SeongJae Park 2021-09-07  443return -ENOENT;
75c1c2b53c78bf SeongJae Park

[kbuild] drivers/net/wwan/t7xx/t7xx_state_monitor.c:67:7: warning: Uninitialized variables: notifier_cur.entry, notifier_cur.notifier_fn, notifier_cur.data [uninitvar]

2022-08-21 Thread kernel test robot

:: 
:: Manual check reason: "low confidence static check warning: 
drivers/net/wwan/t7xx/t7xx_state_monitor.c:67:7: warning: Uninitialized 
variables: notifier_cur.entry, notifier_cur.notifier_fn, notifier_cur.data 
[uninitvar]"
:: 

BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Haijun Liu 
CC: Chandrashekar Devegowda 
CC: Ricardo Martinez 
CC: Loic Poulain 
CC: "Ilpo Järvinen" 
CC: Sergey Ryazanov 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 13e920d93e37fcaef4a9309515798a3cae9dcf19 net: wwan: t7xx: Add core 
components
date:   3 months ago
:: branch date: 8 hours ago
:: commit date: 3 months ago
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (cppcheck warning):
# apt-get install cppcheck
git checkout 13e920d93e37fcaef4a9309515798a3cae9dcf19
cppcheck --quiet --enable=style,performance,portability --template=gcc 
FILE

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot 


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/wwan/t7xx/t7xx_state_monitor.c:67:7: warning: Uninitialized 
>> variables: notifier_cur.entry, notifier_cur.notifier_fn, notifier_cur.data 
>> [uninitvar]
 if (notifier_cur == notifier)
 ^
>> drivers/net/wwan/t7xx/t7xx_state_monitor.c:82:17: warning: Uninitialized 
>> variable: notifier->notifier_fn [uninitvar]
 if (notifier->notifier_fn)
   ^
>> drivers/net/wwan/t7xx/t7xx_state_monitor.c:123:27: warning: Uninitialized 
>> variables: cmd.flag, cmd.done, cmd.ret [uninitvar]
 fsm_finish_command(ctl, cmd, -EINVAL);
 ^
>> drivers/net/wwan/t7xx/t7xx_state_monitor.c:130:20: warning: Uninitialized 
>> variables: event.entry, event.length [uninitvar]
 fsm_del_kf_event(event);
  ^
>> drivers/net/wwan/t7xx/t7xx_state_monitor.c:455:14: warning: Uninitialized 
>> variable: event->event_id [uninitvar]
 if (event->event_id == event_id)
^
--
>> drivers/net/wwan/t7xx/t7xx_hif_cldma.c:370:16: warning: Uninitialized 
>> variable: req_cur->mapped_buff [uninitvar]
 if (req_cur->mapped_buff && req_cur->skb) {
  ^
>> drivers/net/wwan/t7xx/t7xx_hif_cldma.c:786:12: warning: Uninitialized 
>> variable: req->skb [uninitvar]
 if (req->skb) {
  ^

vim +67 drivers/net/wwan/t7xx/t7xx_state_monitor.c

13e920d93e37fc Haijun Liu 2022-05-06   58  
13e920d93e37fc Haijun Liu 2022-05-06   59  void 
t7xx_fsm_notifier_unregister(struct t7xx_modem *md, struct t7xx_fsm_notifier 
*notifier)
13e920d93e37fc Haijun Liu 2022-05-06   60  {
13e920d93e37fc Haijun Liu 2022-05-06   61   struct t7xx_fsm_notifier 
*notifier_cur, *notifier_next;
13e920d93e37fc Haijun Liu 2022-05-06   62   struct t7xx_fsm_ctl *ctl = 
md->fsm_ctl;
13e920d93e37fc Haijun Liu 2022-05-06   63   unsigned long flags;
13e920d93e37fc Haijun Liu 2022-05-06   64  
13e920d93e37fc Haijun Liu 2022-05-06   65   
spin_lock_irqsave(>notifier_lock, flags);
13e920d93e37fc Haijun Liu 2022-05-06   66   
list_for_each_entry_safe(notifier_cur, notifier_next, >notifier_list, 
entry) {
13e920d93e37fc Haijun Liu 2022-05-06  @67   if (notifier_cur == 
notifier)
13e920d93e37fc Haijun Liu 2022-05-06   68   
list_del(>entry);
13e920d93e37fc Haijun Liu 2022-05-06   69   }
13e920d93e37fc Haijun Liu 2022-05-06   70   
spin_unlock_irqrestore(>notifier_lock, flags);
13e920d93e37fc Haijun Liu 2022-05-06   71  }
13e920d93e37fc Haijun Liu 2022-05-06   72  
13e920d93e37fc Haijun Liu 2022-05-06   73  static void fsm_state_notify(struct 
t7xx_modem *md, enum md_state state)
13e920d93e37fc Haijun Liu 2022-05-06   74  {
13e920d93e37fc Haijun Liu 2022-05-06   75   struct t7xx_fsm_ctl *ctl = 
md->fsm_ctl;
13e920d93e37fc Haijun Liu 2022-05-06   76   struct t7xx_fsm_notifier 
*notifier;
13e920d93e37fc Haijun Liu 2022-05-06   77   unsigned long flags;
13e920d93e37fc Haijun Liu 2022-05-06   78  
13e920d93e37fc Haijun Liu 2022-05-06   79   
spin_lock_irqsave(>notifier_lock, flags);
13e920d93e37fc Haijun Liu 2022-05-06   80   list_for_each_entry(notifier, 
>notifier_list, entry) {
13e920d93e37fc Haijun Liu 2022-05-06   81   
spin_unlock_irqrestore(>notifier_lock, flags);
13e920d93e37fc Haijun Liu 2022-05-06  @82   if 
(notifier->notifier_fn)
13e920d93e37fc Haijun Liu 2022-05-06   83   
notifier->notifier_fn(state, notifier->data);
13e920d93e37fc Haijun Liu 2022-05-06   84  
13e920d93e37fc Haijun Liu 2022-05-06   85   
spin_lock_irqsave(>notifier_lock, flags);
13e920d93e37fc Haijun Liu 2022-05-06   86   }
13e920d93e37fc Haijun Liu 2022-05-06   87   
spin_unlock_irqrestore(>notifier_lock, flags);
13e920d93e37fc Haijun Liu 2022-05-06   88  }
13e920d93e37fc

[kbuild] Re: [PATCH 01/31] crypto: Introduce crypto_pool

[kbuild] drivers/soundwire/qcom.c:478 qcom_swrm_enumerate() error: buffer overflow 'ctrl->status' 11 <= 11

[kbuild] [leon-rdma:rdma-next 12/27] drivers/vfio/vfio_main.c:1756 vfio_ioctl_device_feature_logging_report() warn: comparison of a potentially tagged address (vfio_ioctl_device_feature_logging_report

[kbuild] Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

[kbuild] Re: [PATCH v9 3/4] pwm: add microchip soft ip corePWM driver

[kbuild] drivers/comedi/drivers/comedi_8254.c:164 __i8254_write() warn: ignoring unreachable code.

[kbuild] drivers/soundwire/qcom.c:1319 qcom_swrm_probe() warn: passing zero to 'PTR_ERR'

[kbuild] Re: [PATCH] clk: Add Sunplus SP7021 clock driver

[kbuild] mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer to 'PTR_ERR'

[kbuild] net/mctp/test/route-test.c:296:24: warning: use of uninitialized value '' [CWE-457]

[kbuild] [jgunthorpe:vfio_iommufd 27/29] drivers/vfio/vfio_main.c:1497 vfio_pin_pages() warn: impossible condition '(iova > (~0)) => (0-u32max > u32max)'

[kbuild] drivers/pci/endpoint/functions/pci-epf-vntb.c:907 epf_ntb_mw1_show() warn: potential spectre issue 'ntb->mws_size' [w]

[kbuild] [intel-lts:5.10/preempt-rt 17467/26241] net/core/rtnetlink.c:1500 rtnl_xdp_fill() warn: missing error code 'err'

[kbuild] mm/damon/dbgfs.c:227 dbgfs_schemes_write() warn: passing a valid pointer to 'PTR_ERR'

[kbuild] drivers/pci/endpoint/functions/pci-epf-vntb.c:891 epf_ntb_mw1_store() warn: potential spectre issue 'ntb->mws_size' [w]

[kbuild] drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]

[kbuild] mm/damon/dbgfs.c:396 dbgfs_mk_context_write() warn: passing a valid pointer to 'PTR_ERR'

[kbuild] drivers/net/wwan/t7xx/t7xx_state_monitor.c:67:7: warning: Uninitialized variables: notifier_cur.entry, notifier_cur.notifier_fn, notifier_cur.data [uninitvar]

18 matches

Site Navigation

Mail list logo

Footer information