CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Mark Pearson <markpear...@lenovo.com>
CC: Hans de Goede <hdego...@redhat.com>
CC: Mark Gross <markgr...@kernel.org>
CC: platform-driver-...@vger.kernel.org
CC: linux-ker...@vger.kernel.org

From: kernel test robot <l...@intel.com>

drivers/platform/x86/think-lmi.c:284:32-33: WARNING opportunity for min()


 Check for opencoded min(), max() implementations.
 Generated patches sometimes require adding a cast to fix compile warning.
 Warnings/patches scope intentionally limited to a function body.

Generated by: scripts/coccinelle/misc/minmax.cocci

Fixes: 640a5fa50a42 ("platform/x86: think-lmi: Opcode support")
CC: Mark Pearson <markpear...@lenovo.com>
Reported-by: kernel test robot <l...@intel.com>
Signed-off-by: kernel test robot <l...@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   34e047aa16c0123bbae8e2f6df33e5ecc1f56601
commit: 640a5fa50a42b99bfa2a0ec51b4ea9591d9bd055 platform/x86: think-lmi: 
Opcode support
:::::: branch date: 7 hours ago
:::::: commit date: 4 months ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/platform/x86/think-lmi.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/platform/x86/think-lmi.c
+++ b/drivers/platform/x86/think-lmi.c
@@ -281,8 +281,7 @@ static int tlmi_get_pwd_settings(struct
                return -EIO;
        }
 
-       copy_size = obj->buffer.length < sizeof(struct tlmi_pwdcfg) ?
-               obj->buffer.length : sizeof(struct tlmi_pwdcfg);
+       copy_size = min(obj->buffer.length, sizeof(struct tlmi_pwdcfg));
        memcpy(pwdcfg, obj->buffer.pointer, copy_size);
        kfree(obj);
 
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

Reply via email to